Bartłomiej Dach
c2dd2ad978
Clamp beat divisor to sane range when decoding
...
In my view this is a nice change, but do note that on its own it does
nothing to fix https://github.com/ppy/osu/issues/29492 , because of
`BeatmapInfo` reference management foibles when opening the editor. See
also: https://github.com/ppy/osu/issues/20883#issuecomment-1288149271 ,
https://github.com/ppy/osu/pull/28473 .
2024-08-20 13:52:29 +02:00
Bartłomiej Dach
bb964e32fa
Fix crash on attempting to edit particular beatmaps
...
Closes https://github.com/ppy/osu/issues/29492 .
I'm not immediately sure why this happened, but some old locally
modified beatmaps in my local realm database have a `BeatDivisor` of 0
stored, which is then passed to
`BindableBeatDivisor.SetArbitraryDivisor()`, which then blows up.
To stop this from happening, just refuse to use values outside of a sane
range.
2024-08-20 13:51:58 +02:00
Bartłomiej Dach
f0ddb6daa4
Merge pull request #29445 from OliBomby/transparent-break
...
Make break periods in bottom timeline transparent
2024-08-20 11:46:02 +02:00
Dean Herbert
28f1ea9911
Merge pull request #29531 from bdach/remove-dead-classes
...
Remove dead row attribute classes
2024-08-20 18:36:14 +09:00
Dean Herbert
bccc797bcb
Move break display to background of summary timeline
2024-08-20 17:45:44 +09:00
Dean Herbert
c85b04bca5
Add more test coverage to better show overlapping break / kiai sections
2024-08-20 17:45:44 +09:00
Bartłomiej Dach
373ff47a94
Remove dead row attribute classes
...
These aren't shown on the control point table since difficulty and
sample control points were moved into objects.
2024-08-20 09:53:40 +02:00
Dan Balasescu
95a3dcfdae
Merge pull request #29515 from TheOmyNomy/add-cursor-trail-expanding-behaviour
...
Apply current cursor expansion scale to trail parts
2024-08-20 16:14:58 +09:00
Dan Balasescu
4a19ed7472
Add test
2024-08-20 15:20:48 +09:00
Dan Balasescu
180c4a0248
Fix tests by removing assumption
2024-08-20 14:20:52 +09:00
TheOmyNomy
67de43213c
Apply current cursor expansion scale to trail parts
2024-08-19 23:21:06 +10:00
Bartłomiej Dach
24a0a3c47f
Merge pull request #29476 from EVAST9919/buffered-editor-grid
...
Improve draw performance of editor grids
2024-08-19 12:44:08 +02:00
Dan Balasescu
03188e40ee
Merge pull request #29504 from peppy/skin-editor-fix-sidebar-reload
...
Fix skin editor components sidebar not reloading when changing skins
2024-08-19 18:13:52 +09:00
Dan Balasescu
bb723a466b
Merge pull request #29503 from peppy/catcher-trail-fix
...
Fix osu!catch trail spacing not matching osu!stable expectations
2024-08-19 18:12:56 +09:00
Dan Balasescu
c18f7a239c
Merge pull request #29474 from peppy/fix-legacy-combo-counter-animation-dead
...
Fix legacy combo counter bounce animation not always playing
2024-08-19 18:09:57 +09:00
Dan Balasescu
4351de7abf
Merge pull request #29502 from peppy/no-duck-when-zero-sample-volume
...
Don't duck music when effect volume is set to zero
2024-08-19 16:13:57 +09:00
Dean Herbert
1bd2f4c6a2
Fix skin editor components sidebar not reloading when changing skins
...
Closes https://github.com/ppy/osu/issues/29098 .
2024-08-19 15:45:18 +09:00
Dean Herbert
ca92c116b5
Fix osu!catch trail spacing not matching osu!stable expectations
...
Closes https://github.com/ppy/osu/issues/28997 .
2024-08-19 15:01:16 +09:00
Dean Herbert
4a3f4c3a55
Don't duck music when effect volume is set to zero
...
Addresses https://github.com/ppy/osu/discussions/28984 .
2024-08-19 14:46:50 +09:00
Dean Herbert
510f2c8ce2
Merge pull request #28538 from bdach/polygon-tool
...
Reimplement stable polygon tool
2024-08-19 14:34:02 +09:00
Dean Herbert
7248c04ba4
Merge branch 'master' into polygon-tool
2024-08-19 13:54:02 +09:00
Dean Herbert
95d06333c1
Fix typo in editor field
2024-08-19 13:49:59 +09:00
Dean Herbert
f34132fd6b
Merge branch 'master' into polygon-tool
2024-08-19 13:00:02 +09:00
Dean Herbert
e75ae4a37b
More hardening of TestMultiplayerClient to attempt to fix test failures
2024-08-19 04:04:24 +09:00
Dean Herbert
07929b440a
Merge pull request #29485 from Joehuu/fix-carousel-panel-hover
...
Fix beatmap carousel panels not blocking hover of other panels in song select
2024-08-19 03:46:28 +09:00
Joseph Madamba
6dd08e9a96
Fix beatmap carousel panels not blocking hover of other panels in song select
2024-08-17 11:45:54 -07:00
Andrei Zavatski
3cd5820b5b
Make PositionSnapGrid a BufferedContainer
2024-08-17 10:34:39 +03:00
Dean Herbert
04a2d67ca4
Fix legacy combo counter bounce animation not always playing
...
As mentioned [in
discord](https://discord.com/channels/188630481301012481/1097318920991559880/1274231995261649006 ).
2024-08-17 15:13:44 +09:00
Dan Balasescu
ba4956ace4
Merge pull request #29467 from EVAST9919/online-bg-box
...
Remove extra box in `OnlinePlayBackgroundScreen`
2024-08-17 10:34:34 +09:00
Andrei Zavatski
f74263db81
Remove extra box in OnlinePlayBackgroundScreen
2024-08-17 01:01:51 +03:00
Dan Balasescu
e4c1545bf0
Merge pull request #29458 from peppy/fix-incorrect-skin-shortcutting
...
Fix custom skin sprites no longer working
2024-08-17 03:13:46 +09:00
Dean Herbert
d1d195cf18
Fix incorrect skin lookup shortcutting causing sprites to no longer work
2024-08-17 02:33:52 +09:00
OliBomby
5624c1d304
Make break periods in bottom timeline transparent
2024-08-16 13:22:09 +02:00
Dan Balasescu
3b94d1f8eb
Merge pull request #29433 from OliBomby/grid-anchors
...
Fix grid snap slider placement double-click not making new segment if anchor not hovered
2024-08-16 17:42:15 +09:00
Dean Herbert
68bad9a277
Attempt file operations more than once in another test instance
...
See
https://github.com/ppy/osu/pull/29433/checks?check_run_id=28833985792 .
2024-08-16 17:39:45 +09:00
Dan Balasescu
4ea7d9fb9a
Merge pull request #29438 from Joehuu/fix-play-button-click-area
...
Fix preview play button having incorrect click area
2024-08-16 16:29:49 +09:00
Joseph Madamba
e2bf02cf94
Fix preview play button having incorrect click area
2024-08-15 22:49:12 -07:00
Joseph Madamba
fda17a5a72
Expose BeatmapCardNormal height const
2024-08-15 22:49:12 -07:00
Dean Herbert
e01e630fd7
Merge pull request #29434 from OliBomby/change-segment
...
Fix PathControlPointVisualiser eating inputs when no control points are selected
2024-08-16 12:35:46 +09:00
OliBomby
00e210147a
Fix inputs being eaten by PathControlPointVisualizer when no control points are selected
2024-08-15 23:11:07 +02:00
OliBomby
29fda745a4
add failure test
2024-08-15 22:59:26 +02:00
OliBomby
f717938a28
Fix grid snap slider placement double-click does not make new segment if anchor not hovered
2024-08-15 22:49:05 +02:00
Dan Balasescu
52c1858bbe
Merge pull request #29428 from peppy/update-editor-menu-items-difficulty-change
...
Ensure the "Change Difficulty" menu uses up-to-date difficulty names
2024-08-16 00:44:59 +09:00
Dean Herbert
5710f0f302
Merge pull request #26254 from frenzibyte/mania-combo-counter
...
Add argon/classic osu!mania combo counter
2024-08-15 17:56:28 +09:00
Dean Herbert
e7b4a2f451
Merge pull request #29427 from frenzibyte/fix-ruleset-components-beatmap-skin
...
Fix beatmap skin always overriding ruleset HUD components
2024-08-15 17:53:13 +09:00
Dean Herbert
b5f615882f
Ensure the "Change Difficulty" menu uses up-to-date difficulty names
...
Closes https://github.com/ppy/osu/issues/29391 .
2024-08-15 17:25:30 +09:00
Salman Ahmed
7427237873
Try make code look better
2024-08-15 17:03:08 +09:00
Salman Ahmed
358572ebb3
Update code order to match everything else
2024-08-15 16:57:29 +09:00
Salman Ahmed
a421231aad
Fix beatmap skin on mania breaking HUD apart
2024-08-15 16:55:05 +09:00
Salman Ahmed
49c71f7863
Fix beatmap skin always overriding ruleset HUD components
2024-08-15 16:47:10 +09:00
