Bartłomiej Dach
44b9a06639
Allow more lenient parsing of incoming timestamps
2024-06-18 13:13:50 +02:00
Bartłomiej Dach
e1827ac28d
Address review feedback
2024-06-18 13:07:18 +02:00
Bartłomiej Dach
5fe21f16b9
Fix test failures
2024-06-18 10:41:26 +02:00
Bartłomiej Dach
87888ff0bb
Extend slider selection box bounds to contain all control points inside
...
Previously, the selection box was only guaranteed to contain the actual
body of the slider itself, the control point nodes were allowed to exit
it. This lead to a lot of weird interactions with the selection box
controls (rotation/drag handles, also the buttons under/over it) as the
slider anchors could overlap with them.
To bypass this issue entirely just ensure that the selection box's size
does include the control point nodes at all times.
2024-06-18 10:28:36 +02:00
Bartłomiej Dach
1b4a3b0e2e
Change editor speed adjustment back to adjusting tempo
...
- Partially reverts https://github.com/ppy/osu/pull/12080
- Addresses https://github.com/ppy/osu/discussions/27830 ,
https://github.com/ppy/osu/discussions/23789 ,
https://github.com/ppy/osu/discussions/15368 , et al.
The important distinction here is that to prevent misuse when timing,
the control will revert to 1.0x speed and disable when moving to timing
screen, with a tooltip explaining why.
2024-06-18 09:46:00 +02:00
Dean Herbert
e6187ebec0
Fix nullability insepction
2024-06-18 15:13:52 +08:00
Bartłomiej Dach
2421751419
Fix code quality inspections
2024-06-18 08:33:02 +02:00
Bartłomiej Dach
73786a6f9f
Adjust & expand test coverage
2024-06-18 08:32:12 +02:00
Bartłomiej Dach
a3326086f7
Adjust hotkeys to address feedback
2024-06-18 08:25:05 +02:00
Bartłomiej Dach
310265c43f
Add slider placement binding description in tooltip
2024-06-18 08:16:25 +02:00
Bartłomiej Dach
366ba26cb6
Adjust calls to DrawableExtensions.With<T>()
2024-06-18 07:41:20 +02:00
Bartłomiej Dach
659505f711
Adjust calls to GetContainingInputManager()
2024-06-18 07:41:19 +02:00
Bartłomiej Dach
8a4ae5d23d
Null-propagate all calls to GetContainingFocusManager()
2024-06-18 07:30:46 +02:00
Bartłomiej Dach
7f08008059
Adjust AudioFilter to framework-side changes
...
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2024-06-18 07:30:46 +02:00
Bartłomiej Dach
da4160439e
Update framework
2024-06-18 07:26:20 +02:00
Dean Herbert
316125d47a
Merge pull request #23443 from OliBomby/edit-nodesample
...
Make NodeSamples editable
2024-06-18 11:12:02 +09:00
Bartłomiej Dach
683d5310b1
Implement direct choice of slider control point path type via Alt-number
2024-06-17 18:33:36 +02:00
Bartłomiej Dach
a631d245da
Fix test failure
2024-06-17 18:14:33 +02:00
Bartłomiej Dach
5652a558f9
Allow to jump to a specific timestamp via bottom bar in editor
...
Apparently this is a stable feature and is helpful for modding.
2024-06-17 17:07:55 +02:00
Bartłomiej Dach
7898100698
Add testing for keyboard control of path during selection
2024-06-17 15:56:48 +02:00
Bartłomiej Dach
1e137271ab
Add testing for keyboard control of path during placement
2024-06-17 15:56:48 +02:00
Bartłomiej Dach
88bdc12022
Add ability to cycle through available types when selecting single control point on a slider
2024-06-17 15:56:48 +02:00
Bartłomiej Dach
16ea8f67b0
Add ability to start a new segment during placement via S key
2024-06-17 15:56:48 +02:00
Bartłomiej Dach
b5f0e58524
Add ability to better control slider control point type during placement via Tab
2024-06-17 15:56:48 +02:00
Dean Herbert
b535f7c519
Merge pull request #28507 from bdach/editor-opacity
...
Reduce editor opacity of several editor components when hovering over composer
2024-06-17 22:16:08 +09:00
Dean Herbert
a6f09bc626
Merge pull request #28468 from bdach/daily-challenge/event-feed
...
Implement event feed view for daily challenge screen
2024-06-17 20:16:48 +09:00
Dean Herbert
d3d325c46c
Record on single line
2024-06-17 19:16:23 +08:00
Dean Herbert
05596a391d
Disable collection expression inspections completely
2024-06-17 19:11:08 +08:00
Bartłomiej Dach
7cfe8d8df2
Reduce editor opacity of several editor components when hovering over composer
...
Addresses https://github.com/ppy/osu/discussions/24384 .
2024-06-17 12:14:28 +02:00
Dean Herbert
cc0ef20afd
Merge pull request #28505 from bdach/move-timeline-toggles-elsewhere
...
Move timeline toggle controls to "view" menu
2024-06-17 18:59:38 +09:00
Bartłomiej Dach
07f1994a13
Align beat snap control width with right toolbox
2024-06-17 11:47:37 +02:00
Bartłomiej Dach
3884bce239
Remove unused delegate for now
...
To silence inspections.
2024-06-17 11:09:07 +02:00
Bartłomiej Dach
f7910f774d
Remove redundant type spec
2024-06-17 10:54:52 +02:00
Dean Herbert
291a7f07e6
Merge pull request #28504 from bdach/osu-playfield-border-includes-radius
...
Account for osu! circle radius when drawing playfield border
2024-06-17 17:48:29 +09:00
Bartłomiej Dach
57688c2cfa
Merge pull request #28503 from smoogipoo/partial-aot-trimming
...
Annotate `ControlPoint` and `Mod` for AOT trimming support
2024-06-17 10:36:17 +02:00
Bartłomiej Dach
03049d45bb
Remove stuff that looks bad after moving timeline toggle controls
2024-06-17 10:23:00 +02:00
Bartłomiej Dach
b42752c9f0
Move timeline toggle controls to "view" menu
2024-06-17 10:16:40 +02:00
Dan Balasescu
f86e9c9a4a
Also annotate ControlPointInfo
...
Same deal with this class. Fully qualifying the type names because this
has `#nullable disable` and makes use of `NotNull` which is also present
in the `System.Diagnostics.CodeAnalysis` namespace and AAAAAAARGH
NAMESPACE CONFLICTS.
2024-06-17 17:13:44 +09:00
Bartłomiej Dach
1b00d0181a
Fix playfield border size not updating in editor on circle size change
2024-06-17 09:36:01 +02:00
Dan Balasescu
41446a08b6
Annotate ControlPoint and Mod for AOT trimming support
2024-06-17 16:19:33 +09:00
Bartłomiej Dach
97003b3679
Account for osu! circle radius when drawing playfield border
...
Addresses https://github.com/ppy/osu/discussions/13167 .
2024-06-17 09:08:43 +02:00
Dan Balasescu
030853ed5a
Merge pull request #28472 from bdach/taiko-mod-relax
...
Implement relax mod for taiko
2024-06-17 13:49:17 +09:00
Dean Herbert
15fbad0097
Merge pull request #28480 from bdach/storyboard-pass-fail-show
...
Implement toggling visibility of pass and fail storyboard layers
2024-06-16 11:08:00 +09:00
Dan Balasescu
294f9bd626
Merge pull request #28481 from shiumano/no-offset-change
...
Disable the automatic offset adjustment button if the offset of the previous play was 0
2024-06-15 19:16:22 +09:00
Dan Balasescu
2ecb9cd79e
Merge pull request #28353 from Givikap120/catch_nf_penalty
...
Changed Catch NF penalty to match Osu
2024-06-15 18:54:02 +09:00
Dean Herbert
ff2d721029
Inline enabled setting
2024-06-15 17:34:04 +08:00
Dean Herbert
6bd633f8ce
Apply NRT to test scene
2024-06-15 17:26:57 +08:00
Shiumano
6c82f1de9b
Set to enable or disable at load time
2024-06-14 21:43:17 +09:00
Bartłomiej Dach
31a8bc7553
Remove redundant qualifier
2024-06-14 14:12:55 +02:00
Bartłomiej Dach
67ca7e4135
Implement toggling visibility of pass and fail storyboard layers
...
Closes https://github.com/ppy/osu/issues/6842 .
This is a rather barebones implementation, just to get this in place
somehow at least. The logic is simple - 50% health or above shows pass
layer, anything below shows fail layer.
This does not match stable logic all across the board because I have
no idea how to package that. Stable defines "passing" in like fifty
ways:
- in mania it's >80% HP
(bb57924c15/osubb57924c15/osubb57924c15/osubb57924c15/osu
2024-06-14 13:59:02 +02:00
