67488 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Bartłomiej Dach	bdeea37a44	Commit active placement when starting drag selection via timeline ... This was reported in https://github.com/ppy/osu/pull/28474, albeit the code changes proposed there did not fix the issue at all. See 8b6385f7d0 for demonstration of the crash scenario. Basically what is happening there is: - The starting premise is that there is a spinner placement active. - At this time, a drag selection is started via the timeline. - Once the drag selection finds at least one suitable object to select, it mutates `SelectedItems`. - When selection changes for any reason, the `HitObjectComposer` decides to switch to the "select" tool, regardless of why the selection changed. - Changing the active tool causes the current placement - if any - to be committed, which mutates the beatmap. - Back at the drag box selection code, this causes a "collection modified when enumerating" exception. The proposed fix here is to eagerly commit active placement - if any - when drag selection is initiated via the timeline, which avoids this issue. This also appears to vaguely match stable behaviour and is sort of consistent with the logic of committing any outstanding changes upon switching to the selection tool.	2024-06-14 09:32:40 +02:00
Bartłomiej Dach	8b6385f7d0	Add failing test case demonstrating crash	2024-06-14 09:24:53 +02:00
Dean Herbert	2d4121b14a	Merge pull request #28475 from Joppe27/scorepanel-applause-balance ... Fix excessive `applause` audio balancing in result screen	2024-06-14 13:33:23 +09:00
Joppe27	47f89b8969	Clamp X value to avoid excessive balance shift	2024-06-13 18:06:19 +02:00
Bartłomiej Dach	fdb63bd7cd	Merge pull request #28466 from smoogipoo/fix-long-hold-length ... Fix missing texture on extremely long hold notes	2024-06-13 09:13:03 +02:00
Dan Balasescu	16aebb97a5	Merge pull request #28458 from bdach/mania-editor-hold-note-drag ... Allow modifying hold note start/end time via mania composer playfield	2024-06-13 15:42:44 +09:00
Dean Herbert	b61a705f64	Merge pull request #28465 from smoogipoo/hitobject-drawvis-display ... Use more descriptive HitObject names for debugger displays	2024-06-13 15:23:13 +09:00
Dan Balasescu	1ff20cc13d	Fix missing texture on extremely long hold notes	2024-06-13 15:19:41 +09:00
Dan Balasescu	91f2cf8cc3	Use more descriptive HitObject names for debugger displays	2024-06-13 15:18:39 +09:00
Bartłomiej Dach	6d2f910813	Add test coverage	2024-06-12 15:43:33 +02:00
Bartłomiej Dach	feadf7a56e	Allow modifying hold note start/end time via mania composer playfield	2024-06-12 15:30:27 +02:00
Dean Herbert	67f1511ad1	Merge pull request #28456 from bdach/daily-challenge/countdown ... Implement time remaining display for daily challenge screen	2024-06-12 19:56:59 +09:00
Bartłomiej Dach	ae6dd9d053	Use extracted headings on daily challenge screen	2024-06-12 11:44:19 +02:00
Bartłomiej Dach	51c598627a	Move out section header component from editor ... This sort of thing has been showing up on flyte designs more and more so I want to start using it more over that rather ugly "overlined" text that's there on multiplayer screens right now.	2024-06-12 11:43:40 +02:00
Bartłomiej Dach	2be6b29f21	Implement time remaining display for daily challenge screen	2024-06-12 11:43:24 +02:00
Bartłomiej Dach	6fb0cabf36	Add start date to Room	2024-06-12 11:43:18 +02:00
Dean Herbert	94b7148a9e	Merge pull request #28440 from bdach/daily-challenge/new-screen ... Add minimal viable new screen for daily challenge feature	2024-06-12 17:49:02 +09:00
Bartłomiej Dach	5e002fbf9b	Fix user mod select button being inserted in incorrect place	2024-06-12 08:59:50 +02:00
Dean Herbert	90481223dd	Merge pull request #28445 from bdach/mania-key-count-change-force-reload ... Attempt full editor reload on key count change	2024-06-12 14:42:59 +09:00
Dan Balasescu	39b219bacc	Merge pull request #28441 from bdach/fix-editor-stacking-not-applying-immediately ... Fix stack leniency not applying immediately after change	2024-06-12 12:24:28 +09:00
Dean Herbert	2a8bd8d968	Fix failing tests due to missing DI pieces	2024-06-12 11:23:56 +08:00
Bartłomiej Dach	fb99daea2a	Merge pull request #28443 from ColdVolcano/shorten-accuracy ... Fix Argon accuracy counter layout when under 10% and wireframe off	2024-06-11 14:57:59 +02:00
Bartłomiej Dach	e67d73be7d	Add test coverage	2024-06-11 12:28:39 +02:00
Bartłomiej Dach	da53a11d3c	Attempt full editor reload on key count change	2024-06-11 11:31:49 +02:00
Bartłomiej Dach	3afe98612c	Add RestoreState() to IEditorChangeHandler	2024-06-11 11:31:30 +02:00
Bartłomiej Dach	10af642342	Split mania difficulty section implementation off completely from base ... - "Circle size" / key count needs completely different handling. - Approach rate does not exist in mania.	2024-06-11 11:30:20 +02:00
Dean Herbert	c640fbbaf0	Merge branch 'master' into daily-challenge/new-screen	2024-06-11 18:24:31 +09:00
ColdVolcano	4048a4bdfb	fix accuracy counter separating whole and fraction parts with wireframes off	2024-06-11 02:20:14 -06:00
Dean Herbert	cd3b455341	Merge pull request #28420 from bdach/mutually-exclusive-save-related-actions ... Disallow running save-related operations concurrently	2024-06-11 01:03:47 +09:00
Bartłomiej Dach	25b2dfa601	Fix stack leniency not applying immediately after change	2024-06-10 14:34:22 +02:00
Bartłomiej Dach	073ddcebe4	Hide daily challenge from playlists listing	2024-06-10 13:12:21 +02:00
Bartłomiej Dach	2321e408cb	Add test scene for daily challenge screen	2024-06-10 13:12:20 +02:00
Bartłomiej Dach	e6da17d248	Add minimal viable variant of new daily challenge screen	2024-06-10 13:09:12 +02:00
Bartłomiej Dach	ffd788c65c	Use room mod select overlay rely on explicit binding rather than DI resolution	2024-06-10 12:45:51 +02:00
Bartłomiej Dach	dd6e9308b3	Extract user mod select button for reuse	2024-06-10 12:45:27 +02:00
Bartłomiej Dach	f135a9a923	Make SelectedItem externally mutable ... Not being able to externally mutate this was making reuse in new daily challenge screen unnecessarily arduous.	2024-06-10 12:44:38 +02:00
Bartłomiej Dach	d80f09e0c0	Adjust online play header to be reusable for new daily challenge screen	2024-06-10 12:43:58 +02:00
Bartłomiej Dach	19f39ca1b6	Extract OnlinePlayScreenWaveContainer from OnlinePlayScreen	2024-06-10 12:42:37 +02:00
Bartłomiej Dach	acf4dbb62c	Merge branch 'master' into mutually-exclusive-save-related-actions	2024-06-10 10:30:35 +02:00
Bartłomiej Dach	1d6b7e9c9b	Refactor further to address code quality complaints	2024-06-10 10:30:30 +02:00
Dean Herbert	a8a2e543d5	Merge pull request #28436 from omkelderman/fix-auto-pick-map-on-zero-ban-round ... Fix auto picking maps on zero ban rounds	2024-06-10 13:51:41 +09:00
Olle Kelderman	642095b07b	On the mappool screen the auto-pick map logic on map change still assumed 1 ban per team. Now it listens to the BanCount value from the round	2024-06-09 21:42:37 +02:00
Dean Herbert	be48377c4c	Merge pull request #28185 from frenzibyte/footer-v2-become-global ... Move new screen footer to `OsuGame` and add temporary `SongSelectV2` screen	2024-06-09 19:06:38 +09:00
Salman Ahmed	6201220994	Merge branch 'master' into footer-v2-become-global	2024-06-08 14:13:05 +03:00
Dean Herbert	daf85c320a	Merge pull request #22237 from mk56-spn/LeaderBoardScore_clean ... New leaderboard score card design implementation	2024-06-08 20:06:17 +09:00
Dean Herbert	7fc6ad5340	Merge pull request #28184 from frenzibyte/footer-v2-transitions ... Add basic animation to new footer and buttons	2024-06-08 19:43:23 +09:00
Salman Ahmed	5f8f6caedd	Use OsuGame.SHEAR	2024-06-07 22:45:22 +03:00
Salman Ahmed	6f729be573	Merge branch 'master' into LeaderBoardScore_clean	2024-06-07 22:42:49 +03:00
Salman Ahmed	f59d94bba4	Move transitions inside ScreenFooterButton and re-use Content from base implementation instead ... The point is to apply the transitions against a container that's inside of `ScreenFooterButton`, because the `ScreenFooterButton` drawable's position is being controlled by the flow container it's contained within, and we cannot apply the transitions on it directly.	2024-06-07 22:07:39 +03:00
Dean Herbert	1045742321	Merge pull request #28421 from bdach/mania-editor-flip-controls ... Implement flip operations in mania editor	2024-06-08 00:10:16 +09:00