osu-lazer

Fix several issues with incorrect sample playback (#35685 )

* Add failing test coverage for layered hit samples not playing in mania when beatmap is converted

Adding the `osu.Game.Rulesets.Osu` reference to the mania test project
is required so that `HitObjectSampleTest` base logic doesn't die on

https://github.com/ppy/osu/blob/f0aeeeea966f06add12cf2bca3dd48dac8573e82/osu.Game/Tests/Beatmaps/HitObjectSampleTest.cs#L88-L91

* Fix layered hit sounds not playing on converted beatmaps in mania

Compare
https://github.com/peppy/osu-stable-reference/blob/f9e58b4864a10f801393199e7652b2192c7342c3/osu!/GameplayElements/HitObjects/HitObject.cs#L476-L477.

In case of converted beatmaps, the last condition there
(`BeatmapManager.Current.PlayMode != PlayModes.OsuMania`) fails,
and thus layered hitsounds are allowed to play.

* Add failing test coverage for mania beatmap conversion assigning wrong samples to spinners

* Fix mania beatmap conversion assigning wrong samples to spinners

A spinner is never `IHasRepeats`. It was a dead condition, leading to
the hitobject generating fallback `NodeSamples`, which in particular
feature a silent tail which stable doesn't do.

Noticeably, stable also appears to force the head of the generated hold
note to have no addition sounds:

https://github.com/peppy/osu-stable-reference/blob/f9e58b4864a10f801393199e7652b2192c7342c3/osu!/GameplayElements/HitObjects/Mania/SpinnerMania.cs#L86-L89

* Add failing test coverage for file hit sample not falling back to plain samples if file missing

* Allow `FileHitSampleInfo` to fall back to standard samples if the file is not found (or not allowed to be looked up)

I'm honestly not 100% as to how closely this matches stable because I
reached the point wherein I'd rather not look at stable code anymore, so
as long as this passes tests I'm fine to wait for someone else to report
new breakage.

* Use alternative workaround for lack of osu! ruleset assembly in mania test project

* Fix encode stability test failures

Bartłomiej Dach · 2025-11-15 16:19:08 +09:00

bd4ed49c06

Adjust tests to pass (and add test coverage of fail case)

Bartłomiej Dach · 2025-06-27 14:07:00 +02:00

edafac2aaa

Refactor hit windows class structure to reduce rigidity

This change pulls back a significant degree of overspecialisation and
rigidity in the class structure of `HitWindows` to make subsequent
changes to hit windows, whose purpose is to improve replay playback
accuracy, possible to do cleanly.

Notably:

- `HitWindows` is full abstract now. In a few use cases, and as a
  reference for ruleset implementors, `DefaultHitWindows` is provided as
  a separate class instead.

  This fixes the weirdness wherein `HitWindows` always declared 6 fields
  for result types but some of them would never be set to a non-zero
  value or read.

- `HitWindow.GetRanges()` is deleted because it is overspecialised and
  prevents being able to adjust hitwindows by ±0.5ms cleanly which will
  be required later.

  The fallout of this is that the assertion that used `GetRanges()` in
  the `HitWindows` ctor must use something else now, and the closest
  thing to it was `GetAllAvailableWindows()`, which didn't return
  the miss window - so I made it return the miss window and fixed the
  one consumer that didn't want it (bar hit error meter) to skip it.

- Diff also contains some clean-up around `DifficultyRange` to unify
  handling of it.

Bartłomiej Dach · 2025-06-25 08:40:12 +02:00

8b542e5442

Make CreateJudgement public again and add remarks

Andrei Zavatski · 2024-02-16 20:24:02 +03:00

060b01eee8

Fix remaining use cases

Andrei Zavatski · 2024-02-10 14:16:45 +03:00

5fa54c8c63

Merge branch 'master' into hit-object-result-allocations

Bartłomiej Dach · 2024-02-05 13:24:10 +01:00

39fe078984

Refactor result application around again to remove requirement for fields

Co-authored-by: Dean Herbert <pe@ppy.sh>

Bartłomiej Dach · 2024-02-05 13:21:01 +01:00

efe6bb25b1

Update R# + fix inspections

Dan Balasescu · 2024-02-02 21:00:28 +09:00

b44f77cee1

update DrawableHitCircle.ApplyResult to pass this to its callback

Chandler Stowell · 2024-01-25 11:25:41 -05:00

93bd3ce5ae

Expose only as one method

Dan Balasescu · 2023-12-21 14:58:23 +09:00

6b4b2a57fc

Relocate HitResult numeric score to ScoreProcessor

Dan Balasescu · 2023-12-21 14:52:31 +09:00

4e3b994142

Merge branch 'master' into hp-drain-fix-breaks

Dean Herbert · 2023-11-24 15:15:48 +09:00

e3217bc82e

Fix first object after break not starting a new combo

Dan Balasescu · 2023-11-22 17:22:48 +09:00

cb4568c4a1

Fix osu! and base HP processor break time implementation

Dan Balasescu · 2023-11-14 01:11:17 +09:00

e3137d575b

Add failing test case

Bartłomiej Dach · 2023-10-26 19:38:52 +02:00

0482c05d7c

Remove pointless test class in TestSceneStoryboardSamples

Dean Herbert · 2023-10-06 16:43:28 +09:00

f9021bf551

Add test coverage of Judged state

Dean Herbert · 2023-07-05 18:20:25 +09:00

e21dc56fcb

Automated pass

Dean Herbert · 2023-06-24 01:00:03 +09:00

0ab0c52ad5

Add xmldoc and change naming around ScoreProcessorStatistics a bit

Dean Herbert · 2023-05-29 18:38:16 +09:00

a789d1e49c

Fix tests

Dan Balasescu · 2023-05-23 18:18:27 +09:00

844c023fb7

Fix intermittent failure in GCC seeking test

Salman Ahmed · 2023-01-14 14:34:22 +03:00

befb275512

Add test coverage

Bartłomiej Dach · 2022-12-30 20:55:54 +01:00

ae026e2d2d

Add test coverage for failure case

Bartłomiej Dach · 2022-11-30 22:53:56 +01:00

830e243d12

Partial everything

Dan Balasescu · 2022-11-27 00:00:27 +09:00

7bc8908ca9

Merge branch 'master' into long-standard

maromalo · 2022-11-12 09:52:11 -03:00

1911120afe

Merge branch 'master' into combo-colour-brightness-limit

Dan Balasescu · 2022-11-11 15:31:28 +09:00

db25e9e9c8

Add "Component" prefix to lookup naming

Dean Herbert · 2022-11-09 17:46:43 +09:00

1aa0e40f2f

Rename ISkinComponent to ISkinLookup

Dean Herbert · 2022-11-09 17:46:43 +09:00

c908969d9b

Make score type consistent

maromalo · 2022-11-06 19:59:27 -03:00

b7ef9b176d

Fix test failures and rename configuration value to match better

Dean Herbert · 2022-11-02 18:15:18 +09:00

3ec9686e58

Adjust test

Dan Balasescu · 2022-08-29 15:59:57 +09:00

d4a37725c4

Fix test regressions on windows due to Reset never being called

I'm not sure this is great. Without calling `Reset`, the correct initial
time may not be set (ever). In practice this doesn't happen anywhere in
the gameplay flow, but something worth noting.

This change is required now that `Reset` isn't called in the
constructor. It couldn't be called in the constructor because it would
cause the audio track to reset its position too early.

What an ordeal.

Dean Herbert · 2022-08-24 11:50:20 +09:00

46d000b8ce

Move operation of setting GameplayClockContainer.StartTime to Reset call

Dean Herbert · 2022-08-22 14:11:06 +09:00

af2e82d7d5

Ensure setting a StartTime on a GameplayClockContainer always resets to the new time

Dean Herbert · 2022-08-18 18:54:10 +09:00

43879633db

Make GameplayClockContainer also an IGameplayClock and expose to remaining tests

Dean Herbert · 2022-08-15 18:30:53 +09:00

f81c7644b4

Update usages of GameplayClockContainer.GameplayClock to access properties directly