osu-lazer

Fix osu! editor composer scale handles not updating correctly when selected object is changed (#36681 )

Before:


https://github.com/user-attachments/assets/d0a0373d-2d46-48a9-9ea5-bac82a612f32

After:


https://github.com/user-attachments/assets/f5785b54-d7fc-4ce0-86b0-60c96ff22bc3

---

Closes https://github.com/ppy/osu/issues/36677.

Kinda shocking this went by unnoticed for this long.

Bartłomiej Dach · 2026-02-17 00:50:16 +09:00

42bf25442b

Update editor slider controls to new design (#36346 )

(partially) Closes: #36233
Surpasses: #36244 

This PR meant to be one of the last steps that finally make editor use
the new forms. Initially it meant to only change one
SliderWithTextBoxInput in "Effects section" in timing screen, however
soon after it was obvious that there's many other places that still
using it. This currently won't affect
IndeterminateSliderWithTextBoxInput that is being used in hitsounds, for
example, since I think it needs more consideration.
Anyways, with this PR, SliderWithTextBoxInput, will no longer be used at
all, as it's going to be replaced with modern FormSliderBar

Comparison:
|master|this PR|
|:---:|:---:|
|<img width="510" height="316"
alt="532203751-eb965923-d3a8-441d-a7c8-5c364a6328ad"
src="https://github.com/user-attachments/assets/268b45b8-e235-494f-91a5-d00db057dba8"
/>|<img width="540" height="321"
alt="535466527-3a700a8b-bc3c-4610-998f-a4e55ee03eed"
src="https://github.com/user-attachments/assets/20cd4b58-b0bd-49bc-8c48-7de5cf8556b3"
/>|
|<img width="694" height="639"
alt="534509844-f00e4da4-53c4-45e8-80ea-1be62da6c83b"
src="https://github.com/user-attachments/assets/398c4484-a867-4df1-9de3-0940aa748a01"
/>|<img width="720" height="433" alt="изображение"
src="https://github.com/user-attachments/assets/b6359443-a224-4a55-b171-07e8f013cf46"
/>|
|<img width="715" height="353"
alt="534509421-a6ac950f-16e8-4a16-bca6-1a781f82135f"
src="https://github.com/user-attachments/assets/4854312b-772f-4b81-a800-89e58d4c715d"
/>|<img width="710" height="296" alt="изображение"
src="https://github.com/user-attachments/assets/a7fed53e-e006-4285-92c9-bb84cb603f60"
/>|
|<img width="717" height="374"
alt="534509478-80222623-7766-481d-8682-088276d415ee"
src="https://github.com/user-attachments/assets/8143b6dc-4599-45d5-bd3b-f059caf3d93d"
/>|<img width="718" height="328" alt="изображение"
src="https://github.com/user-attachments/assets/bffa04de-983c-45ae-a1ec-373701ea0e49"
/>|
|<img width="702" height="446"
alt="534509935-58954060-7ac1-4392-8754-a58f909e86aa"
src="https://github.com/user-attachments/assets/2bb67a2d-3f57-42a1-96ce-b30b4891e1a4"
/>|<img width="722" height="386" alt="изображение"
src="https://github.com/user-attachments/assets/01b7fff4-7f31-4aac-90c9-353b15f4964e"
/>|

De4n · 2026-01-16 20:08:52 +09:00

e05b6f44b9

Add basic colour indication as to when placements are valid

Unsure about this one, but I find the preceding commit to be very
lacking in explaining to the user why the editor don't work. Shining
some things red may help aid understanding.

Bartłomiej Dach · 2025-12-04 14:37:56 +01:00

c6cc92315c

Disallow placing hit objects before first timing point

Because they can break stable. See
https://github.com/ppy/osu/issues/31591#issuecomment-3575270120 for
detailed rationale.

Bartłomiej Dach · 2025-12-04 14:15:52 +01:00

12170df80a

Fix several issues with editor timestamps for objects with fractional start times in osu!mania (#35829 )

* Fix mania editor timestamp generation being culture-dependent

Mostly closes https://github.com/ppy/osu/issues/35809.

* Add failing test for notes with fractions

* Round note time when copying out timestamp & apply half-millisecond tolerance when parsing

Closes the rest of https://github.com/ppy/osu/issues/35809.

One issue here was that while the timestamp generation would allow
fractional object timestamps to be output, the parsing (via
`selection_regex`) would *reject* fractional timestamps, therefore
making lazer incompatible even with itself.

The other is that rounding is probably fine to do anyway for
interoperability with stable. I'd hope nobody actually *needs*
sub-millisecond precision but I'm ready to be proven wrong by some
aspire jokester.

* Specify invariant culture when writing out combo indices to editor timestamp in other rulesets

Pretty sure this is just a much-of-muchness because it's integers but
might as well if I'm spending time here already.

Bartłomiej Dach · 2025-11-28 08:21:13 +09:00

a8f058141b

Adjust precisions to be less weird

In a perfect world you could specify different precisions for the slider
and the text box but let's start here and see if we get complaints
first.

Bartłomiej Dach · 2025-11-20 12:36:05 +01:00

f0f33b6df4

Adjust element spacing in editor toolboxes

Bartłomiej Dach · 2025-11-19 13:38:34 +01:00

397041099e

Use new sliders-with-text-input in editor toolboxes

Addresses https://github.com/ppy/osu/discussions/35732.

And yes, I renamed "perfect curve threshold" to "bias" so that the text
can fit. Sue me.

Bartłomiej Dach · 2025-11-19 13:22:20 +01:00

4b59a4657f

Merge pull request #35056 from OliBomby/anchor-snap

Allow snapping slider control points to nearby objects in the editor

Dean Herbert · 2025-09-30 18:01:02 +09:00

1a084f28ff

Merge pull request #35057 from OliBomby/snap-to-anchor

Allow snapping to nearby visible slider control points in the editor

Dean Herbert · 2025-09-30 18:00:31 +09:00

a0ff7728b9

Simplify logic further

Bartłomiej Dach · 2025-09-30 08:32:53 +02:00

057406c910

Updated moveSelectionInBounds in OsuSelectionScaleHandler to match the one in OsuSelectionHandler

AeroKoder · 2025-09-29 09:27:01 -07:00

41698d5848

Remove all linq calls from getScreenSpaceControlPointNodes

OliBomby · 2025-09-29 15:07:03 +02:00

18549ea7dc

dont snap inherited bspline type control points to nearby objects

OliBomby · 2025-09-29 14:44:12 +02:00

d76dce76ec

Revert inline method for code abstraction

OliBomby · 2025-09-29 14:23:19 +02:00

40cbe58220

Reword inline comments

Olivier Schipper · 2025-09-19 01:22:35 +02:00

9fddce92e9

Fix incorrect skip count

Olivier Schipper · 2025-09-19 01:09:42 +02:00

7c5278ea45

Allow snapping to visible slider control points

Olivier Schipper · 2025-09-19 00:30:31 +02:00

0e523d3eb7

Allow slider control points to snap to nearby objects

and a bit of code cleanup to reduce code duplication with the slider head anchor snapping

Olivier Schipper · 2025-09-18 21:26:49 +02:00

55a4c75e76

Fix certain slider shapes incorrectly registering as a horizontal/vertical only slider.

AeroKoder · 2025-09-17 15:34:18 -07:00

6dc3432735

Fix typos

Bartłomiej Dach · 2025-09-01 12:01:36 +02:00

e2d661736e

Fix movement via slider while popover closes

NiyazBiyaz · 2025-09-01 13:57:14 +05:00

677c008b4d

Move guard to scale/rotationInfo

NiyazBiyaz · 2025-09-01 13:55:29 +05:00

12430ce464

Add OperationInProgress checking

NiyazBiyaz · 2025-08-31 17:17:17 +05:00

b02093505d

initial pass on updated verifier context usage across most checks

Hivie · 2025-08-11 14:57:14 +01:00

fd6cf680b9

Reword comment to be more coherent

Bartłomiej Dach · 2025-08-06 15:04:29 +02:00

f1f7784272

Fix grid placement aggressively changing tool selection

Salman Alshamrani · 2025-08-05 15:20:04 +03:00

6001d6418b

use TimeSpan for defining thresholds

Hivie · 2025-07-21 12:32:45 +01:00

86369ab403

Add verify check for lowest diff drain time requirement

Hivie · 2025-07-13 02:00:50 +01:00

ccf6d9c173

Merge pull request #33248 from chris-ehmann/fix-distance-snapping-to-stacks

Use stacked position when determining distance snap

Bartłomiej Dach · 2025-05-27 10:49:54 +02:00

c7304fca48

Establish public constant for stacking lenience

Bartłomiej Dach · 2025-05-27 09:31:14 +02:00

f28674502f

Change actualDistance to use StackedEndPosition to match StackedPosition

Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

Chris · 2025-05-26 11:30:04 -07:00

e92205b3eb

Make CheckConcurrentObject ruleset specific

Derrick Timmermans · 2025-05-25 14:19:23 +02:00

0065696248

Change back to using Vector2.Distance instead of length, keep order of before-after consistent

Chris Ehmann · 2025-05-23 22:33:04 -07:00

a4e78a34ac

Change OsuDistanceSnapProvider to use StackedPosition when determining distance between notes

Chris Ehmann · 2025-05-23 12:36:16 -07:00

441c941039

Merge pull request #33115 from bdach/fix-snapping-to-loading-grid

Fix distance snap grid being used before it's ready for use

Dan Balasescu · 2025-05-20 12:46:39 +09:00

e97c757084

Fix crashes when attempting to adjust length of slider whose maximum path length is less than the current beat snap

Closes https://github.com/ppy/osu/issues/32289.

There are two possible choices here: either pulling the lower bound of
the clamp down to `HitObject.Path.CalculatedDistance`, or pulling the
higher bound up to `minDistance`, if it happens to be larger than the
path's calculated distance.

Both options are a bit weird; pulling down can result in unsnapped
sliders when attempting to drag a slider's end when on a lower beat
divisor than was used to place the slider, and pulling up can result in
weird sliders wherein they get extended beyond their path's definition
with a weird linear section at the end without an anchor that is tangent
to the slider shape's end. I decided the first one was less weird, but
I'm open to discuss further.

Bartłomiej Dach · 2025-05-14 13:34:12 +02:00

9b2f25cb93

Fix distance snap grid being used before it's ready for use

Closes https://github.com/ppy/osu/issues/32136.

`DistanceSnapGrid.MaxIntervals` is written to in

	https://github.com/ppy/osu/blob/a360f153f73255d6f78148da17edf2c348af4e94/osu.Game/Screens/Edit/Compose/Components/DistanceSnapGrid.cs#L107-L110

which gets run the first time on `LoadComplete()`:

	https://github.com/ppy/osu/blob/a360f153f73255d6f78148da17edf2c348af4e94/osu.Game/Screens/Edit/Compose/Components/DistanceSnapGrid.cs#L96-L97

meaning it is not valid to attempt to use the grid to snap before it's
loaded, which does actually appear to occur sometimes before this
change.

Bartłomiej Dach · 2025-05-13 11:00:41 +02:00

a09d5468c7

Discard distance snapping result if it results in objects being placed out of playfield bounds

Mainly an issue with "limit distance snap to current time". Reported in
https://discord.com/channels/90072389919997952/1259818301517725707/1369037235797753999.

This slightly changes behaviour of distance snap when the mouse is near
the edges of the screen (will turn off snap rather than clamp to edge as
previously), but I think that's probably fine.

Bartłomiej Dach · 2025-05-07 14:23:35 +02:00

9c40344c9e

Merge pull request #32732 from peppy/vertex-selection-increase

Increase range of vertex selection in polygon generation popover

Bartłomiej Dach · 2025-04-08 09:07:49 +02:00

b1b8601105

Increase range of vertex selection in polygon generation popover

Addresses https://github.com/ppy/osu/discussions/32703.

Dean Herbert · 2025-04-08 15:26:41 +09:00

e990099cd9

Fix editor setup screen sliders not having correct keyboard steps

Closes https://github.com/ppy/osu/issues/32691.

Fixes some extra cases of failure that aren't pointed out in the issue.

Dean Herbert · 2025-04-08 14:45:43 +09:00

f2088496c5

Add explanation of why the logic is in such a bad place

Dean Herbert · 2025-03-12 16:56:16 +09:00

c2de43f677

Fix new combo being toggled when selection is made

Dean Herbert · 2025-03-12 16:52:51 +09:00

6a7a834151

Merge branch 'master' into editor-right-click-as-people-expect

Dean Herbert · 2025-03-12 14:51:28 +09:00

083979e299

Fix edge case allowing almost-zero-length sliders to be placed during distance snapping

Dean Herbert · 2025-03-11 16:17:44 +09:00

23891b1994

Allow grid spacing setting up to 256 pixels

Addresses https://github.com/ppy/osu/discussions/29713.

I think there's valid uses of this apart from just hiding (ie values
between 128 and 256) so let's just get this in.

Dean Herbert · 2025-03-10 14:45:36 +09:00

bbd2c33934

Fix precise movement popover crashing if selection bounding box exceeds playfield size

Closes https://github.com/ppy/osu/issues/32252.

Bartłomiej Dach · 2025-03-07 09:38:14 +01:00

6d22502739

Merge pull request #32158 from bdach/scaling-crash

Fix possible crash when scaling objects in editor

Dean Herbert · 2025-03-04 13:40:41 +09:00

3fe92fb83c

Mark MathHelper.Clamp() as banned API

See previous commit for partial rationale.

There's an argument to be made about the `NaN`-spreading semantics being
desirable because at least something will loudly fail in that case, but
I'm not so sure about that these days. It feels like either way if
`NaN`s are produced, then things are outside of any control, and chances
are the game can probably continue without crashing. And, this move
reduces our dependence on osuTK, which has already been living on
borrowed time for years now and is only awaiting someone brave to go
excise it.

Bartłomiej Dach · 2025-02-28 13:48:22 +01:00

35b0ff80bb

1188 Commits