601 Commits

• Fix failing tests after disallowing object placements before first timing point
  Bartłomiej Dach · 2025-12-05 09:52:32 +01:00
  66ebce8c12
• Fix several issues with editor timestamps for objects with fractional start times in osu!mania (#35829)

  * Fix mania editor timestamp generation being culture-dependent
  
  Mostly closes https://github.com/ppy/osu/issues/35809.
  
  * Add failing test for notes with fractions
  
  * Round note time when copying out timestamp & apply half-millisecond tolerance when parsing
  
  Closes the rest of https://github.com/ppy/osu/issues/35809.
  
  One issue here was that while the timestamp generation would allow
  fractional object timestamps to be output, the parsing (via
  `selection_regex`) would *reject* fractional timestamps, therefore
  making lazer incompatible even with itself.
  
  The other is that rounding is probably fine to do anyway for
  interoperability with stable. I'd hope nobody actually *needs*
  sub-millisecond precision but I'm ready to be proven wrong by some
  aspire jokester.
  
  * Specify invariant culture when writing out combo indices to editor timestamp in other rulesets
  
  Pretty sure this is just a much-of-muchness because it's integers but
  might as well if I'm spending time here already.

  Bartłomiej Dach · 2025-11-28 08:21:13 +09:00
  a8f058141b
• Fix several issues with incorrect sample playback (#35685)

  * Add failing test coverage for layered hit samples not playing in mania when beatmap is converted
  
  Adding the `osu.Game.Rulesets.Osu` reference to the mania test project
  is required so that `HitObjectSampleTest` base logic doesn't die on
  
  https://github.com/ppy/osu/blob/f0aeeeea966f06add12cf2bca3dd48dac8573e82/osu.Game/Tests/Beatmaps/HitObjectSampleTest.cs#L88-L91
  
  * Fix layered hit sounds not playing on converted beatmaps in mania
  
  Compare
  https://github.com/peppy/osu-stable-reference/blob/f9e58b4864a10f801393199e7652b2192c7342c3/osu!/GameplayElements/HitObjects/HitObject.cs#L476-L477.
  
  In case of converted beatmaps, the last condition there
  (`BeatmapManager.Current.PlayMode != PlayModes.OsuMania`) fails,
  and thus layered hitsounds are allowed to play.
  
  * Add failing test coverage for mania beatmap conversion assigning wrong samples to spinners
  
  * Fix mania beatmap conversion assigning wrong samples to spinners
  
  A spinner is never `IHasRepeats`. It was a dead condition, leading to
  the hitobject generating fallback `NodeSamples`, which in particular
  feature a silent tail which stable doesn't do.
  
  Noticeably, stable also appears to force the head of the generated hold
  note to have no addition sounds:
  
  https://github.com/peppy/osu-stable-reference/blob/f9e58b4864a10f801393199e7652b2192c7342c3/osu!/GameplayElements/HitObjects/Mania/SpinnerMania.cs#L86-L89
  
  * Add failing test coverage for file hit sample not falling back to plain samples if file missing
  
  * Allow `FileHitSampleInfo` to fall back to standard samples if the file is not found (or not allowed to be looked up)
  
  I'm honestly not 100% as to how closely this matches stable because I
  reached the point wherein I'd rather not look at stable code anymore, so
  as long as this passes tests I'm fine to wait for someone else to report
  new breakage.
  
  * Use alternative workaround for lack of osu! ruleset assembly in mania test project
  
  * Fix encode stability test failures

  Bartłomiej Dach · 2025-11-15 16:19:08 +09:00
  bd4ed49c06
• test(ManiaFilterCriteriaTest): simplify test case
  Binwalker · 2025-08-26 21:36:20 +09:00
  149f18c3f5
• test(ManiaFilterCriteriaTest): fix some test case for ln filter
  Binwalker · 2025-08-26 21:36:20 +09:00
  65253708d8
• test(ManiaFilterCriteriaTest): add some testcase
  Binwalker · 2025-08-26 21:36:20 +09:00
  f7b0e114a9
• Ignore more potentially incorrect data from BASS

  This is still a workaround but arguably it's something we could leave in
  place without much loss. I think this at least feels better than the
  previous code.
  
  Notably, you could argue the test coverage of the fail case is lower
  since made it implicit that all tests will avoid the "backwards seek"
  detections.  But we never really had tests correctly- fail on the original
  so I don't see any loss of value.

  Dean Herbert · 2025-08-14 19:20:30 +09:00
  82906300b4
• Merge branch 'master' into osu!mania-touch-on-desktop
  Salman Alshamrani · 2025-08-11 11:15:16 +03:00
  2d1ca7dacc
• Allow enabling osu!mania touch overlay on non-mobile platforms
  AeroKoder · 2025-08-11 11:09:58 +03:00
  ef972e4a04
• Add test coverage
  Salman Alshamrani · 2025-08-05 10:25:58 +03:00
  9798889ace
• refactor issue templates to be more unified
  Hivie · 2025-07-24 13:25:15 +01:00
  c0ba8bc997
• Account for almost concurrent case in concurrent objects check
  Hivie · 2025-07-24 13:12:24 +01:00
  806d3160f8
• Fix test
  Bartłomiej Dach · 2025-07-02 14:00:33 +02:00
  9562e83fc0
• Unignore relevant test cases to demonstrate improved behaviour
  Bartłomiej Dach · 2025-07-02 12:26:50 +02:00
  110fcf9634
• Support mania-specific hit window quirks

  The quirks in question being that lazer's hit windows in mania preceding
  this change are used in stable *if and only if* Score V2 is active. If
  Score V2 is *not* active, stable has two disparate other sets of hit
  window ranges, dependent on whether the beatmap is a convert or not.
  
  With this commit, those hit windows are used in lazer when the Classic
  mod is active.
  
  Open points for discussion would be:
  
  - What does this mean for plays already set on lazer using the Classic
    mod? Are there even enough of them to care about? Also, on `master`
    the Classic mod does precisely nothing, so maybe such scores should
    just have Classic mod stripped from them?
  
  - What does this mean for the mod multiplier of Classic in mania? (I don't
    expect an answer to this one.)

  Bartłomiej Dach · 2025-07-02 12:26:50 +02:00
  6afdf99df8
• Uncomment & adjust relevant replay test cases

  The replay stability tests needed adjustments because hit windows have
  been materially changed with the previous commit. What matters in the
  replay stability tests is covering the time instants near the hit window
  edges and ensuring that re-encode doesn't mutate the resulting
  judgements, not what the particular numbers used are.

  Bartłomiej Dach · 2025-06-25 12:22:19 +02:00
  89c48451cd
• Move concurrent hold note tests to mania tests

  The general check no longer considers mania.

  Derrick Timmermans · 2025-05-25 17:33:48 +02:00
  9a254afa0a
• Add failing test case
  Bartłomiej Dach · 2025-05-20 12:28:28 +02:00
  b60cf08635
• Fix hold notes being missed after rewinding gameplay

  Closes https://github.com/ppy/osu/issues/27589.
  
  Follows osu! spinner precedent in storing the holding state to the
  judgement result rather than attempting to keep it in the DHO (which is
  prone to getting dropped on pool re-use).

  Bartłomiej Dach · 2025-05-19 12:23:47 +02:00
  59490054db
• Add failing test case
  Bartłomiej Dach · 2025-05-19 11:38:42 +02:00
  3d4763bdb5
• Adjust failing replay recording tests

  cd4ab9307c made these tests fail because
  they were basically pressing and releasing a key in a single frame,
  which hopefully never actually happens in real scenarios. (It's a bit
  tricky to determine if it can.)

  Bartłomiej Dach · 2025-05-16 08:59:56 +02:00
  953a93309c
• Add baseline test coverage of replay recording in all rulesets

  Nothing fancy, just basics to ensure the subsequent commit doesn't break
  anything.

  Bartłomiej Dach · 2025-05-14 11:25:14 +02:00
  168c3cf018
• Rename mod setting

  Just feels better?

  Bartłomiej Dach · 2025-05-08 07:47:24 +02:00
  1e61abde74
• Expand test coverage
  Bartłomiej Dach · 2025-05-08 07:46:51 +02:00
  4d5a7e5604
• Merge branch 'master' into perfect-feat
  fredzio2006 · 2025-05-07 21:58:29 +02:00
  9748073037
• Add test coverage
  fredzio2006 · 2025-05-07 21:29:17 +02:00
  70d2eb841d
• Add failing test case
  Salman Alshamrani · 2025-04-30 03:59:41 +03:00
  a3a4881432
• Add test coverage for mania hit windows with various mods active
  Bartłomiej Dach · 2025-04-21 12:26:09 +02:00
  a46a1f569b
• Merge branch 'master' into stable-hitwindow-tests
  Bartłomiej Dach · 2025-04-17 11:40:50 +02:00
  2eb3bfa232
• Add theoretically-valid-but-practically-not commented-out test cases
  Bartłomiej Dach · 2025-04-17 10:36:04 +02:00
  a82bb5c2f6
• Fix code quality once more
  Bartłomiej Dach · 2025-04-16 08:35:35 +02:00
  8273583fd0
• Add test cases covering correct legacy replay playback with respect to hitwindow treatment

  This continues on https://github.com/ppy/osu/pull/32770 via adding test
  cases which cover treatment of hit windows in stable in osu!, taiko, and
  mania. The test cases are exportable to beatmap `.osu` files and replay
  `.osr` files for stable crosscheck by setting `ExportLocation` on the
  test scene classes to a non-null path.
  
  For the most part, osu! and taiko ground truth matches previous findings
  - hit windows in those rulesets are floored to the nearest integer.
  The real "star" of this diff is mania, because:
  
  - The hit windows in mania depend on:
    - overall difficulty (as expected)
    - whether Score V2 is active
    - if Score V2 is not active, the hit windows also depend on whether
      the map was converted from another ruleset or not
  
  - Regardless of all aforementioned factors, mania hitwindows are *not
    symmetrical*. Due to what *appears* to be a straight-up bug, it is
    *not possible to achieve a MEH / 50 hit result when hitting late*.
    There is specific code that coerces late hits beyond 100 hit window
    range to full misses:
  
       https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameplayElements/HitObjectManagerMania.cs#L737-L751
  
  Note that despite the fact that I'm PRing these test cases, none of this
  is a promise that all of stable behaviours will be returning unchanged
  when I PR something to actually do something about this and the other
  issue of replay instability. This is just coverage, to be used for
  awareness of what's still broken. The extent of how much stable is going
  to be humored here going forward will be subject to negotiation.

  Bartłomiej Dach · 2025-04-15 13:22:06 +02:00
  82b2a92894
• Add extra comments regarding notation
  Bartłomiej Dach · 2025-04-14 13:13:21 +02:00
  9cfba9008f
• Fix code quality
  Bartłomiej Dach · 2025-04-11 14:16:24 +02:00
  d4cae3232b
• Add test exercising mania replay playback stability after encode
  Bartłomiej Dach · 2025-04-11 12:09:53 +02:00
  674af698b6
• Remove redundant argument list
  Dan Balasescu · 2025-04-04 10:58:29 +09:00
  2df3dfb99c
• Add test coverage
  Bartłomiej Dach · 2025-04-02 09:56:30 +02:00
  71f55928b6
• Merge branch 'master' into mania-bring-back-touch-controls
  Dean Herbert · 2025-03-12 18:42:39 +09:00
  007198fd98
• Apply suggested renames
  Salman Alshamrani · 2025-03-11 09:06:01 -04:00
  b64e69d581
• Fix placement blueprint tests
  Bartłomiej Dach · 2025-03-11 07:55:48 +01:00
  c962210b4f
• Replace toggles with a single dropdown
  Salman Alshamrani · 2025-03-10 04:45:32 -04:00
  857b8637ae
• Bring back touch control under a setting
  Salman Alshamrani · 2025-03-10 03:48:45 -04:00
  edcc607f4b
• Add "discard unsaved changes" operation to beatmap editor

  Apparently useful in modding workflows when you want to test out a few
  different variants of a thing.
  
  Re-uses `Ctrl-L` binding from stable. Some folks may argue that the
  dialog makes the hotkey pointless, but I really do want to protect
  users from accidental data loss, and also if you want to power through
  it quickly, you can hit the 1 key when the dialog shows, which will
  bypass the hold-to-activate period (which wasn't intentional, but so
  many people want a bypass at this point that we're probably keeping that
  behaviour for power users).

  Bartłomiej Dach · 2025-03-05 14:34:44 +01:00
  3f461c0734
• Minor bump some packages
  Dean Herbert · 2025-02-17 15:23:26 +09:00
  db4a4a1723
• Merge pull request #31368 from frenzibyte/mobile-fix-mania

  Improve osu!mania playability on mobile devices

  Dean Herbert · 2025-02-01 14:49:46 +09:00
  cf3a379b1c
• Revert unnecessary inheritance

  Everyone is right, too much inheritance and polymorphism backfires very badly.

  Salman Alshamrani · 2025-01-25 19:12:37 -05:00
  8151c3095d
• Fix tests
  Bartłomiej Dach · 2025-01-24 11:59:07 +01:00
  269ade178e
• Remove dependence of blueprint containers on IPositionSnapProvider
  Bartłomiej Dach · 2025-01-24 11:59:05 +01:00
  15b6e28ebe
• Fix mania fade in test not actually testing the mod
  Salman Alshamrani · 2025-01-12 22:57:35 -05:00
  4774d9c9ae
• Merge branch 'master' into mobile-fix-mania
  Salman Alshamrani · 2025-01-12 02:00:49 -05:00
  f121b03a78