1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-24 23:12:54 +08:00
Commit Graph

24 Commits

Author SHA1 Message Date
Dan Balasescu
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Dean Herbert
00e3af3366 Update model manager and many related classes to get things compiling again 2022-01-12 17:00:00 +09:00
Bartłomiej Dach
15feb17da8
Change difficulty cache storage type to nullable
The recent changes related to adding support for working beatmap load
cancellation exposed a flaw in the beatmap difficulty cache. With the
way the difficulty computation logic was written, any error in the
calculation process (including beatmap load timeout, or cancellation)
would result in a 0.00 star rating being permanently cached in memory
for the given beatmap.

To resolve, change the difficulty cache's return type to nullable.
In failure scenarios, `null` is returned, rather than
`default(StarDifficulty)` as done previously.
2021-11-20 17:00:50 +01:00
Dean Herbert
7c2e79f911 Update all simple cases of switching to IWorkingBeatmap 2021-11-17 20:56:57 +09:00
Dean Herbert
51a353e12d Rename BeatmapInfo.Version to DifficultyName to match underlying interface 2021-11-11 17:20:53 +09:00
Dean Herbert
ebe58cee11 Rename BeatmapInfo.StarDifficulty to StarRating to match underlying interface 2021-11-11 17:19:46 +09:00
Dean Herbert
3598adb344 Fix test implementing old version of class 2021-10-29 17:04:56 +09:00
Dean Herbert
cf633973a9 Refactor exposed mod retrieval methods for better safety 2021-09-10 11:09:13 +09:00
Dean Herbert
665bd3690a Add a few cases of missing ConfigureAwait calls in tests project 2021-07-30 15:27:24 +09:00
Dean Herbert
78c74e97d1 Change to alternative formatting 2021-07-12 18:08:19 +09:00
Dean Herbert
3642febbb6 Fix one new incorrect formatting inspection from EAP6 2021-07-12 12:35:40 +09:00
Salman Ahmed
db361efecf Add test beatmap difficulty cache with calc. blocking support 2021-05-14 15:53:56 +03:00
Dean Herbert
9ba412d27e Add the osu! logo to the test scene
Makes no sense to add a test intended to test visual behaviour with one
of the main elements missing. Not sure how you would be able to test the
flow with the logo's presence.
2021-05-10 12:44:08 +09:00
Dean Herbert
b7acf9de52 Make test work without manually clicking things 2021-05-10 12:36:56 +09:00
Dean Herbert
2b90bc4f1f Remove unnecessary ruleset switching steps 2021-05-10 12:35:37 +09:00
Dean Herbert
0c973feb53 Tidy up test scene 2021-05-10 12:34:21 +09:00
Salman Ahmed
8fba655d2e Allow changing ruleset during test 2021-05-08 23:02:38 +03:00
Salman Ahmed
f701c331f2 Add initial fade in to the metadata display
Avoids first frame discrepancies from appearing in the test scene, those can be delt with later on, if needed.
2021-05-08 21:19:46 +03:00
Salman Ahmed
ca55287dd0 Pass empty facade and replace random property with method instead 2021-05-08 18:43:45 +03:00
Salman Ahmed
d9605e8070 Remove test scene description 2021-05-08 18:18:23 +03:00
Salman Ahmed
26c0010fe6 Fix test not handling 0 beatmap sets 2021-05-08 13:03:50 +03:00
Salman Ahmed
dca5efc59a Remove no longer necessary ruleset info requirement 2021-05-08 13:00:39 +03:00
Salman Ahmed
b4801faf32 Pass ruleset info to constructor instead
Follows the way working beatmap is passed, not sure why mods are passed as a bindable though, don't wanna bother too much with that.
2021-05-08 11:57:13 +03:00
Salman Ahmed
169a283402 Add visual test scene 2021-05-08 11:47:18 +03:00