48683 Commits

This Branch

This Branch

All Branches

• Fix crash when selecting swap mod as freemod
  Dan Balasescu · 2022-02-02 18:42:22 +09:00
  b5fb3b7dae
• Merge pull request #16738 from peppy/fix-ruleset-incorrectly-loading

  Fix rulesets potentially being marked `Available` even when methods are missing

  Dan Balasescu · 2022-02-02 18:03:04 +09:00
  db0f3b7f5e
• Merge pull request #16739 from nekodex/cursor-tap

  Add cursor 'tap' audio feedback

  Dean Herbert · 2022-02-02 17:02:33 +09:00
  6260c5fc13
• Merge branch 'master' into cursor-tap
  Dean Herbert · 2022-02-02 16:34:34 +09:00
  cb31ce812c
• Update resources
  Dean Herbert · 2022-02-02 16:27:59 +09:00
  4758de226b
• Fix rulesets potentially being marked Available even when methods are missing

  Came up when running the game after the recent breaking changes
  (https://github.com/ppy/osu/pull/16722), where two template rulesets I
  had loaded were erroring on startup but still being marked as available,
  allowing them to crash the game on attempting to initiate relpay logic.
  
  These cases are already handled for first-time ruleset loading via the
  `GetTypes()` enumeration in `RulesetStore.addRuleset`, but when
  consistency checking already present rulesets the only runtime
  validation being done was `ruleset.CreateInstance()`, which does not
  handle missing types or methods.

  Dean Herbert · 2022-02-02 14:52:01 +09:00
  0c5da9370a
• Change from click to mousedown+mouseup and only play when cursor is visible
  Jamie Taylor · 2022-02-02 14:44:06 +09:00
  6e60e68b80
• Merge pull request #16726 from dekrain/leaderboard-score-tooltip

  Add basic tooltip for leaderboard scores

  Dean Herbert · 2022-02-02 13:56:45 +09:00
  6d962e7925
• Merge pull request #16658 from Spooghetti420/no-long-notes-mod

  Add "Hold Off" mod (no long notes)

  Dean Herbert · 2022-02-02 13:35:44 +09:00
  4b646709c1
• Update description
  Dean Herbert · 2022-02-02 13:34:23 +09:00
  ddc8094a75
• Fix crash due to MatchLeaderboardScores not having populated rulesets
  Dean Herbert · 2022-02-02 13:23:49 +09:00
  d065e32ca1
• Revert mod flow changes and add visual test coverage showing an overflow case
  Dean Herbert · 2022-02-02 09:13:19 +09:00
  35b7653290
• Merge pull request #16734 from bdach/war-on-unused-params

  Fix several cases of unused constructor and method parameters

  Dean Herbert · 2022-02-02 07:40:58 +09:00
  6033c89e7b
• Remove unused game host parameter

  No longer used since eeccf836ec.

  Bartłomiej Dach · 2022-02-01 21:53:21 +01:00
  3674ed15ce
• Remove unused allowMissing parameter in audio file check test

  No longer used since 7f95400f46.

  Bartłomiej Dach · 2022-02-01 21:53:21 +01:00
  b978010b48
• Remove unused FindProvider() methods

  No longer needed since 39f99bf785.

  Bartłomiej Dach · 2022-02-01 21:53:21 +01:00
  7cdf63c654
• Remove index ctor param from ColumnHitObjectArea

  No longer used since 5692cecaa4.

  Bartłomiej Dach · 2022-02-01 21:49:52 +01:00
  e4028b8fc1
• Remove skin ctor param from LegacyCatchComboCounter

  No longer used since 004798d61d.

  Bartłomiej Dach · 2022-02-01 21:49:52 +01:00
  e042f29ee3
• Remove unused ruleset ctor params from test beatmap model managers

  No longer used since 00e3af3366.

  Bartłomiej Dach · 2022-02-01 21:49:41 +01:00
  75101b1105
• Remove Host ctor param from SkinModelManager

  No longer used since 29d074bdb8.

  Bartłomiej Dach · 2022-02-01 21:37:19 +01:00
  994fb966b6
• Remove unused parameter from createGameplayComponents()

  No longer used since 136843c8e4.

  Bartłomiej Dach · 2022-02-01 21:35:41 +01:00
  07d09b3520
• Remove unused parameters in LegacyComboCounter

  No longer used since 9bb8a43bce.

  Bartłomiej Dach · 2022-02-01 21:35:41 +01:00
  a94702b3ae
• Remove unused parameter from createColourBars()

  No longer used since b61aa660c6.

  Bartłomiej Dach · 2022-02-01 21:35:40 +01:00
  1fa2bf5d69
• Remove unused parameter from createContent()

  No longer used since 513e470b52.

  Bartłomiej Dach · 2022-02-01 21:35:40 +01:00
  c6a65ccfed
• Remove IIpcHost param from ScoreManager

  No longer used since 3e3b9bc963.

  Bartłomiej Dach · 2022-02-01 21:35:40 +01:00
  16e0cc6a2b
• Fix RealmLive unnecessarily passing ID around

  Appears to have never been needed. When the `retrieveFromID` method was
  created in 81b5717ae7, it didn't use the
  `id` parameter for anything either.

  Bartłomiej Dach · 2022-02-01 21:35:12 +01:00
  a378e78ced
• Fix BeatmapMetadata not using its user param correctly
  Bartłomiej Dach · 2022-02-01 21:16:28 +01:00
  3d7af805a3
• Cleanup tooltip layout

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  dekrain · 2022-02-01 20:26:52 +01:00
  eee020f8e4
• Improve beat length logic

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Spooghetti420 · 2022-02-01 13:36:36 +00:00
  b75c08c9ab
• Merge pull request #16722 from smoogipoo/spectator-consistency-frames

  Implement spectator consistency frames

  Dean Herbert · 2022-02-01 17:28:13 +09:00
  2c0c44a950
• Add test coverage of no header doing nothing
  Dean Herbert · 2022-02-01 16:55:28 +09:00
  15479ae046
• Add xmldoc for new ResetFromReplayFrame method
  Dean Herbert · 2022-02-01 16:52:53 +09:00
  0f83f77d2b
• Remove unnecessary GridContainer and list mods verticall to give more space
  Dean Herbert · 2022-02-01 16:43:26 +09:00
  f87920cd83
• Synchronise (roughly) backgrounds of all custom tooltips
  Dean Herbert · 2022-02-01 16:35:25 +09:00
  8eace12fe3
• Add test scores in BeatmapLeaderboard test scene with more mods
  Dean Herbert · 2022-02-01 16:35:25 +09:00
  3ca2c90684
• Remove gap in tooltip display between statistics
  Dean Herbert · 2022-02-01 16:35:25 +09:00
  fdb52a8fd7
• Fix potential nullref during display due to incorrect equality check
  Dean Herbert · 2022-02-01 16:13:27 +09:00
  855135c51e
• Fix inspections
  Dean Herbert · 2022-02-01 16:07:57 +09:00
  e1b57c4bf6
• Code quality improvements
  dekrain · 2022-02-01 07:10:00 +01:00
  d7b939277e
• Add missing license header
  dekrain · 2022-02-01 06:51:00 +01:00
  fd287e06f2
• Minor alignment adjustments
  dekrain · 2022-02-01 06:45:59 +01:00
  c2b775c0a3
• Merge branch 'master' into spectator-consistency-frames
  Dan Balasescu · 2022-02-01 14:35:30 +09:00
  0641264a11
• Add basic tooltip for leaderboard scores
  dekrain · 2022-02-01 06:28:18 +01:00
  db973fb348
• Ignore FodyWeavers.xml files in subdirectories

  These are created when building specific projects rather than the main
  solution (typically iOS / android) and of no use to us.

  Dean Herbert · 2022-02-01 13:30:28 +09:00
  aa492270dd
• Update fastlane and dependencies
  Dean Herbert · 2022-02-01 12:43:35 +09:00
  5a6d57efb7
• Merge pull request #16719 from peppy/mania-column-touch

  Add basic touch input support for osu!mania

  Dan Balasescu · 2022-02-01 12:26:29 +09:00
  c421d8d3cd
• Apply suggestion from review

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dan Balasescu · 2022-02-01 10:48:41 +09:00
  c50577e25f
• Pass column in rather than accessing parent
  Dean Herbert · 2022-02-01 00:53:56 +09:00
  2f88efd3c3
• Make incompatible with
  Spooghetti420 · 2022-01-31 15:00:36 +00:00
  e5601772a9
• Reset ScoreProcessor from statistics replay frames
  Dan Balasescu · 2022-01-31 21:32:56 +09:00
  4fb565e15f