68700 Commits

This Branch

This Branch

All Branches

• Hide scroll speed in bottom timeline
  OliBomby · 2024-08-16 14:43:09 +02:00
  b253d8ecbf
• Merge pull request #29433 from OliBomby/grid-anchors

  Fix grid snap slider placement double-click not making new segment if anchor not hovered

  Dan Balasescu · 2024-08-16 17:42:15 +09:00
  3b94d1f8eb
• Attempt file operations more than once in another test instance

  See
  https://github.com/ppy/osu/pull/29433/checks?check_run_id=28833985792.

  Dean Herbert · 2024-08-16 17:39:45 +09:00
  68bad9a277
• Merge pull request #29438 from Joehuu/fix-play-button-click-area

  Fix preview play button having incorrect click area

  Dan Balasescu · 2024-08-16 16:29:49 +09:00
  4ea7d9fb9a
• Fix preview play button having incorrect click area
  Joseph Madamba · 2024-08-15 22:49:12 -07:00
  e2bf02cf94
• Expose BeatmapCardNormal height const
  Joseph Madamba · 2024-08-15 22:49:12 -07:00
  fda17a5a72
• Merge pull request #29434 from OliBomby/change-segment

  Fix PathControlPointVisualiser eating inputs when no control points are selected

  Dean Herbert · 2024-08-16 12:35:46 +09:00
  2024.816.0 e01e630fd7
• Fix inputs being eaten by PathControlPointVisualizer when no control points are selected
  OliBomby · 2024-08-15 23:11:07 +02:00
  00e210147a
• add failure test
  OliBomby · 2024-08-15 22:59:26 +02:00
  29fda745a4
• Fix grid snap slider placement double-click does not make new segment if anchor not hovered
  OliBomby · 2024-08-15 22:49:05 +02:00
  f717938a28
• Merge pull request #29428 from peppy/update-editor-menu-items-difficulty-change

  Ensure the "Change Difficulty" menu uses up-to-date difficulty names

  Dan Balasescu · 2024-08-16 00:44:59 +09:00
  52c1858bbe
• Merge pull request #26254 from frenzibyte/mania-combo-counter

  Add argon/classic osu!mania combo counter

  Dean Herbert · 2024-08-15 17:56:28 +09:00
  5710f0f302
• Merge pull request #29427 from frenzibyte/fix-ruleset-components-beatmap-skin

  Fix beatmap skin always overriding ruleset HUD components

  Dean Herbert · 2024-08-15 17:53:13 +09:00
  e7b4a2f451
• Ensure the "Change Difficulty" menu uses up-to-date difficulty names

  Closes https://github.com/ppy/osu/issues/29391.

  Dean Herbert · 2024-08-15 17:25:30 +09:00
  b5f615882f
• Try make code look better
  Salman Ahmed · 2024-08-15 17:03:08 +09:00
  7427237873
• Update code order to match everything else
  Salman Ahmed · 2024-08-15 16:57:29 +09:00
  358572ebb3
• Fix beatmap skin on mania breaking HUD apart
  Salman Ahmed · 2024-08-15 16:55:05 +09:00
  a421231aad
• Fix beatmap skin always overriding ruleset HUD components
  Salman Ahmed · 2024-08-15 16:47:10 +09:00
  49c71f7863
• Fix mistake
  Dean Herbert · 2024-08-15 16:44:15 +09:00
  4b279ecaa8
• Update MultiplayerClient test output with new knowledge
  Dean Herbert · 2024-08-15 16:16:48 +09:00
  26da2c0637
• Actually bring back position-flipping logic and disable "closest" anchor
  Salman Ahmed · 2024-08-15 15:50:32 +09:00
  66adddbfb8
• Merge pull request #29415 from Joehuu/difficulty-name-content

  Implement song select v2 difficulty name content component

  Dean Herbert · 2024-08-15 15:20:52 +09:00
  9dc496d6a7
• Remove x symbol from argon mania combo counter
  Salman Ahmed · 2024-08-15 15:08:35 +09:00
  3a4546d62d
• Remove position-flipping logic from mania combo counters for now

  We need a general method to do this amicably, such as an HUD target that flips the position of its children when the direction is flipped. Something to consider later.

  Salman Ahmed · 2024-08-15 15:02:18 +09:00
  ff1ab2bb0e
• Merge pull request #29426 from peppy/fix-dot-misalign

  Fix some characters ('.', ',') being misaligned in legacy counters

  Dan Balasescu · 2024-08-15 14:19:53 +09:00
  70cfac0eb8
• Use zero baseline for legacy sprite text display
  Dean Herbert · 2024-08-15 13:07:42 +09:00
  054366b25d
• Merge pull request #29406 from peppy/fix-skin-change-crash

  Fix crash on changing skins when classic mod is enabled and game is rewound

  Dan Balasescu · 2024-08-15 01:04:32 +09:00
  8bfb5cedc4
• Merge pull request #29417 from peppy/remove-main-menu-challenge-tooltip

  Remove daily challenge tooltip from main menu

  Dan Balasescu · 2024-08-14 22:30:56 +09:00
  a6aa35a9b8
• Update remaining tests to use new base class (and tidy up V2 suffixes)
  Dean Herbert · 2024-08-14 21:09:28 +09:00
  e603888130
• Fix failing test setup
  Dean Herbert · 2024-08-14 21:01:35 +09:00
  1665d9a93e
• Remove daily challenge tooltip from main menu

  Now that we have a nice intro screen for the daily challenge, it's
  generally thought that we want to "spoil" the beatmap until the intro is
  shown.
  
  Also I was never a huge fan of having a tooltip on a main menu button..
  just feels a bit odd.

  Dean Herbert · 2024-08-14 20:45:27 +09:00
  28ab65243d
• Merge pull request #29414 from smoogipoo/fix-daily-challenge-2

  Add localisation for daily challenge day/week units

  Dean Herbert · 2024-08-14 18:45:12 +09:00
  58d9a4adba
• Use Content override instead
  Joseph Madamba · 2024-08-14 00:44:03 -07:00
  6f2bc7e6f1
• Inline single-frame layout issue comment instead
  Joseph Madamba · 2024-08-14 00:41:43 -07:00
  11bd0c9a61
• Move other V2 tests to new test namespace
  Dean Herbert · 2024-08-14 15:51:07 +09:00
  2174510544
• Directly resolve IBindable<WorkingBeatmap> by making a local variant of DifficultyNameContent
  Joseph Madamba · 2024-08-13 23:26:18 -07:00
  c24f1444f9
• Move resizing width and background logic to SongSelectComponentsTestScene
  Joseph Madamba · 2024-08-13 23:26:17 -07:00
  f8796e3192
• Workaround single-frame layout issues with {Link|Text|Fill}FlowContainers
  Joseph Madamba · 2024-08-13 23:26:17 -07:00
  2b41f71fd0
• Implement song select v2 difficulty name content component
  Joseph Madamba · 2024-08-13 23:26:17 -07:00
  625c6fc7eb
• Add base song select components test scene
  Joseph Madamba · 2024-08-13 23:26:17 -07:00
  46d41cb590
• Fix incorrect anchor handling in ArgonManiaComboCounter
  Dean Herbert · 2024-08-14 15:12:23 +09:00
  7c142bcedf
• Merge branch 'master' into mania-combo-counter
  Dean Herbert · 2024-08-14 15:12:00 +09:00
  e465049050
• Add localisation for daily challenge day/week units
  Dan Balasescu · 2024-08-14 15:10:55 +09:00
  f882ad4a53
• Merge pull request #29412 from peppy/file-io-test-failure
  Dan Balasescu · 2024-08-14 13:06:14 +09:00
  6840f4bca4
• Fix file access test failure by forcing retries

  See https://github.com/ppy/osu/actions/runs/10369630825/job/28708248682.

  Dean Herbert · 2024-08-14 12:26:21 +09:00
  dd9705b660
• Update test debug output to test second scenario
  Dean Herbert · 2024-08-14 12:23:47 +09:00
  78ef436ea0
• Merge pull request #29403 from smoogipoo/fix-catch-missing-objects

  Fix fruit positions getting mangled when exploded from the plate

  Dean Herbert · 2024-08-14 00:59:56 +09:00
  1b29b9bbb8
• Remove legacy non-pooled pathway to DrawableJudgement
  Dean Herbert · 2024-08-13 21:03:00 +09:00
  2221c4891f
• Add log output when judgements aren't being pooled
  Dean Herbert · 2024-08-13 20:57:23 +09:00
  bb0c9e2497
• Never call prepareDrawables from unsafe context

  I can't mentally figure out *what* is causing the issue here, but in the
  case where `prepareDrawables` is called from
  `JudgementBody.OnSkinChanged` (only happens in a non-pooled scenario),
  things go very wrong.
  
  I think a smell test is enough for anyone to agree that the flow was
  very bad. Removing this call doesn't seem to cause any issues.
  
  `runAnimation` should always be called in `PrepareForUse` (both pooled
  and non-pooled scenarios) so things should still always be in a correct
  state.
  
  Closes #29398.

  Dean Herbert · 2024-08-13 20:57:20 +09:00
  d74ac57092