151 Commits

• Turn tests green, for a short while, maybe (#37218)

  ## [Rewrite `BackgroundMusicManager` to not run into framework
  breakage](https://github.com/ppy/osu/commit/622216d8911832c39fa4e126b2810e4e0f46cbf7)
  
  The attempted proper fix to this was
  https://github.com/ppy/osu-framework/pull/6727. Unfortunately when
  presented with [the framework
  bump](https://github.com/ppy/osu/pull/37217) with that change, CI says
  "you're stupid" and fails on some disposal idiocy that of course is
  undebuggable and irreproducible:
  
  The active test run was aborted. Reason: Test host process crashed :
  Unhandled exception. System.AggregateException: One or more errors
  occurred. (Object reference not set to an instance of an object.)
  ---> System.NullReferenceException: Object reference not set to an
  instance of an object.
  at osu.Framework.Audio.Sample.SampleChannelBass.Dispose(Boolean
  disposing)
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext
  executionContext, ContextCallback callback, Object state)
  	--- End of stack trace from previous location ---
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext
  executionContext, ContextCallback callback, Object state)
  at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task&
  currentTaskSlot, Thread threadPoolThread)
  	   --- End of inner exception stack trace ---
  	   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren()
  	   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren()
  	   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren()
  	   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren()
  	   at osu.Framework.Threading.AudioThread.OnExit()
  at osu.Framework.Threading.GameThread.setExitState(GameThreadState
  exitState)
  	   at osu.Framework.Threading.GameThread.RunSingleFrame()
  at osu.Framework.Threading.GameThread.<createThread>g__runWork|70_0()
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext
  executionContext, ContextCallback callback, Object state)
  	--- End of stack trace from previous location ---
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext
  executionContext, ContextCallback callback, Object state)
  
  
  (https://github.com/ppy/osu/actions/runs/24019928154/job/70046733058?pr=37217#step:5:119)
  
  I no longer have the energy for any of this shit.
  
  @nekodex would appreciate if you could check that I actually haven't
  broken anything with the bgm here. Seems okay to me in test scenes at
  least.
  
  ## [Apply lowest-effort maybe-fixing changes to a bunch of flaking
  tests](https://github.com/ppy/osu/commit/7bd3ca4adfcce5b90add11565a13f3fe9177ad5e)
  
  None of the failures are reproducible locally, of course. I'm tired of
  this. If anyone else wants to subject themselves to actually
  investigating any of these, by all means, godspeed and good luck.

  Bartłomiej Dach · 2026-04-06 17:59:39 +09:00
  809298ddeb
• Fix osu!mania editor not zooming playfield to match timeline (#37176)

  - Fixes CI failures due to completely wrong test (sorry)
  - Fixes #37167 (oops)

  Dean Herbert · 2026-04-02 12:49:45 +02:00
  e207a42889
• "Fix" performance drop caused by changing scroll speed (#37149)

  The fix is just disabling the animation. It works I guess.
  
  ---
  
  - Closes https://github.com/ppy/osu/issues/37042
  
  Currently in Mania, you can change the scroll speed for a brief period
  during the beginning of a song. However this scroll speed change occurs
  over a short period of time, which causes a bunch of extra hit object
  updates, causing major fps and latency drops.
  
  This fix simply replaces the dampening with an immediate scroll speed
  update. Since the scroll speed can only be updated for a short time at
  the beginning of the song, providing immediate visual feedback on the
  scroll speed makes sense to me. However another potential solution would
  be to filter the TimeRange Value updates to keep the gradual scroll
  speed visual change, while greatly reducing the number of updates to the
  hit objects currently on screen.
  
  If there is any feedback I would greatly appreciate it as this is my
  first issue here. I had ran both inspectCode.ps1 and the code formatter
  before creating the merge request. Thank you.
  
  Before fix:
  
  https://github.com/user-attachments/assets/55e30894-7341-414a-af2e-2ec051c3a252
  
  After fix:
  
  https://github.com/user-attachments/assets/c085d33f-c0ae-45dd-8131-e79a5682b9ca
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Austin Moore · 2026-03-31 23:33:53 +09:00
  cbcbc788b8
• Move v2 files to final location

  This contains only renames and namespace updates.

  Dean Herbert · 2026-03-03 16:45:15 +09:00
  c28c64940a
• Move leaderboards classes to gameplay namespace for now
  Dean Herbert · 2026-03-03 16:45:13 +09:00
  54a1417dd8
• Rename one more missed song select v2 class
  Dean Herbert · 2026-02-25 02:18:18 +09:00
  ee8d99034c
• Fix failing test case due to mod overlay being moved to game level
  Dean Herbert · 2026-01-10 01:44:07 +09:00
  dda1c7f75b
• Fix/remove tests broken by screen behaviour change
  Dean Herbert · 2026-01-01 00:29:04 +09:00
  0a2fc12061
• Merge branch 'master' into new-playlists-song-select
  Dan Balasescu · 2025-12-17 13:33:34 +09:00
  67e0348fa8
• Fix dragging volume meter to adjust volume closing overlays if mouse is released outside of overlay content (#35940)

  * Add failing test
  
  * Fix dragging volume meter to adjust volume closing overlays if mouse is released outside of overlay content
  
  Fixes https://osu.ppy.sh/community/forums/topics/2159553.

  Bartłomiej Dach · 2025-12-11 13:47:08 +09:00
  095a67c24e
• Fix tests
  Dan Balasescu · 2025-10-17 09:18:04 +09:00
  b663fe17ab
• Fix test failure due to over-scoping
  Dean Herbert · 2025-08-04 18:53:55 +09:00
  13ff11ac85
• Remove duplicate test
  Dean Herbert · 2025-07-24 13:24:57 +09:00
  ad9584e658
• Adjust variable name
  eyhn · 2025-07-23 22:33:22 +08:00
  843cd86551
• Fix present beatmap audio start at the preview point
  eyhn · 2025-07-23 22:29:07 +08:00
  e55a9e486b
• Fix flaky playlists navigation test

  See: https://github.com/ppy/osu/actions/runs/16267403227/job/45929099025
  
  Repro:
  
  ```diff
  diff --git a/osu.Game/Screens/OnlinePlay/Lounge/LoungeSubScreen.cs b/osu.Game/Screens/OnlinePlay/Lounge/LoungeSubScreen.cs
  index a4e808ff76..db0a0e83a6 100644
  --- a/osu.Game/Screens/OnlinePlay/Lounge/LoungeSubScreen.cs
  +++ b/osu.Game/Screens/OnlinePlay/Lounge/LoungeSubScreen.cs
  @@ -88,6 +88,7 @@ public abstract partial class LoungeSubScreen : OnlinePlaySubScreen, IOnlinePlay
           [BackgroundDependencyLoader(true)]
           private void load()
           {
  +            System.Threading.Thread.Sleep(1000);
               Masking = true;
  
               const float controls_area_height = 25f;
  
  ```

  Dan Balasescu · 2025-07-14 22:41:08 +09:00
  3a3c1c4e09
• Remove duplicated test method
  Dean Herbert · 2025-07-01 17:34:52 +09:00
  99220408f6
• Update existing tests to work with Song Select v2
  Dean Herbert · 2025-07-01 17:25:38 +09:00
  397b9b3994
• Attempt to fix flaky test TestExitWithHoldDisabled

  See
  https://github.com/ppy/osu/actions/runs/15915618971/job/44892620536#step:5:203.
  
  Note that the `DialogOverlay` only finishes loading after the until step
  failure.

  Dean Herbert · 2025-06-27 14:32:58 +09:00
  e713a68c49
• Add back test covering immediate exit song select
  Dean Herbert · 2025-06-04 17:59:08 +09:00
  7d8df1d8d4
• Fix audio not correctly continuing on resuming from gameplay
  Dean Herbert · 2025-06-04 17:39:22 +09:00
  f086be9c18
• Fix test being sensitive to selected tab on new song select
  Bartłomiej Dach · 2025-05-30 10:02:40 +02:00
  9d0d3bb97a
• Add test coverage of volume changing while at song select

  This passes without changes in this pull request. But I'm just copying
  across from https://github.com/ppy/osu/pull/33225 to stay in theme?

  Dean Herbert · 2025-05-27 15:53:31 +09:00
  7d8dc1bd0a
• Fix nullability inspections
  Bartłomiej Dach · 2025-05-15 12:55:21 +02:00
  840e51e6a1
• Disallow adjusting scroll speed during gameplay

  Matches stable. Addresses https://github.com/ppy/osu/discussions/32670.

  Dean Herbert · 2025-04-04 19:46:14 +09:00
  32c60bfb36
• Minor bump some packages
  Dean Herbert · 2025-02-17 15:23:26 +09:00
  db4a4a1723
• Add failing test coverage of random rewind button not working
  Dean Herbert · 2025-01-21 17:24:41 +09:00
  c8cc36e9af
• Fix test potentially false-negative due to realm write delays
  Dean Herbert · 2025-01-17 14:16:38 +09:00
  224f39825f
• Add failing test coverage showing offset adjust is not limited correctly
  Dean Herbert · 2025-01-16 18:05:58 +09:00
  a4174a3644
• Flip navigation test expectations in line with new behaviour
  Dean Herbert · 2025-01-04 00:55:12 +09:00
  1161b7b3c0
• Add test coverage governing new behaviour
  Dean Herbert · 2024-11-28 18:03:19 +09:00
  c26c84ba45
• Also ensure filter is applied when returning to song select
  Dean Herbert · 2024-09-18 17:22:08 +09:00
  743d509241
• Add failing test showing crash at song select on selection edge case
  Dean Herbert · 2024-09-18 16:12:34 +09:00
  aae98e6906
• Fix some tests not always waiting long enough for beatmap loading

  These used to work because there was a huge blocking load operation,
  which is now more asynchronous.
  
  Note that the change made in `SongSelect` is not required, but defensive
  (feels it should have been doing this the whole time).

  Dean Herbert · 2024-08-29 18:42:43 +09:00
  def1abaeca
• Attempt file operations more than once in another test instance

  See
  https://github.com/ppy/osu/pull/29433/checks?check_run_id=28833985792.

  Dean Herbert · 2024-08-16 17:39:45 +09:00
  68bad9a277
• Fix file access test failure by forcing retries

  See https://github.com/ppy/osu/actions/runs/10369630825/job/28708248682.

  Dean Herbert · 2024-08-14 12:26:21 +09:00
  dd9705b660
• Fix TestTouchScreenDetectionAtSongSelect test failure

  https://github.com/ppy/osu/actions/runs/9985890747/job/27597501295
  
  In this case, the settings overlay is taking a very long time to load
  (on a background thread), and pops in when it finishes loading because
  it's been requested to open.
  
  The opens the settings overlay, closes it (by pressing escape, this does
  not actually close it because it's not loaded yet), and then enters song
  select by pressing 'P' 3 times. The settings overlay finishes loading at
  just the right opportune moment to eat one of the 'P' key presses.

  Dan Balasescu · 2024-07-18 16:26:16 +09:00
  1906c2f725
• Add failing test case
  Salman Ahmed · 2024-07-10 16:14:12 +03:00
  8ca8648a09
• Fix confirm exit dialog overflowing from too many ongoing operations
  Salman Ahmed · 2024-07-10 16:06:53 +03:00
  7d667ac46b
• Add medal overlay to game
  Bartłomiej Dach · 2024-02-20 16:31:31 +01:00
  8abcc70b93
• Add failing tests for beatmap inconsistencies
  Dean Herbert · 2024-02-18 19:32:21 +08:00
  415a65bf59
• Add failing test case
  Salman Ahmed · 2024-02-14 02:04:20 +03:00
  a96a66bc9e
• Add failing test coverage of skin getting nuked

  This doesn't fail in headless unfortunately.
  
  Run a few times manually to confirm.

  Dean Herbert · 2024-01-16 15:22:38 +09:00
  0e41d0c9cf
• Add test for crashing scenario
  Bartłomiej Dach · 2024-01-08 21:34:54 +01:00
  8a87301c55
• Use repeat step for more delay between the two exits
  Joseph Madamba · 2024-01-04 09:00:24 -08:00
  b190333c17
• Fix failing tests due to more textboxes being present with searchable dropdowns
  Dean Herbert · 2023-12-13 15:11:47 +09:00
  5e10f9f899
• Split test into two

  They would fail on CI when written as one, and I don't care why.

  Bartłomiej Dach · 2023-11-02 22:14:38 +01:00
  d25b54c06d
• Add failing test covering crash scenario
  Bartłomiej Dach · 2023-11-02 21:24:58 +01:00
  21a4da463b
• Add test scene for basic touchscreen detection scenarios
  Bartłomiej Dach · 2023-11-02 21:24:58 +01:00
  29d4d81eaa
• Automatically activate and deactivate touch device mod in song select
  Bartłomiej Dach · 2023-11-02 19:45:48 +01:00
  2f6ff893b5