59083 Commits

This Branch

This Branch

All Branches

• Change placeComponent to only add to selection, not clear an existing selection
  Dean Herbert · 2023-02-21 14:11:18 +09:00
  af062e7a68
• Only add valid placed components to selected collection on paste
  Dean Herbert · 2023-02-20 20:02:43 +09:00
  43d33d45ca
• Make placeComponent resilient to missing dependencies
  Dean Herbert · 2023-02-20 20:00:12 +09:00
  b68562b033
• Remove copy pasted comment
  Dean Herbert · 2023-02-20 19:57:16 +09:00
  a9c7edd087
• Merge branch 'master' into skin-editor-clipboard
  Bartłomiej Dach · 2023-02-17 22:59:18 +01:00
  704dddf14b
• Merge pull request #22648 from peppy/skinnable-clean-up-documentation

  Refactor structure and naming of skin-related classes

  Bartłomiej Dach · 2023-02-17 21:37:54 +01:00
  23a636b74b
• Merge branch 'master' into skinnable-clean-up-documentation
  Bartłomiej Dach · 2023-02-17 20:59:18 +01:00
  6afa65bd3d
• Rename one more left-over skinnable naming
  Salman Ahmed · 2023-02-17 22:09:55 +03:00
  449e5fa6f8
• Add xmldoc around SkinComponentsContainerLookup
  Dean Herbert · 2023-02-17 14:18:05 +09:00
  1a63ca9ece
• Merge pull request #22338 from Pasi4K5/hide-resume-overlay

  Hide `ResumeOverlay` when `OsuModAutopilot` is enabled

  Bartłomiej Dach · 2023-02-16 22:22:19 +01:00
  9f9893d93a
• Merge branch 'master' into hide-resume-overlay
  Bartłomiej Dach · 2023-02-16 21:33:23 +01:00
  66e9bb2581
• Merge pull request #22645 from peppy/adjust-song-select-background-dim

  Adjust song select background dimming to be more evenly applied

  Bartłomiej Dach · 2023-02-16 21:27:27 +01:00
  bba1722725
• Revert ResumeOverlay setter accessibility change
  Bartłomiej Dach · 2023-02-16 21:26:01 +01:00
  b8084a15eb
• Merge branch 'master' into adjust-song-select-background-dim
  Bartłomiej Dach · 2023-02-16 20:52:36 +01:00
  0186062246
• Remove redundant conditional access qualifier

  It is impossible for the callback passed to `ApplyToBackground()` to
  receive a null reference. See `OsuScreen.ApplyToBackground()` - if the
  background to call the callback on were `null`, then an
  `InvalidOperationException` would be thrown instead.

  Bartłomiej Dach · 2023-02-16 20:47:51 +01:00
  ad5132ed41
• Merge pull request #22658 from peppy/gameplay-sample-trigger-source-test-fix

  Refactor `GameplaySampleTriggerSource` test to not be realtime dependent

  Bartłomiej Dach · 2023-02-16 19:39:18 +01:00
  7d86f49fce
• Add one more assert to keep coverage from previous implementation
  Bartłomiej Dach · 2023-02-16 19:02:51 +01:00
  5bdc5dfadd
• Apply NRT to SerialisedDrawableInfo
  Dean Herbert · 2023-02-16 20:01:59 +09:00
  cb7df7282b
• Fix song select potentially updating background parameters when not the current screen
  Dean Herbert · 2023-02-16 18:45:22 +09:00
  394d368f16
• Refactor GameplaySampleTriggerSource test to not be realtime dependent
  Dean Herbert · 2023-02-16 17:58:44 +09:00
  979c079f8b
• Apply NRT to GamepleSampleTriggerSource tests
  Dean Herbert · 2023-02-16 17:58:44 +09:00
  9d02a2ef0e
• Always create ResumeOverlay, with UseResumeOverlay flag only affecting whether it is displayed or not
  Dean Herbert · 2023-02-16 15:47:20 +09:00
  ce9ef3bc3c
• Merge branch 'master' into hide-resume-overlay
  Dean Herbert · 2023-02-16 15:42:14 +09:00
  7afdcb9383
• Rename left-over skinnable naming in SerialisedDrawableExtensions
  Dean Herbert · 2023-02-16 15:34:41 +09:00
  81dcc105a9
• Standardise all local SkinComponentsContainerLookup variables to containerLookup
  Dean Herbert · 2023-02-16 15:33:56 +09:00
  76f7accd13
• Reword xmldoc on ISerialisableDrawable to make less skin-centric
  Dean Herbert · 2023-02-16 15:31:35 +09:00
  eea0cd3cf8
• Reword and fix typos in some new xmldoc

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2023-02-16 15:27:30 +09:00
  0b25f7baeb
• Add clipboard dependency to SkinEditor specific tests

  This is usually provided by the `SkinEditorOverlay`, which is not always
  present in tests.

  Dean Herbert · 2023-02-16 15:24:38 +09:00
  2fbaf88a3c
• Merge pull request #22292 from ekrctb/maximum-judgement-offset-in-hit-object

  Move MaximumJudgementOffset to HitObject

  Bartłomiej Dach · 2023-02-16 00:52:35 +01:00
  87901bc8b1
• Merge branch 'master' into maximum-judgement-offset-in-hit-object
  Bartłomiej Dach · 2023-02-16 00:15:51 +01:00
  c315113fde
• Merge branch 'master' into skinnable-clean-up-documentation
  Bartłomiej Dach · 2023-02-15 21:26:11 +01:00
  768eea1ea8
• Merge pull request #22647 from peppy/remove-target-component-container

  Simplify and rename `SkinnableTargetComponentsContainer`

  Bartłomiej Dach · 2023-02-15 21:25:49 +01:00
  1d5d34ba0e
• Merge pull request #22646 from peppy/fix-skin-export-matching-directory

  Fix exports failing if a directory exists with the proposed filename

  Bartłomiej Dach · 2023-02-15 19:04:15 +01:00
  455fb7789c
• Make skin editor clipboard shared between screens and skins to allow moving elements over
  Dean Herbert · 2023-02-15 19:35:37 +09:00
  925deb7ca5
• Fix clipboard changes not batching as undo steps
  Dean Herbert · 2023-02-15 19:35:22 +09:00
  bc83b0c264
• Fix components having incorrect default positions
  Dean Herbert · 2023-02-15 19:34:42 +09:00
  bcf2555545
• Add basic skin editor clipboard implementation
  Dean Herbert · 2023-02-15 19:28:42 +09:00
  d653335b6f
• Change GameplaySkinComponentLookup's generic to always be an enum

  And document the class better.

  Dean Herbert · 2023-02-15 18:48:14 +09:00
  08ed174f61
• Rename SkinnableTargetContainer to SkinComponentsContainer

  Also use full `SkinComponentsContainerLookup` instead of the sub-type.
  This will potentially be useful once we bring in per-ruleset targets.

  Dean Herbert · 2023-02-15 18:37:41 +09:00
  a92e42bb84
• Move extension methods closer to serialisation classes
  Dean Herbert · 2023-02-15 18:37:41 +09:00
  b1cf6d83d8
• Move the lookup type out of ISserialisableDrawableContainer
  Dean Herbert · 2023-02-15 18:37:41 +09:00
  e61d2d571c
• Rename ISkinnableTarget to ISerialisableDrawableContainer
  Dean Herbert · 2023-02-15 18:37:41 +09:00
  a7b47f6503
• Rename ISkinnableDrawable to ISerialisableDrawable
  Dean Herbert · 2023-02-15 18:37:41 +09:00
  d159d6b970
• Add further documentation to skin classes
  Dean Herbert · 2023-02-15 18:23:19 +09:00
  8cb5a51aa7
• Rename SkinnableDrawableInfo to SerialisedDrawableInfo
  Dean Herbert · 2023-02-15 18:23:19 +09:00
  856efd9fd9
• Rename SkinnableInfo to SkinnableDrawableInfo
  Dean Herbert · 2023-02-15 18:23:17 +09:00
  9e651a7ca2
• Move SkinnableInfo to better namespace
  Dean Herbert · 2023-02-15 18:23:10 +09:00
  6010dde86e
• Fix test container lookup failure
  Dean Herbert · 2023-02-15 17:47:34 +09:00
  d9b4d932c9
• Apply NRT to TestSceneBeatmapSkinFallbacks
  Dean Herbert · 2023-02-15 17:30:21 +09:00
  ca75f0ec77
• Simplify and rename SkinnableTargetComponentsContainer
  Dean Herbert · 2023-02-15 17:30:21 +09:00
  8bbd00822c