osu-lazer

Fix garbage data in test case

Bartłomiej Dach · 2025-04-17 11:37:28 +02:00

5f4afe156f

Make some test methods static for future reuse

Dean Herbert · 2025-04-16 19:41:49 +09:00

2ac1b89037

Add failing test

Bartłomiej Dach · 2025-04-16 10:27:05 +02:00

64b9d4642a

Extract leaderboard fetch logic from song select beatmap leaderboard drawable

RFC. Another attempt at this.

- Supersedes https://github.com/ppy/osu/pull/31881
- Supersedes / closes https://github.com/ppy/osu/pull/31355
- Closes https://github.com/ppy/osu/issues/29861

This is a weird diff because I am feeling rather boxed in by all the
constraints, namely that:

- Leaderboard state should be global state
- But the global state is essentially managed by song select and namely
  `BeatmapLeaderboard` itself. That's because trying to e.g. not have
  `BeatmapLeaderboard` pass the beatmap and the ruleset to the global
  leaderboard manager is worse, as it essentially introduces two
  parallel paths of execution that need to be somehow merged into one
  (as in I'd have to somehow sync `LeaderboardManager` responding to
  beatmap/ruleset changes with `BeatmapLeaderboard` which is inheritance
  hell)
- Also local leaderboard fetching is data-push (as in the scores can
  change under the leaderboard manager), and online leaderboard fetching
  is data-pull (as in the scores do not change unless the leaderboard
  manager does something). Also online leaderboard fetching can fail.
  Which is why I need to still have the weird setup wherein there's a
  `FetchWithCriteriaAsync()` (because I need to be able to respond to
  online requests taking time, or failing), but also the
  `BeatmapLeaderboard` only uses the public `Scores` bindable to
  actually read the scores (because it needs to respond to new local
  scores arriving).
- Another thing to think about here is what happens when a retrieval
  fails because e.g. the user requested friend leaderboards without
  having supporter. With how this diff is written, that special
  condition is handled to `BeatmapLeaderboard`, and
  `LeaderboardManager`'s state will remain as whatever it was before
  that scope change was requested, which may be considered good or it
  may not (I imagine it's better to show scores in gameplay than not in
  this case, but maybe I'm wrong?)

Bartłomiej Dach · 2025-03-21 12:06:16 +01:00

0209129618

Add support for team beatmap leaderboards

Dean Herbert · 2025-03-13 16:28:20 +09:00

b0cf5e8bff

Add visual test coverage

Bartłomiej Dach · 2025-03-07 08:51:55 +01:00

33dccfcec8

Try to fix test

Bartłomiej Dach · 2025-03-05 12:32:58 +01:00

7975c301a8

Add failing test coverage

Bartłomiej Dach · 2025-03-05 09:21:47 +01:00

abc4955e81

Add test coverage of stores stored in database as well

Dean Herbert · 2023-02-08 15:38:07 +09:00

38031fdf23

Improve test to also check that reverting hash restores old scores

Dean Herbert · 2023-02-08 15:34:46 +09:00

d4d985ba0f

Clean up tests somewhat

Dean Herbert · 2023-02-08 15:22:17 +09:00

c7eec371f5

Add leaderboard test on beatmap update

Cootz · 2023-02-08 05:01:54 +03:00

338d96534a

Update reference

PC · 2023-02-07 11:52:47 +03:00

7e127dafe2

Fix test's score generation

Cootz · 2023-02-07 02:29:28 +03:00

cb26601cb4

Partial everything

Dan Balasescu · 2022-11-27 00:00:27 +09:00

7bc8908ca9

Apply NRT to base Leaderboard classes

Dean Herbert · 2022-09-26 16:12:47 +09:00

a1297af441

Remove async calls from ScoreManager

Dan Balasescu · 2022-08-29 15:34:08 +09:00

423f6f90f2

Remove unused RulesetStore from BeatmapManager constructor

Dean Herbert · 2022-07-28 16:19:05 +09:00

2b9d46d803

Country -> CountryCode

Salman Ahmed · 2022-07-18 08:40:34 +03:00

100c53f9ef

Update various usages of Country inline with new enum

Salman Ahmed · 2022-07-16 05:04:24 +03:00

e62049f4a9

Fix build failing on tests

Salman Ahmed · 2022-07-11 21:45:39 +03:00

09bfca4e4a

Automated #nullable processing

Dan Balasescu · 2022-06-17 16:37:17 +09:00

f8830c6850

Update further tests to cache using IDialogOverlay

Salman Ahmed · 2022-04-18 21:04:22 +03:00

3cbc6cd297

Add specific placeholder message for custom rulesets rather than showing network error

Dean Herbert · 2022-03-02 14:10:59 +09:00

c342030b2c

Merge pull request #16890 from peppy/beatmap-decoder-ruleset-store

Fix `LegacyBeatmapDecoder` not populating correct rulesets

Dan Balasescu · 2022-02-25 19:03:43 +09:00

3a03833912

Merge scoreboard and leaderboard implementations together

dekrain · 2022-02-19 20:47:02 +01:00

15ed9ec4fa

Add tests for timerefs

dekrain · 2022-02-17 10:38:29 +01:00

f4d1e6f600

Update existing usages to point to RealmRulesetStore

Dean Herbert · 2022-02-16 17:13:54 +09:00

0138f22c8d

Revert mod flow changes and add visual test coverage showing an overflow case

Dean Herbert · 2022-02-02 09:13:19 +09:00

35b7653290

Add test scores in BeatmapLeaderboard test scene with more mods

Dean Herbert · 2022-02-01 16:35:25 +09:00

3ca2c90684

Track loading via state as well

Dean Herbert · 2022-01-31 01:12:03 +09:00

f8939af5e6

Disallow setting "NoScores" externally as it is handled internally

Dean Herbert · 2022-01-30 16:18:19 +09:00

04dbb5d3c6

Consolidate flows of Set operations, either result or error

Dean Herbert · 2022-01-30 16:16:00 +09:00

acc1199add

Also refactor placeholder logic to make more sense

Dean Herbert · 2022-01-30 10:50:32 +09:00

c401629dd8

Fix null beatmap in test scene

Dean Herbert · 2022-01-30 03:02:56 +09:00

06660ff960

Fix assertions to work in both directions

Dean Herbert · 2022-01-30 02:54:51 +09:00

d21464ea61

Change test exposure to property instead of method

Dean Herbert · 2022-01-30 02:29:51 +09:00

51acf79935

Remove pointless tests that no longer show anything valid

Dean Herbert · 2022-01-30 00:03:22 +09:00

9861c50b33

Make score setter private

Dean Herbert · 2022-01-29 23:58:57 +09:00

661fec7c8a

Remove Task from the inner-most Import method in RealmArchiveModelImporter

One of my pending work items for post-realm merge.

The lowest-level import task is no longer asynchronous, as we don't want
it to span multiple threads to allow easier interaction with realm.
Removing the `Task` spec simplifies a heap of usages.

Individual usages should decide whether they want to run the import
asynchronously, by either using an alternative override or spooling up a
thread themselves.

Dean Herbert · 2022-01-25 15:30:29 +09:00

778d2a71b4

Fix cases of Access instead of Realm

Dean Herbert · 2022-01-25 12:58:15 +09:00

3e5c9e8436

Rename RealmContextFactory to RealmAccess

Dean Herbert · 2022-01-24 20:38:07 +09:00

6eb2c28e41

Fix incorrect realm (non-isolated instance) being used in two test scenes

Dean Herbert · 2022-01-17 14:55:23 +09:00

5dc7425b2c

Update one more mismatched test implementation