2675 Commits

• Convert gameplay leaderboard to skinnable component

  This PR converts the leaderboard into a full-fledged skinnable component
  that can be manipulated by users at will.
  
  Notably, this finally allows https://github.com/ppy/osu/issues/20422 to
  be fixed - although it's a very mixed bag, for several reasons:
  
  - Because of taiko players' refusal to see reason^W^W^W^Winsistence on
    keeping stable behaviours related to aspect ratio treatment, I have to
    assume the worst case scenario, which means than on typical
    resolutions like 16:9 (or even worse, 4:3), the leaderboard will
    likely not occupy as much vertical space as it probably could.
  
  - Additionally, there's the problem of where to put the spectator list.
    I settled on putting it to the right of the leaderboard, but that's
    kind of janky, because the leaderboard sometimes collapses and
    sometimes fully hides, leading to a very awkward space left behind. If
    we had the capability to anchor elements to other elements, maybe this
    could be resolved, but for now, I'm not sure what to do. I think if
    some users are bothered by it they can move it where they want it. Or
    delete it.

  Bartłomiej Dach · 2025-04-24 13:10:30 +02:00
  59b826c321
• Minor fix to the description text
  Shavixinio · 2025-04-22 19:49:34 +02:00
  3b2382ceb0
• Rename new property to better explain visual-only usage
  Dean Herbert · 2025-04-14 18:38:04 +09:00
  f05a50f4e1
• Introduce numeric value in beatmap hit count statistics
  Salman Alshamrani · 2025-04-12 00:14:53 +09:00
  85556e0c3e
• Shorten beatmap hit statistics names
  Salman Alshamrani · 2025-04-11 02:33:57 +09:00
  1dbcbbde15
• Fix editor setup screen sliders not having correct keyboard steps

  Closes https://github.com/ppy/osu/issues/32691.
  
  Fixes some extra cases of failure that aren't pointed out in the issue.

  Dean Herbert · 2025-04-08 14:45:43 +09:00
  f2088496c5
• Remove obsoleted ScrollTime setting
  Dean Herbert · 2025-04-04 19:46:15 +09:00
  9cdb3fe6ae
• Disallow adjusting scroll speed during gameplay

  Matches stable. Addresses https://github.com/ppy/osu/discussions/32670.

  Dean Herbert · 2025-04-04 19:46:14 +09:00
  32c60bfb36
• Remove unreachable code
  Dan Balasescu · 2025-04-04 10:47:40 +09:00
  db2366b736
• Simplify filter logic
  Bartłomiej Dach · 2025-04-02 09:59:44 +02:00
  446b26c1e6
• Fixed the filter empty condition
  iamnotcoding · 2025-03-31 20:27:22 +09:00
  8e3d05cbb0
• Made key with equal operator intersect with other filters and removed unnecessary value range check
  iamnotcoding · 2025-03-31 20:26:31 +09:00
  9761a64d52
• Added the "!:" option for NotEqual operator
  iamnotcoding · 2025-03-31 18:39:02 +09:00
  e2bdb70daa
• Made it use only one has variable and deleted key exclude function for now
  iamnotcoding · 2025-03-31 18:32:51 +09:00
  e6f3c5351c
• Changed code quality issues
  iamnotcoding · 2025-03-31 17:48:56 +09:00
  80879319bb
• Made it able to include or exclude multiple key mods by comma separated values
  iamnotcoding · 2025-03-30 17:47:33 +09:00
  acffe31e41
• Merge pull request #32357 from Nunolin/mania-invert-end-notes

  Remove end note conversion in mania invert mod (causing unwanted jacks)

  Dan Balasescu · 2025-03-13 21:54:00 +09:00
  01828931a2
• Merge pull request #32344 from frenzibyte/mania-judgement-position-fix

  Improve handling for top-anchored judgement positions in osu!mania

  Dean Herbert · 2025-03-13 12:48:44 +09:00
  02579dc0a4
• Remove end note conversion in mania invert mod
  Nuno · 2025-03-13 01:02:34 +00:00
  a075a5641a
• Merge branch 'master' into mania-bring-back-touch-controls
  Dean Herbert · 2025-03-12 18:42:39 +09:00
  007198fd98
• Remove unused thing
  Dean Herbert · 2025-03-12 18:36:02 +09:00
  92d374a5bb
• Fix weird implementation of layout validation
  Dean Herbert · 2025-03-12 18:34:33 +09:00
  70693c8bb8
• Improve handling for top-anchored judgement positions in osu!mania
  Salman Alshamrani · 2025-03-12 03:05:10 -04:00
  5a5246a407
• Fix touch input area not handling settings changes
  Salman Alshamrani · 2025-03-11 09:17:19 -04:00
  b3ea63598e
• Apply suggested renames
  Salman Alshamrani · 2025-03-11 09:06:01 -04:00
  b64e69d581
• Add draw size invalidation handling to column extension logic

  Also indirectly makes the setting effective during gameplay as requested.

  Salman Alshamrani · 2025-03-11 08:28:24 -04:00
  2af3bebff3
• Fix multiple code inspections
  Dean Herbert · 2025-03-11 17:23:09 +09:00
  4565c271dd
• Fix failing tests
  Salman Alshamrani · 2025-03-10 22:40:24 -04:00
  d5e06102d4
• Fix code quality error
  Salman Alshamrani · 2025-03-10 06:49:52 -04:00
  905afd5714
• Replace toggles with a single dropdown
  Salman Alshamrani · 2025-03-10 04:45:32 -04:00
  857b8637ae
• Bring back mobile landscape column extension logic under a setting
  Salman Alshamrani · 2025-03-10 04:45:32 -04:00
  1f749250ac
• Bring back touch control under a setting
  Salman Alshamrani · 2025-03-10 03:48:45 -04:00
  edcc607f4b
• Hook up portarit setting with behaviour
  Salman Alshamrani · 2025-03-10 03:47:51 -04:00
  918e248cd2
• Add config settings for mania mobile modes
  Salman Alshamrani · 2025-03-10 03:47:06 -04:00
  3cf0031e16
• Add "discard unsaved changes" operation to beatmap editor

  Apparently useful in modding workflows when you want to test out a few
  different variants of a thing.
  
  Re-uses `Ctrl-L` binding from stable. Some folks may argue that the
  dialog makes the hotkey pointless, but I really do want to protect
  users from accidental data loss, and also if you want to power through
  it quickly, you can hit the 1 key when the dialog shows, which will
  bypass the hold-to-activate period (which wasn't intentional, but so
  many people want a bypass at this point that we're probably keeping that
  behaviour for power users).

  Bartłomiej Dach · 2025-03-05 14:34:44 +01:00
  3f461c0734
• Add support for legacy osu!mania barline height and colour spec
  Dean Herbert · 2025-02-28 15:13:13 +09:00
  cb29459a1e
• Add basic setup for mania legacy barline implementation
  Dean Herbert · 2025-02-28 14:43:00 +09:00
  3e8dafa3c5
• Merge branch 'master' into pp-dev
  Dean Herbert · 2025-02-17 11:59:14 +09:00
  ab88ccb081
• Flip the Y offset of skin judgement pieces on flipped scroll direction
  Salman Alshamrani · 2025-02-10 01:52:50 -05:00
  1e06c5cc4a
• Flip mania judgement anchor on flipped scroll direction
  Salman Alshamrani · 2025-02-10 01:52:12 -05:00
  a3cd62ec72
• Calculate hit windows in performance calculator instead of databased difficulty attributes (#31735)

  * Calculate hit windows in performance calculator instead of databased difficulty attributes
  
  * Apply mods to beatmap difficulty in osu! performance calculator
  
  * Remove `GreatHitWindow` difficulty attribute for osu!mania
  
  * Remove use of approach rate and overall difficulty attributes for osu!
  
  * Remove use of hit window difficulty attributes in osu!taiko
  
  * Remove use of approach rate attribute in osu!catch
  
  * Remove unused attribute IDs
  
  * Code quality
  
  * Fix `computeDeviationUpperBound` being called before `greatHitWindow` is set

  James Wilson · 2025-02-07 19:21:12 +09:00
  9f90ebb2f7
• Merge branch 'master' into pp-dev
  Dean Herbert · 2025-02-07 14:09:25 +09:00
  6c069b3373
• Merge pull request #31368 from frenzibyte/mobile-fix-mania

  Improve osu!mania playability on mobile devices

  Dean Herbert · 2025-02-01 14:49:46 +09:00
  cf3a379b1c
• Remove pointless comment
  Dean Herbert · 2025-02-01 14:48:13 +09:00
  cc3bb590c9
• Enable NRT on Column
  Salman Alshamrani · 2025-01-30 08:22:35 -05:00
  64b67252a2
• Fix skin SourceChanged event never being unbound
  Dean Herbert · 2025-01-29 18:16:04 +09:00
  e8d20fb402
• Avoid extra unnecessary DI

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Salman Alshamrani · 2025-01-25 19:12:42 -05:00
  ffc37cece0
• Revert unnecessary inheritance

  Everyone is right, too much inheritance and polymorphism backfires very badly.

  Salman Alshamrani · 2025-01-25 19:12:37 -05:00
  8151c3095d
• Refactor further to avoid weird non-virtual common method
  Bartłomiej Dach · 2025-01-24 13:14:31 +01:00
  daec91f61d
• Remove dependence of placement blueprints on IPositionSnapProvider
  Bartłomiej Dach · 2025-01-24 11:59:07 +01:00
  a6987f5c95