4055 Commits

• Update R# + fix inspections
  Dan Balasescu · 2024-02-02 21:00:28 +09:00
  b44f77cee1
• Show a better message when score submission fails due to system clock being set wrong
  Dean Herbert · 2024-01-31 16:52:50 +09:00
  a7f9f50ce5
• Mark ResultsScreen.Score as nullable

  Is nullable in playlist results at very least.

  Dean Herbert · 2024-01-29 16:43:26 +09:00
  fb24c66342
• Remove unnecessary bindable
  Dean Herbert · 2024-01-29 02:13:39 +09:00
  462dab3c90
• Fix various inconsistencies and document better
  Dean Herbert · 2024-01-29 02:10:33 +09:00
  f4dd84fa77
• Should not be a container
  Dean Herbert · 2024-01-29 01:50:27 +09:00
  23f12e1ea3
• Stop using SliderBar as a base
  Andrei Zavatski · 2024-01-28 18:06:09 +03:00
  b48f99ba4b
• Merge branch 'master' into progress-bar-improvements
  Andrei Zavatski · 2024-01-28 17:59:29 +03:00
  ed9e0fe1db
• Fix song progress value may go beyond 1
  Andrei Zavatski · 2024-01-27 03:11:12 +03:00
  3387565ba9
• Refactor ArgonSongProgress for same CurrentTime meaning
  Andrei Zavatski · 2024-01-27 03:03:01 +03:00
  567d2bedbf
• Move cast to local function and make direct cast
  Dean Herbert · 2024-01-26 12:55:36 +09:00
  6e3eb674f6
• Move common logic into own SongProgressBar class
  Andrei Zavatski · 2024-01-26 05:03:40 +03:00
  9b5b313193
• Remove useless bindable from ArgonSongProgressBar
  Andrei Zavatski · 2024-01-26 04:09:00 +03:00
  d2af05b30e
• Remove LINQ cast in HUDOverlay
  Andrei Zavatski · 2024-01-26 01:03:22 +03:00
  542f571dee
• Fix ArgonScoreCounter is still using localisation
  Andrei Zavatski · 2024-01-25 03:28:02 +03:00
  7811968582
• Avoid using .Children for enumeration in other locations
  Dean Herbert · 2024-01-23 05:32:11 +09:00
  02bb506cce
• Reduce enumerator overhead in GameplayLeaderboard
  Dean Herbert · 2024-01-23 05:31:53 +09:00
  069af13aaf
• Merge pull request #26609 from peppy/fix-per-ruleset-hud-positioning

  Fix gameplay elements not correctly offsetting to avoid per-ruleset skin layout

  Bartłomiej Dach · 2024-01-22 15:00:03 +01:00
  49c117793c
• Merge pull request #26591 from peppy/offset-awareness

  Show offset explanation tooltip on settings offset adjust slider bar

  Bartłomiej Dach · 2024-01-22 14:59:31 +01:00
  95435ecd13
• Merge branch 'master' into fix-per-ruleset-hud-positioning
  Bartłomiej Dach · 2024-01-22 13:55:56 +01:00
  b8dd78eec8
• Revert keyboard seek speed change
  Dean Herbert · 2024-01-22 21:47:38 +09:00
  15df6b1da1
• Fix crash if ruleset components container is not present
  Bartłomiej Dach · 2024-01-22 13:45:55 +01:00
  99d3fcc326
• Merge pull request #26649 from peppy/fix-more-allocations

  Remove `FillFlow` overhead of argon counters

  Bartłomiej Dach · 2024-01-22 12:57:16 +01:00
  0d6c681275
• Merge pull request #26662 from peppy/fix-player-crash

  Fix potential null reference in player screen transition handling

  Bartłomiej Dach · 2024-01-22 11:07:16 +01:00
  b7f0102461
• Merge branch 'master' into replay-seek-single-frame
  Bartłomiej Dach · 2024-01-22 09:36:15 +01:00
  1ac682e2c9
• Merge pull request #26605 from peppy/simplify-gameplay-pause

  Simplify gameplay pause sequence

  Bartłomiej Dach · 2024-01-22 08:49:08 +01:00
  493d495992
• Fix potential null reference in player screen transition handling

  See https://github.com/ppy/osu/actions/runs/7607677219/job/20715418536?pr=26660.

  Dean Herbert · 2024-01-22 16:37:56 +09:00
  3e5fe66e58
• Remove FillFlow overhead of argon counters
  Dean Herbert · 2024-01-21 13:22:58 +09:00
  02369139b3
• Move seek/step logic into ReplayPlayer
  Dean Herbert · 2024-01-18 20:38:15 +09:00
  c50534c819
• Keep replay controls expanded by default
  Dean Herbert · 2024-01-18 20:13:32 +09:00
  8c4af58109
• Add ability to step forward/backwards single frames
  Dean Herbert · 2024-01-18 20:13:32 +09:00
  60e972cd15
• Tidy up implementation of PlaybackSettings
  Dean Herbert · 2024-01-18 20:13:32 +09:00
  dafff26d0e
• Remove test guarantee of audio time not advancing
  Dean Herbert · 2024-01-18 20:06:53 +09:00
  c4e9bcd140
• Merge pull request #26542 from peppy/non-touch-fade-button

  Fade hold-for-menu button out completely on non-touch devices

  Bartłomiej Dach · 2024-01-18 11:27:50 +01:00
  2be989b9f5
• Fix gameplay elements not correcly offsetting to avoid per-ruleset skin layout

  Closes https://github.com/ppy/osu/issues/26601.

  Dean Herbert · 2024-01-18 15:44:27 +09:00
  ee3de9c522
• Remove "pause rate adjust" flow
  Dean Herbert · 2024-01-18 14:21:02 +09:00
  8ab8c90e33
• Simplify gameplay pause sequence
  Dean Herbert · 2024-01-18 14:17:19 +09:00
  799c74cfe5
• Merge pull request #26593 from peppy/rolling-counter-unstick

  Change rolling counters to use quicker easing types

  Bartłomiej Dach · 2024-01-17 14:37:52 +01:00
  b718897b30
• Merge pull request #26502 from frenzibyte/prevent-submission-with-invalid-mods

  Add guard against submitting score with invalid mod instances

  Bartłomiej Dach · 2024-01-17 11:39:32 +01:00
  5cb17bcacf
• Merge pull request #26549 from bdach/hit-error-meter-pooling-bad

  Fix `ColourHitErrorMeter` not loading pooled drawables ahead of time

  Dean Herbert · 2024-01-17 18:43:47 +09:00
  456a8e6e82
• Change rolling counters to use quicker easing types
  Dean Herbert · 2024-01-17 18:18:53 +09:00
  a66ddc7813
• Show tooltip on global offset adjust slider bar
  Dean Herbert · 2024-01-17 17:57:49 +09:00
  cc7be137bc
• Change display text for beatmap audio offset adjust to make more sense
  Dean Herbert · 2024-01-17 17:51:46 +09:00
  123e36a999
• Merge pull request #26446 from LeNitrous/add/replay-playback-controls

  Add replay playback controls

  Dean Herbert · 2024-01-17 17:06:15 +09:00
  c1c2e61723
• Fix test failures
  Dean Herbert · 2024-01-17 16:40:45 +09:00
  e97b31d82e
• Make PlayerSettingsOverlay's api more stringent
  Dean Herbert · 2024-01-17 15:13:59 +09:00
  e7732caaf7
• Add tooltips and localisation
  Dean Herbert · 2024-01-17 15:12:33 +09:00
  2788bd912e
• Change replay playback adjustment to skew frequency, not tempo
  Dean Herbert · 2024-01-17 15:02:42 +09:00
  e53989faeb
• Adjust playback speed range to allow slower minimum speed
  Dean Herbert · 2024-01-17 15:02:42 +09:00
  042e852a3e
• Move load procedure to async method and simplify code
  Dean Herbert · 2024-01-17 15:02:42 +09:00
  42f64c2c44