41381 Commits

This Branch

This Branch

All Branches

• Convert RulesetResourcesSkin to plain ResourcesSkin and pass non-null resources
  Salman Ahmed · 2021-06-24 10:07:38 +03:00
  a98b5618b8
• Handle case where SkinManager sources aren't part of AllSources

  In tests.

  Salman Ahmed · 2021-06-23 10:44:23 +03:00
  d484469906
• Add ruleset resources skin before SkinManager.DefaultSkin
  Salman Ahmed · 2021-06-23 10:09:25 +03:00
  53fa229880
• Enable NRT in RulesetResourcesSkin
  Salman Ahmed · 2021-06-23 09:52:00 +03:00
  2e6800f586
• Dispose resource stores on finalizer
  Salman Ahmed · 2021-06-23 09:41:45 +03:00
  0db06c727b
• Resolve conflict issues
  Salman Ahmed · 2021-06-22 20:38:24 +03:00
  ee84364d7c
• Merge branch 'master' into ruleset-resources-skin
  Salman Ahmed · 2021-06-22 20:36:49 +03:00
  896c1dc202
• Merge pull request #13605 from aitani9/overlay-item-sound-edge

  Empty the space between `OverlayStreamItem`s

  Dan Balasescu · 2021-06-22 22:13:39 +09:00
  bdc440f11c
• Merge pull request #13423 from frenzibyte/transformers-per-skin

  Refactor ruleset skin transforming logic to be per-`ISkin` rather than one `ISkinSource`

  Dean Herbert · 2021-06-22 21:24:56 +09:00
  4cb9c6a842
• Merge pull request #13610 from gagahpangeran/markdown-heading-font-size

  Change osu markdown heading to use actual font size

  Dan Balasescu · 2021-06-22 20:58:48 +09:00
  e39ce6cc67
• Merge pull request #13615 from peppy/mod-utils-check-duplicate-mods

  Ensure duplicate mods cannot be defined

  Dan Balasescu · 2021-06-22 20:28:40 +09:00
  c436f9f0fa
• Merge branch 'master' into markdown-heading-font-size
  Dan Balasescu · 2021-06-22 20:21:25 +09:00
  883b3e56f4
• Fix potential null reference in LINQ method
  Salman Ahmed · 2021-06-22 12:25:29 +03:00
  37f7486fb1
• Update and improve code documentation

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Salman Ahmed · 2021-06-22 12:05:17 +03:00
  71e2815e7e
• Remove unused using directive
  Salman Ahmed · 2021-06-22 12:03:55 +03:00
  ece63b9ba1
• Implement FindProvider and AllSources properly on all test ISkinSources
  Salman Ahmed · 2021-06-22 12:03:14 +03:00
  31cbb36a64
• Update framework
  Dean Herbert · 2021-06-22 17:59:24 +09:00
  b8126e3ca8
• Fix incorrect existing test case
  Dean Herbert · 2021-06-22 17:41:27 +09:00
  6e0801b852
• Ensure duplicate mods cannot be defined
  Dean Herbert · 2021-06-22 17:41:20 +09:00
  c4fde635c6
• Merge pull request #13349 from ribbanya/skin-editor-closest-anchor

  Allow skin elements to find closest anchor

  Dean Herbert · 2021-06-22 17:31:05 +09:00
  2bea44fe94
• Fix potentially providing the same skin instance twice in AllSources
  Salman Ahmed · 2021-06-22 10:49:37 +03:00
  c1284940e1
• Reuse AllSources when looking up on FindProvider
  Salman Ahmed · 2021-06-22 10:49:21 +03:00
  d0cdc07b11
• Remove all test skinning changes in favour of the ISkinSource.AllSources path
  Salman Ahmed · 2021-06-22 10:48:03 +03:00
  b12adc6073
• Merge branch 'master' into skin-editor-closest-anchor
  Dean Herbert · 2021-06-22 16:41:51 +09:00
  1fff9a93b9
• Move scoped functionality into local function
  Dean Herbert · 2021-06-22 16:40:56 +09:00
  4b3165084d
• Reword xmldoc
  Dean Herbert · 2021-06-22 16:40:48 +09:00
  ffac32a848
• Merge pull request #13606 from Naxesss/low-diff-checks

  Add low difficulty spacing checks

  Dean Herbert · 2021-06-22 16:29:37 +09:00
  6c3d2315d0
• Add missing newline
  Dean Herbert · 2021-06-22 16:20:09 +09:00
  14bdcef26b
• Expose skin sources via ISkinSource and revert to consuming based on hierarchy
  Dean Herbert · 2021-06-22 16:19:55 +09:00
  0ad189e357
• Merge branch 'master' into transformers-per-skin
  Dean Herbert · 2021-06-22 16:03:15 +09:00
  1b0aadcc6f
• Merge pull request #13611 from ekrctb/remove-unused-argument

  Remove unused constructor argument from `CatchPlayfield`

  Dan Balasescu · 2021-06-22 15:54:31 +09:00
  d8b23bb841
• Remove unused argument from CatchPlayfield
  ekrctb · 2021-06-22 15:23:50 +09:00
  b54e82eb99
• Move some inline comments on consts to xmldoc instead
  Dean Herbert · 2021-06-22 15:16:19 +09:00
  e9339d6100
• add font size in HeadingTextFlowContainer
  Gagah Pangeran Rosfatiputra · 2021-06-22 12:24:56 +07:00
  5c3129f1a2
• change GetFontSizeByLevel to return actual font size
  Gagah Pangeran Rosfatiputra · 2021-06-22 12:24:25 +07:00
  f89c154e18
• Fix leak due to not properly unbinding SourceChanged event on disposal
  Salman Ahmed · 2021-06-22 05:05:41 +03:00
  ec040ff3fc
• Fix default skin potentially added twice in RulesetSkinProvidingContainer
  Salman Ahmed · 2021-06-22 03:45:43 +03:00
  caa90bccc6
• Propagate SourceChanged events from SkinManager down in the ruleset skin container
  Salman Ahmed · 2021-06-22 03:45:24 +03:00
  627c857da8
• Add xmldoc to SkinManager

  The `<summary>` part comes from `BeatmapManager`, which I believe works correctly here as well, as this does handle the "storage and retrieval" of skins.

  Salman Ahmed · 2021-06-22 03:07:31 +03:00
  9e5bb146d3
• Add back SkinManager.DefaultSkin to the ruleset skin lookup sources
  Salman Ahmed · 2021-06-22 02:54:34 +03:00
  97dbc7f20e
• Isolate RulesetSkinProvidingContainer from falling back to parent skin sources

  For simplicity of lookup order, and which sources are used for the lookup.

  Salman Ahmed · 2021-06-22 02:53:22 +03:00
  d53a43cf3c
• Add ability to disallow falling back to parent skins
  Salman Ahmed · 2021-06-22 02:51:17 +03:00
  ebe0d43790
• Use margin instead of padding
  aitani9 · 2021-06-21 13:42:15 -07:00
  36e459e97e
• Add time distance equality tests
  Naxess · 2021-06-21 15:34:11 +02:00
  629c98e6a0
• Add low difficulty overlap tests

  Moq is introduced to mock sliders' end time/position. This is already used similarly in `osu.Game.Tests`.

  Naxess · 2021-06-21 15:33:50 +02:00
  e11139eadf
• Add new checks to verifier
  Naxess · 2021-06-21 15:30:45 +02:00
  2f3f4f3e4b
• Add time distance equality check
  Naxess · 2021-06-21 15:30:23 +02:00
  fcb918d0e1
• Add low difficulty overlaps check
  Naxess · 2021-06-21 15:30:04 +02:00
  3eb088f89a
• Merge pull request #13545 from frenzibyte/legacy-spinner-approach-circle

  Add support for legacy spinner approach circles

  Dean Herbert · 2021-06-21 18:52:06 +09:00
  5b9bf54f1f
• Remove unnecessary abstraction of ApproachCircle property
  Salman Ahmed · 2021-06-21 12:07:00 +03:00
  999bf27eae