70580 Commits

This Branch

This Branch

All Branches

• Merge branch 'master' into save-android
  Dean Herbert · 2024-11-29 13:46:53 +09:00
  a67f7ea3fb
• Merge pull request #30906 from Hiviexd/daily-challenge-tier-thresholds

  Adjust daily challenge tier thresholds to match expectations

  Salman Alshamrani · 2024-11-28 18:36:31 -05:00
  f664e97496
• Remove no longer required comment
  Salman Alshamrani · 2024-11-28 17:55:15 -05:00
  51bcde67aa
• Fix weird default in test scene
  Salman Alshamrani · 2024-11-28 17:54:03 -05:00
  078d62fe09
• Merge branch 'master' into daily-challenge-tier-thresholds
  Salman Alshamrani · 2024-11-28 17:46:55 -05:00
  a8db35ac45
• Merge pull request #30895 from peppy/watch-replay-reliability

  Fix watch replay button sometimes not loading the replay on first click

  Bartłomiej Dach · 2024-11-28 13:16:40 +01:00
  d0e80ce982
• update test
  Hiviexd · 2024-11-28 12:49:48 +01:00
  6ed21229b7
• Adjust daily challenge tier thresholds to match expectations
  Hiviexd · 2024-11-28 12:49:30 +01:00
  66093872e8
• Merge pull request #30874 from peppy/chat-order

  Sort public chat channels alphabetically, private channels based on recent messages

  Bartłomiej Dach · 2024-11-28 12:46:14 +01:00
  98a156ae2d
• Merge pull request #30893 from peppy/realm-perf-improvements

  Improve realm update performance

  Dan Balasescu · 2024-11-28 19:08:22 +09:00
  1575eed5ba
• Merge pull request #30905 from peppy/fix-multiple-offset-applications

  Clear previous `LastLocalUserScore` when returning to song select

  Dan Balasescu · 2024-11-28 18:58:13 +09:00
  077719903b
• Merge pull request #30852 from frenzibyte/fix-daily-challenge-leaderboard

  Fix daily challenge results screen fetching scores beginning from the user's highest

  Bartłomiej Dach · 2024-11-28 10:21:52 +01:00
  d218c19799
• Add test coverage governing new behaviour
  Dean Herbert · 2024-11-28 18:03:19 +09:00
  c26c84ba45
• Clear previous LastLocalUserScore when returning to song select

  This seems like the lowest friction way of fixing
  https://github.com/ppy/osu/issues/30885.
  
  We could also only null this on application, but this feels worse
  because
  
  - It would require local handling (potentially complex) in
    `BeatmapOffsetControl` if we want to continue displaying the graph and
  button after clicking it.
  - It would make the session static very specific in usage and
    potentially make future usage not possible due to being nulled in only
  a very specific scenario.
  
  One might argue that it would be nice to have this non-null until the
  next play, but if such a usage comes up I'd propose we rename this
  session static and add a new one with that purpose.

  Dean Herbert · 2024-11-28 18:01:28 +09:00
  ced8dda1a2
• Merge branch 'master' into fix-daily-challenge-leaderboard
  Bartłomiej Dach · 2024-11-28 09:41:24 +01:00
  0d491e3159
• Merge pull request #30894 from HenintsoaSky/star-fountains-toggle-setting

  Add a toggle for star fountains during gameplay

  Dan Balasescu · 2024-11-28 17:35:11 +09:00
  5d7aafaab3
• Remove unused accessors
  Bartłomiej Dach · 2024-11-28 09:22:08 +01:00
  4314f9c0a9
• Fix android workflow not installing .NET 8 version
  Salman Alshamrani · 2024-11-27 23:46:21 -05:00
  19e396f878
• Merge pull request #30848 from Joehuu/dicord-fix-beatmap-button-visibility

  Fix discord "view beatmap" button being shown when editing and hide identifiable information is set

  Dean Herbert · 2024-11-28 13:29:09 +09:00
  e0fdcaf523
• Move beatmap ID lookup to UesrActivity
  Salman Alshamrani · 2024-11-27 16:54:51 -05:00
  24c0799680
• Delete changes.patch

  oops

  HenintsoaSky · 2024-11-27 10:22:30 +03:00
  c3ac6d7fe5
• Ensure events are unbound on disposal as a safety
  Dean Herbert · 2024-11-27 15:46:55 +09:00
  4fcc76270a
• Use RealmLive in SaveFailedScoreButton

  This also optimises the manager classes to better support `Live` usage
  where the managed object is already in a good state (ie. doesn't require
  re-fetching).

  Dean Herbert · 2024-11-27 15:25:42 +09:00
  5260a401d4
• Knock some sense into the playlists results screen implementation

  As we're moving towards using the `/playlist/<id>/scores/<id>` endpoint,
  the existing playlists results screen classes needed some restructuring.

  Salman Alshamrani · 2024-11-27 01:20:43 -05:00
  dfbccc2144
• Remove unnecessary local subscription in BeatmapCarousel

  Not sure why I left this around during the refactor. This is 100%
  handled by the `DetachedBeatmapStore`.
  
  Removing this subscription reduces overheads by a huge amount for users
  with large beatmap databases. My hypothesis is that subscriptions are
  more expensive based on **the number of results matching**. This one
  matches almost every beatmap so removing it is a large win.

  Dean Herbert · 2024-11-27 14:24:57 +09:00
  aa3d3a6344
• Renaming of 'StarFountainEnabled'
  HenintsoaSky · 2024-11-27 07:38:33 +03:00
  a477bb7bfe
• Merge pull request #27128 from frenzibyte/user-statistics-provider

  Introduce `UserStatisticsProvider` component and add support for respecting selected ruleset

  Dean Herbert · 2024-11-27 13:13:47 +09:00
  573aaf6637
• Fix epic code failure

  I wasn't feeling well last night.

  Salman Alshamrani · 2024-11-26 20:04:36 -05:00
  9083daf363
• A toggle for star fountains
  HenintsoaSky · 2024-11-27 00:53:22 +03:00
  16d8b11385
• rename and remove again
  HenintsoaSky · 2024-11-27 00:41:02 +03:00
  80a66085a9
• Rename of the setting
  HenintsoaSky · 2024-11-27 00:27:22 +03:00
  460471e73f
• Add option to disable star fountain in gameplay
  HenintsoaSky · 2024-11-27 00:13:32 +03:00
  df74a177ae
• Merge pull request #30865 from ItsShamed/xxx-add-localisation-support-for-menu-tip

  Add localisation support for menu tip

  Joseph Madamba · 2024-11-26 12:54:17 -08:00
  a1a63608dd
• Merge branch 'master' into xxx-add-localisation-support-for-menu-tip
  Joseph Madamba · 2024-11-26 12:13:08 -08:00
  9173a74552
• Edit one more word not using british english
  Joseph Madamba · 2024-11-26 12:11:29 -08:00
  f04862ea74
• Merge pull request #30884 from peppy/fix-spinner-legacy-new-order-

  Fix classic skin spinner's middle pieces displaying in the wrong order

  Bartłomiej Dach · 2024-11-26 14:57:42 +01:00
  359cb71dd9
• Merge pull request #30881 from peppy/fix-editor-state-leaking

  Fix hitobjects' samples getting in bad state when changing selection between objects

  Bartłomiej Dach · 2024-11-26 13:54:50 +01:00
  33c2eb1af7
• Merge pull request #30868 from peppy/ur-perf-fix

  Improve performance of UR calculations

  Bartłomiej Dach · 2024-11-26 13:54:17 +01:00
  3e373ae85e
• Empty commit to fix CI
  Dan Balasescu · 2024-11-26 21:35:24 +09:00
  bd1f978138
• Remove leftover [Solo] attribute
  Bartłomiej Dach · 2024-11-26 12:40:49 +01:00
  c69d36dc96
• Fix classic skin spinner's middle pieces displaying in the wrong order

  Closes https://github.com/ppy/osu/issues/30873.
  See [stable
  reference](https://github.com/peppy/osu-stable-reference/blob/3ea48705eb67172c430371dcfc8a16a002ed0d3d/osu!/GameplayElements/HitObjects/Osu/SpinnerOsu.cs#L148-L158).

  Dean Herbert · 2024-11-26 18:12:28 +09:00
  312336de24
• chore(MenuTip): update text according to recent changes

  Signed-off-by: tsrk. <tsrk@tsrk.me>

  tsrk. · 2024-11-26 09:35:18 +01:00
  41c309fb72
• Don't reset state when changing from one selection to another in the editor

  This was causing state pollution in the new selection. I can't see why
  this needs to happen when a selection changes to another.
  
  This fixes https://github.com/ppy/osu/issues/30839 and also the same
  issue happening for the new combo toggle.
  
  Tests all seem to pass, and I can't immediately find anything broken,
  but YMMV.

  Dean Herbert · 2024-11-26 17:33:41 +09:00
  3ecb3b674d
• Add failing test case showing changing selection in editor affects samples
  Dean Herbert · 2024-11-26 17:33:41 +09:00
  e0199386a3
• Merge pull request #30832 from peppy/mania-precise-scroll-speed

  Allow setting osu!mania scroll speed to single decimal precision

  Dan Balasescu · 2024-11-26 17:30:56 +09:00
  d3d111de7d
• Merge pull request #30878 from peppy/config-pause-hold-thing-of-course

  Add setting to allow hold-for-pause to still exist

  Dan Balasescu · 2024-11-26 16:35:35 +09:00
  943837e3b5
• Add inline comment
  Salman Alshamrani · 2024-11-26 01:28:58 -05:00
  42c68ba43e
• Schedule the thing

  Queuing up requests on change to `api.LocalUser` is bad because the API
  state is updated after `LocalUser` is updated, therefore we have to
  schhhhhedullllllllleeeeeeeeeeeeeeee.

  Salman Alshamrani · 2024-11-26 01:26:44 -05:00
  b76460f100
• Add setting to allow hold-for-pause to still exist

  Users have asked for this multiple times since last release.
  
  Not sure on the best default value, but I'm going with the
  stable/classic one, at least for the initial release to avoid needing
  migrations.
  
  In the future we may reconsider this for new users.

  Dean Herbert · 2024-11-26 15:14:19 +09:00
  e3ea38a366
• Remove DailyChallengePlayer
  Salman Alshamrani · 2024-11-26 01:10:19 -05:00
  7201bac60d