71223 Commits

This Branch

This Branch

All Branches

• Remove unnecessary masking spec

  It was clipping the daily challenge completion checkmark, and it
  originates in some veeeeery old code where the profile overlay looked
  and behaved very differently (0fa0271878).

  Bartłomiej Dach · 2025-01-17 10:40:26 +01:00
  a67a68c596
• Add completion marker to daily challenge profile counter
  Bartłomiej Dach · 2025-01-17 10:26:59 +01:00
  b215073957
• Merge pull request #31513 from smoogipoo/remove-status-from-apiuser

  Remove `Status` and `Activity` bindables from `APIUser`

  Dean Herbert · 2025-01-17 17:36:47 +09:00
  a8456ce9ac
• Merge pull request #31535 from peppy/beatmap-carousel-v2-right-click-scroll

  Refactor absolute scrolling at song select

  Dan Balasescu · 2025-01-17 17:02:14 +09:00
  88829d5321
• Fix double-retrieval of user presence from dictionary in online display
  Dean Herbert · 2025-01-17 16:41:02 +09:00
  41c603b56f
• Update TestMetadataClient to correctly set local user state in line with changes
  Dean Herbert · 2025-01-17 16:29:02 +09:00
  311f08b962
• Rename fields from State to Presence when presence is involved
  Dean Herbert · 2025-01-17 16:25:48 +09:00
  3bb4b0c2b8
• Merge pull request #31533 from peppy/fix-gameplay-offset-adjust-limitations

  Fix gameplay offset adjustment limits not being enforced

  Bartłomiej Dach · 2025-01-17 08:21:24 +01:00
  7d026761fc
• Merge branch 'master' into beatmap-carousel-v2-right-click-scroll
  Dan Balasescu · 2025-01-17 16:12:52 +09:00
  79fff136a9
• Separate the local user state
  Dan Balasescu · 2025-01-17 15:59:34 +09:00
  a51938f4e9
• Merge branch 'master' into remove-status-from-apiuser
  Dan Balasescu · 2025-01-17 15:42:40 +09:00
  5425d62186
• Fix tests
  Dan Balasescu · 2025-01-17 15:42:19 +09:00
  ae7e4bef86
• Fix test potentially false-negative due to realm write delays
  Dean Herbert · 2025-01-17 14:16:38 +09:00
  224f39825f
• Merge pull request #31526 from bdach/spectator-list-visuals

  Implement spectator list display

  Dean Herbert · 2025-01-17 10:26:02 +09:00
  3272224a28
• Fix potential index accounting mistake when creating spectator list with spectators already present

  Noticed by accident, but if the `BindCollectionChanged()` callback fires
  immediately in `LoadComplete()` when set up and there are spectators
  present already, then `NewStartingIndex` in the related event is -1:
  
  	https://github.com/dotnet/runtime/blob/b03f83de362f7168c94daa2f4b192959abefe366/src/libraries/System.ObjectModel/src/System/Collections/Specialized/NotifyCollectionChangedEventArgs.cs#L84-L92
  
  which kinda breaks the math introducing off-by-ones and in result causes
  11 items to be displayed together rather than 10.

  Bartłomiej Dach · 2025-01-16 14:29:41 +01:00
  81f54507dd
• Merge branch 'master' into spectator-list-visuals
  Bartłomiej Dach · 2025-01-16 14:07:53 +01:00
  e3b780d0fb
• Merge pull request #31534 from bdach/nvika-dotnet-8

  Bump NVika tool to 4.0.0

  Bartłomiej Dach · 2025-01-16 14:04:59 +01:00
  70c81b1b0c
• Move absolute scroll support local to carousel and allow custom bindings
  Dean Herbert · 2025-01-16 20:47:59 +09:00
  a6057a9f54
• Bump NVika tool to 4.0.0

  Code quality CI runs have suddenly started failing out of nowhere:
  
  - Passing run: https://github.com/ppy/osu/actions/runs/12806242929/job/35704267944#step:10:1
  - Failing run: https://github.com/ppy/osu/actions/runs/12807108792/job/35707131634#step:10:1
  
  In classic github fashion, they began rolling out another runner change
  wherein `ubuntu-latest` has started meaning `ubuntu-24.04` rather than
  `ubuntu-22.04`. `ubuntu-24.04` no longer has .NET 6 bundled.
  
  Therefore, upgrade NVika to 4.0.0 because that version is compatible
  with .NET 8.

  Bartłomiej Dach · 2025-01-16 12:30:27 +01:00
  48609d44e2
• Add support to CarouselV2 for right mouse button scrolling
  Dean Herbert · 2025-01-16 20:27:38 +09:00
  1c2621d88e
• Remove setting for right-mouse scroll (make it always applicable)
  Dean Herbert · 2025-01-16 20:27:38 +09:00
  56b450c4a6
• Merge pull request #31471 from peppy/beatmap-carousel-v2

  Add basic framework for carousel displays (aka `BeatmapCarouselV2`)

  Bartłomiej Dach · 2025-01-16 12:21:53 +01:00
  6b921fc4e4
• Move bindables to OsuConfigManager & SessionStatics
  Dan Balasescu · 2025-01-16 19:33:42 +09:00
  8400726887
• Adjust animations a bit

  Removed autosize duration stuff because it looks weird when the list is
  shown from scratch where users are already fully populated in it.

  Dean Herbert · 2025-01-16 19:23:54 +09:00
  e47244989a
• Add gradient on final spectator if more than list capacity are displayed
  Dean Herbert · 2025-01-16 19:05:19 +09:00
  32906aefde
• Avoid list width changing when spectator count changes
  Dean Herbert · 2025-01-16 19:02:14 +09:00
  996798d2df
• Adjust test to work better when running in sequence
  Dean Herbert · 2025-01-16 18:56:21 +09:00
  56dfe4a231
• Fix idle/hover colour handling weirdness in OsuHoverContainer
  Dean Herbert · 2025-01-16 18:54:51 +09:00
  cde8e7b82e
• Fix gameplay limitations for adjusting offset not actually being applied
  Dean Herbert · 2025-01-16 18:05:59 +09:00
  1d240eb405
• Add failing test coverage showing offset adjust is not limited correctly
  Dean Herbert · 2025-01-16 18:05:58 +09:00
  a4174a3644
• Allow setting of DummyAPIAccess status
  Dan Balasescu · 2025-01-16 17:06:54 +09:00
  c1f0c47586
• Expose as IBindable from IAPIProvider, writes via config
  Dan Balasescu · 2025-01-16 17:05:18 +09:00
  b54d959263
• Merge pull request #31519 from EVAST9919/trail-rotate

  Add support for `CursorTrailRotate` skin command

  Dan Balasescu · 2025-01-16 14:56:53 +09:00
  471180d947
• Add test
  Dan Balasescu · 2025-01-16 14:11:21 +09:00
  fe8389bc2b
• Minor refactorings and xmldoc additions
  Dan Balasescu · 2025-01-16 14:00:27 +09:00
  920648c267
• Merge pull request #31531 from shawwn/2025-01-15/patch

  Fix typo in xmldoc

  Dan Balasescu · 2025-01-16 13:31:33 +09:00
  93a0ecd065
• Typo fix
  Shawn Presser · 2025-01-15 19:29:41 -06:00
  6008c3138e
• Simplify rotation sync with no clocks involved
  Andrei Zavatski · 2025-01-15 20:38:51 +03:00
  2eb63e6fe0
• Implement spectator list display

  - First step for https://github.com/ppy/osu/issues/22087
  - Supersedes / closes https://github.com/ppy/osu/pull/22795
  
  Roughly uses design shown in
  https://github.com/ppy/osu/pull/22795#issuecomment-1579936284 with some
  modifications to better fit everything else, and some customisation
  options so it can fit better on other skins.

  Bartłomiej Dach · 2025-01-15 14:17:53 +01:00
  582c5180b9
• Update framework
  Dean Herbert · 2025-01-15 20:42:46 +09:00
  e22dc09149
• Clear Discord presence when logged out
  Dan Balasescu · 2025-01-15 17:48:22 +09:00
  7ca3a6fc26
• Move animation handling to Carousel implementation to better handle add/removes

  With the animation logic being external, it was going to make it very
  hard to apply the scroll offset when a new panel is added or removed
  before the current selection.
  
  There's no real reason for the animations to be local to beatmap
  carousel. If there's a usage in the future where the animation is to
  change, we can add more customisation to `Carousel` itself.

  Dean Herbert · 2025-01-15 17:01:07 +09:00
  6027947657
• Merge pull request #31506 from peppy/fix-storyboard-break-overhead

  Fix stutter on intensive storyboards when entering break time with 100% background dim

  Bartłomiej Dach · 2025-01-15 08:23:58 +01:00
  614243fef4
• Fix substring of GetHashCode potentially failing
  Dean Herbert · 2025-01-15 16:18:34 +09:00
  0b764e6372
• Merge pull request #31523 from Rudicito/apply-offset-when-same-audio

  Apply beatmap offset to all difficulties only if they have the same audio

  Dan Balasescu · 2025-01-15 14:20:16 +09:00
  b9f3a1de6a
• Merge pull request #31446 from EVAST9919/new-combo-editor

  Fix performance degradation while trying to place object with a new combo in the editor.

  Dean Herbert · 2025-01-15 12:56:06 +09:00
  ef7982fbfa
• Apply beatmap offset on every beatmap set difficulty if they have the same audio
  Rudi Herouard · 2025-01-15 04:12:54 +01:00
  57a9911b22
• Sync cursor trail rotation with the cursor
  Andrei Zavatski · 2025-01-14 23:12:23 +03:00
  7a6355d7cf
• Add ability for cursor trail to spin
  Andrei Zavatski · 2025-01-14 22:16:32 +03:00
  208824e9f4
• Make config the definitive status value
  Dan Balasescu · 2025-01-15 00:01:19 +09:00
  b7a9b77efe