h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-15 16:25:32 +08:00
Code Issues Releases Wiki Activity
61,771 Commits 3 Branches 661 Tags 368 MiB
a4065486c1
Commit Graph

61771 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Dean Herbert
871056790b Mark editor tile as non-localisable 2023-07-19 15:01:20 +09:00
Dean Herbert
7f336b8dac Merge branch 'master' into editor-metrics 2023-07-19 15:00:51 +09:00
Dean Herbert
4a6a5b174a Fix editor blueprints being selectable for too long when hit markers are enabled 
Addresses https://github.com/ppy/osu/discussions/24163.
 2023-07-19 14:59:22 +09:00
Dean Herbert
b9a66ad7b3 Add test coverage of incorrect selection behaviour 2023-07-19 14:59:22 +09:00
Dean Herbert
5e2a0bd733 Fix spawning edge case when elapsed became unexpectedly negative 2023-07-19 14:10:27 +09:00
Dean Herbert
7fa95f7512 Fix #region 2023-07-19 13:52:43 +09:00
Dean Herbert
2e3d1fe950 Fix regression in time jumping behaviour 2023-07-19 13:38:04 +09:00
OliBomby
e7a9175aea fix skin using wrong stream 2023-07-18 13:08:05 +02:00
Dean Herbert
ba237a0e3a Convert StarFountain to use ParticleSpewer 
More efficient
 2023-07-18 20:04:52 +09:00
Dean Herbert
ccbb30cdda Fix ParticleSpewer not correctly accounting for lower frame rates (and spawning less particles) 2023-07-18 19:52:45 +09:00
OliBomby
63dd8bd991 use base.GetFileContents to get file stream 2023-07-18 12:40:48 +02:00
OliBomby
395dd23966 Put 'Export package' and 'Export legacy package' in one nested menu 2023-07-18 12:37:37 +02:00
OliBomby
bcdf531039 truncate end time before start time 2023-07-18 12:28:35 +02:00
OliBomby
5d82190b70 Merge remote-tracking branch 'upstream/master' into legacy-export 2023-07-18 12:18:49 +02:00
OliBomby
c02684d985 truncate hit object end time 2023-07-18 12:18:43 +02:00
Dean Herbert
f4acc86df8 Adjust metrics to closer match expectations 2023-07-18 16:26:37 +09:00
Dean Herbert
49bb0b190a Split out star constant to reuse in pool definition 2023-07-18 16:14:54 +09:00
Dean Herbert
e6e66c6aef
Remove mention of clock being nullable in IBeatSyncProvider 
Co-authored-by: Susko3 <Susko3@protonmail.com>
 2023-07-18 13:08:23 +09:00
Bartłomiej Dach
88ac53557a
Merge pull request #24236 from Joehuu/remove-android-manifest-overlay 
Remove android manifest overlay
 2023-07-17 22:12:11 +02:00
Bartłomiej Dach
551c243945
Merge pull request #24189 from peppy/discord-rpc-reconnect-fix 
Re-enable connection retrying on discord connector
 2023-07-17 19:58:37 +02:00
NiceAesth
ff529d9df7 Rename variables, fix check message formatting 2023-07-17 20:48:53 +03:00
Bartłomiej Dach
17aac0694e
Re-enable connection retrying on discord connector 2023-07-17 19:19:03 +02:00
Dean Herbert
66269be189
Merge pull request #24256 from tybug/update-download-icon 
Use `FontAwesome.Download` for updates instead of `FontAwesome.Upload`
 2023-07-17 12:25:04 +09:00
NiceAesth
b3974b34e7 Test break checks 2023-07-16 23:03:30 +03:00
NiceAesth
3888471148 Add break length and bounds checks 2023-07-16 23:03:21 +03:00
Liam DeVoe
6200e207d2 use fa_download for updates instead of fa_upload 2023-07-16 15:21:15 -04:00
Dean Herbert
a472fe6789
Merge pull request #24255 from bdach/multiplayer-disconnection-schedule-bomb 
Fix several issues in multiplayer exit-on-disconnection flow
 2023-07-17 04:04:38 +09:00
Bartłomiej Dach
7fbd47e9ee
Fix MultiplayerMatchSubScreen erroneously pushing exit dialog on API failure 
If `IAPIProvider.State` changes from `Online` at any point when being on
an `OnlinePlayScreen`, it will be forcefully exited from. However,
`MultiplayerMatchSubScreen` had local logic that suppressed the exit in
order to show a confirmation dialog.

The problem is, that in the suppression logic,
`MultiplayerMatchSubScreen` was checking
`MultiplayerClient.IsConnected`, which is a SignalR flag, and was not
checking `IAPIAccess.State`, which is maintained separately. Due to
differing timeouts and failure thresholds, it is not impossible to have
`MultiplayerClient.IsConnected == true` but `IAPIAccess.State !=
APIState.Online`.

In such a case, the match subscreen would wrongly consider itself to be
still online and due to that, push useless confirmation dialogs, while
being in the process of being forcefully exited. This then caused the
dialog to cause a crash, as it was calling `.Exit()` on the screen which
would already have been exited by that point, by the force-exit flow.
 2023-07-16 19:56:22 +02:00
Bartłomiej Dach
cd02a8a9ca
Fix PopupDialog potentially accumulating schedules during load 2023-07-16 19:43:37 +02:00
Dean Herbert
a6b1559e1f Update DiscordRichPresence to pull in performance fix 
See https://github.com/Lachee/discord-rpc-csharp/pull/237
 2023-07-17 02:24:51 +09:00
Dean Herbert
acb51dfca3
Merge pull request #24246 from bdach/fix-exit-dialog-crash 
Fix potential crash in confirm exit dialog while attempting to exit game
 2023-07-17 01:11:07 +09:00
Dean Herbert
e25cd03e4b Update framework 2023-07-17 00:55:25 +09:00
Bartłomiej Dach
a42992d3fd
Remove unused local variable 2023-07-16 17:10:26 +02:00
Bartłomiej Dach
d25a03984b
Fix PerformAction<T>() potentially crashing when no matching button is found 2023-07-16 16:55:20 +02:00
Bartłomiej Dach
72bf43e297
Add failing test covering exit dialog crash 2023-07-16 16:55:20 +02:00
Joseph Madamba
ce12afde70
Remove android manifest overlay 2023-07-15 23:38:06 -07:00
Dean Herbert
50e6f0aee9
Merge pull request #24233 from chayleaf/fix-taiko-maps-not-finishing 
Fix taiko maps sporadically not completing with Hidden mod active
 2023-07-16 13:32:38 +09:00
Dean Herbert
416ee0d99c Fix covariant array spec in new test 2023-07-16 12:48:58 +09:00
Dean Herbert
2d51aa21b7
Merge pull request #24235 from AkiSakurai/toplocalrank 
Compute the top local rank directly without an expensive detach call
 2023-07-16 12:14:56 +09:00
Dean Herbert
cf70f5e04d
Merge pull request #24219 from peppy/fix-mania-everything 
Fix osu!mania scores failing to convert to new standardised score due to cast failure
 2023-07-16 11:54:42 +09:00
Aki
cb354685ca
simplify code 2023-07-16 10:21:32 +08:00
Bartłomiej Dach
041e818892
Fix nested hits not being hittable if cut off by parent object ending 2023-07-15 18:44:47 +02:00
Bartłomiej Dach
955aa70e46
Add failing test case for hitting nested hit past parent end time 2023-07-15 18:43:31 +02:00
Bartłomiej Dach
9e960894c2
Add inline commentary about OnKilled() override 2023-07-15 18:22:04 +02:00
Bartłomiej Dach
24d63a4d96
Add test coverage for failing hit judgement with HD active 2023-07-15 18:17:45 +02:00
Bartłomiej Dach
542916f857
Bring back test coverage for fail case from #16475 
It was inadvertently dropped during refactoring in
b185194d07.
 2023-07-15 18:15:42 +02:00
chayleaf
3e91d30825 move StrongNestedHit OnKilled to DrawableStrongNestedHit 2023-07-15 22:33:16 +07:00
Aki
309c852222
Compute the top local rank directly without an expensive detach call 2023-07-15 23:00:13 +08:00
chayleaf
7f957d3fbe Fix some taiko maps not finishing in some conditions 
I don't know how to reproduce this issue in a test, so no tests for now.
Nonetheless, this fixes the issue for me at least on one map:
https://osu.ppy.sh/beatmapsets/1899665#taiko/3915653

This workaround is similar to #16475 (the test from that commit got
eventually removed for some reason).
 2023-07-15 20:24:40 +07:00
Dean Herbert
eb81eac635 Flag decoded scores more correctly 2023-07-15 12:19:18 +09:00