46642 Commits

This Branch

This Branch

All Branches

• Avoid json serialisation of aggregate helper properties

  Also avoids `throw`ing when there are no beatmaps available. Until now
  this wasn't an issue due to the `Beatmaps` list being null instead of empty.

  Dean Herbert · 2021-11-24 13:36:34 +09:00
  a3fdab34d5
• Fix cases of dynamically assigning Beatmaps to BeatmapSetInfo using list assignment
  Dean Herbert · 2021-11-24 13:27:37 +09:00
  8c60f37508
• Initialise BeatmapSet.Beatmaps list to line up with realm expectations
  Dean Herbert · 2021-11-24 13:25:55 +09:00
  49c2cb9125
• Merge pull request #15757 from smoogipoo/fix-multiplayer-tests

  Fix several intermittent multiplayer test failures

  Dean Herbert · 2021-11-24 09:32:01 +09:00
  049f25a133
• Merge pull request #15740 from peppy/realm-ruleset-setting-short-name

  Switch realm ruleset configuration to use ruleset's `ShortName` as key

  Bartłomiej Dach · 2021-11-23 20:13:12 +01:00
  fe9a03c032
• Merge branch 'master' into realm-ruleset-setting-short-name
  Bartłomiej Dach · 2021-11-23 19:44:41 +01:00
  fa96b29d6b
• Handle the case where the ruleset isn't found in the EF database any more
  Dean Herbert · 2021-11-23 19:15:52 +09:00
  6b134359c9
• Fix incorrect disposal
  Dean Herbert · 2021-11-23 18:13:05 +09:00
  40cd998f99
• Resolve inspection
  Dan Balasescu · 2021-11-23 17:55:04 +09:00
  79a8e60468
• Add xmldoc and verbatim string markers
  Dean Herbert · 2021-11-23 17:47:43 +09:00
  b1b6723826
• Pass the full EF context rather than a legacy RulesetStore
  Dean Herbert · 2021-11-23 17:40:20 +09:00
  505fede44d
• Merge pull request #15754 from peppy/tournament-test-isolation-clear-previuos

  Fix tournament tests potentially using data left over from previous runs

  Dan Balasescu · 2021-11-23 17:10:41 +09:00
  216c18b0bb
• Wait for ready button to be enabled first
  Dan Balasescu · 2021-11-23 17:09:38 +09:00
  a521d1b835
• Merge pull request #15745 from bdach/settings-number-box-stack-overflow

  Fix crashes on trying to play back replays of seeded mods with seed value over 1 billion

  Dan Balasescu · 2021-11-23 16:36:05 +09:00
  fd4d5e98a7
• Remove unused using
  Dan Balasescu · 2021-11-23 16:32:44 +09:00
  0cf5a738dc
• Merge pull request #15753 from peppy/osu-test-scene-isolation-clean-up

  Restructure how the headless storage is used / documented to hopefully make more sense

  Dan Balasescu · 2021-11-23 16:29:39 +09:00
  b7510697c8
• Merge pull request #15756 from peppy/add-range-extension-method

  Remove usage of `Nuget.Packaging` extension methods for `IList.AddRange`

  Dan Balasescu · 2021-11-23 16:22:25 +09:00
  6ae678ba48
• Revert unnecessary changes
  Dan Balasescu · 2021-11-23 16:17:09 +09:00
  6363833fb3
• Don't poll while in room

  Fixes timeout in `TestJoinRoomWithoutPassword`, because the 'server' returns
  out-of-date data while the `MatchSubScreen` has possible not been entered
  yet (and thus hasn't disabled polling itself yet).
  
  Can be tested by adding a `Task.Delay(3000);` at the end of
  the `MultiplayerClient.JoinRoom()` task.

  Dan Balasescu · 2021-11-23 16:14:01 +09:00
  1f13669636
• Fix a few more multiplayer test timeouts

  These can be tested by adding a `Task.Delay(3000);` at the end of the
  `MultiplayerClient.JoinRoom` task. The reason is typically that
  `Client.Room` becomes not-null but the join task still hasn't completed
  yet, so e.g. the ready button is still disabled.

  Dan Balasescu · 2021-11-23 16:07:03 +09:00
  69a9fc9732
• Update room immediately on join
  Dan Balasescu · 2021-11-23 16:03:37 +09:00
  7906ae2b1d
• Add BannedSymbols entry for NuGet.Packaging
  Dean Herbert · 2021-11-23 15:04:44 +09:00
  a8c4fd694f
• Remove usage of Nuget.Packaging extension methods for IList.AddRange
  Dean Herbert · 2021-11-23 15:02:02 +09:00
  6fb2757739
• Merge branch 'master' into realm-ruleset-setting-short-name
  Dean Herbert · 2021-11-23 14:55:36 +09:00
  f264b128c2
• Rewrite overflow test step for legibility
  Bartłomiej Dach · 2021-11-23 06:43:17 +01:00
  b596a0204c
• Fix tournament tests potentially using data left over from previous runs
  Dean Herbert · 2021-11-23 14:38:37 +09:00
  4624977b77
• Add more xmldoc
  Dean Herbert · 2021-11-23 14:17:24 +09:00
  473f6b0347
• Rename and reorder fields in OsuTestScene
  Dean Herbert · 2021-11-23 14:13:14 +09:00
  55f7d120e6
• Restructure how the headless storage is used / documented to hopefully make more sense
  Dean Herbert · 2021-11-23 14:11:27 +09:00
  5631e75f16
• Don't directly reset the database when running tests

  The containing storage is destroyed anyway, so this is redundant.

  Dean Herbert · 2021-11-23 14:08:04 +09:00
  49e2a8afa3
• Fix potential test failure in TestSceneMultiplayerReadyButton

  Couldn't exactly reproduce https://github.com/ppy/osu/runs/4294316800,
  but I found a similar issue via:
  
  ```diff
  diff --git a/osu.Game.Tests/Visual/Multiplayer/TestSceneMultiplayerReadyButton.cs b/osu.Game.Tests/Visual/Multiplayer/TestSceneMultiplayerReadyButton.cs
  index 84b63a5733..29cac9b061 100644
  --- a/osu.Game.Tests/Visual/Multiplayer/TestSceneMultiplayerReadyButton.cs
  +++ b/osu.Game.Tests/Visual/Multiplayer/TestSceneMultiplayerReadyButton.cs
  @@ -3,6 +3,7 @@
  
   using System;
   using System.Linq;
  +using System.Threading;
   using System.Threading.Tasks;
   using NUnit.Framework;
   using osu.Framework.Allocation;
  @@ -81,6 +82,8 @@ private void load(GameHost host, AudioManager audio)
  
                           await Client.ToggleReady();
  
  +                        Thread.Sleep(1000);
  +
                           readyClickOperation.Dispose();
                       });
                   }
  ```

  Dan Balasescu · 2021-11-23 14:07:55 +09:00
  10bd7176e0
• Merge pull request #15752 from peppy/rename-debug-namespace

  Rename `Debug` namespace to avoid collisions

  Dan Balasescu · 2021-11-23 13:39:47 +09:00
  8c24d6eb76
• Rename Debug namespace to avoid collisions
  Dean Herbert · 2021-11-23 13:09:41 +09:00
  feb983d5bd
• Run EF migrations earlier to ensure it is complete before usage
  Dean Herbert · 2021-11-23 11:48:58 +09:00
  1f321e2910
• Merge pull request #15734 from peppy/realm-beatmap-file-relation

  Add helper property to access a realm beatmap's beatmap file

  Dan Balasescu · 2021-11-23 11:13:59 +09:00
  ae1ae45df1
• Merge branch 'master' into realm-beatmap-file-relation
  Dean Herbert · 2021-11-23 10:20:22 +09:00
  119ac19f86
• Merge pull request #15735 from peppy/remove-ruleset-info-inheritance

  Remove subclassing of `RulesetInfo`

  Dean Herbert · 2021-11-23 10:18:32 +09:00
  e580fc5abc
• Merge branch 'master' into realm-beatmap-file-relation
  Bartłomiej Dach · 2021-11-22 21:53:08 +01:00
  1ec5dd2cdf
• Merge pull request #15736 from peppy/ruleset-use-short-name

  Use `Ruleset`'s `ShortName` for mod caching purposes

  Bartłomiej Dach · 2021-11-22 21:37:45 +01:00
  d9db3b9e78
• Accept full range of int in SettingsNumberBox

  This fixes stack overflow exceptions that would arise when a
  `Current.Value` of 1 billion or more was set on a `SettingsNumberBox`.
  The stack overflow was caused by the "maximum 9 digits" spec. If a value
  technically within `int` bounds, but larger than 1 billion (in the range
  [1,000,000,000; 2,147,483,647], to be more precise), a feedback loop
  between the setting control's `Current` and its inner text box's
  `Current` would occur, wherein the last digit would be trimmed and then
  re-appended again forevermore.
  
  To resolve, remove the offending spec and rely on `int.TryParse`
  entirely to be able to discern overflow range. Additionally, UX of the
  text box is slightly changed to notify when the `int` range is exceeded
  with a red flash.
  
  This behaviour would not have been possible to implement without recent
  framework-side fixes to text box (removal of text set scheduling).

  Bartłomiej Dach · 2021-11-22 20:49:14 +01:00
  4a9f080f3c
• Add extended test coverage for desired input handling
  Bartłomiej Dach · 2021-11-22 20:39:44 +01:00
  dced6a2e68
• Add failing test case for number box stack overflow scenario
  Bartłomiej Dach · 2021-11-22 20:26:45 +01:00
  2350806b4c
• Merge branch 'master' into ruleset-use-short-name
  Dan Balasescu · 2021-11-22 23:56:34 +09:00
  fba9e360a1
• Merge pull request #15739 from peppy/realm-migration-ordering

  Fix realm applying migrations from one version too early

  Dan Balasescu · 2021-11-22 23:52:50 +09:00
  7ce5cb6162
• Merge pull request #15738 from peppy/preferred-ruleset-short-name

  Store preferred ruleset to configuration using `ShortName` instead of `ID`

  Dan Balasescu · 2021-11-22 23:51:47 +09:00
  29829cd29d
• Merge pull request #15737 from peppy/use-equality-comparison-beatmap-carousel-tests

  Use `Equals` in carousel tests for better realm compatibility

  Dan Balasescu · 2021-11-22 23:48:50 +09:00
  743fe4cef3
• Add back allowance for tests scenes using empty ShortName
  Dean Herbert · 2021-11-22 21:41:09 +09:00
  6c36770eb3
• Switch realm ruleset configuration to use ruleset's ShortName as key
  Dean Herbert · 2021-11-22 18:52:00 +09:00
  329bae50b0
• Provide RealmContextFactory with the EF RulesetStore for migration purposes
  Dean Herbert · 2021-11-22 18:51:44 +09:00
  ca26b6c540
• Reformat realm migrations list for legibility
  Dean Herbert · 2021-11-22 18:47:18 +09:00
  d2062ff97f