74874 Commits

This Branch

This Branch

All Branches

• Refresh realm before performing song select refetches following an online metadata lookup

  Probably closes https://github.com/ppy/osu/issues/34716
  
  Can't see any other cause, can reproduce the issue on master using
  manual db modifications via realm studio and it is not a consistent
  reproduction, so seems like an open-and-shut lack of refresh.

  Bartłomiej Dach · 2025-08-18 09:48:32 +02:00
  a393b3c6b1
• Merge pull request #34668 from smoogipoo/refactor-avatar-notification

  Refactor notification avatar to remove `OnUpdate`

  Dean Herbert · 2025-08-17 23:43:50 +09:00
  28fae938d5
• Merge pull request #34684 from minisbett/public-mods

  Ensure all mod types are `public`

  Dean Herbert · 2025-08-16 21:29:04 +09:00
  4fe50f98ef
• change access modifier of internal mods to public
  minisbett · 2025-08-16 13:44:01 +02:00
  d3910d80e5
• Merge pull request #34682 from smoogipoo/use-xcode-16.2

  Force Xcode 16.4 on CI

  Dean Herbert · 2025-08-16 20:05:44 +09:00
  2025.816.0-lazer 1f9b429450
• Merge pull request #34676 from bdach/branch

  Fix a bunch of issues with replay fail indicator

  Dean Herbert · 2025-08-16 16:31:47 +09:00
  09d19d475a
• Always add an icon
  Dan Balasescu · 2025-08-16 16:03:47 +09:00
  01de2dc55b
• Force Xcode 16.4 on CI
  Dan Balasescu · 2025-08-16 15:52:27 +09:00
  1306f56fba
• Fix score rank not being F on fail in replays

  closes https://github.com/ppy/osu/issues/34673
  
  This is a bit half-baked because the next thing someone is going to
  report is that when rewinding with a rank display present in the user's
  skin, the rank doesn't revert from F anymore. That is because of
  
      https://github.com/ppy/osu/blob/237de1ef72a06babd9e3dbd582d5c29faca171b9/osu.Game/Rulesets/Scoring/ScoreProcessor.cs#L392-L394
  
  which I'm not willing to touch on short notice.

  Bartłomiej Dach · 2025-08-15 19:51:44 +02:00
  fd13e94c6f
• Fix fail indicator being hideable by toggling HUD off

  closes https://github.com/ppy/osu/issues/34675

  Bartłomiej Dach · 2025-08-15 19:42:46 +02:00
  8dfe72c7e1
• Fix frequency not returning to normal when proceeding to results screen of a failed replay

  closes https://github.com/ppy/osu/issues/34674

  Bartłomiej Dach · 2025-08-15 19:41:20 +02:00
  78a3a1b721
• Merge pull request #34568 from Valerus9/notequaloperator

  Support not equal operator in song select search

  Dean Herbert · 2025-08-15 23:38:32 +09:00
  2025.815.0-tachyon af27bd1157
• Merge pull request #34612 from frenzibyte/auto-beatmap-offset

  Add setting for adjusting beatmap offset automatically based on last play

  Dean Herbert · 2025-08-15 23:33:32 +09:00
  99dc2bb58f
• Reorder class to suck a bit less
  Dean Herbert · 2025-08-15 22:55:49 +09:00
  12811e2506
• Always use UR algorithm
  Dean Herbert · 2025-08-15 22:51:37 +09:00
  2d8aa403f7
• Update resources
  Dean Herbert · 2025-08-15 22:40:38 +09:00
  abd5dbabd7
• Merge branch 'master' into notequaloperator
  Salman Alshamrani · 2025-08-15 14:30:55 +03:00
  1741142673
• Adjust code to be more reviewable
  Salman Alshamrani · 2025-08-15 13:59:04 +03:00
  a1f0cd3b31
• Add inline comment
  Salman Alshamrani · 2025-08-15 13:35:55 +03:00
  d5758cd8fb
• Merge pull request #34628 from bdach/show-results-on-failed-replay

  Show indicator in replay player once replay fails

  Dean Herbert · 2025-08-15 19:33:47 +09:00
  a14d7a23bd
• Make non-nullable member truly non-nullable
  Dan Balasescu · 2025-08-15 19:33:19 +09:00
  2750f5bb53
• Replace OnUpdate() usage with local update
  Dan Balasescu · 2025-08-15 19:32:54 +09:00
  5a1750071e
• Merge pull request #34662 from bdach/refetch-leaderboard-on-retry

  Refetch leaderboard when (slow) retrying a beatmap

  Dean Herbert · 2025-08-15 18:29:17 +09:00
  46744c6f15
• Fix incorrect parsing
  Bartłomiej Dach · 2025-08-15 11:12:10 +02:00
  5a9592a769
• Merge pull request #34651 from Hiviexd/verify/check-video-usage

  Add verify check for inconsistent video usage

  Bartłomiej Dach · 2025-08-15 11:06:20 +02:00
  099d1dc459
• Merge pull request #34657 from peppy/audio-hotfix-aaaaaaaaaaaa

  Ignore more potentially incorrect data from BASS

  Bartłomiej Dach · 2025-08-15 11:05:52 +02:00
  6f733fd3fc
• Rename variables
  Bartłomiej Dach · 2025-08-15 10:21:50 +02:00
  5722e85791
• Remove failing test

  Test was added in 5495c2090a to exercise a
  previous version of the hotfix-workaround of not allowing seeking back.
  Now that the hotfix-workaround also encompasses seeking *forward*, which
  breaks another 100 tests, thus requiring the hotfix-workaround to be
  turned off for tests, this situation is just completely out of
  control. So I'm just removing the test because ugh.

  Bartłomiej Dach · 2025-08-15 10:01:10 +02:00
  126d0c6bdb
• Merge pull request #34533 from AeroKoder/user-avatar-notification

  Made the user avatar square, in `UserAvatarNotification`.

  Dean Herbert · 2025-08-15 16:05:00 +09:00
  6ed7ba350d
• Mark flaky test as explicit

  See https://github.com/ppy/osu/pull/34625#discussion_r2269595186.

  Bartłomiej Dach · 2025-08-15 08:54:03 +02:00
  b89d8cc5b3
• Merge pull request #33558 from frenzibyte/ssv2-crash

  Fix song select crashing on beatmap with two difficulties of same online ID

  Bartłomiej Dach · 2025-08-15 08:50:51 +02:00
  0e5900add9
• Fix half written comment and adjust threshold down slightly
  Dean Herbert · 2025-08-15 15:40:30 +09:00
  1f10bff7a7
• Don't enforce hotfix during debug builds, to allow interactive tests to run correctly
  Dean Herbert · 2025-08-15 15:29:51 +09:00
  69647f4c9c
• Merge pull request #34659 from bdach/bss-submission-double-bind

  Fix navigating back and forth from beatmap submission settings screen crashing

  Dean Herbert · 2025-08-15 02:45:37 +09:00
  4bb5509267
• Merge pull request #34640 from bdach/multiple-tag-filters

  Add support for specifying multiple user tag filters at once

  Dean Herbert · 2025-08-15 02:39:47 +09:00
  734043fb0d
• Merge branch 'master' into bss-submission-double-bind
  Salman Alshamrani · 2025-08-14 17:20:51 +03:00
  28c9a62634
• Merge pull request #34658 from peppy/fix-tag-search-operation
  Bartłomiej Dach · 2025-08-14 15:55:01 +02:00
  f7a029ff55
• Refetch leaderboard when (slow) retrying a beatmap

  Probably closes https://github.com/ppy/osu/issues/34645.
  
  Obviously this is only good if the score has managed to process online
  and slot into a leaderboard before the user requested a retry. I can't
  make miracles happen.
  
  Notably this is not applied to quick retry, because it would make quick
  retry slower, and the presumption is that if the user is quick-retrying
  their last score is likely useless for global leaderboards anyway. (The
  one exception to that last part is possibly quick-retrying from results
  screen, which is a flow that we have, but maybe fine to ignore it...?)

  Bartłomiej Dach · 2025-08-14 14:31:49 +02:00
  44e76a61a9
• Add failing test
  Bartłomiej Dach · 2025-08-14 14:18:25 +02:00
  116a45c9cb
• add more tests for pairwise comparison
  Hivie · 2025-08-14 13:15:19 +01:00
  07e982e02f
• handle pairwise comparison for video start times
  Hivie · 2025-08-14 13:14:58 +01:00
  f928f9953b
• Also ensure that ordering doesn't matter
  Dean Herbert · 2025-08-14 21:14:35 +09:00
  7a1cad7312
• Update test code
  Salman Alshamrani · 2025-08-14 14:14:45 +03:00
  67b4d8432c
• Merge branch 'master' into ssv2-crash
  Salman Alshamrani · 2025-08-14 14:09:54 +03:00
  347d621437
• Fix navigating back and forth from beatmap submission settings screen crashing

  supersedes https://github.com/ppy/osu/pull/34656

  Bartłomiej Dach · 2025-08-14 12:57:10 +02:00
  3bfa7bf862
• Fix current change check not solid enough
  Salman Alshamrani · 2025-08-14 13:48:08 +03:00
  76630cff98
• Fix calibrating offset with auto-adjust enabled does not account for UR

  Covered by test `TestAutomaticAdjustmentWithUnstableRate`.

  Salman Alshamrani · 2025-08-14 13:48:08 +03:00
  de7e3c96a6
• Move beatmap offset write logic to a separate method

  Note that calling `writeOffsetToBeatmap` from `currentChanged` is still intentionally not
  scheduled, see https://github.com/ppy/osu/pull/34612#discussion_r2269052138.
  
  This commit is done so that if that call is scheduled, then the logic
  above it that update the play graph and visibility state of the button
  still don't get scheduled, otherwise the test will fail (as noticed in https://github.com/ppy/osu/pull/34612#discussion_r2269208998).

  Salman Alshamrani · 2025-08-14 13:48:08 +03:00
  1db49d250f
• Add failing test case
  Salman Alshamrani · 2025-08-14 13:47:58 +03:00
  69b6166e58
• Fix tags popover search functionality not always working

  This is super haphazard in the first place but I'm going to look past
  that for now.
  
  Basically, due to the order of operation, the tags could be initialised
  via `updateTags()` before the perform search action was initialised,
  leading to clicks doing nothing.

  Dean Herbert · 2025-08-14 19:43:03 +09:00
  6c4c2c1a6a