h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-05-31 02:30:06 +08:00
Code Issues Releases Wiki Activity

Refetch leaderboard when (slow) retrying a beatmap

Browse Source 
Probably closes https://github.com/ppy/osu/issues/34645.

Obviously this is only good if the score has managed to process online
and slot into a leaderboard before the user requested a retry. I can't
make miracles happen.

Notably this is not applied to quick retry, because it would make quick
retry slower, and the presumption is that if the user is quick-retrying
their last score is likely useless for global leaderboards anyway. (The
one exception to that last part is possibly quick-retrying from results
screen, which is a flow that we have, but maybe fine to ignore it...?)
This commit is contained in:
Bartłomiej Dach
2025-08-14 14:24:21 +02:00
Unverified
parent 116a45c9cb
commit 44e76a61a9
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game/Screens/Play/PlayerLoader.cs
+11 -1
View File
@@ -283,11 +283,16 @@ namespace osu.Game.Screens.Play
// (as the solo gameplay leaderboard provider uses the global leaderboard manager to populate itself)
// - the sort mode is not specified and defaults to `Score` which is good because gameplay leaderboards only support sorting by score.
// this may change at some point in the future, at which point specifying a sort mode should be considered.
refetchLeaderboard(force: false);
}
private void refetchLeaderboard(bool force)
{
leaderboardManager?.FetchWithCriteria(new LeaderboardCriteria(
Beatmap.Value.BeatmapInfo,
Ruleset.Value,
leaderboardManager?.CurrentCriteria?.Scope ?? BeatmapLeaderboardScope.Global,
leaderboardManager?.CurrentCriteria?.ExactMods));
leaderboardManager?.CurrentCriteria?.ExactMods), force);
}
#region Screen handling
@@ -497,6 +502,11 @@ namespace osu.Game.Screens.Play
QuickRestart = quickRestartRequested;
hideOverlays = true;
ValidForResume = true;
// when retrying, it is desired to refetch the global state leaderboard so that the user's previous score can show up on the leaderboard, if it needs to.
// that said, only do this when the user is *not* quick-retrying.
// this avoids the quick retry becoming longer than it needs to (because an extra API request has to complete before gameplay can start),
// and if the user is quick-retrying, their last score is most likely not important for global leaderboards, or the user won't care.
refetchLeaderboard(force: !quickRestartRequested);
}
private void contentIn(double delayBeforeSideDisplays = 0)