45 Commits

• Merge branch 'master' into fix-song-select-star-rating-display-zero-flashing
  smoogipoo · 2021-02-25 22:13:48 +09:00
  c1f27ba938
• Fix the star rating display at song select flashing to zero when changing mods

  Due to the use of bindable flow provided by `BeatmapDifficultyCache` in
  this usage, the display would briefly flash to zero while difficulty
  calculation was still running (as there is no way for a consumer of the
  provided bindable to know whether the returned 0 is an actual 0 SR or a
  "pending" calculation).
  
  While I hope to fix this by making the bindable flow return nullable
  values, I think this particular use case works better with non-bindable
  flow so have switched across to that.

  Dean Herbert · 2021-02-25 16:05:13 +09:00
  9f3ceb99eb
• Apply changes to UI components overriding functions with changing signatures
  Dean Herbert · 2021-02-22 19:01:42 +09:00
  1fd76ea3fb
• Rename second usage variable name to match
  Dean Herbert · 2021-02-11 14:54:50 +09:00
  eaa7b4cb93
• Ensure tracker is disposed
  smoogipoo · 2021-02-10 20:09:45 +09:00
  6fff7c39da
• Add helper class for tracking changes to mod settings
  smoogipoo · 2021-02-10 19:40:07 +09:00
  393cd6c74a
• Rename BeatmapDifficultyManager to BeatmapDifficultyCache
  Dean Herbert · 2020-11-06 13:14:29 +09:00
  5113d4af8f
• Remove local cancellation token
  smoogipoo · 2020-07-24 16:11:28 +09:00
  877b985e90
• Change method signatures to remove tracked/untracked
  smoogipoo · 2020-07-24 13:52:43 +09:00
  b10b99a670
• Add support for bindable retrieval
  smoogipoo · 2020-07-21 23:13:04 +09:00
  107b5ca4f2
• Update beatmap details SR on ruleset/mod changes
  smoogipoo · 2020-07-16 21:08:08 +09:00
  24f14751ce
• Add spaces to comments
  alex · 2020-05-04 18:36:24 -07:00
  0e2ccac33b
• Remove redundant using directives
  TheWildTree · 2020-02-16 21:52:08 +01:00
  64a9b9c6fb
• Adjust font sizes and spacing in BeatmapSetOverlay
  TheWildTree · 2020-02-16 21:43:33 +01:00
  4d180a685a
• Apply precision when comparing adjusted values

  In some cases, applying the Difficulty Adjust mod without actually
  changing any of the settings previously caused the bar in song select
  beatmap details to appear red/blue instead of staying white.
  
  This was caused by not accounting for floating-point imprecisions when
  determining bar colour in AdvancedStats. To resolve, first check
  equality with tolerance, and only then apply blue/red colours if that
  equality check does not hold.

  Bartłomiej Dach · 2020-02-01 16:16:15 +01:00
  0bfadfbbf1
• Extract beatmap stats test to separate scene
  Bartłomiej Dach · 2020-02-01 15:50:33 +01:00
  a74d22d9e5
• Fix key count being incorrectly adjusted by hard/easy mods
  Dean Herbert · 2020-01-28 17:21:50 +09:00
  12ff51f686
• Remove unnecessary directive
  TheWildTree · 2020-01-12 21:09:48 +01:00
  b5ac707c6c
• Fix adjusted value always being 0
  TheWildTree · 2020-01-12 20:43:48 +01:00
  aa2645502c
• Remove unused using
  Dean Herbert · 2019-12-20 18:36:39 +09:00
  a6bdf04f6b
• Update song select statistics when mod changes settings
  Dean Herbert · 2019-12-20 18:01:35 +09:00
  822903d5db
• Fix incorrectly binding inside BDL load()
  smoogipoo · 2019-12-18 17:41:30 +09:00
  8e651962c7
• Use tuple to avoid potential for incorrect display
  Dean Herbert · 2019-12-18 17:12:41 +09:00
  ada2ae2b2c
• Don't clone beatmap unnecessarily
  Dean Herbert · 2019-12-18 17:00:35 +09:00
  e87aa281bf
• improve tests and refactor AdvancedStats
  unknown · 2019-12-13 09:39:54 +08:00
  3945e7403a
• apply mod difficulty settings during song select
  unknown · 2019-12-12 23:41:46 +08:00
  ec5b506960
• Use MathF instead of Math- functions when possible

  MathF-functions are faster than the Math-counterpart and it looks cleaner, so use MathF when we cast to float or int anyway.

  Berkan Diler · 2019-11-25 00:45:42 +01:00
  fccdbffa93
• Merge branch 'master' into more-inspections
  Dean Herbert · 2019-02-28 14:32:57 +09:00
  0788a7e9f1
• Use expression body for property get/set where possible
  Dean Herbert · 2019-02-28 13:58:19 +09:00
  42be7857d1
• Fix remaining issues
  Dean Herbert · 2019-02-28 13:31:40 +09:00
  26d53d06a9
• Adjust sprite texts in-line with framework changes
  smoogipoo · 2019-02-20 15:03:20 +09:00
  a2aa3ec5cb
• Update licence header (and remove year)
  Dean Herbert · 2019-01-24 17:43:03 +09:00
  8617aaa2a7
• OpenTK -> osuTK
  smoogipoo · 2018-11-20 17:14:59 +09:00
  f27bd3ef3e
• Make BeatmapSetOverlay accept nulls everywhere
  Dean Herbert · 2018-04-18 16:08:45 +09:00
  1be2571d33
• Normalize all the line endings
  Dean Herbert · 2018-04-13 18:26:38 +09:00
  32a74f95a5
• Update licence headers
  Dean Herbert · 2018-01-05 20:21:19 +09:00
  37d393bca0
• Fix all remaining db structure issues
  Dean Herbert · 2017-10-19 14:05:11 +09:00
  5d5ea5fb2e
• Let's not rename columns yet
  smoogipoo · 2017-10-14 14:30:58 +09:00
  b178be21d1
• Rework EF Core usage in model classes
  TocoToucan · 2017-10-06 00:23:26 +03:00
  887aa7496b
• Initial EF Core commit
  TocoToucan · 2017-10-04 22:52:12 +03:00
  6a4198d0d6
• Avoid nullrefs when data is not present
  Dean Herbert · 2017-09-25 23:35:02 +08:00
  f129902ee0
• CI fixes.
  DrabWeb · 2017-09-07 15:38:23 -03:00
  55e8bdfb05
• Cleanup, remove unneeded files.
  DrabWeb · 2017-09-07 15:21:18 -03:00
  109531b66c
• Fix .00 being displayed for star difficulty when the value is 0.
  DrabWeb · 2017-09-07 15:01:31 -03:00
  fd2700a5b4
• Rewrite BeatmapDetails to be more modular for future code sharing.
  DrabWeb · 2017-09-07 14:53:53 -03:00
  5e685ff5b1