Dean Herbert
8069674824
Merge remote-tracking branch 'upstream/master' into bindable-control-points
2019-10-28 11:52:04 +09:00
Dean Herbert
4e80eda6da
Add test coverage
2019-10-28 11:40:42 +09:00
Dean Herbert
45da22afe9
Add xmldoc and combine GroupAt / CreateGroup
2019-10-28 11:40:33 +09:00
Dean Herbert
2a6b3fd67c
Disallow inserting a group if one already exists with the current time value
2019-10-28 11:40:10 +09:00
Dean Herbert
59d983b66e
Allow binding to ControlPointInfo's Groups
2019-10-28 11:39:53 +09:00
Dean Herbert
10033239c7
Allow binding to ControlPointGroup's ControlPoints
2019-10-28 11:39:17 +09:00
Bartłomiej Dach
c8d3dd0e5a
Make carousel item sorting stable
...
Migrate beatmap carousel item sorting from List<T>.Sort()
to IEnumerable<T>.OrderBy(), as the second variant is documented to be
a stable sorting algorithm. This allows for eliminating unnecessary
movement of carousel items occurring whenever any set of items is tied
when changing sorting criteria.
2019-10-27 23:14:14 +01:00
Bartłomiej Dach
022cc13952
Add beatmap carousel item sorting stability test
...
Add visual test to ensure sorting stability when sorting criteria are
applied in the beatmap carousel.
2019-10-27 22:55:46 +01:00
nwabear
dc672b2b4c
Merge branch 'master' into master
2019-10-26 22:19:47 -05:00
Dan Balasescu
dd16b938cb
Merge pull request #6601 from peppy/equivalent-to
...
Replace local Equatable implementations with abstract EquivalentTo
2019-10-27 12:08:52 +09:00
Dan Balasescu
676460019d
Merge branch 'master' into equivalent-to
2019-10-27 11:51:05 +09:00
Dean Herbert
814b520e5e
Avoid potential mis-cast in comparison
2019-10-27 11:35:45 +09:00
nwabear
e35931fdfc
removed blank line
2019-10-26 14:33:59 -05:00
nwabear
349a2745c5
Merge remote-tracking branch 'origin/master'
2019-10-26 14:30:17 -05:00
nwabear
9e2e87c8d1
added visual tests
...
added small commenting
added xmldoc for CancelResume();
2019-10-26 14:29:52 -05:00
Dean Herbert
16e9b404b9
Add temporary mobile report moratorium issue template ( #6614 )
...
Add temporary mobile report moratorium issue template
2019-10-26 22:28:54 +09:00
Bartłomiej Dach
654890776d
Add exemption for potential code contributors
...
Add an exemption clause allowing potential code contributors to submit
issues if they state they would like to work on them, and note that
mobile-related pull requests are still accepted.
Suggested-by: Dean Herbert <pe@ppy.sh>
2019-10-26 14:56:29 +02:00
Dean Herbert
474626c2b3
Refactor distance snapping to be handled by HitObjectComposer ( #6599 )
...
Refactor distance snapping to be handled by HitObjectComposer
Co-authored-by: Dean Herbert <pe@ppy.sh>
2019-10-26 14:55:26 +09:00
Dean Herbert
194e501f86
Merge branch 'master' into snapping-refactor
2019-10-26 14:20:08 +09:00
Dean Herbert
4290a71f44
Add special case for timing points
...
Timing points can't fallback to defaults and must be added at least once.
2019-10-26 11:38:05 +09:00
Dean Herbert
9e5eed97c4
Fix not being able to drag non-snaked sliders ( #6600 )
...
Fix not being able to drag non-snaked sliders
2019-10-26 10:47:21 +09:00
Dean Herbert
7502b64541
Merge branch 'control-point-grouping' into no-auto-gen
2019-10-26 10:35:34 +09:00
Dean Herbert
d6a49b9e93
Add back autogeneration rules
...
Will be removed in https://github.com/ppy/osu/pull/6604
2019-10-26 10:25:37 +09:00
Bartłomiej Dach
dca8de5e6b
Rephrase template description
2019-10-26 02:06:39 +02:00
Bartłomiej Dach
a724909c25
Add temporary mobile report issue template
...
Due to an overwhelming amount of mobile reports that are not actively
being worked on (neither by the core team, due to more pressing
priorities, nor by external contributors) and take up considerable time
to manage, add an issue template that aims to enforce a temporary
moratorium on accepting mobile issues.
2019-10-26 01:56:46 +02:00
Dean Herbert
7100319858
Fix incorrect control point retrieval in non-lookup cases
2019-10-26 08:31:41 +09:00
nwabear
f8354eefc4
Added null check in the CancelResume method
2019-10-25 16:49:18 -05:00
nwabear
b0e21c2749
Fixed Issue #6442
2019-10-25 14:57:49 -05:00
Dean Herbert
b52be3d639
Merge branch 'control-point-grouping' into no-auto-gen
2019-10-26 01:20:08 +09:00
Dean Herbert
d25f7f4c27
Correctly clear other lists
2019-10-26 01:19:23 +09:00
Dean Herbert
c031aeb14c
Fix inspection
2019-10-26 00:06:05 +09:00
Dean Herbert
eefa411182
Merge branch 'control-point-grouping' into no-auto-gen
2019-10-25 23:15:25 +09:00
Dean Herbert
d4fed43be7
Merge branch 'equivalent-to' into control-point-grouping
2019-10-25 23:15:15 +09:00
Dean Herbert
e39016bf01
Fix known non-nulls
2019-10-25 20:04:27 +09:00
Dean Herbert
8baf569f59
Remove necessity of AutoGenerated flag
2019-10-25 19:58:42 +09:00
Dan Balasescu
2b7115f5fb
Merge pull request #6529 from EVAST9919/comments-vote-pill
...
Implement working VotePill for CommentsContainer
2019-10-25 19:56:03 +09:00
Dean Herbert
e987db37ec
Add grouping of ControlPoints
2019-10-25 19:52:02 +09:00
Dean Herbert
e2f2638212
Replace local Equatable implementations with abstract EquivalentTo
2019-10-25 19:44:28 +09:00
Dan Balasescu
c2f6cd9c24
Merge branch 'master' into comments-vote-pill
2019-10-25 19:19:44 +09:00
Dan Balasescu
5a70431263
Merge pull request #6591 from bdach/markdown-inline-links
...
Add support for Markdown inline links
2019-10-25 19:19:14 +09:00
smoogipoo
a9ec6b2562
Fix testcase failure
2019-10-25 19:00:10 +09:00
Dan Balasescu
c9505f89dd
Merge branch 'master' into markdown-inline-links
2019-10-25 18:52:11 +09:00
Dan Balasescu
ad6e828571
Merge pull request #6598 from peppy/fix-datetime-results
...
Fix DateTime display sizing on results screen
2019-10-25 18:40:16 +09:00
smoogipoo
da6ee05dd6
Fix not being able to drag non-snaked sliders
2019-10-25 18:37:44 +09:00
Dan Balasescu
3692846367
Merge branch 'master' into snapping-refactor
2019-10-25 18:26:14 +09:00
smoogipoo
ccc45dea20
Add hitobject composer snapping test
2019-10-25 18:19:26 +09:00
smoogipoo
ae011e8ee8
Fix distance snap grid test scenes
2019-10-25 17:25:46 +09:00
smoogipoo
4ca6a5a0cc
Interface the distance snap provider
2019-10-25 16:50:21 +09:00
smoogipoo
607b4d874a
Refactor flow of snapping through HitObjectComposer
2019-10-25 16:40:30 +09:00
Dean Herbert
e5b5d286fd
Increase spacing to closer match the design
2019-10-25 12:48:34 +09:00
