54866 Commits

This Branch

This Branch

All Branches

• Merge branch 'master' into fix-merge-crash
  Dean Herbert · 2022-08-31 13:28:57 +09:00
  a15ea71aed
• Merge pull request #20025 from peppy/fix-results-sample-glitching

  Fix audio glitching when showing results screen with many scores

  Dan Balasescu · 2022-08-31 13:10:08 +09:00
  1908a2e394
• Merge pull request #20031 from peppy/fix-replay-file-missing-crash

  Fix crash when attempting to watch a replay when the storage file doesn't exist

  Dan Balasescu · 2022-08-31 13:06:45 +09:00
  cb4fd08f27
• Merge pull request #20029 from peppy/profile-header-assert

  Assert non-null in `ProfileHeader` to appease r#

  Bartłomiej Dach · 2022-08-30 21:36:32 +02:00
  0afa775f3f
• Fix crash when attempting to watch a replay when the storage file doesn't exist
  Dean Herbert · 2022-08-30 18:18:46 +09:00
  928bce8fcd
• Assert non-null in ProfileHeader to appease r#
  Dean Herbert · 2022-08-30 18:09:10 +09:00
  d600058c98
• Merge pull request #20026 from peppy/notifications-nrt

  Apply NRT to notification classes

  Dan Balasescu · 2022-08-30 17:23:11 +09:00
  0e68620f70
• Merge pull request #20028 from smoogipoo/add-legacy-total-score

  Add LegacyTotalScore to SoloScoreInfo

  Dean Herbert · 2022-08-30 16:39:25 +09:00
  e39d236f27
• Apply NRT to notification classes

  and tidy things up a bit.

  Dean Herbert · 2022-08-30 15:57:10 +09:00
  b8fda1a16f
• Add LegacyTotalScore to SoloScoreInfo
  Dan Balasescu · 2022-08-30 15:50:19 +09:00
  799c015bff
• Merge pull request #20024 from smoogipoo/populate-maximum-statistics-test

  Populate `MaximumStatistics` for test scores

  Dean Herbert · 2022-08-30 15:44:52 +09:00
  ea7e5797d1
• Fix test by also clearing out maximum statistics
  Dan Balasescu · 2022-08-30 15:42:36 +09:00
  8b3742188f
• Populate MaximumStatistics for test scores
  Dan Balasescu · 2022-08-30 15:11:39 +09:00
  5202c15a0e
• Remove unnecessary usage of DrawableAudioMixer in ScorePanel
  Dean Herbert · 2022-08-30 15:05:21 +09:00
  5d41fdfc89
• Merge pull request #19982 from OliBomby/fix-illegal-merge

  Fixed 0 length merge being allowed

  Dean Herbert · 2022-08-30 12:28:18 +09:00
  706ac3e44f
• Updated canMerge check to be totally accurate
  OliBomby · 2022-08-30 00:18:55 +02:00
  44916c51d7
• Move helper method to bottom of class
  Dean Herbert · 2022-08-30 02:51:42 +09:00
  2e5770be4e
• Moved guards to separate canMerge method
  OliBomby · 2022-08-29 18:58:29 +02:00
  d50e9caa11
• remove call to changeHandler BeginChange
  OliBomby · 2022-08-29 16:05:35 +02:00
  a296c1ec81
• Merge pull request #19716 from MBmasher/fl-grid

  Nerf repeated angles in Flashlight skill

  Dan Balasescu · 2022-08-29 21:15:45 +09:00
  e34c8e4975
• Merge pull request #19974 from peppy/no-gameplay-clock-editor-offset

  Fix editor not applying offsets

  Dan Balasescu · 2022-08-29 21:10:29 +09:00
  0491addbbd
• Merge pull request #19973 from peppy/no-gameplay-clock-beat-synced-container

  Fix beat synced components not applying offsets

  Dan Balasescu · 2022-08-29 20:43:26 +09:00
  8e42af8e66
• Merge pull request #20011 from smoogipoo/scoring-refactor

  Refactor scoring to remove async methods / simplify

  Dean Herbert · 2022-08-29 19:55:27 +09:00
  82b9e1f0eb
• Merge pull request #20013 from peppy/always-reprocess-beatmap-after-update

  Always reprocess beatmaps after a user update request

  Dan Balasescu · 2022-08-29 18:50:27 +09:00
  eb3601b7ff
• Merge pull request #19907 from peppy/ruleset-api-versioning

  Add ruleset API versioning

  Dan Balasescu · 2022-08-29 18:50:01 +09:00
  e3e204001e
• Merge pull request #20012 from peppy/target-mod-toggle-metronome

  Add setting to toggle metronome in "Target" mod

  Dan Balasescu · 2022-08-29 18:47:43 +09:00
  b25d1fbbae
• Merge branch 'master' into no-gameplay-clock-beat-synced-container
  Dean Herbert · 2022-08-29 18:22:54 +09:00
  2e3c62296a
• Always reprocess beatmaps after a user update request

  This covers the rare case where metadata may have changed server-side but not
  the beatmap itself.
  
  Tested with the provided user database to resolve the issue.
  
  Closes #19976.

  Dean Herbert · 2022-08-29 18:17:42 +09:00
  3eda284b03
• Simplify OrderByTotalScore implementation
  Dan Balasescu · 2022-08-29 17:58:57 +09:00
  07b502f69a
• Merge pull request #19409 from peppy/carousel-maintain-selection-over-update

  Fix beatmap carousel not maintaining selection if currently selected beatmap is updated

  Salman Ahmed · 2022-08-29 11:55:04 +03:00
  b56fbacaa6
• Merge branch 'master' into carousel-maintain-selection-over-update
  Salman Ahmed · 2022-08-29 11:23:22 +03:00
  f2378d3fde
• Add setting to toggle metronome in "Target" mod

  As mentioned in https://github.com/ppy/osu/discussions/20006#discussioncomment-3496732.

  Dean Herbert · 2022-08-29 17:12:10 +09:00
  780121eeee
• Merge pull request #20010 from smoogipoo/scoreprocessor-no-rewrite-statistics

  Don't include misses in failed score statistics

  Dean Herbert · 2022-08-29 17:07:13 +09:00
  9b830d063f
• Account for offset being applied to editor clock time in TestSceneEditorClock
  Dean Herbert · 2022-08-29 16:42:50 +09:00
  2dafa041a7
• Update template rulesets to include baked value
  Dean Herbert · 2022-08-29 16:32:41 +09:00
  cf8fad045d
• Encapsulate Track inside a FramedClock to avoid mutating operations
  Dean Herbert · 2022-08-29 16:29:19 +09:00
  be5c6232e8
• Merge branch 'master' into no-gameplay-clock-beat-synced-container
  Dean Herbert · 2022-08-29 16:16:59 +09:00
  c50695ea49
• Adjust test
  Dan Balasescu · 2022-08-29 15:59:57 +09:00
  d4a37725c4
• Merge pull request #20008 from smoogipoo/scoreprocessor-computescore

  Refactor/merge `ScoreProcessor.ComputeScore()` methods

  Dean Herbert · 2022-08-29 15:54:43 +09:00
  2b7b77157a
• Update xmldoc
  Dan Balasescu · 2022-08-29 15:51:12 +09:00
  81ac0daba8
• Simplify GetMaximumAchievableCombo further
  Dan Balasescu · 2022-08-29 15:36:10 +09:00
  d75543ad68
• Remove async calls from ScoreManager
  Dan Balasescu · 2022-08-29 15:34:08 +09:00
  423f6f90f2
• Don't include misses in failed score statistics
  Dan Balasescu · 2022-08-29 15:27:19 +09:00
  b2e80ca7f0
• Add test coverage of selection being retained
  Dean Herbert · 2022-08-29 15:23:34 +09:00
  e8ae6840ea
• Add test coverage of ruleset being marked unavailable if methods are throwing
  Dean Herbert · 2022-08-29 14:28:55 +09:00
  892f43da43
• Add test coverage for outdated ruleset
  Dean Herbert · 2022-08-29 14:26:12 +09:00
  5ff4e6a4fe
• Remove "internal" identifier as unnecessary
  Dean Herbert · 2022-08-29 14:01:15 +09:00
  90b9c02ac6
• Refactor ScoreProcessor ComputeScore() methods
  Dan Balasescu · 2022-08-29 13:51:10 +09:00
  c0b13c7e1f
• Merge pull request #19995 from its5Q/import-crash-fix

  Fix crash with legacy import from incomplete installs

  Dean Herbert · 2022-08-28 13:52:12 +09:00
  3e246caf05
• Fix crash with legacy import from incomplete installs
  its5Q · 2022-08-28 14:13:38 +10:00
  0cc6a76c17