68285 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Bartłomiej Dach	8d89557ab8	Fix not being able to send chat reports on daily challenge screen ... Something something some people cannot be trusted with a textbox.	2024-07-25 11:11:54 +02:00
Bartłomiej Dach	9790c5a574	Merge pull request #29058 from frenzibyte/daily-challenge-fix-score-selection ... Fix daily challenge abruptly discarding score selection when opening results screen	2024-07-25 10:46:32 +02:00
Salman Ahmed	9d5fbb8b4f	Fix target score selection abruptly discarded after opening results screen	2024-07-25 09:01:43 +03:00
Salman Ahmed	e1ccf68801	Revert "Add failing test case" ... This reverts commit 0182f3d7c3.	2024-07-25 08:51:48 +03:00
Dan Balasescu	542cb12059	Merge pull request #28995 from bdach/swell-editor-test-play ... Fix swells not being correctly treated in editor gameplay test	2024-07-25 14:39:49 +09:00
Dean Herbert	f1dda4ab1e	Fix too many event rows displaying after spending a long time in gameplay/results	2024-07-25 14:31:22 +09:00
Dean Herbert	c90d345ff9	Scroll content forever rather than aggressively fading	2024-07-25 14:31:21 +09:00
Dean Herbert	bba151a776	Make event feed test show more realistic content automatically	2024-07-25 14:31:21 +09:00
Bartłomiej Dach	ccef98d24e	Merge pull request #29054 from peppy/fix-leaderboard-refreshing ... Fix excessive leaderboard refreshes in daily challenge screen	2024-07-25 07:15:17 +02:00
Salman Ahmed	dad8e28446	Fix replay download button not added when no score is selected initially	2024-07-25 07:40:17 +03:00
Salman Ahmed	0182f3d7c3	Add failing test case	2024-07-25 07:39:58 +03:00
Dean Herbert	aac98ab6b2	Debounce leaderboard refetches to stop excessive operations after returning from gameplay	2024-07-25 12:58:35 +09:00
Dean Herbert	9ec687caab	Avoid reloading the daily challenge leaderboard when already requested	2024-07-25 12:55:45 +09:00
Dan Balasescu	a696e3c261	Add reference to android project	2024-07-25 10:44:44 +09:00
Dan Balasescu	c5814e0869	Merge pull request #29047 from RealCyGuy/good-first-issues ... Fix link to good first issues in CONTRIBUTING.md	2024-07-25 10:38:23 +09:00
Cyrus Yip	d63335082e	fix link to good first issues	2024-07-24 18:24:52 -07:00
Dan Balasescu	3dd7db5499	Merge pull request #29046 from peppy/disable-macos-runs ... Disable macOS test runs for now	2024-07-25 09:49:00 +09:00
Dean Herbert	4cc07badbd	Disable macOS test runs for now ... We are seeing update frames run as little as [once per second](aa4d16bdb8/osu.Game/Overlays/BeatmapListingOverlay.cs (L141)). Until we can ascertain why this is happening, let's reduce developer stress by not running macOS tests for now.	2024-07-25 09:05:58 +09:00
Dan Balasescu	d057bee4fb	Merge pull request #29044 from frenzibyte/fix-drag-overwritten-by-focus ... Fix dragging number boxes no longer working correctly	2024-07-25 08:36:39 +09:00
Salman Ahmed	b3e3bf7cec	Add lenience to avoid floating point errors	2024-07-24 23:26:23 +03:00
Salman Ahmed	6645dac71d	Fix dragging number boxes overwritten by select-all-on-focus feature	2024-07-24 23:19:04 +03:00
Dean Herbert	4983e5f33e	Merge pull request #29039 from bdach/multiple-selection-sample-popover ... Make sample popover change properties of all samples in multiple selection	2024-07-24 22:49:20 +09:00
Bartłomiej Dach	1ed7e4b075	Make sample popover change properties of all samples in multiple selection ... Closes https://github.com/ppy/osu/issues/28916. The previous behaviour *may* have been intended, but it was honestly quite baffling. This seems like a saner variant.	2024-07-24 12:15:12 +02:00
Bartłomiej Dach	55382a4ba6	Add test coverage for expected sample popover behaviour	2024-07-24 12:08:13 +02:00
Dean Herbert	6e4625609d	Merge pull request #29036 from bdach/hardcode-positions-for-leaderboard ... Fill daily challenge top 50 position numbers client-side	2024-07-24 17:49:51 +09:00
Dean Herbert	65fcef1929	Merge pull request #29037 from bdach/daily-challenge-exit-when-offline ... Exit daily challenge screen when going offline	2024-07-24 17:48:07 +09:00
Bartłomiej Dach	788b70469d	Exit daily challenge screen when going offline ... This sort of thing is bound to happen when rewriting screens from scratch without invoking abstract eldritch entities sometimes. Damned if you do, damned if you don't...	2024-07-24 09:15:32 +02:00
Bartłomiej Dach	bf4bf4d39e	Fill daily challenge top 50 position numbers client-side ... Only doing this client-side, because doing this server-side is expensive: https://github.com/ppy/osu-web/pull/11354#discussion_r1689224285	2024-07-24 08:57:11 +02:00
Dean Herbert	aded31bd07	Merge pull request #29021 from bdach/editor-breaks-respect-time-preempt ... Respect pre-empt time when auto-generating breaks	2024-07-24 15:21:12 +09:00
Dean Herbert	a9ccb50b98	Merge pull request #29020 from bdach/drag-selection-tolerance ... Add tolerance when drag-scrolling editor timeline	2024-07-23 22:28:29 +09:00
Dean Herbert	aed7ba9508	Change order of application to avoid bias to side with more room to drag ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2024-07-23 20:56:21 +09:00
Bartłomiej Dach	c3062f96ee	Fix autogenerated breaks not invalidating on change to pre-empt time	2024-07-23 13:38:50 +02:00
Bartłomiej Dach	c2fa30bf81	Add test coverage for break generation respecting pre-empt time	2024-07-23 13:38:25 +02:00
Bartłomiej Dach	088e8ad0a2	Respect pre-empt time when auto-generating breaks ... Closes https://github.com/ppy/osu/issues/28703.	2024-07-23 13:30:13 +02:00
Bartłomiej Dach	25d63ac6a5	Move editor beatmap processor test cases off of OsuHitObjects ... Most of them are about to become obsolete once consideration for `TimePreempt` is re-added.	2024-07-23 13:28:49 +02:00
Dean Herbert	40b171f544	Merge pull request #29019 from bdach/catch-juice-stream-editing-weirdness-continued ... Fix duration fluctuations and one-frame jitters when editing juice streams	2024-07-23 19:02:30 +09:00
Dean Herbert	cc4ed0ff3f	Use non-screen-space coordinates and add time-based drag ramping for better control	2024-07-23 18:59:22 +09:00
Bartłomiej Dach	38fc6f70f6	Add tolerance when drag-scrolling editor timeline ... Closes https://github.com/ppy/osu/issues/28983. While the direct cause of this is most likely mouse confine in full-screen, it shouldn't/can't really be disabled just for this, and I also get this on linux in *windowed* mode. In checking other apps, adding some tolerance to this sort of drag-scroll behaviour seems like a sane UX improvement anyways.	2024-07-23 11:10:18 +02:00
Dean Herbert	aba05a21aa	Merge branch 'master' into catch-juice-stream-editing-weirdness-continued	2024-07-23 17:05:40 +09:00
Dean Herbert	5911c42116	Merge pull request #28999 from bdach/catch-juice-stream-editing-weirdness ... Fix various shortcomings in juice stream selection blueprint	2024-07-23 16:43:39 +09:00
Bartłomiej Dach	6100f5269d	Fix tests	2024-07-23 09:13:43 +02:00
Bartłomiej Dach	f3617eadad	Fix editing juice stream path sometimes changing its duration ... I'm not *super* sure why this works, but it appears to, and my educated guess as to why is that it counteracts the effects of a change in the SV of the juice stream by artificially increasing or decreasing the velocity when running the appropriate path conversions and expected distance calculations. The actual SV change takes effect on the next default application, which is triggered by the `Update()` call at the end of the method.	2024-07-22 15:14:45 +02:00
Bartłomiej Dach	56af009e77	Fix EditablePath.UpdateHitObjectFromPath() not automatically updating object ... This is important because the editable path conversions heavily depend on the value of `JuiceStream.Velocity` being correct. The value is only guaranteed to be correct after an `ApplyDefaults()` call, which is triggered by updating the object via `EditorBeatmap`.	2024-07-22 14:50:25 +02:00
Bartłomiej Dach	f86ab1a64e	Fix filename	2024-07-22 13:49:52 +02:00
Bartłomiej Dach	1d91201c43	Fix tests	2024-07-22 13:37:24 +02:00
Bartłomiej Dach	6b3c1f4e47	Unify juice stream piece UX with osu! control point pieces ... - Use same hover state - Use shift-right click for quick delete rather than shift-left click	2024-07-22 13:30:15 +02:00
Bartłomiej Dach	47964f33d7	Fix catch juice stream vertex remove operation not undoing	2024-07-22 13:21:49 +02:00
Bartłomiej Dach	64381d4087	Fix catch juice stream vertex add operation not undoing	2024-07-22 12:18:53 +02:00
Dean Herbert	7e5fda4539	Merge pull request #28996 from bdach/fix-dim-again ... Fix editor UI dimming when hovering over expanded part of toolboxes	2024-07-22 19:11:31 +09:00
Bartłomiej Dach	57fa502786	Fix editor UI dimming when hovering over expanded part of toolboxes ... Closes https://github.com/ppy/osu/issues/28969.	2024-07-22 11:57:46 +02:00