2020 Commits

• use TimeSpan for defining thresholds
  Hivie · 2025-07-21 12:32:45 +01:00
  86369ab403
• Add verify check for lowest diff drain time requirement
  Hivie · 2025-07-13 02:00:50 +01:00
  ccf6d9c173
• Fix mania Hard Rock & Easy mods not matching stable

  The implementation in `master` was presuming that Hard Rock and Easy
  worked the same way across all rulesets, but actually, in stable mania,
  the two mods have special treatment as per
  
  	https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameplayElements/HitObjectManagerMania.cs#L147-L150
  
  The open question here would be what this means for existing scores set
  on lazer using this mod.

  Bartłomiej Dach · 2025-07-02 12:26:50 +02:00
  8e53f47e78
• Merge pull request #33960 from bdach/catch-timestamp-support

  Read & output combo indices in timestamps in catch editor

  Dean Herbert · 2025-07-01 17:28:29 +09:00
  b3ba51d730
• Fix Difficulty Adjust extended mod icon information not showing with extended limits active

  - Closes https://github.com/ppy/osu/issues/33522.
  - Alternative to / closes https://github.com/ppy/osu/pull/33561.

  Bartłomiej Dach · 2025-06-30 12:20:05 +02:00
  28caa03d21
• Read & output combo indices in timestamps in catch editor

  Addresses https://github.com/ppy/osu/discussions/33912 for catch
  specifically. Code copy-pasted from osu! ruleset.
  
  I'm leaving taiko be because new combo still doesn't make any sense in
  taiko. It'd probably either have to be object index in beatmap period
  instead of index in combo, or the `kdkdkdkdkkkdkdkkkdkkdkd` notation
  people use.

  Bartłomiej Dach · 2025-06-30 11:50:31 +02:00
  535d9f5b58
• Add localisation usage to BeatmapStatistic and revert ShowDetailsMappedBy
  diquoks · 2025-06-21 21:01:48 +03:00
  cad4382350
• Fix replays being misrecorded if an action is pressed and released in one update frame

  Closes https://github.com/ppy/osu/issues/33465 probably.
  
  This reverts the replay frame de-duplication logic to what it was before
  https://github.com/ppy/osu/pull/33148#discussion_r2091549388.
  
  I don't have good reproduction steps. I tried to write a test case for
  this that isn't just "press and release a key in the same frame",
  thinking that maybe there was some loophole in the osu! touch input
  mapper that may produce this situation artificially, but I could not in
  many configurations. So I have to assume that this just *can happen*
  organically.

  Bartłomiej Dach · 2025-06-06 09:10:51 +02:00
  12cc8e38da
• Make CheckConcurrentObject ruleset specific
  Derrick Timmermans · 2025-05-25 14:19:23 +02:00
  0065696248
• Merge branch 'master' into gameplay-leaderboard-skinnable
  Bartłomiej Dach · 2025-05-07 10:45:51 +02:00
  5b61761bbd
• Merge pull request #32970 from peppy/mod-icon-improvements

  Improve visibility of setting adjustments on mod icons

  Dean Herbert · 2025-04-30 17:21:12 +09:00
  373a74da4b
• Don't bother with localised implementation of AdjustedSettingsCount

  I was avoiding using reflection to save on overheads, but it's probably
  not worth it.

  Dean Herbert · 2025-04-30 12:58:40 +09:00
  babccca2bb
• Fix osu!catch getting upscaled on portrait orientation
  Salman Alshamrani · 2025-04-30 05:03:51 +03:00
  a8ca60497c
• Show singular difficulty adjust modifications inline in mod icons
  Dean Herbert · 2025-04-28 16:58:16 +09:00
  c16514274d
• Convert gameplay leaderboard to skinnable component

  This PR converts the leaderboard into a full-fledged skinnable component
  that can be manipulated by users at will.
  
  Notably, this finally allows https://github.com/ppy/osu/issues/20422 to
  be fixed - although it's a very mixed bag, for several reasons:
  
  - Because of taiko players' refusal to see reason^W^W^W^Winsistence on
    keeping stable behaviours related to aspect ratio treatment, I have to
    assume the worst case scenario, which means than on typical
    resolutions like 16:9 (or even worse, 4:3), the leaderboard will
    likely not occupy as much vertical space as it probably could.
  
  - Additionally, there's the problem of where to put the spectator list.
    I settled on putting it to the right of the leaderboard, but that's
    kind of janky, because the leaderboard sometimes collapses and
    sometimes fully hides, leading to a very awkward space left behind. If
    we had the capability to anchor elements to other elements, maybe this
    could be resolved, but for now, I'm not sure what to do. I think if
    some users are bothered by it they can move it where they want it. Or
    delete it.

  Bartłomiej Dach · 2025-04-24 13:10:30 +02:00
  59b826c321
• Minor fix to the description text
  Shavixinio · 2025-04-22 19:49:34 +02:00
  3b2382ceb0
• Don't include spinner types in note sums
  Dean Herbert · 2025-04-14 19:21:36 +09:00
  3d47a2b5b2
• Rename new property to better explain visual-only usage
  Dean Herbert · 2025-04-14 18:38:04 +09:00
  f05a50f4e1
• Introduce numeric value in beatmap hit count statistics
  Salman Alshamrani · 2025-04-12 00:14:53 +09:00
  85556e0c3e
• Shorten beatmap hit statistics names
  Salman Alshamrani · 2025-04-11 02:33:57 +09:00
  1dbcbbde15
• Fix editor setup screen sliders not having correct keyboard steps

  Closes https://github.com/ppy/osu/issues/32691.
  
  Fixes some extra cases of failure that aren't pointed out in the issue.

  Dean Herbert · 2025-04-08 14:45:43 +09:00
  f2088496c5
• Change SettingDescription to differentiate between settings and values
  Salman Alshamrani · 2025-03-23 13:43:26 -04:00
  6e635f124a
• Move BeatmapVersion from BeatmapInfo to IBeatmap

  Closes https://github.com/ppy/osu/issues/32420.
  
  The failure cause here is that in editor the beatmap version for the
  beatmap affected (or... any beatmap, really), is 0 (ZERO). That is
  probably a regression from https://github.com/ppy/osu/pull/32315, but
  like... can we universally agree that calling that change "a regression"
  in any capacity is dumb? Like what was that code *doing* playing dumb
  reference games and copying stuff into an arbitrary instance that could
  get or not get used later on? And now you have a 50/50 chance of
  accessing the *correct* model's field, depending on whether you go via
  `BeatmapInfo` or `Beatmap.BeatmapInfo`?
  
  Moving the field to `IBeatmap`, i.e. what is by now - by consensus,
  since https://github.com/ppy/osu/pull/28473 - supposed to be the "decoded
  and materialised" beatmap, fixes this issue.
  
  I probably should have done this as part of
  https://github.com/ppy/osu/pull/28473 but it slipped my mind. Probably
  for the better too because this change has rather large chances of
  breaking stuff so maybe better to examine it in isolation (via diffcalc
  runs or whatever).
  
  For added humour points, you'd say that the field on `BeatmapInfo` was
  not `[Ignore]`d, so this is a realm schema change, right? No. As far as
  I can tell, it's not. I opened realm studio and `BeatmapVersion` *is not
  a listed column` on `Beatmap` models.
  
  I'm also not gonna get into the fact that I think `EditorBeatmap` doing
  dumb games with juggling two `BeatmapInfo` references since
  https://github.com/ppy/osu/pull/15075 is bad, because I don't think I
  have the mental capacity to hotfix this by going down that train of
  thought.

  Bartłomiej Dach · 2025-03-17 15:04:48 +01:00
  91f3be5fea
• Fix edge case allowing almost-zero-length sliders to be placed during distance snapping
  Dean Herbert · 2025-03-11 16:17:44 +09:00
  23891b1994
• Bump difficulty calculator versions in preparation for release
  Dean Herbert · 2025-03-06 16:05:51 +09:00
  bdd2808fb5
• Mark MathHelper.Clamp() as banned API

  See previous commit for partial rationale.
  
  There's an argument to be made about the `NaN`-spreading semantics being
  desirable because at least something will loudly fail in that case, but
  I'm not so sure about that these days. It feels like either way if
  `NaN`s are produced, then things are outside of any control, and chances
  are the game can probably continue without crashing. And, this move
  reduces our dependence on osuTK, which has already been living on
  borrowed time for years now and is only awaiting someone brave to go
  excise it.

  Bartłomiej Dach · 2025-02-28 13:48:22 +01:00
  35b0ff80bb
• Merge branch 'master' into pp-dev
  Dean Herbert · 2025-02-27 00:08:43 +09:00
  87b6dddd11
• Scale catch down to remain playable on mobile
  Salman Alshamrani · 2025-02-21 01:21:10 +09:00
  440a776bd7
• Fix nudge operations incurring FP error from coordinate space conversions

  Closes https://github.com/ppy/osu/issues/31915.
  
  Reproduction of aforementioned issue requires 1280x720 resolution, which
  should also be a good way to confirm that this does anything.
  
  To me this is also equal-parts-bugfix, equal-parts-code-quality PR,
  because tell me: what on earth was this code ever doing at
  `ComposeBlueprintContainer` level? Nudging by one playfield-space-unit
  doesn't even *make sense* in something like taiko or mania.

  Bartłomiej Dach · 2025-02-17 15:21:07 +01:00
  f37a56c307
• Rename buzz variable per review
  Dean Herbert · 2025-02-10 18:05:08 +09:00
  340e081965
• Calculate hit windows in performance calculator instead of databased difficulty attributes (#31735)

  * Calculate hit windows in performance calculator instead of databased difficulty attributes
  
  * Apply mods to beatmap difficulty in osu! performance calculator
  
  * Remove `GreatHitWindow` difficulty attribute for osu!mania
  
  * Remove use of approach rate and overall difficulty attributes for osu!
  
  * Remove use of hit window difficulty attributes in osu!taiko
  
  * Remove use of approach rate attribute in osu!catch
  
  * Remove unused attribute IDs
  
  * Code quality
  
  * Fix `computeDeviationUpperBound` being called before `greatHitWindow` is set

  James Wilson · 2025-02-07 19:21:12 +09:00
  9f90ebb2f7
• Merge branch 'master' into pp-dev
  Dean Herbert · 2025-02-07 14:09:25 +09:00
  6c069b3373
• Refactor IDistanceSnapProvider to accept slider velocity objects as a reference

  Method signatures are also changed to be a lot more explicit as to what
  inputs they expect.

  Bartłomiej Dach · 2025-02-03 14:00:57 +01:00
  a1185df2eb
• Merge pull request #31655 from bdach/deabstractify-editor-snap

  Refactor editor object snapping to remove bad abstractions

  Dan Balasescu · 2025-01-30 01:38:42 +09:00
  48b1c7398e
• Remove "Accuracy" and "Stack Leniency" from osu!catch editor setup
  Dean Herbert · 2025-01-28 21:22:51 +09:00
  1aa1137b09
• Refactor further to avoid weird non-virtual common method
  Bartłomiej Dach · 2025-01-24 13:14:31 +01:00
  daec91f61d
• Remove dependence of placement blueprints on IPositionSnapProvider
  Bartłomiej Dach · 2025-01-24 11:59:07 +01:00
  a6987f5c95
• Remove dependence of blueprint containers on IPositionSnapProvider
  Bartłomiej Dach · 2025-01-24 11:59:05 +01:00
  15b6e28ebe
• Merge branch 'master' into pp-dev
  Dean Herbert · 2025-01-21 13:19:01 +09:00
  aeca37c230
• Replace indexed skill access with skills.OfType<...>().Single() (#30034)

  * Replace indexed skill access with `skills.First(s is ...)`
  
  * Fix comment
  
  * Further refactoring to remove casts
  
  ---------
  
  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  StanR · 2025-01-20 09:39:35 +00:00
  22e839d62b
• Fix osu!catch "buzz slider" SR abuse (#31126)

  * Implement fix for catch buzz sliders SR abuse
  
  * Run formatting
  
  ---------
  
  Co-authored-by: StanR <hi@stanr.info>

  Bastien D. · 2025-01-18 22:26:23 +03:00
  67723b3e52
• Merge spectator list classes into one skinnable
  Bartłomiej Dach · 2025-01-17 11:23:14 +01:00
  3c4bfc0a01
• Merge branch 'spectator-list-visuals' into spectator-list-ready
  Bartłomiej Dach · 2025-01-16 15:13:04 +01:00
  0c54853710
• Add skinnable spectator list to default skins
  Bartłomiej Dach · 2025-01-15 14:29:53 +01:00
  99c7e164dc
• Merge pull request #31446 from EVAST9919/new-combo-editor

  Fix performance degradation while trying to place object with a new combo in the editor.

  Dean Herbert · 2025-01-15 12:56:06 +09:00
  ef7982fbfa
• Merge branch 'master' into new-combo-editor
  Bartłomiej Dach · 2025-01-10 14:13:14 +01:00
  933f5db208
• Merge conditionals
  Bartłomiej Dach · 2025-01-10 14:13:03 +01:00
  0d9a3428ae
• Add combo colour override control to editor

  Closes https://github.com/ppy/osu/issues/25608.
  
  Logic mostly matching stable. All operations are done on `ComboOffset`
  which still makes overridden combo colours weirdly relatively dependent
  on each other rather than them be an "absolute" choice, but alas...
  
  As per stable, two consecutive new combos can use the same colour only
  if they are separated by a break:
  
      https://github.com/peppy/osu-stable-reference/blob/52f3f75ed7efd7b9eb56e1e45c95bb91504337be/osu!/GameModes/Edit/Modes/EditorModeCompose.cs#L4564-L4571
  
  This control is only available once the user has changed the combo
  colours from defaults; additionally, only a single new combo object
  must be selected for the colour selector to show up.

  Bartłomiej Dach · 2025-01-10 13:40:56 +01:00
  48196949e0
• Merge pull request #31462 from bdach/ternary-button-is-bad

  Simplify editor "ternary button" structure

  Dan Balasescu · 2025-01-10 14:24:41 +09:00
  38d95abc24
• Merge pull request #31453 from bdach/fix-juice-stream-placement-offset

  Fix juice stream placement blueprint being initially visually offset

  Dean Herbert · 2025-01-10 01:51:24 +09:00
  2133ac6d01