Dean Herbert
99e55bb9c0
Add logging and Debug.Fail on detached beatmap detection
2023-06-28 12:21:05 +09:00
Dean Herbert
8e80e2fa32
Fix incorrect realm copy logic when a beatmap becomes detached from its set
...
The code here was assuming that if the beatmap which is having changes
copied across does not exist within the `BeatmapSet.Beatmaps` list, it
was not yet persisted to realm.
In some edge case, it can happen that the beatmap *is* persisted to
realm but not correctly attached to the beatmap set. I don't yet know
how this occurs, but it has caused loss of data for at least two users.
The fix here is to check realm-wide for the beatmap (using its primary
key) rather than only in the list. We then handle the scenario where the
beatmap needs to be reattached to the set as a seprate step.
---
This does raise others questions like "are we even structuring this
correctly? couldn't a single beatmap exist in two different sets?"
Maybe, but let's deal with that if/when it comes up.
2023-06-27 18:20:01 +09:00
Dean Herbert
4ecc724841
Add test coverage of save failure when beatmap is detached from set
2023-06-27 18:18:58 +09:00
Dean Herbert
9b08aaf93f
Merge pull request #24045 from peppy/exact-match-song-select
...
Add exact match support for song select searches
2023-06-27 13:47:26 +09:00
Bartłomiej Dach
9c30b1d3e0
Merge branch 'master' into exact-match-song-select
2023-06-26 22:33:50 +02:00
Bartłomiej Dach
e998be0eee
Use == true rather than ?? false
2023-06-26 22:29:20 +02:00
Bartłomiej Dach
4cb122dad4
Escape user input before embedding into regex
2023-06-26 22:27:48 +02:00
Bartłomiej Dach
4873aaf7ed
Add failing test case for filters potentially crashing due to invalid regex
2023-06-26 22:27:08 +02:00
Bartłomiej Dach
8a7a42b7ec
Remove weird nullable enable and double licence header
2023-06-26 22:19:52 +02:00
Dean Herbert
c84a75406c
Merge pull request #24053 from bdach/fix-skip-when-ready-2
...
Fix skip not always triggering in multiplayer
2023-06-27 05:10:14 +09:00
timiimit
e1cbcabe0b
Fix skip not always triggering in multiplayer
2023-06-26 21:26:41 +02:00
Dean Herbert
a74547c43c
Add exact match support at song select
2023-06-26 18:26:44 +09:00
Dean Herbert
1960cd0839
Add test coverage of exact matching of search terms
2023-06-26 18:26:44 +09:00
Dean Herbert
14c95f4584
Apply NRT to FilterCriteria
2023-06-26 17:54:11 +09:00
Dean Herbert
6ec8ccda11
Merge pull request #24039 from bastianpedersen/localise-multiplayer-countdown-buttons
...
Localise multiplayer countdown buttons
2023-06-26 14:55:28 +09:00
Dean Herbert
719ac75ad2
Merge pull request #24037 from cdwcgt/tournament-beatmapcache
...
Use beatmap cache to populate beatmap information in tournament client
2023-06-26 14:55:05 +09:00
Bastian Pedersen
506829d9a5
Merge branch 'master' into localise-multiplayer-countdown-buttons
2023-06-26 07:28:05 +02:00
Dean Herbert
e085a36aac
Merge pull request #23331 from letsgoawaydev/ui-login-spacing-fix
...
Update login overlay appearance to match new designs
2023-06-26 14:11:57 +09:00
Dean Herbert
b240ce295b
Rename class and key to better match expectations
2023-06-26 13:38:34 +09:00
Dean Herbert
1abce098b4
Apply nullability to login form related classes
2023-06-26 13:26:07 +09:00
Dean Herbert
372cef3c0a
Merge branch 'master' into ui-login-spacing-fix
2023-06-26 13:24:26 +09:00
Dean Herbert
ac0c988d49
Fix weirdly named test method and add xmldoc
2023-06-26 13:21:29 +09:00
Dean Herbert
8d2dccbda5
Remove pointless zero opacity specification
2023-06-26 13:19:07 +09:00
Dean Herbert
55ab27c5b6
Merge pull request #24022 from frenzibyte/fix-open-user-profile-argument
...
Fix `OpenUserProfile` links having multiple argument types
2023-06-26 13:13:05 +09:00
Joseph Madamba
5477ef6bfb
Remove unused usings
2023-06-25 12:58:51 -07:00
Joseph Madamba
ccc4d16096
Remove most custom styling of user dropdown
2023-06-25 12:46:00 -07:00
Joseph Madamba
6ebc2581c2
Normalise login overlay padding/spacing
2023-06-25 12:26:01 -07:00
Joseph Madamba
671f84e32b
Remove unnecessary container
2023-06-25 12:15:03 -07:00
Joseph Madamba
4582faee79
Refactor login panel to not inherit FillFlowContainer
2023-06-25 12:06:02 -07:00
Bastian Pedersen
a7153478d6
Use newly create localised strings for buttons
2023-06-25 21:03:07 +02:00
Bastian Pedersen
59fa46bbdd
Create localisation string class for multiplayer countdown buttons
2023-06-25 21:02:51 +02:00
Joseph Madamba
4a3b8c405e
Fix login error text adding unnecessary spacing
2023-06-25 11:57:17 -07:00
Joseph Madamba
442fda3598
Remove using aliases
2023-06-25 11:39:33 -07:00
Joseph Madamba
1058f434d7
Update login overlay background to conform to other overlays
2023-06-25 11:39:32 -07:00
Joseph Madamba
25c9bf4061
Improve and refactor LoginPanel test scene to use LoginOverlay
2023-06-25 11:39:32 -07:00
Joseph Madamba
f87ac3f405
Merge remote-tracking branch 'upstream/master' into pr/23331
2023-06-25 10:01:32 -07:00
Bartłomiej Dach
66f1ed052b
Merge pull request #24033 from cdwcgt/chatdisplay-fix
...
Fix tournament chat potentially crashing due to null current match
2023-06-25 18:12:15 +02:00
cdwcgt
1b671b8c6e
Use GetResultSafely()
2023-06-26 00:45:59 +09:00
Bartłomiej Dach
88fbc3094a
Merge branch 'master' into chatdisplay-fix
2023-06-25 17:39:45 +02:00
Bartłomiej Dach
44a3f40188
Rename test step
2023-06-25 17:39:36 +02:00
Bartłomiej Dach
7d9d7066cd
Remove no-longer-needed BDL permitNulls spec
2023-06-25 17:39:15 +02:00
Bartłomiej Dach
9862992af0
Use alternative guard
...
Early-returning from ctors feels pretty bad. Also saves on some
nested accesses.
2023-06-25 17:37:05 +02:00
cdwcgt
14e26d2a85
use BeatmapCache for populate beatmap information
2023-06-25 22:57:39 +09:00
cdwcgt
e02a06e3e5
Revert "remove #nullable disable in LadderInfo"
...
This reverts commit 0dced46100
2023-06-25 22:47:36 +09:00
Bartłomiej Dach
35d2c0f4cf
Merge pull request #23987 from peppy/no-confirmation-on-update-restart
...
Only require exit confirmation when there are background operations
2023-06-25 15:12:03 +02:00
Bartłomiej Dach
4215ca313f
Add missing using
2023-06-25 14:36:21 +02:00
Dean Herbert
cf43cd2bdc
Rename test scene to match updated class name
2023-06-25 21:26:10 +09:00
Dean Herbert
3d1a8aeb54
Use more understandable cancel button text
2023-06-25 21:25:16 +09:00
Dean Herbert
95e8dd2e8e
Don't attempt to access notifications before loaded
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-06-25 21:25:07 +09:00
cdwcgt
a3cd0d14a3
null guard for Current Match in MatchMessage
2023-06-25 20:46:58 +09:00
