Bartłomiej Dach
|
6cb8231054
|
Add test coverage for failure case
|
2023-12-22 13:22:26 +01:00 |
|
Bartłomiej Dach
|
7e557152fb
|
Fix relax mod not considering full follow area radius when automatically holding sliders
Closes https://github.com/ppy/osu/issues/25947.
Regressed in https://github.com/ppy/osu/pull/25776 with the changes to
`DrawableSliderBall`.
I would have liked to include tests, but relax mod is a bit untestable,
because it disengages completely in the presence of a replay:
7e09164d70/osu.Game.Rulesets.Osu/Mods/OsuModRelax.cs (L49-L58)
Additionally, `RulesetInputManager` disengages completely from parent
inputs when there is a replay active:
7e09164d70/osu.Game/Rulesets/UI/RulesetInputManager.cs (L116)
which means there is really no easy way to control positional input
while still having relax logic work. So I'm hoping the fix could be
considered obvious enough to not require test coverage.
|
2023-12-22 12:50:42 +01:00 |
|
Dean Herbert
|
7e09164d70
|
Merge pull request #26036 from smoogipoo/fix-perfect-mod-special-judgements
Fix perfect mod not failing with special judgements
|
2023-12-22 18:22:28 +09:00 |
|
Dan Balasescu
|
a0185508b7
|
Add basic consideration of density for HP drain
|
2023-12-22 18:08:26 +09:00 |
|
Dan Balasescu
|
5703546d71
|
Revert change to ModSuddenDeath
|
2023-12-22 16:43:17 +09:00 |
|
Dan Balasescu
|
88a5ba8167
|
Add mania/osu sudden death mod tests
|
2023-12-22 16:43:09 +09:00 |
|
Dan Balasescu
|
93efa98d9b
|
Fix mania "Great" hits failing with perfect mod
|
2023-12-22 16:19:36 +09:00 |
|
Dan Balasescu
|
ea778c6e0a
|
Fix perfect/sudden death not working on slider tails
|
2023-12-22 14:02:25 +09:00 |
|
Dan Balasescu
|
9c35e25036
|
Add failing tests
|
2023-12-22 13:58:12 +09:00 |
|
Simon G
|
b31b9e96d0
|
adjust beatmap length and drain based on rate changing mods
|
2023-12-22 03:04:48 +01:00 |
|
Dan Balasescu
|
3f6dad5502
|
Use classic HP values for non-classic osu! HP drain
|
2023-12-22 02:16:46 +09:00 |
|
Bartłomiej Dach
|
a7326e3891
|
Merge pull request #26004 from DanielPower/25049-fix-skin-element-bounding-box
Fix scale of skin element bounding box
|
2023-12-21 18:14:24 +01:00 |
|
Dean Herbert
|
716d866178
|
Merge pull request #25998 from peppy/add-score-version
Add versioning of local scores
|
2023-12-21 23:58:23 +09:00 |
|
Dean Herbert
|
472a9da6da
|
Merge pull request #26003 from bdach/big-slider-judgements
Fix slider tick / end misses displaying with full size on legacy skins with animated misses
|
2023-12-21 23:57:36 +09:00 |
|
Bartłomiej Dach
|
b4e71a0787
|
Fix slider tick / end misses displaying with full size on legacy skins with animated misses
Resolves https://github.com/ppy/osu/issues/25987.
Structure is a bit clumsy but I'm not sure how to do better...
|
2023-12-21 13:58:12 +01:00 |
|
Daniel Power
|
d4731e0830
|
Fix scale of skin element bounding box
|
2023-12-21 08:56:39 -03:30 |
|
Bartłomiej Dach
|
fbf19ea598
|
Merge branch 'master' into add-score-version
|
2023-12-21 13:06:53 +01:00 |
|
Bartłomiej Dach
|
5ff95db02c
|
Add test coverage of ClientVersion serialisation
|
2023-12-21 13:06:42 +01:00 |
|
Bartłomiej Dach
|
2baf579f7c
|
Serialise and deserialise ClientVersion to replays
|
2023-12-21 12:58:08 +01:00 |
|
Bartłomiej Dach
|
81bbdccee7
|
Rename ScoreInfo.{ -> Client}Version
|
2023-12-21 12:56:43 +01:00 |
|
Bartłomiej Dach
|
7e9d12e1d2
|
Merge pull request #25993 from smoogipoo/fix-total-score-conversion
Relocate numeric HitResult values, add accuracy conversion
|
2023-12-21 12:10:54 +01:00 |
|
Dean Herbert
|
a4baa0a716
|
Add versioning of local scores
For any potential future usage
|
2023-12-21 18:37:15 +09:00 |
|
Dean Herbert
|
0648201844
|
Cancel test more
|
2023-12-21 18:17:03 +09:00 |
|
Dan Balasescu
|
c3c1752a5a
|
Reconvert all legacy scores
|
2023-12-21 15:32:34 +09:00 |
|
Dan Balasescu
|
eb072a1d24
|
Add accuracy conversion, fix usages
|
2023-12-21 15:09:56 +09:00 |
|
Dan Balasescu
|
6b4b2a57fc
|
Expose only as one method
|
2023-12-21 14:58:23 +09:00 |
|
Dan Balasescu
|
4e3b994142
|
Relocate HitResult numeric score to ScoreProcessor
|
2023-12-21 14:52:31 +09:00 |
|
Dean Herbert
|
4f1e6c31d7
|
Merge pull request #25972 from bdach/argon-pro-no-slider-tick-judgements
|
2023-12-21 10:01:42 +09:00 |
|
Dean Herbert
|
fa4c9051cb
|
Merge branch 'master' into argon-pro-no-slider-tick-judgements
|
2023-12-21 10:01:22 +09:00 |
|
Dean Herbert
|
c8c26df5fa
|
Merge pull request #25976 from bdach/autopilot-incompatibility
|
2023-12-21 09:58:23 +09:00 |
|
Bartłomiej Dach
|
88e36eb08c
|
Fix autopilot mod still declaring incompatibility with fail-preventing mods
Closes https://github.com/ppy/osu/issues/25974.
|
2023-12-20 21:46:18 +01:00 |
|
Bartłomiej Dach
|
b7cca788b5
|
Merge pull request #25964 from rushiiMachine/fix-export-replay-spam
Fix save & export failed replay hotkeys handling repeated keypresses
|
2023-12-20 21:07:36 +01:00 |
|
Bartłomiej Dach
|
b6a331b2f7
|
Fix argon pro not showing slider tick judgements
Addresses https://github.com/ppy/osu/discussions/25968.
|
2023-12-20 20:52:26 +01:00 |
|
Bartłomiej Dach
|
53cca61e61
|
Merge pull request #25951 from peppy/show-tick-results
Show slider tick / slider end misses with a visible judgement
|
2023-12-20 20:44:04 +01:00 |
|
Bartłomiej Dach
|
975bacaeb7
|
Add back blank line to fix code quality inspection
|
2023-12-20 19:07:26 +01:00 |
|
Bartłomiej Dach
|
a763ad8473
|
Add remarks to Is{Hit,Miss}() to explain their simultaneous existence
|
2023-12-20 19:07:18 +01:00 |
|
Dean Herbert
|
c23dd1f808
|
Merge pull request #25945 from smoogipoo/mania-scorev2-values
Adjust mania scoring to be more in line with ScoreV2 + 85% acc / 15% combo
|
2023-12-21 01:53:30 +09:00 |
|
Dean Herbert
|
c5fb4d0f5c
|
Mark flaky test temporarily
|
2023-12-21 01:52:40 +09:00 |
|
rushiiMachine
|
ebbc8333e8
|
Prevent ExportReplay being spammed on fail by being held down
This was already handled in ReplayDownloadButton (98efff0bd6/osu.Game/Screens/Ranking/ReplayDownloadButton.cs (L114-L115)) but seemingly missed for SaveFailedScoreButton
|
2023-12-20 08:41:16 -08:00 |
|
Dean Herbert
|
eb8fb8092d
|
Attempt to standardise miss handling logic
|
2023-12-21 00:59:35 +09:00 |
|
Dean Herbert
|
fcf47267fd
|
Revert change to OsuHitWindows and move logic local to pooling initialisation
|
2023-12-21 00:48:46 +09:00 |
|
Bartłomiej Dach
|
9515f7dbfa
|
Bump score version in order to recompute legacy scores
|
2023-12-20 16:01:59 +01:00 |
|
Bartłomiej Dach
|
8c06d3873d
|
Merge branch 'master' into mania-scorev2-values
|
2023-12-20 15:54:31 +01:00 |
|
Bartłomiej Dach
|
b0da24176e
|
Remove outdated inline comments
|
2023-12-20 15:44:02 +01:00 |
|
Dean Herbert
|
a8c9db2115
|
Merge pull request #25958 from smoogipoo/remove-mania-rate-multipliers
Remove mania mod multiplier for DT/NC
|
2023-12-20 23:31:44 +09:00 |
|
Bartłomiej Dach
|
77d8bbf152
|
Merge pull request #25949 from peppy/fix-song-select-extra-selections
Fix beatmap updates causing one extra carousel selection
|
2023-12-20 15:30:38 +01:00 |
|
Dan Balasescu
|
bff08d124b
|
Remove mania mod multiplier for DT/NC
|
2023-12-20 22:28:50 +09:00 |
|
Bartłomiej Dach
|
83e885192b
|
Merge pull request #25931 from peppy/fix-thread-safety
Fix thread safety of `OnlineMetadataClient.UserStates`
|
2023-12-20 12:55:31 +01:00 |
|
Dean Herbert
|
d1ba2a4a64
|
Use orange for non-combo-breaking miss
|
2023-12-20 20:45:27 +09:00 |
|
Dean Herbert
|
d2716d8557
|
Improve animation for legacy skins
|
2023-12-20 20:34:05 +09:00 |
|