h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-03-21 22:27:23 +08:00
Code Issues Releases Wiki Activity

Merge pull request #26003 from bdach/big-slider-judgements

Browse Source 
Fix slider tick / end misses displaying with full size on legacy skins with animated misses
This commit is contained in:
Dean Herbert 2023-12-21 23:57:36 +09:00 committed by GitHub
commit 472a9da6da
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
osu.Game/Skinning/LegacyJudgementPieceOld.cs
View File

@ -50,17 +50,16 @@ namespace osu.Game.Skinning
// legacy judgements don't play any transforms if they are an animation.... UNLESS they are the temporary displayed judgement from new piece.
if (animation?.FrameCount > 1 && !forceTransforms)
{
if (isMissedTick())
applyMissedTickScaling();
return;
}
if (result.IsMiss())
{
bool isTick = result != HitResult.Miss;
if (isTick)
{
this.ScaleTo(0.6f);
this.ScaleTo(0.3f, 100, Easing.In);
}
if (isMissedTick())
applyMissedTickScaling();
else
{
this.ScaleTo(1.6f);
@ -95,6 +94,14 @@ namespace osu.Game.Skinning
}
}
private bool isMissedTick() => result.IsMiss() && result != HitResult.Miss;
private void applyMissedTickScaling()
{
this.ScaleTo(0.6f);
this.ScaleTo(0.3f, 100, Easing.In);
}
public Drawable GetAboveHitObjectsProxiedContent() => CreateProxy();
}
}