1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-15 10:42:54 +08:00
Commit Graph

63445 Commits

Author SHA1 Message Date
Bartłomiej Dach
88e10dd051
Update framework 2023-10-30 20:19:52 +01:00
Dean Herbert
f706fd2fca
Merge pull request #25307 from bdach/slider-velocity-undo
Fix slider velocity changes not being undone correctly
2023-10-31 01:44:18 +09:00
Bartłomiej Dach
30ffb15868
Merge pull request #25304 from peppy/fix-click-through-timeline
Fix right clicks on timeline potentially not working as expected
2023-10-30 15:03:21 +01:00
Bartłomiej Dach
b2d3aa982d
Merge branch 'master' into fix-click-through-timeline 2023-10-30 12:52:00 +01:00
Bartłomiej Dach
cea24298cb
Privatise setters 2023-10-30 12:42:34 +01:00
Bartłomiej Dach
de89b7e53c
Fix slider velocity changes not being undone correctly
Closes https://github.com/ppy/osu/issues/25239.

`LegacyEditorBeatmapPatcher.processHitObjectLocalData()` was already
supposed to be handling changes to hitobjects that will show up neither
when comparing the hitobjects themselves or the timing point with
"legacy" info stripped - so, in other words, changes to slider velocity
and samples.

However, a change to slider velocity requires default application to
take effect, so just resetting the value would visually fix the timeline
marker but not change the actual object. Calling
`EditorBeatmap.Update()` fixes this by way of triggering default
re-application.

This could probably be smarter (by only invoking the update when
strictly necessary, etc.) - but I'm not sure it's worth the hassle. This
is intended to be a quick fix, rather than a complete solution - the
complete solution would indeed likely entail a wholesale restructuring
of the editor's change handling.
2023-10-30 10:59:02 +01:00
Bartłomiej Dach
b3369dbb7b
Add failing test for slider velocity 2023-10-30 10:57:48 +01:00
Bartłomiej Dach
e1ff0d12c6
Update tests to NUnit-style assertions 2023-10-30 10:55:26 +01:00
Bartłomiej Dach
0ed5f274f6
Enable NRT in TestSceneSliderVelocityAdjust 2023-10-30 10:48:31 +01:00
Dean Herbert
fbba3787d1
Merge pull request #25190 from frenzibyte/match-skin-element-animation-support
Match capability of animating legacy skin elements with osu!(stable)
2023-10-30 18:25:06 +09:00
Dean Herbert
8828562512
Merge pull request #25277 from Susko3/fix-cut-in-filter-textbox
Fix cut and copy not working in song select search filter textbox
2023-10-30 18:18:46 +09:00
Bartłomiej Dach
2dc2469507
Merge pull request #25303 from peppy/last-played-import-score-update
Update the last played date of a beatmap when importing a replay by the local user
2023-10-30 10:12:27 +01:00
Dean Herbert
63e6eaf538
Fix failing tests 2023-10-30 18:06:11 +09:00
Dean Herbert
57d88a0ac4
Fix right clicks on timeline objects potentially getting eaten by playfield area
`SelectionHandler` is receiving input from anywhere out of necessity:

19f892687a/osu.Game/Screens/Edit/Compose/Components/SelectionHandler.cs (L119-L125)

Also important is that `BlueprintContainer` will selectively not block
right clicks to make sure they fall through to the
`ContextMenuContainer`:

19f892687a/osu.Game/Screens/Edit/Compose/Components/BlueprintContainer.cs (L122-L126)

But because the whole editor is sharing a `ContextMenuContainer` and
it's at a higher level than both components, we observe here the
playfield's `SelectionHandler` intercepting the right click before it
can reach the `ContextMenuContainer`.

The fix here is similar to what we're already doing in
`TimelineBlueprintContaienr`.
2023-10-30 18:06:11 +09:00
Dean Herbert
6be02966b9
Add test coverage of failing context menu display 2023-10-30 18:06:11 +09:00
Salman Ahmed
39abb8e408 Only run "select all on focus" behaviour on desktop platforms 2023-10-30 11:54:19 +03:00
Dean Herbert
66fa09ba66
Merge pull request #25287 from frenzibyte/fix-user-profile-support-banners
Update user profile overlay to show more than one tournament banner
2023-10-30 17:32:20 +09:00
Bartłomiej Dach
a000c06900
Merge branch 'master' into last-played-import-score-update 2023-10-30 09:29:07 +01:00
Bartłomiej Dach
0dfb41b796
Add test coverage for not updating LastPlayed due to newer plays 2023-10-30 09:28:37 +01:00
Bartłomiej Dach
19d10e5e45
Merge pull request #25300 from peppy/better-submission-logging
Improve log output surrounding score submission
2023-10-30 09:04:06 +01:00
Bartłomiej Dach
46d1eca0c7
Merge pull request #25301 from peppy/inspections-bash
Fix some new nullable inspections
2023-10-30 08:42:34 +01:00
Dean Herbert
c1c8e2968f
Move operation to after user population 2023-10-30 15:46:09 +09:00
Dean Herbert
96dd7b3333
Update the last played date of a beatmap when importing a replay by the local user 2023-10-30 15:44:16 +09:00
Dean Herbert
a91b704d21
Fix some new nullable inspections 2023-10-30 15:10:10 +09:00
Dean Herbert
a8c3f59845
Clean up type display for web requests in logs 2023-10-30 15:07:35 +09:00
Dean Herbert
d90f29a5ff
Improve log output surrounding score submission 2023-10-30 15:07:26 +09:00
Salman Ahmed
c7bc8e6865 Move behaviour to settings search text box only 2023-10-30 06:41:01 +03:00
Salman Ahmed
2b24167c47
Merge branch 'master' into fix-user-profile-support-banners 2023-10-30 06:20:59 +03:00
Salman Ahmed
984c30ded6 Load each tournament banner as soon as it is loaded 2023-10-30 06:20:15 +03:00
Salman Ahmed
af10dbb76c Add test case with many tournament banners 2023-10-30 06:20:01 +03:00
Dean Herbert
5ab20f5db7
Merge pull request #25294 from Frederisk/patch-1 2023-10-30 01:01:33 +09:00
Rowe Wilson Frederisk Holme
204ebfade7
Small update to README of Templates 2023-10-29 21:25:15 +08:00
Salman Ahmed
922ad80cfc Update user profile overlay to show more than one tournament banner 2023-10-29 01:50:07 +03:00
Salman Ahmed
ec9ae12bbd Update API response model to accept array of tournament banners 2023-10-29 01:43:49 +03:00
Salman Ahmed
31c6973bb6 Add test coverage 2023-10-29 01:03:45 +03:00
Salman Ahmed
d877536dc0 Select all text content in SearchTextBox on focus 2023-10-29 01:03:38 +03:00
Dean Herbert
bb2da97096
Merge pull request #25279 from frenzibyte/tournament-date-text-box-invariant-culture
Change tournament date text box parsing to use invariant culture info
2023-10-29 00:03:00 +09:00
Salman Ahmed
c38c8e933a Change tournament date text box parsing to use invariant culture info 2023-10-28 16:52:34 +03:00
Susko3
366e41f111 Use local workaround instead of disabling clipboard entirely 2023-10-28 12:23:23 +02:00
Susko3
cfc0520481 Add failing test 2023-10-28 12:13:13 +02:00
Salman Ahmed
e76a5f9419 Fix failing tests 2023-10-28 10:18:15 +03:00
Salman Ahmed
7083c04c59 Refactor logic slightly to display team seed everywhere
This change makes the team seed display in "team intro" screen as well.
2023-10-28 09:27:15 +03:00
Salman Ahmed
81c1634d44 Display team seeds in map pool screen as well 2023-10-28 08:42:40 +03:00
Salman Ahmed
4371a1ab57 Move team seed setting from gameplay screen 2023-10-28 08:42:29 +03:00
Salman Ahmed
832e30c31a Adjust horizontal padding in tournament sprite text 2023-10-28 08:30:59 +03:00
Salman Ahmed
e2788a22b1 Add setting to configure team seed display 2023-10-28 08:30:33 +03:00
Salman Ahmed
28e331deed Support displaying team seed in TeamDisplay 2023-10-28 08:30:24 +03:00
Salman Ahmed
c5ff708c6f
Merge pull request #25267 from bdach/legacy-font-fixed-width
Fix legacy sprite texts not matching stable with respect to fixed width
2023-10-28 07:32:15 +03:00
Salman Ahmed
a53c0adae0 Remove unused using directive 2023-10-28 06:56:12 +03:00
Salman Ahmed
51b7c97cab Fix TestScenePlayerMaxDimensions bottlenecking CI 2023-10-28 06:07:49 +03:00