Dean Herbert
2a8bd8d968
Fix failing tests due to missing DI pieces
2024-06-12 11:23:56 +08:00
OliBomby
869cd40195
Fixed samples without additions contributing to common addition bank while not having an editable addition bank
2024-06-11 21:31:18 +02:00
OliBomby
12dd60736a
remove code already covered by updatePrimaryBankState
2024-06-11 21:20:42 +02:00
Bartłomiej Dach
fb99daea2a
Merge pull request #28443 from ColdVolcano/shorten-accuracy
...
Fix Argon accuracy counter layout when under 10% and wireframe off
2024-06-11 14:57:59 +02:00
Bartłomiej Dach
e67d73be7d
Add test coverage
2024-06-11 12:28:39 +02:00
Bartłomiej Dach
922837dd3a
Reload scrolling composer on control point changes
2024-06-11 12:01:35 +02:00
Bartłomiej Dach
da53a11d3c
Attempt full editor reload on key count change
2024-06-11 11:31:49 +02:00
Bartłomiej Dach
3afe98612c
Add RestoreState() to IEditorChangeHandler
2024-06-11 11:31:30 +02:00
Bartłomiej Dach
10af642342
Split mania difficulty section implementation off completely from base
...
- "Circle size" / key count needs completely different handling.
- Approach rate does not exist in mania.
2024-06-11 11:30:20 +02:00
Dean Herbert
c640fbbaf0
Merge branch 'master' into daily-challenge/new-screen
2024-06-11 18:24:31 +09:00
ColdVolcano
4048a4bdfb
fix accuracy counter separating whole and fraction parts with wireframes off
2024-06-11 02:20:14 -06:00
Bartłomiej Dach
694cfd0e25
Expose singular coarse-grained change event on ControlPointInfo
2024-06-11 09:16:45 +02:00
Bartłomiej Dach
b8e0704554
Implement singular change events for ControlPoint
2024-06-11 09:15:45 +02:00
Dean Herbert
cd3b455341
Merge pull request #28420 from bdach/mutually-exclusive-save-related-actions
...
Disallow running save-related operations concurrently
2024-06-11 01:03:47 +09:00
Bartłomiej Dach
25b2dfa601
Fix stack leniency not applying immediately after change
2024-06-10 14:34:22 +02:00
Bartłomiej Dach
073ddcebe4
Hide daily challenge from playlists listing
2024-06-10 13:12:21 +02:00
Bartłomiej Dach
2321e408cb
Add test scene for daily challenge screen
2024-06-10 13:12:20 +02:00
Bartłomiej Dach
e6da17d248
Add minimal viable variant of new daily challenge screen
2024-06-10 13:09:12 +02:00
Bartłomiej Dach
ffd788c65c
Use room mod select overlay rely on explicit binding rather than DI resolution
2024-06-10 12:45:51 +02:00
Bartłomiej Dach
dd6e9308b3
Extract user mod select button for reuse
2024-06-10 12:45:27 +02:00
Bartłomiej Dach
f135a9a923
Make SelectedItem externally mutable
...
Not being able to externally mutate this was making reuse in new daily
challenge screen unnecessarily arduous.
2024-06-10 12:44:38 +02:00
Bartłomiej Dach
d80f09e0c0
Adjust online play header to be reusable for new daily challenge screen
2024-06-10 12:43:58 +02:00
Bartłomiej Dach
19f39ca1b6
Extract OnlinePlayScreenWaveContainer from OnlinePlayScreen
2024-06-10 12:42:37 +02:00
Bartłomiej Dach
7d5dc750e5
Use slightly lighter shade of pink for alternative colour
2024-06-10 12:04:52 +02:00
Bartłomiej Dach
0efa028e0a
Restructure popover updates to be more centralised
2024-06-10 11:55:51 +02:00
Bartłomiej Dach
acf4dbb62c
Merge branch 'master' into mutually-exclusive-save-related-actions
2024-06-10 10:30:35 +02:00
Bartłomiej Dach
1d6b7e9c9b
Refactor further to address code quality complaints
2024-06-10 10:30:30 +02:00
Dean Herbert
a8a2e543d5
Merge pull request #28436 from omkelderman/fix-auto-pick-map-on-zero-ban-round
...
Fix auto picking maps on zero ban rounds
2024-06-10 13:51:41 +09:00
Olle Kelderman
642095b07b
On the mappool screen the auto-pick map logic on map change still assumed 1 ban per team. Now it listens to the BanCount value from the round
2024-06-09 21:42:37 +02:00
Dean Herbert
be48377c4c
Merge pull request #28185 from frenzibyte/footer-v2-become-global
...
Move new screen footer to `OsuGame` and add temporary `SongSelectV2` screen
2024-06-09 19:06:38 +09:00
Salman Ahmed
6201220994
Merge branch 'master' into footer-v2-become-global
2024-06-08 14:13:05 +03:00
Dean Herbert
daf85c320a
Merge pull request #22237 from mk56-spn/LeaderBoardScore_clean
...
New leaderboard score card design implementation
2024-06-08 20:06:17 +09:00
Dean Herbert
7fc6ad5340
Merge pull request #28184 from frenzibyte/footer-v2-transitions
...
Add basic animation to new footer and buttons
2024-06-08 19:43:23 +09:00
Salman Ahmed
5f8f6caedd
Use OsuGame.SHEAR
2024-06-07 22:45:22 +03:00
Salman Ahmed
6f729be573
Merge branch 'master' into LeaderBoardScore_clean
2024-06-07 22:42:49 +03:00
Salman Ahmed
f59d94bba4
Move transitions inside ScreenFooterButton and re-use Content from base implementation instead
...
The point is to apply the transitions against a container that's inside of `ScreenFooterButton`, because the `ScreenFooterButton` drawable's position is being controlled by the flow container it's contained within, and we cannot apply the transitions on it directly.
2024-06-07 22:07:39 +03:00
Dean Herbert
1045742321
Merge pull request #28421 from bdach/mania-editor-flip-controls
...
Implement flip operations in mania editor
2024-06-08 00:10:16 +09:00
Dean Herbert
030acb153a
Merge pull request #24475 from nanashi-1/add-rank-display
...
Add skinnable rank display
2024-06-07 18:33:27 +09:00
Dean Herbert
9c6e707f00
Adjust transitions
2024-06-07 17:04:16 +08:00
Dean Herbert
366ef64a2c
Apply NRT to UpdateableRank
2024-06-07 16:54:12 +08:00
Bartłomiej Dach
72890bb9ac
Add stable-like animation legacy rank display
...
Just substituting the sprite felt pretty terrible.
2024-06-07 09:56:10 +02:00
Bartłomiej Dach
199d31c0f4
Fix test not compiling
...
A little ugly but maybe it'll do...
2024-06-07 09:54:00 +02:00
Bartłomiej Dach
4cd1ccc4d4
Merge branch 'master' into add-rank-display
2024-06-07 09:33:03 +02:00
Bartłomiej Dach
f787a29f49
Add test coverage
2024-06-07 09:19:17 +02:00
Bartłomiej Dach
629e7652c0
Implement flip operations in mania editor
2024-06-07 09:01:41 +02:00
Bartłomiej Dach
e13e9abda9
Disallow running save-related operations concurrently
...
Closes https://github.com/ppy/osu/issues/25426 .
Different approach to prior ones, this just disables the relevant
actions when something related to save/export is going on. Still ends up
being convoluted because many things you wouldn't expect to touch save
do touch save, so it's not just a concern between export and save
specifically.
2024-06-07 08:13:51 +02:00
Bartłomiej Dach
a6d0cd56b0
Merge pull request #28399 from matheus-cesquim/total-playlist-duration-not-considering-altered-song-durations-from-speed-changing-mods-#28398
...
Fix playlist total time not considering rate adjust mods
2024-06-07 07:24:55 +02:00
Dean Herbert
7cbe93efc3
Refactor latest changes to avoid unnecessary call when mods not present
2024-06-07 10:37:27 +08:00
Xesquim
6e3bea938e
Instancing a Ruleset only when it's necessary to
2024-06-06 13:26:52 -03:00
Dean Herbert
dd3f4bcdab
Fix code quality and null handling
2024-06-07 00:01:50 +08:00
