Dean Herbert
655491ae2d
Fix potential null ref in ResultsScreen
2023-06-21 17:50:06 +09:00
Dean Herbert
1907beb0c9
Add FireAndForget to stray Task.Run
2023-06-21 17:48:55 +09:00
Dean Herbert
9ca772421d
Improve and combine logic that exists in two classes
2023-06-21 17:48:12 +09:00
Dean Herbert
4ff5275208
Make IGameplayClock optional in GameplaySampleTriggerSource to ease testing
2023-06-21 17:33:42 +09:00
Dean Herbert
cb0f642ad7
Change skin editor flow to always save on toggle
...
This also moves the beatmap skin disable toggle to on toggle, in line
with review feedback.
I've decided to always apply the disable, not just on the `Player`
screen. It should be assumed that if a user is in the skin editor they
are never going to need access to this anyway.
2023-06-21 16:14:47 +09:00
Dean Herbert
366dd96875
Use bindable lease instead of reimplementing the same thing locally
2023-06-21 16:09:54 +09:00
Liam DeVoe
6de7328fef
add test for comment when logging in and out
2023-06-21 02:17:51 -04:00
Liam DeVoe
dd4f271158
fix cancel test for new button layout
2023-06-21 02:15:02 -04:00
Liam DeVoe
cc764afe3e
use two separate buttons for posting / login
2023-06-21 00:58:43 -04:00
Liam DeVoe
8460873e61
move commitButton.Text update to appropriate method
2023-06-21 00:37:54 -04:00
Bartłomiej Dach
a7172e7469
Fix one remaining seek
2023-06-20 23:32:38 +02:00
Bartłomiej Dach
29697d4999
Fix taiko test scene failing due to missing gameplay clock dependency
...
`GameplayClock` is inscrutable.
`TestManualClock` is lifted from another test scene because of
`FramedBeatmapClock`'s intensely confusing tendency to not work if it is
given a non-adjustable `ManuelClock` instead.
2023-06-20 23:30:52 +02:00
Bartłomiej Dach
2f77675fe7
Fix errors in tests due to mismatching NRT annotations
2023-06-20 21:57:32 +02:00
Dean Herbert
cb07f2399f
Apply NRT to GameplaySampleTriggerSource
2023-06-20 21:03:55 +09:00
Dean Herbert
92e89c7df7
Update test expectations
2023-06-20 21:02:34 +09:00
Dean Herbert
04dad6c6e8
Use IGameplayClock to ensure our clock source is correct
2023-06-20 20:47:56 +09:00
Dean Herbert
0e86102681
Fix nested lookups
2023-06-20 20:45:02 +09:00
Dean Herbert
786d5a394b
Add back optimisation and increase time allowance slightly
2023-06-20 20:30:07 +09:00
Dean Herbert
555ce7684b
Adjust GameplaySampleTriggerSource to only switch samples when close enough to the next hit object
...
Closes #23963 .
To simplify things, I've removed the optimisation of using
`AliveObject`s because it would break the way this whole lookup works.
2023-06-20 20:06:07 +09:00
Dean Herbert
d7b486e2ac
Disable beatmap skinning when entering the skin editor
2023-06-20 19:18:17 +09:00
Dean Herbert
c815f8cd23
Merge pull request #23973 from peppy/update-framework
...
Update framework
2023-06-20 18:53:55 +09:00
Dean Herbert
2e02b4a85b
Apply more correct fix for double-playing menu track
2023-06-20 18:35:51 +09:00
Dean Herbert
0a81170bca
Merge branch 'master' into fix-intro-playing-twice
2023-06-20 18:34:22 +09:00
Dean Herbert
10ed3787a0
Don't show song select screen when local user doesn't have permission to add an item
2023-06-20 18:27:19 +09:00
Dean Herbert
dc1b4a39aa
Fix presenting beatmaps while in a multiplayer room not working
2023-06-20 18:23:59 +09:00
Dean Herbert
ff8350bac6
Update framework
2023-06-20 17:43:52 +09:00
Dean Herbert
7b69b92eab
Allow notifications while the game is paused (or in break time)
...
RFC. This is to allow notifications to show at the pause screen
(specifically for #23967 , where exports are now happening).
Not sure about the break time part of this, but might be fine? The
toasts are immediately flushed before break time ends.
2023-06-20 16:57:35 +09:00
Dean Herbert
4bd121d3b8
Also add hotkey to export replays
2023-06-20 16:54:37 +09:00
Dean Herbert
7c5813c05a
Fix OsuAnimatedButton not flashing when triggered via code
2023-06-20 16:34:22 +09:00
Dean Herbert
1e0e29847f
Apply NRT and hotkey support to save replay button at results screen
2023-06-20 16:29:15 +09:00
Liam DeVoe
343052410b
update CommentEditor test components
2023-06-19 22:08:45 -04:00
Liam DeVoe
60eedbafd1
rename GetTextBoxPlaceholder to GetPlaceholderText
2023-06-19 22:05:18 -04:00
Liam DeVoe
f7dde53f9b
use runOnceImmediately instead of duplicating logic
2023-06-19 18:20:16 -04:00
Liam DeVoe
591277e0f9
extract button text properties to methods, show login overlay on click
2023-06-19 18:10:37 -04:00
Liam DeVoe
d5d494f07b
resolve protected API in comments superclass
2023-06-19 17:36:40 -04:00
Liam DeVoe
4a9543092a
disable posting comments when logged out
2023-06-19 17:08:04 -04:00
Bartłomiej Dach
c467e6ba1f
Merge pull request #23969 from Joehuu/fix-beatmap-info-bpm
...
Fix beatmap info not showing individual difficulty bpm
2023-06-19 22:57:17 +02:00
Bartłomiej Dach
a600eb5f36
Merge pull request #23938 from peppy/fix-distance-snap-grid-centering
...
Fix distance snap grid circles not correctly being centred on snap point
2023-06-19 21:36:33 +02:00
Joseph Madamba
362fe62b4b
Fix beatmap info not showing individual difficulty bpm
2023-06-19 11:05:29 -07:00
Bartłomiej Dach
ecc5915ab3
Merge branch 'master' into fix-distance-snap-grid-centering
2023-06-19 18:45:06 +02:00
Bartłomiej Dach
9bcd86d66d
Fix test failure due to relying on implementation detail
2023-06-19 18:42:30 +02:00
Bartłomiej Dach
2d8a74d776
Merge pull request #23520 from jtbiddle/snap-colour-mod
...
Add "Synesthesia" mod for osu! ruleset
2023-06-19 18:31:58 +02:00
Bartłomiej Dach
6d32206a08
Fix slider tails receiving wrong colours
...
Only visually apparent on legacy skins.
2023-06-19 17:47:01 +02:00
Dan Balasescu
bfa449e47a
Adjust attribute data
2023-06-19 21:38:13 +09:00
Dean Herbert
69526f25bb
Add hotkey to save replay
...
Defaults to `F2` aka stable.
2023-06-19 20:45:29 +09:00
Dean Herbert
84fc6e92db
Fix slightly incorrect calculations
2023-06-19 20:23:46 +09:00
Dean Herbert
4314f9f46a
Merge branch 'master' into fix-distance-snap-grid-centering
2023-06-19 20:22:09 +09:00
Dean Herbert
0900cebc0d
Avoid doing expensive colour fetch operation every update
2023-06-19 20:12:17 +09:00
Dean Herbert
aa96fefae2
Merge branch 'master' into snap-colour-mod
2023-06-19 20:01:36 +09:00
Dean Herbert
f8b94ed033
Merge pull request #23414 from Cootz/add-mod-search-option
...
Add mod search
2023-06-19 02:07:00 +09:00
