69771 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Bartłomiej Dach	8cec318c1f	Loop track even if shuffling if there is only one available ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2024-10-14 15:28:32 +02:00
Bartłomiej Dach	17aed26f85	Fix shuffle not actually changing the track sometimes ... See https://github.com/ppy/osu/pull/30215#issuecomment-2407775408 for context. Turns out the test failures were more correct than I'd thought. The long-and-short of it is that both in "pure random" mode and in "permutation" mode, when running out of track history to fall back on, it was possible for the random algorithm to pick the same song twice in a row - which is probably not desired, and which this explicit exclude should make impossible.	2024-10-14 13:18:45 +02:00
Bartłomiej Dach	639eb7ae4a	Merge pull request #30274 from shinmorisawa/master ... Respect "Prefer metadata in original language" toggle in beatmap deletion dialog	2024-10-14 12:02:03 +02:00
Shin Morisawa	8ff86d560f	Merge branch 'master' into master	2024-10-14 17:48:04 +09:00
Bartłomiej Dach	120eb9adea	Merge pull request #30261 from peppy/faster-quick-retry ... Decrease the time it takes to quick retry by ~650 ms	2024-10-14 10:24:35 +02:00
Shin Morisawa	0664b185c3	Merge branch 'master' into master	2024-10-14 16:46:44 +09:00
Bartłomiej Dach	74675c8c78	Merge pull request #30080 from OliBomby/clamp-scale2 ... Clamp scale with lower and upper bounds	2024-10-14 08:17:22 +02:00
Shin Morisawa	90a08b8a68	Fix Beatmap Delete Dialog	2024-10-14 09:55:28 +09:00
Dean Herbert	f8bce706fa	Merge pull request #30239 from rozukke/reset-offsets ... Add functionality to mass reset offsets	2024-10-14 01:56:14 +09:00
Dean Herbert	53671ad11e	Only update beatmaps which actually had offsets ... Without this every beatmap gets a write and it reloads the whole of song select, basically.	2024-10-14 00:35:18 +09:00
Dean Herbert	868a7db9e9	Start preparing player earlier when quick retrying ... Should help with https://github.com/ppy/osu/issues/9039.	2024-10-13 22:29:00 +09:00
Dan Balasescu	9681e3ac46	Overwrite downloaded data packages ... In https://github.com/ppy/osu/actions/runs/11311858931/job/31458581002, I cancelled the run during the download from `data.ppy.sh`. In https://github.com/ppy/osu/actions/runs/11313128285/job/31461534857, `wget` skipped downloading the file due to the `-nc` option (no-clobber), i.e.: if the file exists, don't re-download. The only way I'm aware of to resolve this with wget is to either use `-c` (continue), which may lead to broken files, or to explicitly specify the output file via `-O`. Thought I'd clean up a few pieces in the process. Why not curl? Mostly historical - some distros don't come with curl. It may be okay now but there's probably no point changing this at the moment...	2024-10-13 18:43:02 +09:00
Dan Balasescu	9abca53829	Merge pull request #30246 from Joehuu/recommend-csdevkit-instead ... Recommend C# Dev Kit extension on VSCode	2024-10-13 15:02:03 +09:00
Joseph Madamba	e1e8e39a89	Recommend C# Dev Kit extension on VSCode	2024-10-12 12:12:40 -07:00
Artemis Rosman	e4f9c861ba	Add functionality to mass reset offsets	2024-10-13 00:50:45 +11:00
Dan Balasescu	2de1955892	Merge pull request #30218 from bdach/daily-challenge-conclusion-offline ... Do not show daily challenge conclusion notification on disconnection	2024-10-12 18:14:22 +09:00
Dean Herbert	3a8ed889b5	Merge pull request #30215 from bdach/fix-music-controller ... Fix track restarting when trying to switch track change direction with shuffle active	2024-10-12 01:41:44 +09:00
Bartłomiej Dach	5db1f05953	Merge branch 'master' into clamp-scale2	2024-10-11 15:13:54 +02:00
Bartłomiej Dach	d1da1d4079	Rename methods to fit new changes better	2024-10-11 15:03:30 +02:00
Bartłomiej Dach	07d15cc35a	Add positive assertion for conclusion notification being present too	2024-10-11 14:31:30 +02:00
Bartłomiej Dach	968835bb44	Do not show daily challenge conclusion notification on disconnection ... Closes https://github.com/ppy/osu/issues/30194.	2024-10-11 14:18:19 +02:00
Bartłomiej Dach	9d1eb842a7	Add failing test	2024-10-11 14:16:24 +02:00
Bartłomiej Dach	4a16341a94	Fix crash when switching tracks back and forth with shuffle on	2024-10-11 12:45:14 +02:00
Bartłomiej Dach	1a25e9d179	Add another failing test case for crash	2024-10-11 12:45:03 +02:00
Bartłomiej Dach	47cb696b69	Fix switching direction when changing tracks with shuffle on restarting the same track ... Closes https://github.com/ppy/osu/issues/30190.	2024-10-11 12:40:45 +02:00
Bartłomiej Dach	0882f1bb70	Add failing test case	2024-10-11 12:33:43 +02:00
Dan Balasescu	616c2aeefc	Merge pull request #30206 from minetoblend/fix/selection-box-buttons-stuck ... Fix SelectionBox buttons freezing when button is triggered via key event	2024-10-11 12:02:58 +09:00
Marvin Schürz	af55585dc8	Make TriggerAction public	2024-10-10 20:50:47 +02:00
Marvin Schürz	fc7ad96fcd	Move circle flash to TriggerAction	2024-10-10 20:20:02 +02:00
Marvin Schürz	9cc6ee2ebc	Fix SelectionBox buttons freezing when button is triggered via key event	2024-10-10 20:14:11 +02:00
Dan Balasescu	c545269eec	Merge pull request #30198 from bdach/thank-you-discord-once-more ... Fix discord RPC complaining yet again if given a single space character as activity state / details	2024-10-11 01:15:56 +09:00
Dean Herbert	14ecd56913	Merge pull request #30195 from bdach/advanced-stats-stupid-shenanigans ... Fix crashes when attempting to change from a custom ruleset with mods selected to another	2024-10-11 00:57:28 +09:00
Dan Balasescu	245d05a2e2	Merge pull request #30199 from bdach/no-song-progress-tooltip-during-gameplay ... Fix argon song progress bar tooltip showing during active gameplay	2024-10-11 00:03:27 +09:00
Bartłomiej Dach	938c3d78ce	Fix argon song progress bar tooltip showing during active gameplay ... Closes https://github.com/ppy/osu/issues/30197. Pretty bad one, might be worth a hotfix...	2024-10-10 14:36:28 +02:00
Bartłomiej Dach	687bdad389	Remove no-longer-required cache-over hack ... This is now removable after `AdvancedStats` has been weaned off the global mods bindable. I think this is a win all things considered?	2024-10-10 14:22:20 +02:00
Bartłomiej Dach	f1842d781e	Decouple AdvancedStats from global mods ... Closes https://github.com/ppy/osu/issues/30163. If I'm to be blunt, the decoupled stuff in song select makes my head spin. I spent a solid 20 minutes thinking how I was going to fix this one but then finally realised that generally most of the cause there was the fact that `AdvancedStats` was seeing the new rulesets *before* the "ensure global selected mods are valid for current ruleset" logic, and so decided to just _delay_ that until the decoupled transfer thingamajig happens. I was honestly considering combining `BeatmapInfo`, `Ruleset`, and `Mods` into one property on `AdvancedStats`. I figured I'd rather not push my luck and try the baseline version first, but I honestly think that direction is going to be required at some point to properly corral all of the decoupled madness taking place in song select.	2024-10-10 14:22:16 +02:00
Bartłomiej Dach	a7fcfd5f0d	Fix discord RPC complaining yet again if given a single space character as activity state / details ... Closes https://github.com/ppy/osu/issues/30178. Really, discord?	2024-10-10 13:59:18 +02:00
Bartłomiej Dach	cab97a96ab	Merge pull request #30189 from OliBomby/fix-splittable ... Fix split control point context menu option not showing up on newly created control points	2024-10-10 11:37:24 +02:00
OliBomby	9936ec579f	Fix isSplittable depending on unreliable order of path control point pieces	2024-10-09 23:31:12 +02:00
Dean Herbert	a6f56036a2	Merge pull request #30164 from bdach/am-i-fired-this-time ... Fix game deadlocking on startup when set to single thread mode	2024-10-09 19:55:01 +09:00
Bartłomiej Dach	baa64d1486	Migrate MusicController to Live<T> to fix broken migrations instead	2024-10-09 11:59:04 +02:00
Bartłomiej Dach	081d87fe6d	Revert 'Fix any and all migration attempts dying on MusicController' ... This reverts commit 310eec69fc. Way to try and "fix" stuff and screw stuff up even harder instead, me. Great job, well done.	2024-10-09 11:55:59 +02:00
Dean Herbert	270c4c4f12	Merge pull request #30151 from bdach/migration-is-completely-fucked ... Fix several breakages with migration operation	2024-10-09 14:24:34 +09:00
Dean Herbert	d836dba982	Rename and xmldoc RealmResetEmptySet	2024-10-09 14:18:34 +09:00
Dean Herbert	48dacd1c15	Remove unused property	2024-10-09 13:45:35 +09:00
Dean Herbert	7ccb770009	Update framework	2024-10-09 12:36:51 +09:00
Dean Herbert	68ebf64b2d	Fix dependabot line endings	2024-10-09 12:36:44 +09:00
Dean Herbert	4a84c6e778	Merge pull request #30153 from ppy/dependabot/nuget/osu.Desktop/System.IO.Packaging-8.0.1 ... Bump System.IO.Packaging from 8.0.0 to 8.0.1 in /osu.Desktop	2024-10-09 12:13:56 +09:00
dependabot[bot]	6a754222e4	Bump System.IO.Packaging from 8.0.0 to 8.0.1 in /osu.Desktop ... Bumps [System.IO.Packaging](https://github.com/dotnet/runtime) from 8.0.0 to 8.0.1. - [Release notes](https://github.com/dotnet/runtime/releases) - [Commits](https://github.com/dotnet/runtime/compare/v8.0.0...v8.0.1) --- updated-dependencies: - dependency-name: System.IO.Packaging dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>	2024-10-09 01:30:23 +00:00
Bartłomiej Dach	b811b9baf6	Fix DetachedBeatmapStore special condition for detecting resets from blocking all operations failing on empty databases ... See https://discord.com/channels/188630481301012481/188630652340404224/1293309912591368244.	2024-10-08 23:16:17 +02:00