Salman Ahmed
8c92bb0595
Remove unused using directive
2024-03-08 23:09:16 +03:00
Salman Ahmed
1942d46a38
Remove leftover debugging code
2024-03-08 22:37:27 +03:00
Salman Ahmed
6861d9a302
Expose storyboard command lists as read-only and remove unnecessary memory footprint
...
Mutation should be done only with the methods exposed by `StoryboardCommandGroup`.
2024-03-08 22:29:49 +03:00
Salman Ahmed
0efa12a86a
Fix parameter commands applying initial value before start time
2024-03-08 21:56:25 +03:00
Salman Ahmed
c1649b76d6
Reorder command properties to match general format
...
I had them shuffled around in the middle of the refactor.
2024-03-08 21:33:53 +03:00
Salman Ahmed
a85be2a46d
Fix merge conflicts
2024-03-08 20:22:26 +03:00
Salman Ahmed
8d3e502262
Merge branch 'master' into storyboard-loops-v2
2024-03-08 20:22:19 +03:00
Dean Herbert
5d40fdca86
Merge pull request #27533 from bdach/fix-flashlight-gaps
...
Fix 1px flashlight gaps when gameplay scaling mode is active
2024-03-08 22:55:18 +08:00
Dean Herbert
46e5bda40c
Fix test failures
2024-03-08 19:02:12 +08:00
Bartłomiej Dach
44d0dc6113
Fix 1px flashlight gaps when gameplay scaling mode is active
...
Closes https://github.com/ppy/osu/issues/27522 .
Concerns mostly taiko and catch.
Not much of a proper fix rather than a workaround but it is what it is.
I tried a few other things, including setting `MaskingSmoothness = 0` on
the scaling container itself, to no avail.
2024-03-08 11:07:30 +01:00
Bartłomiej Dach
e18bbc9509
Merge pull request #27529 from peppy/fix-slider-repeat-visuals
...
Fix cross-talk between pooled `DrawableSliderRepeat` usage causing incorrect rotation
2024-03-08 09:21:34 +01:00
Dean Herbert
c9b4c684e5
Merge pull request #27403 from Gabixel/increase-modselect-initial-scroll
...
Change initial scroll effect to mod columns
2024-03-08 14:00:40 +08:00
Dean Herbert
5e7d9ea04a
Adjust scroll speed back to original
2024-03-08 13:59:04 +08:00
Dean Herbert
fcc35a6acc
Fix cross-talk between pooled DrawableSliderRepeat usage causing incorrect rotation
2024-03-08 11:37:13 +08:00
Dean Herbert
6323189cfb
Merge pull request #27498 from frenzibyte/argon-pp-counter
...
Add "Argon" performance points counter
2024-03-08 11:16:10 +08:00
Dean Herbert
d9cc619693
Merge branch 'master' into argon-pp-counter
2024-03-08 10:32:16 +08:00
Dean Herbert
9286398633
Move naming migrations to more correct place
2024-03-08 10:26:08 +08:00
Dean Herbert
0ebb12f67f
Move skinnable interface specification to non-abstract classes
2024-03-08 10:23:46 +08:00
Dean Herbert
ae2ef8ee1e
Fix typo in wireframe description
2024-03-08 10:19:00 +08:00
Dean Herbert
f2753ef7a2
Decrease size of pp display relative to accuracy
2024-03-08 09:41:38 +08:00
Dean Herbert
87b4406bdc
Pad at minimum three digits for argon pp display
2024-03-08 09:41:28 +08:00
Salman Ahmed
79da6d8613
Fix refactor error on EndTimeForDisplay
...
Not sure when this happened >.>
2024-03-08 03:08:03 +03:00
Salman Ahmed
fa9b2f0cd5
Add generics to ApplyInitialValue/ApplyTransforms for ability to return custom transform sequences
...
*sigh*
2024-03-08 03:07:39 +03:00
Salman Ahmed
b450abb687
Support applying initial values of storyboard commands
2024-03-08 02:02:48 +03:00
Salman Ahmed
2ca36254f4
Fix comparison interface not implemented on storyboard command classes
2024-03-08 02:02:25 +03:00
Salman Ahmed
3755dd059a
Calculate loop delays at point of transform application
2024-03-08 02:01:02 +03:00
Salman Ahmed
87b065b8c3
Fix incorrect start time calculations
...
`LoopStartTime` is now baked into each `IStoryboardCommand`.
2024-03-08 02:01:02 +03:00
Salman Ahmed
6c257e5159
Fix HasCommands property not set at all
2024-03-08 01:59:44 +03:00
Salman Ahmed
9b77d8c972
Fix group start/end time not calculating correctly
2024-03-08 01:59:28 +03:00
Salman Ahmed
585ab59768
Apply major refactor to the storyboard commands flow structrure
2024-03-08 01:10:09 +03:00
Dean Herbert
646edb239a
Merge pull request #27429 from bdach/rewind-slider-tracking
...
Fix slider tracking state not restoring correctly in all cases on rewind
2024-03-07 22:41:12 +08:00
Dean Herbert
f7d470ce33
Merge pull request #27520 from smoogipoo/missing-event-unbind
...
Fix missing event unbinds
2024-03-07 21:54:58 +08:00
Dan Balasescu
ca92a31cf9
Fix missing event unbinds
2024-03-07 21:10:11 +09:00
Bartłomiej Dach
fba44e67a0
Merge pull request #27214 from Givikap120/freemod_mapinfo_fix
...
Fix mod selection in online-play rooms not accounting for mods of selected item
2024-03-07 12:45:14 +01:00
Bartłomiej Dach
3d8fdc52a4
Merge pull request #27501 from turbedi/throw_helper
...
Use ThrowHelper methods in more places
2024-03-07 11:36:21 +01:00
Bartłomiej Dach
e99030c515
Merge pull request #27516 from frenzibyte/editor-screen-selector
...
Change editor screen switcher control design and behaviour to act like a button
2024-03-07 11:04:18 +01:00
Bartłomiej Dach
74e3c47c2f
Merge pull request #27517 from Joehuu/fix-failed-s-accuracy-circle
...
Fix results screen accuracy circle not showing correctly for failed S with no flair
2024-03-07 10:46:24 +01:00
Bartłomiej Dach
039520d55d
Use slightly nicer parameterisation in test
2024-03-07 09:49:20 +01:00
Bartłomiej Dach
64dc3d728e
Merge pull request #27453 from frenzibyte/mania-key-gaps
...
Fix osu!mania key images potentially showing gaps between columns
2024-03-07 09:32:50 +01:00
Bartłomiej Dach
644553d5b4
Merge branch 'master' into freemod_mapinfo_fix
2024-03-07 09:24:44 +01:00
Joseph Madamba
c36232bc02
Fix results screen accuracy circle not showing correctly for failed S with no flair
2024-03-07 00:10:30 -08:00
Joseph Madamba
56caf19350
Add visual test for failed S display
2024-03-07 00:10:30 -08:00
Dan Balasescu
e0fe33a7a7
Merge pull request #27513 from bdach/osu-score-conversion-bad-very-not-good
...
Fix osu! standardised score estimation algorithm violating basic invariants
2024-03-07 17:05:32 +09:00
Salman Ahmed
0fe139a189
Adjust editor screen switcher control design and behaviour
2024-03-07 08:20:46 +03:00
Salman Ahmed
336a6180e5
Expose TRANSITION_LENGTH from tab control
2024-03-07 08:20:20 +03:00
Bartłomiej Dach
aa3cd402ca
Fix broken english
2024-03-06 21:30:31 +01:00
Bartłomiej Dach
3121cf81e6
Bump score version
2024-03-06 21:30:09 +01:00
Salman Ahmed
672f645cba
Clamp only on horizontal sides
2024-03-06 18:40:20 +03:00
Dean Herbert
0881e7c8c1
Merge pull request #27454 from EVAST9919/sb-lifetime-improvements
...
Improve storyboard performance by better handling sprites lifetime
2024-03-06 20:23:22 +08:00
Dean Herbert
13f7480d79
Merge branch 'master' into sb-lifetime-improvements
2024-03-06 19:27:40 +08:00
