h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-02 07:25:05 +08:00
Code Issues Releases Wiki Activity
65,470 Commits 4 Branches 672 Tags 376 MiB
8c107b4925
Commit Graph

65470 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Dan Balasescu
8c107b4925
Merge pull request #26950 from bdach/2fa-in-registration 
Add 2FA verification screen to registration flow
 2024-02-02 17:30:20 +09:00
Dan Balasescu
108375975d
Merge pull request #26940 from EVAST9919/playfield-mods-alloc 
Reduce allocation overhead in `Playfield`
 2024-02-02 15:45:46 +09:00
Bartłomiej Dach
091618db1a
Add test coverage of full account creation flow 2024-02-02 07:25:07 +01:00
Bartłomiej Dach
a00cf87925
Add 2FA verification screen to registration flow 2024-02-02 07:25:04 +01:00
Bartłomiej Dach
45f60b035e
Enable NRT in AccountCreationOverlay 2024-02-02 07:24:32 +01:00
Bartłomiej Dach
93d34e4115
Enable NRT in ScreenWarning 2024-02-02 07:24:32 +01:00
Bartłomiej Dach
b58ac7950b
Make game dependency in ScreenEntry optional to unbreak tests 2024-02-02 07:24:32 +01:00
Bartłomiej Dach
bb6387bea0
Enable NRT in ScreenEntry 2024-02-02 07:24:32 +01:00
Bartłomiej Dach
5260b8cae0
Merge pull request #26920 from peppy/2fa-visibility 
Give better visibility when the game is pending 2FA
 2024-02-02 07:10:45 +01:00
Bartłomiej Dach
2ff46daf5e
Also change icon and tooltip text when pending 2FA 2024-02-02 06:40:56 +01:00
Andrei Zavatski
53c5483eba Reduce allocation in Playfield 2024-02-02 04:53:48 +03:00
Dean Herbert
bf3746daa8
Show login overlay at main menu when 2FA is required 2024-02-01 21:10:53 +09:00
Dean Herbert
563f4a26b1
Show "failing" icon on user panel when 2FA prompt is present 
This gives the user a chance to know it's required.
 2024-02-01 21:10:37 +09:00
Dean Herbert
7cdedfb6ca
Merge pull request #26889 from peppy/remove-cachebust-online-image 
Fix menu banner not updating as often as we want it to
 2024-01-31 22:44:39 +09:00
Dean Herbert
4248593289
Fix menu banner not updating as often as we want it to 2024-01-31 22:44:24 +09:00
Dean Herbert
89a5be13e2
Merge pull request #26885 from bdach/slider-end-flip-fail 
Fix slider end judgements appearing at incorrect locations when mods that flip playfield are active
 2024-01-31 22:39:37 +09:00
Bartłomiej Dach
dfea2ade6d
Revert incorrect end position optimisation 
Closes https://github.com/ppy/osu/issues/26867.

Reverts 882f490390
and ce643aa68f.

The applied optimisation may have been valid as long as it was
constrained to `Slider`. But it is not, as `SliderTailCircle` stores a
local copy of the object position. And as the commit message of
ce643aa68f states, this could be bypassed
by some pretty hacky delegation from `SliderTailCircle.Position` to the
slider, but it'd also be pretty hacky because it would make flows like
`PositionBindable` break down.

Long-term solution is to probably remove bindables from hitobjects.
 2024-01-31 12:45:42 +01:00
Bartłomiej Dach
a934556bb8
Add failing assertions for head/tail positions after flip 2024-01-31 12:40:03 +01:00
Bartłomiej Dach
f927cb5928
Increase repeat count for better coverage of flip operations 2024-01-31 12:39:48 +01:00
Dean Herbert
56700d672b
Merge pull request #26837 from bdach/2fa-not-verifying-via-link 
Fix 2FA verification via link not working correctly
 2024-01-31 19:15:33 +09:00
Bartłomiej Dach
e7cfbd3c56
Merge pull request #26876 from peppy/slider-miss-last-longer 
Adjust slider tick / end misses to show slightly longer
 2024-01-31 10:43:58 +01:00
Dean Herbert
19fe3a15f3
Merge branch 'master' into 2fa-not-verifying-via-link 2024-01-31 18:32:55 +09:00
Dean Herbert
edab05672b
Merge pull request #26834 from bdach/2fa-cancel-crash 
Fix crash when logging out during 2FA email verification
 2024-01-31 18:32:33 +09:00
Dean Herbert
fbc923b47e
Revert "Merge pull request #26870 from smoogipoo/adjust-default-minresult" 
This reverts commit 1acff746ee, reversing
changes made to 696ecda398.
 2024-01-31 17:51:38 +09:00
Dean Herbert
1acff746ee
Merge pull request #26870 from smoogipoo/adjust-default-minresult 
Adjust default min result of SliderTailHit, remove override
 2024-01-31 17:49:58 +09:00
Dean Herbert
ebf637bd3c
Adjust slider tick / end misses to show slightly longer 2024-01-31 17:41:26 +09:00
Dean Herbert
696ecda398
Merge pull request #26871 from peppy/show-better-expired-message 
Show a better message when score submission fails due to system clock being set wrong
 2024-01-31 17:32:18 +09:00
Dean Herbert
a7f9f50ce5
Show a better message when score submission fails due to system clock being set wrong 2024-01-31 16:52:50 +09:00
Dean Herbert
3f527081bd
Update framework 2024-01-31 16:12:46 +09:00
Dan Balasescu
9b1bbe5f48
Adjust default min result of SliderTailHit, remove override 2024-01-31 16:12:05 +09:00
Dean Herbert
012039ff90
Merge pull request #26839 from bdach/fix-judgement-fade 2024-01-31 09:14:05 +09:00
Bartłomiej Dach
c5e118bd10
Revert "Move fade more local to avoid fading twice" 
This reverts commit d0421fe206
and fixes https://github.com/ppy/osu/issues/26801.

https://github.com/ppy/osu/pull/26703#discussion_r1469409667
was correct in saying that the early fade-out needs to be restored, and
that's because of the early-return. Legacy judgements that are the
temporary displayed judgement from new piece should also receive the
fade-out, and d0421fe206 broke that.
 2024-01-30 22:16:46 +01:00
Bartłomiej Dach
4126dcbe28
Fix 2FA verification via link not working correctly 
Closes https://github.com/ppy/osu/issues/26835.

I must have not re-tested this correctly after all the refactors...

Basically the issue is that the websocket connection would only come
online when the API state changed to full `Online`. In particular
the connector would not attempt to connect when the API state was
`RequiresSecondFactorAuth`, giving the link-based flow no chance to
actually work.

The change in `WebSocketNotificationsClientConnector` is relevant in
that queueing requests does nothing before the API state changes to full
`Online`. It also cleans up things a bit code-wise so... win?

And yes, this means that the _other_ `PersistentEndpointClientConnector`
implementations (i.e. SignalR connectors) will also come online earlier
after this. Based on previous discussions
(https://github.com/ppy/osu/pull/25480#discussion_r1395566545) I think
this is fine, but if it is _not_ fine, then it can be fixed by exposing
a virtual that lets a connector to decide when to come alive, I guess.
 2024-01-30 21:49:06 +01:00
Bartłomiej Dach
000ddc14ac
Fix broken locking in OAuth 
Closes https://github.com/ppy/osu/issues/26824... I think?

Can be reproduced via something like

diff --git a/osu.Game/Online/API/OAuth.cs b/osu.Game/Online/API/OAuth.cs
index 485274f349..e6e93ab4c7 100644
--- a/osu.Game/Online/API/OAuth.cs
+++ b/osu.Game/Online/API/OAuth.cs
@@ -151,6 +151,11 @@ internal string RequestAccessToken()
         {
             if (!ensureAccessToken()) return null;

+            for (int i = 0; i < 10000; ++i)
+            {
+                _ = Token.Value.AccessToken;
+            }
+
             return Token.Value.AccessToken;
         }

The cause is `SecondFactorAuthForm` calling `Logout()`, which calls
`OAuth.Clear()`, _while_ the `APIAccess` connect loop is checking if
`authentication.HasValidAccessToken` is true, which happens to
internally check `Token.Value.AccessToken`, which the clearing of
tokens can brutally interrupt.
 2024-01-30 21:05:23 +01:00
Bartłomiej Dach
6931af664e
Add missing icon.png entry to nuspec 
This is only half of the deployment fix, the other half will be in
`osu-deploy` (making sure the icon is actually in the staging
directory).
 2024-01-30 12:05:31 +01:00
Bartłomiej Dach
26d3409fca
Merge pull request #26797 from peppy/update-endpoints 
Update endpoints to final production endpoints
 2024-01-30 11:12:25 +01:00
Dean Herbert
d895a91cd5
Update endpoints to final production endpoints 2024-01-30 18:40:17 +09:00
Bartłomiej Dach
f5e7697335
Merge pull request #26781 from frenzibyte/taiko-sv-v2 
Rewrite osu!taiko's time range computation logic to match 1:1 with stable
 2024-01-30 09:16:07 +01:00
Dean Herbert
99f4b2c113
Merge pull request #26788 from EVAST9919/scrolling-alloc 
Reduce allocation overhead in `ScrollingHitObjectContainer`
 2024-01-30 14:06:27 +09:00
Dean Herbert
fc8fdb578a
Merge pull request #26790 from EVAST9919/mania-columns-alloc 
Reduce allocation overhead in mania's `ColumnFlow`
 2024-01-30 12:51:38 +09:00
Andrei Zavatski
8e20eed4ef Don't use LINQ in ReceivePositionalInputAt 2024-01-30 03:19:27 +03:00
Andrei Zavatski
7dba870518 Rework Content storage in ColumnFlow 2024-01-30 03:07:37 +03:00
Andrei Zavatski
87f853fcd2 Reduce overhead in ScrollingHitObjectContainer 2024-01-30 00:59:31 +03:00
Dean Herbert
58bcef934b
Merge pull request #26785 from bdach/make-populate-maximum-statistics-public 2024-01-30 06:40:35 +09:00
Bartłomiej Dach
6888cda02c
Make LegacyScoreDecoder.PopulateMaximumStatistics() public 
For `osu-tools` consumption.
 2024-01-29 21:42:38 +01:00
Dean Herbert
b3919bff56
Merge pull request #26780 from bdach/fix-websocket-very-bad-not-good 
Fix incorrect handling of `StartChatRequest` in websocket chat client
 2024-01-30 05:11:55 +09:00
Bartłomiej Dach
39883cc102
Merge pull request #26773 from peppy/fix-song-select-osu-logo-position 
Fix osu! logo being mispositioned in song select on very wide resolutions
 2024-01-29 20:39:44 +01:00
Bartłomiej Dach
1fbc92ca7e
Merge branch 'master' into fix-song-select-osu-logo-position 2024-01-29 20:11:52 +01:00
Bartłomiej Dach
acc2614090
Apply alternative solution 
Fixes the logo flying out of the wrong corner when transitioning from
song select to gameplay.

Co-authored-by: Dean Herbert <pe@ppy.sh>
 2024-01-29 20:07:27 +01:00
Salman Ahmed
959cc7c7d9 Rewrite time range computation logic to be completely based on stable code 2024-01-29 21:26:36 +03:00