1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-17 20:02:58 +08:00
Commit Graph

66309 Commits

Author SHA1 Message Date
Salman Ahmed
c1db9d7819 Add test coverage 2024-02-23 18:16:44 +03:00
Bartłomiej Dach
869f0a82de
Use hashset for faster lookup 2024-02-23 15:38:52 +01:00
Salman Ahmed
fdc0636554 General code cleanup 2024-02-23 17:31:54 +03:00
Salman Ahmed
9ce07a96b2 Rewrite mods flow and remove RoomBeatmapAttributesDisplay 2024-02-23 17:30:13 +03:00
Salman Ahmed
323d7f8e2d Change BeatmapAttributesDisplay retrieval to proper method 2024-02-23 16:59:43 +03:00
Salman Ahmed
918577d530 Compute required mods list once per update 2024-02-23 16:53:41 +03:00
Bartłomiej Dach
f86b7f0702
Enable NRT in EditorBeatmapSkin 2024-02-23 14:52:44 +01:00
Salman Ahmed
f94cd4483c Avoid relying on game-wide ruleset bindable 2024-02-23 16:50:33 +03:00
Salman Ahmed
ae9c58be30 Remove "multiplayer" references from subclass and move to appropriate place 2024-02-23 16:50:33 +03:00
Bartłomiej Dach
d1d32fc16c
Fix editor displaying combo colours in effectively incorrect order
Addresses https://github.com/ppy/osu/discussions/27316.

Stable lies about the first combo colour being first; in the `.osu`
file it is actually second. It does a thing in editor itself to correct
for this.

    https://github.com/peppy/osu-stable-reference/blob/master/osu!/GameModes/Edit/Forms/SongSetup.cs#L233-L234
2024-02-23 14:49:46 +01:00
Dean Herbert
d544b4dbf1
Merge pull request #27320 from frenzibyte/adjust-old-style-spinner
Fix old-style legacy spinner fade-in not matching stable
2024-02-23 12:20:40 +08:00
Dean Herbert
157819c199
Materialise realm collection hashes during song select search process
Without this, there's a large overhead to do a realm-live `Contains`
search when a collection is selected.

This may also help considerably alleviate
https://github.com/ppy/osu/discussions/27298#discussioncomment-8552508
as we will be performing the native realm search much less.
2024-02-23 11:41:27 +08:00
Brandon
6c8204f9a3 Update delete collections message when none 2024-02-22 19:40:02 -08:00
Brandon
d6beae2ce1 Update delete/restore mod presets message when none 2024-02-22 19:10:15 -08:00
Brandon
01d0ad506d Merge branch 'master' into delete_none_message 2024-02-22 17:37:26 -08:00
Bartłomiej Dach
eac4c5f69d
Rename {Solo -> User}StatisticsWatcher et al.
The "solo" prefix is a bit unbecoming now. The updates are not only
for solo.
2024-02-22 20:36:24 +01:00
Bartłomiej Dach
1e53503608
Show user statistics after completing a playlists / multiplayer score 2024-02-22 20:35:50 +01:00
Bartłomiej Dach
0074bdc5a1
Change ResultsScreen constructor boolean params to init-only properties 2024-02-22 20:15:03 +01:00
Dean Herbert
7cbfd4400e
Merge pull request #27329 from SupDos/add-missing-extension-ios
Add missing .olz association to iOS
2024-02-23 02:36:18 +08:00
SupDos
e1ceb8a5fa Add missing .olz association to iOS 2024-02-22 18:54:28 +01:00
Dan Balasescu
083892e753
Merge pull request #27324 from bdach/github-actions-bump
Update github actions to resolve most node deprecation warnings
2024-02-23 02:26:16 +09:00
Bartłomiej Dach
99bbbf810b
Update github actions to resolve most node deprecation warnings
As is github tradition, workflows started yelling about running on a
node version that was getting sunset, so here we go again.

Relevant bumps:

- https://github.com/actions/checkout/releases/tag/v4.0.0
- https://github.com/actions/setup-dotnet/releases/tag/v4.0.0
- https://github.com/actions/cache/releases/tag/v4.0.0
- https://github.com/actions/setup-java/releases/tag/v4.0.0
- https://github.com/peter-evans/create-pull-request/releases/tag/v6.0.0
- https://github.com/dorny/test-reporter/releases/tag/v1.8.0

Notably, `actions/upload-artifact` is _not_ bumped to v4, although it
should be to resolve the node deprecation warnings, because it has more
breaking changes and bumping would break `dorny/test-reporter`
(see https://github.com/dorny/test-reporter/issues/363).
2024-02-22 17:18:10 +01:00
Salman Ahmed
af6ed85880
Merge branch 'master' into adjust-old-style-spinner 2024-02-22 16:43:44 +03:00
Bartłomiej Dach
9018579ecd
Merge pull request #26149 from rushiiMachine/fix-skin-editor-init-fail
Fix `SkinEditorOverlay` freezing when `ReplayPlayer` screen exits early
2024-02-22 14:36:35 +01:00
Salman Ahmed
bbf3f6b56c Fix old-style legacy spinner fade in not matching stable 2024-02-22 16:31:13 +03:00
Bartłomiej Dach
f9e92c69a8
Merge branch 'master' into fix-skin-editor-init-fail 2024-02-22 14:08:38 +01:00
Bartłomiej Dach
82b2edd4b7
Merge pull request #26769 from EVAST9919/results-clean
Rework `AccuracyCircle` to not use `BufferedContainer`s
2024-02-22 13:46:28 +01:00
Bartłomiej Dach
49b7f0e3a7
Merge pull request #26531 from smallketchup82/multiplayer-difficulty-tooltip
Implement difficulty tooltips for multiplayer lobbies
2024-02-22 12:57:35 +01:00
Bartłomiej Dach
7861125e7a
Swap AR and OD on tooltips
Matches everything else.
2024-02-22 12:11:49 +01:00
Bartłomiej Dach
46c8560ca5
Merge branch 'master' into multiplayer-difficulty-tooltip 2024-02-22 12:08:29 +01:00
Bartłomiej Dach
3740064360
Fix test scene not properly setting tooltip type on all icons 2024-02-22 12:05:52 +01:00
Bartłomiej Dach
d06c67ad8f
Substitute two jank interdependent bool flags for single tri-state enums 2024-02-22 12:05:50 +01:00
Bartłomiej Dach
47db317df8
Enable NRT in TestSceneDifficultyIcon 2024-02-22 11:45:57 +01:00
Bartłomiej Dach
6770b73e4e
Merge pull request #27192 from smoogipoo/mod-search-ignore-whitespace
Adjust search terms for mods
2024-02-22 11:41:31 +01:00
Bartłomiej Dach
7388576b5b
Merge pull request #27232 from maromalo/fix-bpm-differences
Fix visual BPM difference between beatmap wedge and mod selection
2024-02-22 11:11:05 +01:00
Bartłomiej Dach
b08fcbd4e9
Adjust tests to new behaviour 2024-02-22 11:02:49 +01:00
Bartłomiej Dach
84fdcd24ef
Remove description from mod search terms
Closes https://github.com/ppy/osu/issues/27111.
2024-02-22 11:02:08 +01:00
Bartłomiej Dach
1a831145ce
Merge branch 'master' into fix-bpm-differences 2024-02-22 10:41:22 +01:00
Dean Herbert
8b24c6a905
Merge pull request #27299 from BoudewijnPopkema/27272-clear-remembered-username
Clear stored username/token from config when relevant checkboxes are unticked on login panel
2024-02-22 17:29:36 +08:00
Bartłomiej Dach
81a9908c60
Extract common helper for BPM rounding 2024-02-22 10:27:37 +01:00
Bartłomiej Dach
01f6ab0336
Use more correct implementation 2024-02-22 09:44:59 +01:00
Bartłomiej Dach
a1046f0a86
Revert "clear remembered username when checkbox is unticked"
This reverts commit d01421b951.
2024-02-22 09:40:27 +01:00
Bartłomiej Dach
2831ff60e1
Add test coverage 2024-02-22 09:39:49 +01:00
Bartłomiej Dach
57bb0b85a1
Merge pull request #27107 from Joehuu/rank-highest-tooltip
Add highest rank tooltip to global rank display
2024-02-22 09:08:22 +01:00
Dean Herbert
d82b398752
Merge pull request #27297 from EVAST9919/timeline-alloc
Reduce allocations in `TimelineBlueprintContainer`
2024-02-22 09:16:16 +08:00
Boudewijn Popkema
d01421b951 clear remembered username when checkbox is unticked 2024-02-21 23:15:37 +01:00
Andrei Zavatski
4cefa8bb8d Reduce allocations in TimelineBlueprintContainer 2024-02-21 23:13:10 +03:00
Dean Herbert
901bb01f57
Merge pull request #27293 from peppy/update-framework
Update framework
2024-02-21 22:19:37 +08:00
Bartłomiej Dach
805f0b6a29
Remove unused using directive 2024-02-21 14:55:10 +01:00
Dean Herbert
1f4ab7a0e8
Merge branch 'slider-input-alloc' into update-framework 2024-02-21 21:45:14 +08:00