64528 Commits

This Branch

This Branch

All Branches

• Add mania/osu sudden death mod tests
  Dan Balasescu · 2023-12-22 16:43:09 +09:00
  88a5ba8167
• Fix mania "Great" hits failing with perfect mod
  Dan Balasescu · 2023-12-22 16:19:36 +09:00
  93efa98d9b
• Fix perfect/sudden death not working on slider tails
  Dan Balasescu · 2023-12-22 14:02:25 +09:00
  ea778c6e0a
• Add failing tests
  Dan Balasescu · 2023-12-22 13:58:12 +09:00
  9c35e25036
• Merge pull request #25972 from bdach/argon-pro-no-slider-tick-judgements
  Dean Herbert · 2023-12-21 10:01:42 +09:00
  4f1e6c31d7
• Merge branch 'master' into argon-pro-no-slider-tick-judgements
  Dean Herbert · 2023-12-21 10:01:22 +09:00
  fa4c9051cb
• Merge pull request #25976 from bdach/autopilot-incompatibility
  Dean Herbert · 2023-12-21 09:58:23 +09:00
  c8c26df5fa
• Fix autopilot mod still declaring incompatibility with fail-preventing mods

  Closes https://github.com/ppy/osu/issues/25974.

  Bartłomiej Dach · 2023-12-20 21:46:18 +01:00
  88e36eb08c
• Merge pull request #25964 from rushiiMachine/fix-export-replay-spam

  Fix save & export failed replay hotkeys handling repeated keypresses

  Bartłomiej Dach · 2023-12-20 21:07:36 +01:00
  b7cca788b5
• Fix argon pro not showing slider tick judgements

  Addresses https://github.com/ppy/osu/discussions/25968.

  Bartłomiej Dach · 2023-12-20 20:52:26 +01:00
  b6a331b2f7
• Merge pull request #25951 from peppy/show-tick-results

  Show slider tick / slider end misses with a visible judgement

  Bartłomiej Dach · 2023-12-20 20:44:04 +01:00
  53cca61e61
• Add back blank line to fix code quality inspection
  Bartłomiej Dach · 2023-12-20 19:07:26 +01:00
  975bacaeb7
• Add remarks to Is{Hit,Miss}() to explain their simultaneous existence
  Bartłomiej Dach · 2023-12-20 19:07:18 +01:00
  a763ad8473
• Merge pull request #25945 from smoogipoo/mania-scorev2-values

  Adjust mania scoring to be more in line with ScoreV2 + 85% acc / 15% combo

  Dean Herbert · 2023-12-21 01:53:30 +09:00
  c23dd1f808
• Mark flaky test temporarily
  Dean Herbert · 2023-12-21 01:52:40 +09:00
  c5fb4d0f5c
• Prevent ExportReplay being spammed on fail by being held down

  This was already handled in ReplayDownloadButton (https://github.com/ppy/osu/blob/98efff0bd61ea6cc5d6a884aeda1614d81592b9d/osu.Game/Screens/Ranking/ReplayDownloadButton.cs#L114-L115) but seemingly missed for SaveFailedScoreButton

  rushiiMachine · 2023-12-20 08:41:16 -08:00
  ebbc8333e8
• Attempt to standardise miss handling logic
  Dean Herbert · 2023-12-21 00:59:35 +09:00
  eb8fb8092d
• Revert change to OsuHitWindows and move logic local to pooling initialisation
  Dean Herbert · 2023-12-21 00:48:46 +09:00
  fcf47267fd
• Bump score version in order to recompute legacy scores
  Bartłomiej Dach · 2023-12-20 16:01:59 +01:00
  9515f7dbfa
• Merge branch 'master' into mania-scorev2-values
  Bartłomiej Dach · 2023-12-20 15:54:31 +01:00
  8c06d3873d
• Remove outdated inline comments
  Bartłomiej Dach · 2023-12-20 15:44:02 +01:00
  b0da24176e
• Merge pull request #25958 from smoogipoo/remove-mania-rate-multipliers

  Remove mania mod multiplier for DT/NC

  Dean Herbert · 2023-12-20 23:31:44 +09:00
  a8c9db2115
• Merge pull request #25949 from peppy/fix-song-select-extra-selections

  Fix beatmap updates causing one extra carousel selection

  Bartłomiej Dach · 2023-12-20 15:30:38 +01:00
  77d8bbf152
• Remove mania mod multiplier for DT/NC
  Dan Balasescu · 2023-12-20 22:28:50 +09:00
  bff08d124b
• Merge pull request #25931 from peppy/fix-thread-safety

  Fix thread safety of `OnlineMetadataClient.UserStates`

  Bartłomiej Dach · 2023-12-20 12:55:31 +01:00
  83e885192b
• Use orange for non-combo-breaking miss
  Dean Herbert · 2023-12-20 20:45:27 +09:00
  d1ba2a4a64
• Improve animation for legacy skins
  Dean Herbert · 2023-12-20 20:34:05 +09:00
  d2716d8557
• Merge branch 'master' into fix-song-select-extra-selections
  Bartłomiej Dach · 2023-12-20 12:23:55 +01:00
  6bddc56851
• Add support for showing tick misses
  Dean Herbert · 2023-12-20 20:23:19 +09:00
  9b383e3276
• Merge pull request #25943 from peppy/fix-song-select-sound-at-gameplay

  Fix song select running updates when screen is not active

  Bartłomiej Dach · 2023-12-20 12:20:06 +01:00
  22513e0070
• Update total score conversion
  Dan Balasescu · 2023-12-20 20:03:13 +09:00
  38d6b7f45b
• Update test expectations
  Dean Herbert · 2023-12-20 19:57:42 +09:00
  d417b156b2
• Remove remaining usage of NotePerfectBonus
  Dean Herbert · 2023-12-20 19:47:36 +09:00
  e0c27510f2
• Schedule even more
  Dean Herbert · 2023-12-20 19:42:05 +09:00
  5284b95bb8
• Fix selection retention logic copy paste failure
  Dean Herbert · 2023-12-20 19:27:57 +09:00
  7fa4dcf0fb
• Fix beatmap updates causing one extra carousel selection
  Dean Herbert · 2023-12-20 19:15:02 +09:00
  e003462f7d
• Merge pull request #25876 from bdach/fix-standardised-score-conversion

  Fix osu! standardised score conversion sometimes exceeding bounds

  Dan Balasescu · 2023-12-20 18:54:33 +09:00
  72274041eb
• Change mania to 85% acc / 15% combo
  Dan Balasescu · 2023-12-20 18:43:06 +09:00
  023bbda7db
• Change mania scoring to match ScoreV2
  Dan Balasescu · 2023-12-20 18:35:45 +09:00
  104fbbde94
• Fix song select running updates when screen is not active

  Who would have guessed that `Schedule` calls were there for a reason!
  
  I've tidied things up. Most of the changes I've made here are not
  required – the schedule is the main thing here. The reason the sound was
  playing is because one-too-many schedules was removed causing beatmap
  updates to update carousel specifics while still at the player loader
  screen.
  
  Note that the selection sound still plays on returning to song select,
  but this is not a regression. I'm looking at fixing this in a separate
  PR because I'm in a good place as far as understanding the logic right
  now and it would be a waste to leave it broken.
  
  Closes https://github.com/ppy/osu/issues/25875.

  Dean Herbert · 2023-12-20 17:31:09 +09:00
  64f62e7d90
• Merge pull request #25887 from smoogipoo/restore-taiko-accuracy

  Restore taiko accuracy to ScoreV2 values

  Dean Herbert · 2023-12-20 17:29:40 +09:00
  831c273b45
• Merge pull request #25934 from peppy/adjust-classic-mod-multiplier

  Adjust "classic" mod multiplier to 0.96x

  Dan Balasescu · 2023-12-20 17:11:09 +09:00
  188c463c9c
• Merge pull request #25900 from peppy/editor-from-any-carousel

  Allow choosing "Edit" from any beatmap carousel item

  Bartłomiej Dach · 2023-12-20 08:35:42 +01:00
  9a5027e556
• Merge pull request #25917 from rushiiMachine/remove-relax-mod-exclusions

  Allow failing with "relax" and "autopilot" mods

  Dean Herbert · 2023-12-20 15:48:21 +09:00
  98efff0bd6
• Also apply to autopilot
  Dean Herbert · 2023-12-20 14:56:52 +09:00
  b6f0c98a09
• Remove ModBlockFail

  Was only being used by `NoFail` now.

  Dean Herbert · 2023-12-20 14:50:45 +09:00
  14d2d0d215
• Merge pull request #25898 from peppy/song-select-stats

  Update song select to always show difficulty stats

  Dan Balasescu · 2023-12-20 14:39:35 +09:00
  3818977a36
• Adjust "classic" mod multiplier to 0.96x

  Following discussions on discord, this seems like the most agreed upon
  value. Increasing this is important so that imported legacy scores don't
  lose too much value.

  Dean Herbert · 2023-12-20 14:33:14 +09:00
  d7603e8021
• Fix thread safety of OnlineMetadataClient.UserStates

  Closes https://github.com/ppy/osu-framework/issues/6081.

  Dean Herbert · 2023-12-20 14:15:00 +09:00
  856c59f7f7
• Apply proposed changes
  Dean Herbert · 2023-12-20 12:42:06 +09:00
  85e5d74a16