69778 Commits

This Branch

This Branch

All Branches

• Remove handling for zero as MaxSizeComboCount, set lower limit as 5
  jhk2601 · 2024-10-15 02:23:41 -04:00
  86a5760ef4
• Merge https://github.com/ppy/osu into std_mod_bloom
  jhk2601 · 2024-10-15 02:15:46 -04:00
  28879529db
• Refactors handling of scale to a function
  jhk2601 · 2024-10-15 02:14:03 -04:00
  bd71da012a
• Merge pull request #30277 from bdach/fix-shuffle-more

  Fix shuffle not actually changing the track sometimes

  Dean Herbert · 2024-10-14 23:09:13 +09:00
  790f863e06
• Loop track even if shuffling if there is only one available

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2024-10-14 15:28:32 +02:00
  8cec318c1f
• Fix shuffle not actually changing the track sometimes

  See https://github.com/ppy/osu/pull/30215#issuecomment-2407775408 for
  context.
  
  Turns out the test failures were more correct than I'd thought. The
  long-and-short of it is that both in "pure random" mode and in
  "permutation" mode, when running out of track history to fall
  back on, it was possible for the random algorithm to pick the same song
  twice in a row - which is probably not desired, and which this explicit
  exclude should make impossible.

  Bartłomiej Dach · 2024-10-14 13:18:45 +02:00
  17aed26f85
• Merge pull request #30274 from shinmorisawa/master

  Respect "Prefer metadata in original language" toggle in beatmap deletion dialog

  Bartłomiej Dach · 2024-10-14 12:02:03 +02:00
  639eb7ae4a
• Merge branch 'master' into master
  Shin Morisawa · 2024-10-14 17:48:04 +09:00
  8ff86d560f
• Merge pull request #30261 from peppy/faster-quick-retry

  Decrease the time it takes to quick retry by ~650 ms

  Bartłomiej Dach · 2024-10-14 10:24:35 +02:00
  120eb9adea
• Merge branch 'master' into master
  Shin Morisawa · 2024-10-14 16:46:44 +09:00
  0664b185c3
• Merge pull request #30080 from OliBomby/clamp-scale2

  Clamp scale with lower and upper bounds

  Bartłomiej Dach · 2024-10-14 08:17:22 +02:00
  74675c8c78
• minor changes
  jhk2601 · 2024-10-14 01:54:02 -04:00
  1a142ff944
• Fix Beatmap Delete Dialog
  Shin Morisawa · 2024-10-14 09:55:28 +09:00
  90a08b8a68
• Merge pull request #30239 from rozukke/reset-offsets

  Add functionality to mass reset offsets

  Dean Herbert · 2024-10-14 01:56:14 +09:00
  f8bce706fa
• Only update beatmaps which actually had offsets

  Without this every beatmap gets a write and it reloads the whole of song
  select, basically.

  Dean Herbert · 2024-10-14 00:35:18 +09:00
  53671ad11e
• Start preparing player earlier when quick retrying

  Should help with https://github.com/ppy/osu/issues/9039.

  Dean Herbert · 2024-10-13 22:29:00 +09:00
  868a7db9e9
• Overwrite downloaded data packages

  In https://github.com/ppy/osu/actions/runs/11311858931/job/31458581002, I cancelled the run during the download from `data.ppy.sh`.
  
  In https://github.com/ppy/osu/actions/runs/11313128285/job/31461534857, `wget` skipped downloading the file due to the `-nc` option (no-clobber), i.e.: if the file exists, don't re-download.
  
  The only way I'm aware of to resolve this with wget is to either use `-c` (continue), which may lead to broken files, or to explicitly specify the output file via `-O`. Thought I'd clean up a few pieces in the process.
  
  Why not curl? Mostly historical - some distros don't come with curl. It may be okay now but there's probably no point changing this at the moment...

  Dan Balasescu · 2024-10-13 18:43:02 +09:00
  9681e3ac46
• Merge pull request #30246 from Joehuu/recommend-csdevkit-instead

  Recommend C# Dev Kit extension on VSCode

  Dan Balasescu · 2024-10-13 15:02:03 +09:00
  9abca53829
• Recommend C# Dev Kit extension on VSCode
  Joseph Madamba · 2024-10-12 12:12:40 -07:00
  e1e8e39a89
• Add functionality to mass reset offsets
  Artemis Rosman · 2024-10-13 00:50:45 +11:00
  e4f9c861ba
• Merge pull request #30218 from bdach/daily-challenge-conclusion-offline

  Do not show daily challenge conclusion notification on disconnection

  Dan Balasescu · 2024-10-12 18:14:22 +09:00
  2de1955892
• Smoother size changing using linear interpolation
  jhk2601 · 2024-10-11 21:52:13 -04:00
  4d367515dc
• Initial Implementation (working, unsafe handling of cursor position)
  jhk2601 · 2024-10-11 18:38:53 -04:00
  0794fc61a0
• Merge pull request #30215 from bdach/fix-music-controller

  Fix track restarting when trying to switch track change direction with shuffle active

  Dean Herbert · 2024-10-12 01:41:44 +09:00
  3a8ed889b5
• Merge branch 'master' into clamp-scale2
  Bartłomiej Dach · 2024-10-11 15:13:54 +02:00
  5db1f05953
• Rename methods to fit new changes better
  Bartłomiej Dach · 2024-10-11 15:03:30 +02:00
  d1da1d4079
• Add positive assertion for conclusion notification being present too
  Bartłomiej Dach · 2024-10-11 14:31:30 +02:00
  07d15cc35a
• Do not show daily challenge conclusion notification on disconnection

  Closes https://github.com/ppy/osu/issues/30194.

  Bartłomiej Dach · 2024-10-11 14:18:19 +02:00
  968835bb44
• Add failing test
  Bartłomiej Dach · 2024-10-11 14:16:24 +02:00
  9d1eb842a7
• Fix crash when switching tracks back and forth with shuffle on
  Bartłomiej Dach · 2024-10-11 12:45:14 +02:00
  4a16341a94
• Add another failing test case for crash
  Bartłomiej Dach · 2024-10-11 12:45:03 +02:00
  1a25e9d179
• Fix switching direction when changing tracks with shuffle on restarting the same track

  Closes https://github.com/ppy/osu/issues/30190.

  Bartłomiej Dach · 2024-10-11 12:40:45 +02:00
  47cb696b69
• Add failing test case
  Bartłomiej Dach · 2024-10-11 12:33:43 +02:00
  0882f1bb70
• Merge pull request #30206 from minetoblend/fix/selection-box-buttons-stuck

  Fix SelectionBox buttons freezing when button is triggered via key event

  Dan Balasescu · 2024-10-11 12:02:58 +09:00
  616c2aeefc
• Make TriggerAction public
  Marvin Schürz · 2024-10-10 20:50:47 +02:00
  af55585dc8
• Move circle flash to TriggerAction
  Marvin Schürz · 2024-10-10 20:20:02 +02:00
  fc7ad96fcd
• Fix SelectionBox buttons freezing when button is triggered via key event
  Marvin Schürz · 2024-10-10 20:14:11 +02:00
  9cc6ee2ebc
• Merge pull request #30198 from bdach/thank-you-discord-once-more

  Fix discord RPC complaining yet again if given a single space character as activity state / details

  Dan Balasescu · 2024-10-11 01:15:56 +09:00
  c545269eec
• Merge pull request #30195 from bdach/advanced-stats-stupid-shenanigans

  Fix crashes when attempting to change from a custom ruleset with mods selected to another

  Dean Herbert · 2024-10-11 00:57:28 +09:00
  14ecd56913
• Merge pull request #30199 from bdach/no-song-progress-tooltip-during-gameplay

  Fix argon song progress bar tooltip showing during active gameplay

  Dan Balasescu · 2024-10-11 00:03:27 +09:00
  245d05a2e2
• Fix argon song progress bar tooltip showing during active gameplay

  Closes https://github.com/ppy/osu/issues/30197.
  
  Pretty bad one, might be worth a hotfix...

  Bartłomiej Dach · 2024-10-10 14:36:28 +02:00
  938c3d78ce
• Remove no-longer-required cache-over hack

  This is now removable after `AdvancedStats` has been weaned off the
  global mods bindable. I think this is a win all things considered?

  Bartłomiej Dach · 2024-10-10 14:22:20 +02:00
  687bdad389
• Decouple AdvancedStats from global mods

  Closes https://github.com/ppy/osu/issues/30163.
  
  If I'm to be blunt, the decoupled stuff in song select makes my head
  spin. I spent a solid 20 minutes thinking how I was going to fix this
  one but then finally realised that generally most of the cause there
  was the fact that `AdvancedStats` was seeing the new rulesets *before*
  the "ensure global selected mods are valid for current ruleset" logic,
  and so decided to just _delay_ that until the decoupled transfer
  thingamajig happens.
  
  I was honestly considering combining `BeatmapInfo`, `Ruleset`, and
  `Mods` into one property on `AdvancedStats`. I figured I'd rather not
  push my luck and try the baseline version first, but I honestly think
  that direction is going to be required at some point to properly corral
  all of the decoupled madness taking place in song select.

  Bartłomiej Dach · 2024-10-10 14:22:16 +02:00
  f1842d781e
• Fix discord RPC complaining yet again if given a single space character as activity state / details

  Closes https://github.com/ppy/osu/issues/30178.
  
  Really, discord?

  Bartłomiej Dach · 2024-10-10 13:59:18 +02:00
  a7fcfd5f0d
• Merge pull request #30189 from OliBomby/fix-splittable

  Fix split control point context menu option not showing up on newly created control points

  Bartłomiej Dach · 2024-10-10 11:37:24 +02:00
  cab97a96ab
• Fix isSplittable depending on unreliable order of path control point pieces
  OliBomby · 2024-10-09 23:31:12 +02:00
  9936ec579f
• Merge pull request #30164 from bdach/am-i-fired-this-time

  Fix game deadlocking on startup when set to single thread mode

  Dean Herbert · 2024-10-09 19:55:01 +09:00
  2024.1009.1 a6f56036a2
• Migrate MusicController to Live<T> to fix broken migrations instead
  Bartłomiej Dach · 2024-10-09 11:59:04 +02:00
  baa64d1486
• Revert 'Fix any and all migration attempts dying on MusicController'

  This reverts commit 310eec69fc.
  
  Way to try and "fix" stuff and screw stuff up even harder instead, me.
  Great job, well done.

  Bartłomiej Dach · 2024-10-09 11:55:59 +02:00
  081d87fe6d
• Merge pull request #30151 from bdach/migration-is-completely-fucked

  Fix several breakages with migration operation

  Dean Herbert · 2024-10-09 14:24:34 +09:00
  2024.1009.0 270c4c4f12