Bartłomiej Dach
3bf3e9133b
Merge pull request #28689 from smoogipoo/fix-break-conversion
...
Fix `ManiaModInvert` permanently destroying the beatmap
2024-07-02 07:53:16 +02:00
Dan Balasescu
04da1209f7
Revert "Change breaks list to IReadOnlyList"
...
This reverts commit 2c3b411bb5
2024-07-02 12:16:11 +09:00
Dean Herbert
2c3b411bb5
Change breaks list to IReadOnlyList
2024-07-02 11:59:24 +09:00
Nathan Du
1eb10e029c
Rewrite no release mod
...
Per the request of spaceman_atlas, the No Release mod is rewritten to
avoid modifications to DrawableHoldNoteTail. The approach is based
on that of the Strict Tracking mod for the osu!(standard) ruleset,
injecting the mod behavior by replacing the normal hold note with
the mod's variant. The variant inherits most bevaior from the normal
hold note, but when creating nested hitobjects, it creates its own
hold note tail variant instead, which in turn is used to instantiate
the mod's variant of DrawableHoldNoteTail with a new behavior.
The time a judgement is awarded is changed from the end of its
Perfect window to the time of the tail itself.
2024-07-01 20:29:30 +08:00
Dan Balasescu
4cb58fbe47
Add failing test
2024-07-01 15:02:00 +09:00
Nathan Du
463ab46fee
formatting
2024-06-29 16:46:16 +08:00
Nathan Du
679f4735b3
add tests for No Release mod
...
The new test scene is essentially a copy of TestSceneHoldNoteInput,
modified to test the judgement changes applied by the new mod. A base
class might need to be abstracted out for them.
2024-06-29 16:20:07 +08:00
Dan Balasescu
878fb2d10d
Add break support
2024-02-15 22:05:25 +09:00
Dan Balasescu
d1a51b474c
Adjust tests
2024-02-15 21:25:40 +09:00
Dan Balasescu
88a5ba8167
Add mania/osu sudden death mod tests
2023-12-22 16:43:09 +09:00
Dan Balasescu
93efa98d9b
Fix mania "Great" hits failing with perfect mod
2023-12-22 16:19:36 +09:00
Dan Balasescu
9c35e25036
Add failing tests
2023-12-22 13:58:12 +09:00
Dean Herbert
d417b156b2
Update test expectations
2023-12-20 19:57:42 +09:00
PercyDan54
b20b2203ac
Fix mania Autoplay mod missing 0ms hold notes
2023-12-11 21:10:14 +08:00
Bartłomiej Dach
c48142816c
Reformat long lines
2023-10-16 09:06:34 +02:00
Bartłomiej Dach
db00b794a2
Fix test failure due to missing zero (and FP shenanigans)
2023-10-16 08:53:56 +02:00
Dean Herbert
7c49843411
Fix various tests
2023-10-16 14:21:33 +09:00
Dean Herbert
c5397bdbb3
Merge branch 'master' into mania-edit-disable-sv
2023-09-20 14:23:07 +09:00
Dan Balasescu
0a1ba2ebe0
Remove ModNoMod usage
2023-09-04 15:56:32 +09:00
Dean Herbert
37c2b330a2
Move toggle implementation to work on all scrolling rulesets automatically
2023-09-01 19:53:10 +09:00
Dan Balasescu
390b6f649d
Add test
2023-08-29 03:46:11 +09:00
Dan Balasescu
5678db4e70
Fix test + cleanup
2023-08-15 19:42:32 +09:00
Dylan Nantz
4fce7f03bd
add mania mod fadein test
2023-01-11 14:14:17 -05:00
Dean Herbert
efded323e4
Rename variables and avoid the need for a property
2023-01-09 16:49:38 +09:00
Dylan Nantz
4a1a023f9e
Code quality improvements
2022-12-20 13:33:33 -05:00
Dylan Nantz
c200e77994
Add mania hidden mod configuration
2022-12-19 18:31:28 -05:00
Dan Balasescu
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
Salman Ahmed
516e99df72
Add test coverage for flashlight mod
2022-10-14 02:38:43 +03:00
Dean Herbert
2ae1aef0be
Move column initialisation to ctor and fix remaining tests
2022-10-07 15:24:36 +09:00
andy840119
9f79e80d8b
Remove nullable disable annotation in the Mania test case.
2022-07-27 22:24:14 +08:00
Dan Balasescu
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
Dean Herbert
bb8dc74e88
Fix constant formatting
2022-01-31 12:20:51 +09:00
Spooghetti420
b52153e73d
Remove settings
2022-01-30 17:40:15 +00:00
Dean Herbert
c7580a5177
Fix inspections in test scene
2022-01-29 14:06:43 +09:00
Dean Herbert
035a84e75c
Rename function and make public again for test usage
2022-01-29 14:05:23 +09:00
Spooghetti420
a4aa501bb5
Change threshold from ms to beat-based, add tests
2022-01-28 21:59:53 +00:00
Spooghetti420
146c54a2c1
Fix code formatting
2022-01-27 21:02:59 +00:00
Spooghetti420
3e068e564d
Update mod per discussion + create test
2022-01-27 20:56:51 +00:00
smoogipoo
30dae5bf1c
Add test to make sure the algorithm is passed down in time
2021-02-04 15:21:26 +09:00
smoogipoo
583760100a
Implement mania invert mod
2020-08-18 01:40:55 +09:00
Salman Ahmed
2fa47992dc
Seal the ruleset creation methods and let abstract method take their place
...
Also makes `CreatePlayerRuleset()` and `CreateRulesetForSkinProvider()` not-null to avoid unwanted behaviour with their derivers
2020-04-23 13:27:12 +03:00
Salman Ahmed
155bc8b49a
Remove ModTestScene ruleset parameter on constructor and use CreateRuleset instead
2020-04-17 11:17:59 +03:00
Dean Herbert
0be423183d
Rename data class
2020-03-11 00:36:56 +09:00
smoogipoo
d11d29c1f7
Adjust namespaces
2020-03-03 15:30:53 +09:00
