Dan Balasescu
80fc13fc1f
Merge pull request #16976 from peppy/dont-expose-mark-as-read-errors-to-user
...
Don't expose "mark as read" errors to the user via notifications
2022-02-24 23:20:34 +09:00
Dan Balasescu
16a3bbbcb4
Merge pull request #16944 from peppy/rooms-request-faster
...
Update playlists/multiplayer to use new compact response
2022-02-24 23:20:07 +09:00
Dean Herbert
2fb16eef56
Merge pull request #16981 from smoogipoo/remove-netanalyzers
...
Remove Microsoft.CodeAnalysis.NetAnalyzers package
2022-02-24 22:33:23 +09:00
Dean Herbert
35302aa297
Merge pull request #16980 from smoogipoo/fix-union-workaround-resolver
...
Fix SignalR union workaround resolver failing on multiple union'd types
2022-02-24 22:24:48 +09:00
Dan Balasescu
cd8190b2e7
Remove Microsoft.CodeAnalysis.NetAnalyzers package
2022-02-24 20:45:15 +09:00
Dan Balasescu
c5b1e5cbf8
Fix union resolver failing on multiple derived types
2022-02-24 20:27:22 +09:00
Dean Herbert
d69446ff6e
Merge pull request #16979 from smoogipoo/fix-playlists-partial-mod
...
Fix playlists not allowing entry with partial mods
2022-02-24 19:37:10 +09:00
Dan Balasescu
7193bc8554
Fix playlists comparing mod equality via APIMod
2022-02-24 17:04:16 +09:00
Dan Balasescu
2acaffd5e7
Fix APIMod storing bindables instead of value
2022-02-24 17:01:12 +09:00
Dan Balasescu
328166f0d5
Add failing test
2022-02-24 17:01:04 +09:00
Dean Herbert
bb1aa032bd
Combine SelectedItem and CurrentPlaylistItem into same storage
2022-02-24 16:21:20 +09:00
Dean Herbert
c6d78b9325
Fix several oversights in data linking causing drawable rooms not updating as expected
2022-02-24 16:12:15 +09:00
Dean Herbert
b4a54b38e7
Remove redundant parameter specification
2022-02-24 16:02:16 +09:00
Dean Herbert
3f6bdc5585
Don't expose "mark as read" errors to the user via notifications
...
This can happen if the user leaves the channel before the request is
fired. You can't mark a channel as read when you're not in the channel.
Addresses https://github.com/ppy/osu/discussions/16973 .
2022-02-24 15:40:07 +09:00
Dean Herbert
7302e66c5f
Merge pull request #16860 from sh0ckR6/issues/16839-spun-out-rate
...
Give "Spun Out" dynamic spin rate
2022-02-24 13:25:53 +09:00
Dean Herbert
8f437354ad
Merge branch 'master' into issues/16839-spun-out-rate
2022-02-24 11:51:53 +09:00
Dean Herbert
8f951f8e8a
Merge pull request #16969 from peppy/update-framework
...
Update framework
2022-02-24 11:32:34 +09:00
Bartłomiej Dach
f0681ccd09
Merge pull request #16909 from peppy/startup-protocol-handling
...
Add handling of beatmap links on startup
2022-02-24 03:12:51 +01:00
Bartłomiej Dach
29d77a29aa
Merge branch 'master' into startup-protocol-handling
2022-02-23 21:10:27 +01:00
Dean Herbert
53bbd00675
Also make APIUser opt-in and remove the remaining serialization exclusion rule
2022-02-23 17:12:38 +09:00
Dean Herbert
43c83d2de1
Add note about why RoomID is nulled in DeepClone
2022-02-23 17:10:11 +09:00
Dean Herbert
f14a9af801
Make Room opt-in rather than opt-out for json serialization
2022-02-23 17:10:10 +09:00
Dean Herbert
28c9c5ab6a
Remove unnecessary ShouldSerialize rules in Room
2022-02-23 17:10:10 +09:00
Dean Herbert
5d73691de4
Use existing HandleLink flow rather than reimplmenting
2022-02-23 17:02:39 +09:00
Dean Herbert
054ed546e3
Fix intermittent failures in remaining test method
2022-02-23 16:56:50 +09:00
Dean Herbert
a6b6644c2e
Replace LINQ queries with recommendations
2022-02-23 16:22:13 +09:00
Dean Herbert
99045c6ac8
Merge pull request #16951 from bdach/mod-overlay/switches
...
Implement mod switches for new mod select design
2022-02-23 14:20:43 +09:00
Dean Herbert
87da650dfb
Update framework
2022-02-23 14:06:56 +09:00
Dean Herbert
5e7dd31f6d
Merge branch 'master' into mod-overlay/switches
2022-02-23 13:49:23 +09:00
Dan Balasescu
71a012bea6
Don't update count twice immediately
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-02-23 13:42:47 +09:00
Dan Balasescu
2bea485af8
Fix currently playing text not showing in lounge
2022-02-23 13:37:47 +09:00
Dean Herbert
b0a74a6851
Merge pull request #16964 from Susko3/osu-links
...
Fix handling of badly-formatted osu:// urls
2022-02-23 11:09:00 +09:00
Susko3
7bdcb5952e
Fix handling badly-formatted osu:// urls
2022-02-23 00:36:56 +01:00
Bartłomiej Dach
d0d0830888
Merge pull request #16960 from peppy/beatmap-overlay-load-after-login
...
Fix beatmap overlay not re-fetching results after initial login
2022-02-22 23:27:49 +01:00
Bartłomiej Dach
d8fa443ea0
Extract default mod switch measurements to constants
...
For use later when specific sizes/scales of the mod switches are
desired.
2022-02-22 23:22:11 +01:00
Bartłomiej Dach
1fe463e4d0
Merge branch 'master' into beatmap-overlay-load-after-login
2022-02-22 22:55:38 +01:00
Bartłomiej Dach
1a358698fb
Merge branch 'master' into startup-protocol-handling
2022-02-22 22:42:16 +01:00
Bartłomiej Dach
d1d6847d32
Add comment about split usage in osu:// protocol link handling
2022-02-22 22:24:37 +01:00
Dean Herbert
6de4e05e49
Fix current selection not being correctly maintained when BeatmapPicker updates its display
2022-02-22 17:17:08 +09:00
Dean Herbert
5efffa208a
Add test coverage of beatmap set overlay actually showing requested beatmap
2022-02-22 17:08:09 +09:00
Dean Herbert
ed008267d7
Fix one more case of escaping not being present
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-02-22 16:45:18 +09:00
Dean Herbert
ca0a041153
Fix missing escaping causing test failures
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-02-22 16:45:04 +09:00
Dan Balasescu
ebdffb3cd9
Merge pull request #16961 from peppy/timeline-load-wait-failure
...
Fix `TestSceneEditorSaving` not waiting for timeline load
2022-02-22 16:12:32 +09:00
Dean Herbert
61b3280de1
Add missing property copies in Room.CopyFrom implementation
2022-02-22 15:47:00 +09:00
Dean Herbert
71ae425fb2
Merge branch 'master' into rooms-request-faster
2022-02-22 15:45:05 +09:00
Dean Herbert
347a2346b9
Fix TestSceneEditorSaving not waiting for timeline load
...
As seen at
https://github.com/ppy/osu/runs/5276431764?check_suite_focus=true .
2022-02-22 15:41:08 +09:00
Dean Herbert
057fd6c352
Add mention of StarRatingRangeDisplay fallback scenario being wrong for multiplayer
2022-02-22 15:37:42 +09:00
Dean Herbert
f12044b03e
Add mention of PlaylistItem.Beatmap being a placeholder in many cases
2022-02-22 15:31:08 +09:00
Dean Herbert
cde3d9c08b
Change precedence order to favour playlist as a source for beatmap count
2022-02-22 15:15:57 +09:00
Dean Herbert
e744840d07
Ensure old results are cleared from beatmap overlay on logout
2022-02-22 14:56:04 +09:00
