62125 Commits

This Branch

This Branch

All Branches

• Fix incorrect selection restore code in split case

  The fallback to "any of the added sets" needs to be applied after
  they've all been added, rather than with every added one. Otherwise, in
  flows that expect a particular difficulty to be selected in the end
  (such as exiting from editor) would end up switching away from the
  edited beatmap.

  Bartłomiej Dach · 2023-08-28 10:06:26 +02:00
  80ec18d117
• Fix online ID not being propagated in split difficulty mode

  Would result in failures to re-download the beatmap in update flows, for
  instance.

  Bartłomiej Dach · 2023-08-28 10:05:59 +02:00
  0af6cc1394
• Add failing test coverage of selection not being retained on song select
  Bartłomiej Dach · 2023-08-28 10:05:59 +02:00
  6251803868
• Add failing test coverage of beatmap update flow w/ split diffs
  Bartłomiej Dach · 2023-08-28 09:51:44 +02:00
  3a6920c306
• Rename remove method to better explain return type being IEnumerable
  Dean Herbert · 2023-08-25 18:10:54 +09:00
  10b1450138
• Adjust test to actually test diff splitting
  Dean Herbert · 2023-08-25 18:09:51 +09:00
  84f4fab9cf
• Reduce complexity of selection restore
  Dean Herbert · 2023-08-25 00:52:54 +09:00
  89eeff515b
• Fix typo in local variable
  Dean Herbert · 2023-08-24 18:33:15 +09:00
  9e94f38091
• Fix typo in test step

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2023-08-24 18:30:59 +09:00
  b471ab07a6
• Fix one more test probably going off-screen
  Dean Herbert · 2023-08-24 13:31:33 +09:00
  ba70d48d2c
• Limit set/diff count in test to better fit on screen
  Dean Herbert · 2023-08-24 03:32:12 +09:00
  4881130cae
• Add coverage of selection retention when difficulties are split out
  Dean Herbert · 2023-08-23 19:44:42 +09:00
  5eac604f8b
• Add test coverage of add/remove when difficulties are split out
  Dean Herbert · 2023-08-23 19:43:08 +09:00
  a64381f855
• Update test to match new behaviour
  Dean Herbert · 2023-08-23 19:38:18 +09:00
  5555f73e97
• Fix selection not being retained when switching between split mode
  Dean Herbert · 2023-08-22 18:49:02 +09:00
  018be4c20f
• Fix incorrect handling when new beatmaps arrive
  Dean Herbert · 2023-08-22 18:48:07 +09:00
  ecbf0f138e
• Ensure ID is maintained in temporary BeatmapSetInfos
  Dean Herbert · 2023-08-22 18:48:07 +09:00
  2b1c6ae612
• Split out difficulties in beatmap carousel in a bit of a hacky way

  Seems like the simplest path forward for now, without a full rewrite.

  Dean Herbert · 2023-08-22 18:47:41 +09:00
  290d18ad69
• Merge pull request #24508 from OliBomby/judge-fix

  Fix hit animation not synchronizing when editing hit objects

  Bartłomiej Dach · 2023-08-22 10:21:42 +02:00
  71ec29041b
• Merge branch 'master' into judge-fix
  Bartłomiej Dach · 2023-08-22 09:44:58 +02:00
  8cd9f0822a
• Merge pull request #24588 from ItsShamed/ux/notifications/flash-on-message

  Flash taskbar when receiving notifications while the game is not focused

  Dean Herbert · 2023-08-22 16:44:16 +09:00
  36ebdd8d30
• Reword comment to be better
  Bartłomiej Dach · 2023-08-22 09:37:54 +02:00
  5be5335784
• Make highlight messages important in order to trigger window flash
  Bartłomiej Dach · 2023-08-22 09:01:32 +02:00
  142abe1fd0
• Remove FlashTaskbar and use IsImportant directly instead
  Bartłomiej Dach · 2023-08-22 08:58:48 +02:00
  aa29e00578
• Make OsuGame dependency nullable
  Bartłomiej Dach · 2023-08-22 08:54:41 +02:00
  be1a712f33
• Merge branch 'master' into ux/notifications/flash-on-message
  Bartłomiej Dach · 2023-08-22 08:20:08 +02:00
  71b5be2568
• Merge pull request #24613 from smoogipoo/masking-ssbo

  Update framework and apply changes to support masking SSBO

  Dean Herbert · 2023-08-22 14:00:34 +09:00
  b581d67416
• Update resources
  Dean Herbert · 2023-08-22 13:17:12 +09:00
  f09b818418
• Update framework and apply changes to support masking SSBO
  Dan Balasescu · 2023-08-22 12:50:13 +09:00
  e8337c592a
• Merge pull request #24610 from bdach/remove-global-action-container-hack

  Remove global action container input queue workaround

  Dean Herbert · 2023-08-22 12:44:26 +09:00
  2937dcef1a
• refactor: make flashing available in Notifications

  This will be used in `NotificationOverlay` when a `Notification` is posted.

  tsrk · 2023-08-21 23:36:54 +02:00
  96c58c86ea
• Merge pull request #24368 from peppy/fix-score-import-fail-fail-fail

  Avoid reprocessing scores which already failed an upgrade previously

  Bartłomiej Dach · 2023-08-21 18:23:06 +02:00
  00c87c782b
• Remove global action container input queue workaround

  As described in #24248, the workaround employed by
  `GlobalActionContainer`, wherein it tried to handle actions with
  priority before its children by being placed in front of the children
  and not _actually containing_ said children, is blocking the resolution
  of some rather major input handling issues that allow key releases to be
  received by deparented drawables.
  
  To resolve, migrate `GlobalActionContainer` to use `Prioritised`, which
  can be done without regressing certain mouse button flows after
  ppy/osu-framework#5966.

  Bartłomiej Dach · 2023-08-21 17:54:08 +02:00
  5454d1caa1
• Also update the reference to added flag in schema change breakdown
  Bartłomiej Dach · 2023-08-21 17:44:35 +02:00
  273dcf9150
• Merge branch 'master' into fix-score-import-fail-fail-fail
  Bartłomiej Dach · 2023-08-21 17:28:10 +02:00
  99c862f894
• Fix mismatching schema version in comment
  Bartłomiej Dach · 2023-08-21 17:27:05 +02:00
  8533cba0bf
• Merge pull request #24527 from Pasi4K5/fix-slider-reversing

  Fix sliders being reversed incorrectly in the editor

  Bartłomiej Dach · 2023-08-21 17:12:00 +02:00
  aa5680a8aa
• Merge pull request #24604 from peppy/fix-star-fountain-directions

  Fix star fountain directions not matching stable

  Bartłomiej Dach · 2023-08-21 17:00:51 +02:00
  6cd48e9db5
• Merge pull request #24605 from peppy/fix-drawable-menu-item-crash

  Fix potential crash when loading menu items due to cross-thread ops

  Bartłomiej Dach · 2023-08-21 16:52:24 +02:00
  a79031dddd
• refactor(MessageNotifier): apply changes required by framework
  tsrk · 2023-08-21 15:29:41 +02:00
  bdac052631
• Update inline comments
  OliBomby · 2023-08-21 13:09:31 +02:00
  e283aa2843
• Revert "Revert "Fix TestSceneFruitRandomness""

  This reverts commit 82de7385d1.

  OliBomby · 2023-08-21 13:02:41 +02:00
  c82e997644
• Revert "Ensure invariant of monotone time"

  This reverts commit 5d1ccc2601.

  OliBomby · 2023-08-21 13:02:23 +02:00
  5bc11ed358
• Revert "Fix typo"

  This reverts commit 90f2acaf0a.

  OliBomby · 2023-08-21 13:00:01 +02:00
  c7b1c75379
• Revert "Fix TestSceneFruitRandomness"

  This reverts commit b9d0a8a9f6.

  OliBomby · 2023-08-21 12:59:58 +02:00
  82de7385d1
• Rename new flag and update xmldoc to match
  Dean Herbert · 2023-08-21 19:36:22 +09:00
  b3e7416972
• Fix some incorrect comments / test step descriptions

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2023-08-21 19:35:04 +09:00
  662073c472
• Merge branch 'master' into fix-score-import-fail-fail-fail
  Dean Herbert · 2023-08-21 19:34:12 +09:00
  db893f3dc7
• Fix potential crash when loading menu items due to cross-thread ops
  Dean Herbert · 2023-08-21 19:05:20 +09:00
  5f040a991b
• Fix star fountain directions not matching stable
  Dean Herbert · 2023-08-21 17:59:24 +09:00
  e7d61e0002