569 Commits

• Tooling updates (#37031)

  Most of this is as everywhere else, but there's also interesting code
  inspection fixes from the InspectCode bump, so I'll talk about that a
  little.
  
  ## [Fix suspicious equality in
  `Hotkey`](https://github.com/ppy/osu/commit/948136e49e88a721827d54e51c5759fe9aca811d)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/TypeWithSuspiciousEqualityIsUsedInRecord.Global.html
  
  Pretty annoying to fix, nullable array types are a pain. Does look legit
  though.
  
  ## [Fix `StarDifficulty` using inefficient struct
  equality](https://github.com/ppy/osu/commit/2db775ebb0bb9f18de67677ef84b993465d26545)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/DefaultStructEqualityIsUsed.Global.html
  
  This is a dodgy one because there's no real sane way to define equality
  on `StarDifficulty` now that it has difficulty and performance
  attributes jammed into it. So I just basically shut the inspection up
  with a `record` modifier and move on.
  
  Unclear where the equality is used precisely. It's from a global
  inspection. F12 is very unhelpful when trying to track down usages of
  `Equals()`. We definitely have `Bindable<StarDifficulty>` instances and
  those do use equality. Maybe more than that.
  
  ## [Use `nameof` expressions to reference enum member
  names](https://github.com/ppy/osu/commit/aa08175c803bc725f3b15a92174dfe6d1b812d91)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html
  
  Pretty quaint.
  
  ## [Prefer using concrete values over `default` or
  `new()`](https://github.com/ppy/osu/commit/b21ee08d7748be10d42268d5c2eb77369026545d)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/PreferConcreteValueOverDefault.html
  
  I could see this one going both ways, but I'm kinda sold on this
  inspection. Explicit is always better. Saves some allocations in the
  `CancellationToken` cases as well.
  
  ## [Explicitly call `.AsEnumerable()` in some realm
  usages](https://github.com/ppy/osu/commit/c8ce1ecd42b9d8abb8b9e2ab93d471f463e80401)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/PossibleUnintendedQueryableAsEnumerable.html
  
  Not fully sold on this one but it's quick and simple so might as well.
  
  ## [Simplify dictionary removal with single `.Remove()`
  call](https://github.com/ppy/osu/commit/5964ceccea900302df726b7a8ecbf6b74eb2e427)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html
  
  Not much to say.

  Bartłomiej Dach · 2026-03-19 00:05:52 +09:00
  18d4ba5874
• Update lots of packages (#36996)

  It's been a while.
  
  Notes:
  
  - `SharpCompress` usages changed a bit. Manually adjusted these, mostly
  just renames or adjusted parameters.
  - nUnit 3 -> 4 migrated using
  https://gist.github.com/peppy/07994386d793a117350cb5f24b156585. there's
  a mode in this script to update to the newer `Assert.That` syntax but it
  requires fixes and couldn't really be bothered.
  - DeepEqual nuked as the only usage was on a disabled test. The reason
  it's disabled has been merged upstream, but it's failing for other
  (realm) reasons which I don't think is worthwhile to investigate for
  now.
  - This bumps Moq. I think the author is back in a sensible headspace and
  the new version has the stupid shit removed, so probably okay? Nice to
  be on a level playing field with packages for once in a long time.
  - Automapper is silly, but we've discussed this elsewhere.
  - `TestRealmKeyBindingStore` failures are a wildcard, but fixed by using
  a more standardised testing method. Dunno why, don't care.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-03-17 03:58:02 +09:00
  a996261304
• Adjust test to exercise actual desired behaviour
  Bartłomiej Dach · 2025-10-03 14:39:48 +02:00
  68d5f53cc7
• Replace old-skin with retro skin in tests
  clayton · 2025-09-05 21:21:52 +09:00
  3c1c537b1b
• Refactor beatmap attribute methods

  This change refactors `GetAdjustedDisplayDifficulty()` and
  `GetBeatmapAttributesToDisplay()` in two ways:
  
  - Both methods now accept `IBeatmapInfo` instead of
    `IBeatmapDifficultyInfo`. This is done in order to make mania key
    count display to work, wherein `IBeatmapDifficultyInfo` is not enough
    to calculate the final key count.
  
  - `GetAdjustedDisplayDifficulty()` now applies all
    `IApplicableToDifficulty` mods itself. I did this after noticing that
    every real consumer of this method had to do that themselves for very
    little reason.

  Bartłomiej Dach · 2025-07-30 14:06:34 +02:00
  7c4dd812b6
• Fix test method not being named correctly
  Dean Herbert · 2025-07-29 17:36:55 +09:00
  67a98292eb
• Rename mod and move back to fun
  Dean Herbert · 2025-07-29 17:11:41 +09:00
  92a5399b4a
• Merge branch 'master' into feature/catch-mod-h2w
  Dean Herbert · 2025-07-29 17:00:26 +09:00
  40f06af357
• Attempt to properly quantify the impact of mania Hard Rock / Easy mod application on overall difficulty

  In stable mania, Hard Rock and Easy mods do not work the same way as
  they do on all of the rulesets. The difference is that mania HR and EZ,
  rather than apply a multiplier to the map's original Overall Difficulty,
  apply multipliers to *the durations of hit windows themselves*.
  
  Prior to the last release, lazer was oblivious to this reality and just
  treated mania HR / EZ as it did every other ruleset. Last release, for
  the sake for gameplay parity across rulesets, the mods in question were
  adjusted to match stable, but in the process, it started looking like HR
  / EZ did not change OD anymore.
  
  The problem is that they do, but applying a multiplier to the map's OD
  and applying a multiplier to the hit window duration is not the same
  thing. The second thing is actually *much harsher* in magnitude, to the
  point where applying HR to any map is almost guaranteed to exceed "the
  effective OD" of 10, and applying EZ to any map is almost guaranteed to
  result in "negative effective OD".
  
  This change attempts to convey that reality by displaying "effective
  OD", similar to what's already done in other rulesets when rate-changing
  mods are active. Note that the values this will display *do not match*
  stable *and that is correct*, because stable song select *lies* about
  the actual impact on OD by just assuming it can treat all rulesets in
  the same way.
  
  ---
  
  Would close https://github.com/ppy/osu/issues/34150 I guess.
  
  And yes I would like *all of the above* to land on the changelog if
  possible if this is merged.
  
  For further convincing that this makes any semblance of sense please see
  the following: https://www.desmos.com/calculator/yigt7jycdv

  Bartłomiej Dach · 2025-07-15 09:40:55 +02:00
  131f828e6a
• Add simple test scene for HoldToWalk mod
  CloneWith · 2025-06-13 23:58:31 +08:00
  2e9e39e123
• Fix some botched assertions
  Bartłomiej Dach · 2025-05-14 14:25:38 +02:00
  81e6d6a2de
• Add baseline test coverage of replay recording in all rulesets

  Nothing fancy, just basics to ensure the subsequent commit doesn't break
  anything.

  Bartłomiej Dach · 2025-05-14 11:25:14 +02:00
  168c3cf018
• Fix placement blueprint tests
  Bartłomiej Dach · 2025-03-11 07:55:48 +01:00
  c962210b4f
• Minor bump some packages
  Dean Herbert · 2025-02-17 15:23:26 +09:00
  db4a4a1723
• Fix tests
  Bartłomiej Dach · 2025-01-24 11:59:07 +01:00
  269ade178e
• Enable NRT in test scene
  Bartłomiej Dach · 2025-01-08 11:47:28 +01:00
  87866d1b96
• Add failing test
  Bartłomiej Dach · 2025-01-08 11:39:48 +01:00
  ac19124632
• Upgrade more packages again

  This also downgrades nunit to be aligned across all projects. Getting it
  up-to-date is a bit high effort.

  Dean Herbert · 2025-01-08 03:13:11 +09:00
  6f42b59e31
• Rename variable to imply it is now a function
  Dean Herbert · 2024-11-22 13:11:32 +09:00
  41addaae9a
• Recreate beatmap every test run in ModTestScene
  Salman Alshamrani · 2024-11-21 17:48:33 -05:00
  5dffc322af
• Update all dependencies (except realm, nunit, moq and deepclone)
  Dean Herbert · 2024-10-18 16:20:07 +09:00
  ca2bd640b4
• fix warnings
  OliBomby · 2024-09-24 20:32:08 +02:00
  d26e677bb7
• Refactor PlacementBlueprint to not be hitobject specific
  OliBomby · 2024-09-24 20:31:00 +02:00
  e3b4483872
• Rename SkinComponentsContainer to SkinnableContainer
  Dean Herbert · 2024-08-22 17:42:50 +09:00
  41756520b1
• Merge branch 'master' into mania-combo-counter
  Dean Herbert · 2024-08-14 15:12:00 +09:00
  e465049050
• Merge pull request #29403 from smoogipoo/fix-catch-missing-objects

  Fix fruit positions getting mangled when exploded from the plate

  Dean Herbert · 2024-08-14 00:59:56 +09:00
  1b29b9bbb8
• Add failing test
  Dan Balasescu · 2024-08-13 18:34:28 +09:00
  93c1a27f22
• Merge branch 'master' into mania-combo-counter
  Dean Herbert · 2024-08-09 00:19:17 +09:00
  e645651ef4
• Merge branch 'master' into ruleset-specific-combo-counter
  Dean Herbert · 2024-08-08 03:21:52 +09:00
  3c572abaa7
• Fix tests
  Bartłomiej Dach · 2024-07-23 09:13:43 +02:00
  6100f5269d
• Fix tests
  Bartłomiej Dach · 2024-07-22 13:37:24 +02:00
  1d91201c43
• Update test to match new behaviour
  Salman Ahmed · 2024-07-04 06:22:53 +03:00
  e4f90719ed
• Add failing test coverage for replay detach
  Bartłomiej Dach · 2024-07-03 10:19:55 +02:00
  7f1d113454
• Merge branch 'master' into ruleset-specific-combo-counter
  Salman Ahmed · 2024-07-01 08:31:40 +03:00
  dce1b4ec6c
• Add test for correct juice stream tick counts in editor

  cda9440a29 inadvertently fixes this in the
  most frequent case by inverting the `TickDistanceMultiplier` from being
  not-1 to 1 on beatmap versions above v8.
  
  This can still potentially go wrong if a beatmap from a version below v8
  is edited, because upon save it will be reencoded at the latest version,
  meaning that the multiplier will change from not-1 to 1 - but this can
  be handled separately.

  Bartłomiej Dach · 2024-06-28 11:58:07 +02:00
  deeb2e99a2
• Make list of breaks bindable
  Bartłomiej Dach · 2024-06-19 07:44:03 +02:00
  6a6ccbc09f
• Merge branch 'master' into ruleset-specific-combo-counter
  Bartłomiej Dach · 2024-06-04 15:44:11 +02:00
  5fcea01c13
• Add failing test case for catch conversion

  Test is an abridged / cropped version of
  https://osu.ppy.sh/beatmapsets/971028#fruits/2062131 to demonstrate
  the specific failure case (unfortunately can't use the whole beatmap
  due to other conversion failures).

  Bartłomiej Dach · 2024-05-28 13:13:17 +02:00
  96af0e1ec3
• Merge pull request #27723 from 64ArthurAraujo/editor-fix-reverse-selection

  Fix reverse selection not updating new combo location

  Bartłomiej Dach · 2024-03-28 11:25:17 +01:00
  21201e616d
• Simplify tests
  Bartłomiej Dach · 2024-03-28 10:05:26 +01:00
  a9cbabf711
• Add reverse pattern visual tests
  Arthur Araujo · 2024-03-27 08:22:51 -03:00
  60c93d2c6d
• Merge branch 'master' into verify-abnormal-difficulty-settings
  Bartłomiej Dach · 2024-03-26 11:13:16 +01:00
  b74f8dba41
• Fix code quality issues
  Bartłomiej Dach · 2024-03-26 10:55:49 +01:00
  9b923b1909
• Make check ruleset specific
  Arthur Araujo · 2024-03-22 14:48:22 -03:00
  6fa663c8ca
• Add test for banana shower fail
  Dan Balasescu · 2024-03-20 17:31:11 +09:00
  66ace02e58
• Merge pull request #27456 from frenzibyte/catch-hr-issues

  Fix catch fruit position getting randomised when last fruit has zero position

  Bartłomiej Dach · 2024-03-05 14:23:27 +01:00
  f91423a775
• Merge branch 'master' into catch-fail-on-banana
  Dan Balasescu · 2024-03-04 13:13:26 +09:00
  5bd037fe8f
• Add failing catch beatmap
  Salman Ahmed · 2024-03-02 03:18:59 +03:00
  82373ff752
• Merge branch 'master' into judgements-rework
  Andrei Zavatski · 2024-02-16 20:08:57 +03:00
  dd32c0a226
• Update other VS code configuration files
  Salman Ahmed · 2024-02-16 01:45:30 +03:00
  ec85bf0ae6