Bartłomiej Dach
fe0af7e720
Fix unnecessary padding of empty strings for discord RPC purposes
...
Closes https://github.com/ppy/osu/issues/28248 .
Destroy all software.
2024-05-20 11:37:35 +02:00
Bartłomiej Dach
a3dfd99f7d
Fix discord arbitrarily refusing to work on "too short" strings
...
Closes https://github.com/ppy/osu/issues/28192 .
2024-05-16 18:24:51 +02:00
Dan Balasescu
03e13ddc30
Globally silence Discord RPC registration failures
2024-04-17 17:10:19 +09:00
Dan Balasescu
c7f3a599c9
Fix crash when entering multiplayer on macOS
2024-04-13 13:17:06 +09:00
Dan Balasescu
7d8fe51178
Fix possible crash due to race in DiscordRichPresence
2024-04-08 23:33:42 +09:00
Dan Balasescu
fb8fb4f34e
Disable Discord URI registration on macOS for now
2024-04-04 16:43:26 +09:00
Bartłomiej Dach
53c3aec3c3
Fix discord RPC errors in multiplayer
...
Reproduction steps:
1. Go to multiplayer
2. Create a room
3. Play a map to completion
4. Wait for "secrets cannot currently be sent with buttons" error
messages
The fix is to clear the buttons since they're the less important ones.
2024-03-25 18:05:00 +01:00
Bartłomiej Dach
a398754a27
Merge all presence methods into one
...
I'm about to make them interdependent (and it's discord's fault),
so it doesn't really make sense to make them separate at this point
I don't think. And it felt weird anyway.
2024-03-25 18:00:42 +01:00
Bartłomiej Dach
e95f29cf4b
Rename updatePresence() => schedulePresenceUpdate()
...
The method doesn't actually update anything by itself, and I want to
free up the `updatePresence()` name for the actual update.
2024-03-25 17:57:13 +01:00
Bartłomiej Dach
3db88fbcea
Use less confusing message format when logging discord errors
...
The "code" is a number, so it looked weird when put in the middle
without any nearby punctuation. Example:
An error occurred with Discord RPC Client: 5005 secrets cannot currently be sent with buttons
2024-03-25 17:54:20 +01:00
Salman Ahmed
5f86b5a2fa
Use DI correctly
2024-03-20 07:36:15 +03:00
Salman Ahmed
b11ae1c571
Organise code, still hook up to RoomChanged to update room privacy mode, and use SkipIdenticalPresence + scheduling to avoid potential rate-limits
2024-03-20 07:28:01 +03:00
jvyden
1a08dbaa2b
Fix code style
2024-03-19 17:03:30 -04:00
jvyden
4305c3db5b
Show login overlay when joining room while not logged in
2024-03-19 16:15:22 -04:00
jvyden
c71daba4f6
Improve logging of RPC
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2024-03-19 16:05:13 -04:00
jvyden
0ecfa580d7
Move room code from activity code, prevent duplicate RPC updates
2024-03-19 16:03:37 -04:00
jvyden
808d6e0943
Prevent potential threading issues
2024-03-19 16:02:06 -04:00
jvyden
e4e7dd14f3
Revert "Update presence on changes to multiplayer room"
...
This reverts commit 8b730acb08
2024-03-11 18:16:13 -04:00
jvyden
5580ce31fa
Log Discord RPC updates
2024-03-11 18:15:18 -04:00
Salman Ahmed
8b730acb08
Update presence on changes to multiplayer room
2024-03-11 13:16:00 +03:00
Salman Ahmed
169e2e1b4e
Change maximum room number to closest powers of two
2024-03-11 13:16:00 +03:00
Dean Herbert
226df7163e
Update client ID
2024-03-11 16:55:49 +08:00
Salman Ahmed
283de215d3
Adjust log message and comment
2024-03-11 01:17:17 +03:00
jvyden
98ca021e66
Catch and warn about osu!stable lobbies
2024-03-06 01:17:37 -05:00
Jayden
9871300317
Improve language of user-facing errors
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-03-05 18:22:39 -05:00
jvyden
b53777c2a4
Refactor room secret handling to use JSON
...
Also log room secrets for debugging purposes
2024-03-05 18:21:26 -05:00
Jayden
cceb616a18
Update failure messages
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2024-03-04 22:25:36 -05:00
Jayden
37e7a4dea7
Fix yapping
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2024-03-01 14:32:44 -05:00
jvyden
92235e7789
Make truncate and getBeatmapID static
...
Code quality was complaining about hidden variables so I opted for this solution.
2024-03-01 00:02:20 -05:00
jvyden
060e17e989
Support Discord game invites in multiplayer lobbies
2024-02-29 23:41:40 -05:00
Salman Ahmed
c69c881cd3
Combine conditionals and remove "InLobby" check
2024-02-28 07:58:02 +03:00
jvyden
e053c08f6b
Hide social interactions while in Do Not Disturb
2024-02-27 16:23:36 -05:00
jvyden
8934cf33f0
Apply Discord RPC changes regardless of user's status
2024-02-23 22:29:09 -05:00
Bartłomiej Dach
d66fa09320
Simplify UserStatus to be an enumeration type
...
There were absolutely no gains from having it be a reference type /
class, only complications, especially when coming from the serialisation
angle.
2023-12-06 18:52:27 +01:00
Bartłomiej Dach
cb823f367f
Simplify UserActivity for serialisability over the wire
...
Up until now, the `UserActivity` class hierarchy contained things like
beatmap info, room info, full replay info, etc. While this was
convenient, it is soon going to be less so, as the data is sent over the
wire to the spectator server so that the user's activity can be
broadcast to other clients.
To counteract this without creating a second separate and slimmed-down
class hierarchy, slim down the `UserActivity` structure to contain the
bare minimum amounts of data such that the structures aren't overly
large and complex to serialise, but also contain enough data that they
can be used by receiving clients directly without having to do beatmap
or score lookups.
2023-12-06 18:52:26 +01:00
Bartłomiej Dach
17aac0694e
Re-enable connection retrying on discord connector
2023-07-17 19:19:03 +02:00
Dean Herbert
d74b1e148d
Make ScoreInfo.BeatmapInfo nullable
2023-07-04 14:50:34 +09:00
Joseph Madamba
afb66d8af4
Make user activity class names more specific
2023-02-12 12:32:17 -08:00
tsrk
da10166628
quality: convert getter property to method so that sensible information can be hidden via an argument
2023-02-06 21:30:55 +00:00
tsrk
bc89f8dc5b
feat: add name and rulset verb display support
2023-02-06 12:44:00 +00:00
Dan Balasescu
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
andy840119
11a4bb5833
Prevent return the null value.
2022-08-02 22:29:54 +08:00
andy840119
78cc28d75f
Remove nullable disable annotation and fix the api broken.
2022-08-02 22:29:54 +08:00
Dean Herbert
31a447fda0
Update parameter discards
2022-06-24 21:26:19 +09:00
Dan Balasescu
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
Dean Herbert
c55c7becba
Always use current ruleset to ensure URL is valid
2022-06-15 02:38:44 +09:00
Dean Herbert
1951eb30bc
Remove call to RegisterUriScheme
...
Seems both unnecessary, and crashes the whole came on macOS.
2022-06-15 02:27:51 +09:00
Dean Herbert
0d36495cfc
Fix up code quality, use more correct URL and update button text
2022-06-15 02:25:06 +09:00
Dean Herbert
cf82843e3d
Merge branch 'master' into jaxxibae/master
2022-06-15 02:15:24 +09:00
Dean Herbert
3799689c7d
Tidy up variable naming and layout
2022-06-09 12:32:30 +09:00
