49450 Commits

This Branch

This Branch

All Branches

• Use correct fonts and colours in ChannelListingItem
  Jai Sharma · 2022-03-09 00:36:19 +00:00
  7daa2d0ea4
• Reorder class attributes
  Jai Sharma · 2022-03-09 00:12:44 +00:00
  7dd51a9c4a
• Implement ChannelListing for new chat design

  Adds components `ChannelListing` and `ChannelListing` item with visual
  test. Essentially a more simplified version of the existing
  `ChannelSelectionOverlay` component.
  
  Correctly implements `IFilterable` behaviour to filter child channel
  items. Channel joined state is based on the underlying `Joined` bindable
  of the `Channel` class.
  
  Channel join/leave events are exposed via `OnRequestJoin` and
  `OnRequestLeave` events which should be handled by parent component.
  
  Requires a cached `OverlayColourScheme` instance to be provided by the
  parent overlay component when added.

  Jai Sharma · 2022-03-08 22:30:58 +00:00
  a3477c3841
• Merge pull request #17167 from peppy/fix-download-button-test-failure

  Fix potential test failure on slow realm callback in `TestSceneBeatmapDownloadButton`

  Dan Balasescu · 2022-03-09 01:49:23 +09:00
  714789f726
• Merge pull request #17166 from peppy/fix-realm-skin-dropdown-failure

  Fix potential crash on rare incorrect firing of skin dropdown update methods

  Dan Balasescu · 2022-03-09 01:46:31 +09:00
  74fe1e8e47
• Merge pull request #17165 from smoogipoo/fix-intermittent-test

  Fix intermittent multiplayer ready button test failures

  Dean Herbert · 2022-03-09 01:16:38 +09:00
  821de83e54
• Fix potential test failure on slow realm callback in TestSceneBeatmapDownloadButton

  As brought to light by https://gist.github.com/smoogipoo/56eda7ab56b9d1966556f2ca7a80a847.

  Dean Herbert · 2022-03-09 01:11:46 +09:00
  56ad684f5b
• Fix potential crash on rare incorrect firing of skin dropdown update methods

  As brought to light by https://gist.github.com/smoogipoo/56eda7ab56b9d1966556f2ca7a80a847.
  
  There's a chance that the dropdown is not populated by the time
  `updateSelectedSkinFromConfig` is fired via an external means (config
  changes).

  Dean Herbert · 2022-03-09 01:08:13 +09:00
  a2ef086c1f
• Fix intermittent test failure
  Dan Balasescu · 2022-03-09 00:48:12 +09:00
  729af28a64
• Fix test failure ripple through entire TestScene
  Dan Balasescu · 2022-03-09 00:48:03 +09:00
  94d5e2f264
• Merge pull request #17157 from peppy/fix-statistics-json-serialisation

  Fix incorrect serialisation of submitted scores

  Dan Balasescu · 2022-03-08 20:20:31 +09:00
  a352a140bc
• Merge pull request #17160 from peppy/remove-unnecessary-user-submittable-score

  Remove `user` from `SubmittableScore`

  Dan Balasescu · 2022-03-08 19:34:47 +09:00
  4603e082f5
• Merge pull request #17159 from smoogipoo/add-hitresult-helper

  Add IsBasic() and IsTick() extensions on HitResult

  Dean Herbert · 2022-03-08 18:46:39 +09:00
  e0dc3a04f3
• Remove user from SubmittableScore

  This wasn't being used by osu-web, and included far too much unnecessary
  data. Of note, `pp` and `ruleset_id` are also not strictly required, but
  there's no harm in sending them so I've left them be for now.

  Dean Herbert · 2022-03-08 18:38:24 +09:00
  b0f40d9e45
• Add IsBasic() and IsTick() extensions on HitResult
  Dan Balasescu · 2022-03-08 18:19:12 +09:00
  a172fc6cb8
• Add test coverage of SubmittableScore serialisation to (roughly) match spec
  Dean Herbert · 2022-03-08 17:58:52 +09:00
  9a347af5c7
• Add EnumMember naming to HitResult to allow for correct json serialisation
  Dean Herbert · 2022-03-08 17:58:37 +09:00
  589a40ca2d
• Merge pull request #17155 from peppy/beatmap-leaderboard-dont-handle-offset-changes

  Fix `BeatmapLeaderboard` refreshing on changes in local offset setting

  Dan Balasescu · 2022-03-08 15:38:05 +09:00
  719331420c
• Fix BeatmapLeaderboard refreshing on unrelated changes to a beatmap
  Dean Herbert · 2022-03-08 14:50:47 +09:00
  622ec53130
• Add extension method to detect and isolate realm collection-level changes
  Dean Herbert · 2022-03-08 14:50:47 +09:00
  2a55c5e02e
• Merge pull request #17046 from peppy/clowd-squirrel

  Replace squirrel fork with `Clowd.Squirrel`

  Dan Balasescu · 2022-03-07 16:25:40 +09:00
  e0d2c8ca5e
• Merge pull request #17075 from peppy/realm-property-watching

  Add ability to watch properties via a `RealmAccess` helper method

  Dan Balasescu · 2022-03-07 14:38:23 +09:00
  51f6eb4028
• Merge branch 'master' into realm-property-watching
  Dean Herbert · 2022-03-07 13:53:17 +09:00
  31d6c75f40
• Merge pull request #17138 from peppy/disallow-icon-interaction

  Disallow interaction with carousel set difficulty icons unless selected

  Dan Balasescu · 2022-03-07 13:00:18 +09:00
  b90a5864b1
• Disallow interaction with carousel set difficulty icons unless selected

  I kinda liked this flow, but from multiple reports from users it
  definitely seems in the way. We can revisit after the new design is
  applied to song select.
  
  Note that this means the tooltips also don't display. If it is preferred
  that they should (arguable from a UX perspective, since I'd expect to be
  able to click at that point) then the issue can be addressed using a
  slightly different path (a few more lines - nothing too complex).

  Dean Herbert · 2022-03-07 11:34:08 +09:00
  da29947ecd
• Merge pull request #17115 from frenzibyte/manual-channel-scroll

  Refactor channel scrolling container to handle non-user scrolls

  Dean Herbert · 2022-03-07 11:26:23 +09:00
  bd1adaf245
• Merge pull request #17134 from bdach/mod-overlay/popup-screen-title

  Implement popup screen title component

  Dan Balasescu · 2022-03-07 11:03:38 +09:00
  ba83db0229
• Merge pull request #17059 from frenzibyte/fix-storyboard-sample-rate

  Fix storyboard samples rate not adjusted from actual gameplay mods

  Dean Herbert · 2022-03-07 09:41:06 +09:00
  3e73b8c78a
• Merge branch 'master' into fix-storyboard-sample-rate
  Salman Ahmed · 2022-03-07 03:12:40 +03:00
  e5a6564034
• Remove no longer necessary CancelUserScroll method
  Salman Ahmed · 2022-03-06 23:58:06 +03:00
  d9be65ea39
• Revert UserTrackingScrollContainer changes
  Salman Ahmed · 2022-03-06 23:57:51 +03:00
  60334046e4
• Add xmldoc to trackNewContent to explain its purpose
  Salman Ahmed · 2022-03-06 23:51:27 +03:00
  a13a087f5d
• Move scrolling to UpdateAfterChildren to avoid scheduling

  At least that's what I believe "let FillFlow update to new size" means.

  Salman Ahmed · 2022-03-06 23:50:58 +03:00
  9ec0e74813
• Further refactor and simplify ChannelScrollContainer
  Salman Ahmed · 2022-03-06 23:34:12 +03:00
  9bc1f3f014
• Use text flow container in popup screen title
  Bartłomiej Dach · 2022-03-06 20:41:31 +01:00
  54275813b5
• Implement popup screen title component
  Bartłomiej Dach · 2022-03-06 16:09:18 +01:00
  df0617f34c
• Merge pull request #17116 from bdach/sample-popover-tabbing

  Allow tabbing between textboxes in sample point popover

  Dean Herbert · 2022-03-06 11:45:16 +09:00
  e322eb578a
• Allow tabbing between textboxes in sample point popover
  Bartłomiej Dach · 2022-03-06 01:43:56 +01:00
  e1eeb9c6bb
• Use the term "programmatically" instead
  Salman Ahmed · 2022-03-06 00:01:45 +03:00
  634821e49f
• Refactor channel scrolling container to handle manual scrolls resiliently
  Salman Ahmed · 2022-03-05 23:27:07 +03:00
  5b3ffb12b7
• Merge pull request #17093 from peppy/offset-ui-improvements

  Show beatmap offset adjustments in a more visual way

  Dean Herbert · 2022-03-06 02:17:36 +09:00
  2022.306.0 4de66bb1c6
• Switch step to Until steps due to AddOnce firing logic
  Dean Herbert · 2022-03-06 01:50:25 +09:00
  0e8ad4b143
• Use const for minimum height specification in final usage location

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2022-03-06 01:01:22 +09:00
  06512e8bd9
• Don't consider judgements beneath the minimum height as being applicable

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2022-03-06 01:00:47 +09:00
  f8ef352306
• Revert "Fix potential crash in tests when attempting to lookup key bindings in cases the lookup is not available"

  This reverts commit 8115a4bb8f.
  
  Commit was cherrypicked out to a separate pull on a different merge
  base, then reverted in that pull, so it should be reverted here too.

  Bartłomiej Dach · 2022-03-05 16:42:51 +01:00
  08b3bc222d
• Merge branch 'master' into offset-ui-improvements
  Bartłomiej Dach · 2022-03-05 16:10:18 +01:00
  e4b4c3c5c4
• Merge pull request #17087 from peppy/combine-time-slider-implementation

  Centralise implementation of slider bars which display millisecond time values

  Dean Herbert · 2022-03-05 23:48:26 +09:00
  6264dd266d
• Merge pull request #17073 from peppy/add-offset-adjust-tooltip-text

  Add tooltip text for offset adjustment slider

  Dean Herbert · 2022-03-05 23:28:24 +09:00
  faddc20dca
• Merge pull request #17047 from peppy/add-display-choice-dropdown

  Add ability to select which display the game runs on

  Bartłomiej Dach · 2022-03-05 15:12:06 +01:00
  cdd7e0b741
• Merge branch 'add-offset-adjust-tooltip-text' into combine-time-slider-implementation
  Bartłomiej Dach · 2022-03-05 14:58:56 +01:00
  346cec3577