Dean Herbert
7a23363d74
Add migration of song progress setting from config to component
2022-04-27 18:10:58 +09:00
Dean Herbert
e6bb5e84ec
Merge branch 'master' into move-difficulty-graph-toggle
2022-04-27 17:22:25 +09:00
Dean Herbert
26f34e8fb9
Merge pull request #17991 from frenzibyte/invoke-all-fail-conditions
...
Fix `HealthProcessor` fail conditions not handling multiple invocations
2022-04-27 16:31:36 +09:00
Salman Ahmed
8842847b18
Fix wrong result applied
2022-04-27 00:05:49 +03:00
Salman Ahmed
1676c2c3f6
Change boolean argument to HitResult
instead
2022-04-27 00:05:15 +03:00
Salman Ahmed
cccc9d7d39
Rename method to better reflect what it's doing
2022-04-27 00:03:48 +03:00
Salman Ahmed
fb6a112708
Mark OsuModTarget
and OsuModSuddenDeath
as mutually exclusive
...
`OsuModTarget` already fails on miss, so "Sudden Death" doesn't make
sense to be enabled and may only cause issues.
2022-04-26 23:27:03 +03:00
Salman Ahmed
31f64b1381
Fix HealthProcessor
fail conditions not handling multiple invocations
2022-04-26 23:27:03 +03:00
Salman Ahmed
a884f20c65
Add failing test case
2022-04-26 23:27:03 +03:00
Joseph Madamba
b82ccb816c
Merge pull request #17988 from frenzibyte/use-correct-translation
...
Use correct translation for "Accuracy" label in break overlay
2022-04-26 09:42:43 -07:00
Salman Ahmed
e646233722
Use correct translation for "Accuracy" label in break overlay
2022-04-26 19:16:36 +03:00
Dan Balasescu
e9d1982a7f
Merge pull request #17982 from peppy/sheared-button
...
Add basic sheared button implementation
2022-04-26 19:54:06 +09:00
Salman Ahmed
8880ff16c3
Merge branch 'master' into sheared-button
2022-04-26 13:09:10 +03:00
Dan Balasescu
b19e738315
Merge pull request #17913 from molneya/hold-addition-fix
...
Fix mania SR inflation for hold note releases in quick succession
2022-04-26 18:31:07 +09:00
Salman Ahmed
9911f3658f
Merge pull request #17980 from peppy/fix-joystick-bindable-mayhe
2022-04-26 12:27:22 +03:00
Dean Herbert
4a370f429e
Reorder initialisation of bindable action binding to make more sense
2022-04-26 18:21:46 +09:00
Dean Herbert
52a8f3848d
Expose font size and add big button test
2022-04-26 18:14:57 +09:00
Dean Herbert
cd197a9380
Reduce the hover lightening effect slightly
2022-04-26 18:11:03 +09:00
Salman Ahmed
6e83aceaf9
Merge branch 'master' into fix-joystick-bindable-mayhe
2022-04-26 12:05:09 +03:00
Dan Balasescu
c37e87d92f
Merge pull request #17981 from peppy/osu-button-click-flash
...
Fix all buttons gamewide not animating properly on click
2022-04-26 18:04:32 +09:00
Dean Herbert
4bc4ff179a
Add flash effect on click
2022-04-26 18:03:34 +09:00
Dean Herbert
6864623bac
Add ShearedButton
test coverage
2022-04-26 18:03:27 +09:00
Dean Herbert
4e260e7410
Fix all buttons gamewide not animating properly on click
...
Not sure how or when this happened.
2022-04-26 17:32:25 +09:00
Dean Herbert
9f33e627de
Split out ShearedButton
from ShearedToggleButton
2022-04-26 17:31:55 +09:00
Dean Herbert
c52c08fe97
Rename test to increase scope
2022-04-26 17:31:39 +09:00
Dean Herbert
280cd048f6
Fix joystick settings changing enabled state of config level bindables
...
Just copied what we had in place for the mouse sensitivity setting. For
tablet settings I believe I avoided this by just hiding the settings
when not enabled. Might be a better way forward, but this is simplest
for now.
Run `TestSceneSettingsPanel` twice to get a crash without this change.
2022-04-26 17:31:28 +09:00
Dan Balasescu
dc0f1a9419
Merge pull request #17979 from peppy/first-run-show-get-started
...
Improve displayed text on first run setup back/next buttons
2022-04-26 17:04:03 +09:00
Dean Herbert
a078440012
Show last step on back button as well
2022-04-26 16:03:17 +09:00
Dean Herbert
37ae39f5fe
Move "Next" localisation to common strings
2022-04-26 15:48:40 +09:00
Dan Balasescu
9d198ad6bb
Merge pull request #17972 from peppy/hotfix-context-menu
...
Fix windows taskbar context menu not popping up correctly
2022-04-26 13:52:02 +09:00
Dan Balasescu
9911584fe1
Merge pull request #17977 from peppy/show-during-gameplay-improvement
...
Change conditions for HUD being shown to include pause/fail states
2022-04-26 12:55:31 +09:00
Dean Herbert
8ab3636f87
Change conditions for HUD being shown to include pause/fail states
...
As proposed in https://github.com/ppy/osu/discussions/17975 . Feels pretty good to me, and probably how it should have been implemented from the start.
2022-04-26 12:09:21 +09:00
Dean Herbert
d310886c26
Add test coverage of IsPlaying
state during fail and pause
2022-04-26 12:09:18 +09:00
Dan Balasescu
51b4821efa
Merge pull request #17976 from frenzibyte/improve-score-grading
...
Change score accuracy grading logic to be inclusive
2022-04-26 12:06:58 +09:00
Salman Ahmed
7d32490198
Change score accuracy grading logic to be inclusive
2022-04-26 04:55:27 +03:00
Salman Ahmed
f958010d29
Fix AccuracyCircle
storing accuracy values in float
2022-04-26 04:52:48 +03:00
Dean Herbert
5e48b37569
Show "Get Started" text on first run button
2022-04-25 23:59:07 +09:00
Dean Herbert
ed894d6428
Merge pull request #17941 from frenzibyte/remove-legacy-skin-fallback
...
Handle all legacy skin component types explicitly and remove texture fallback
2022-04-25 21:55:05 +09:00
Dean Herbert
3284a464a9
Merge pull request #17952 from frenzibyte/scene-library-incompatible-mods
...
Deselect mods incompatible with "Autoplay" when entering gameplay via scene library
2022-04-25 19:56:50 +09:00
Dean Herbert
d2780c2c50
Add a touch more detail to the unsupported skin component exception
2022-04-25 19:06:47 +09:00
Dean Herbert
7ac3ba132c
Remove unused using statements
2022-04-25 18:55:12 +09:00
Dean Herbert
a0e80cf901
Merge branch 'master' into scene-library-incompatible-mods
2022-04-25 18:54:40 +09:00
Dean Herbert
7e9d51f33f
Fix windows taskbar context menu not popping up correctly
...
Closes https://github.com/ppy/osu/issues/17965 .
Note that this will cause a second osu! icon to appear after running the
application (after any update). As per the inline comment, this will
eventually be resolved via https://github.com/clowd/Clowd.Squirrel/issues/24 .
I do think having context menus working is more important than duplicate
icons.
Note that for anyone who already has a pinned taskbar icon, it will need
to be manually unpinned and repinned after a future update to actually
fix this issue.
Thanks to @caesay for help with investigation.
2022-04-25 18:37:41 +09:00
Dean Herbert
2d1cc2e5ea
Merge pull request #17962 from peppy/fix-scroll-container-regressions
...
Fix context menus not working
2022-04-24 22:38:43 +09:00
Dean Herbert
51aa17eb52
Fix context menus not working
2022-04-24 22:17:38 +09:00
Dean Herbert
07462384e8
Merge pull request #17930 from peppy/fix-song-select-music-control
...
Fix nested song select in first-run dialog fiddling with global audio
2022-04-24 19:18:27 +09:00
Dean Herbert
d92c905600
Actually use exposed property
2022-04-24 18:15:35 +09:00
Dean Herbert
21665f605a
Merge pull request #17937 from frenzibyte/settings-filter-regression-fix-2
...
Fix settings overlay components not invalidating presence on filter change
2022-04-24 18:12:34 +09:00
Dean Herbert
83970f009c
Merge branch 'master' into settings-filter-regression-fix-2
2022-04-24 17:40:25 +09:00
Dean Herbert
176d263252
Merge pull request #17942 from maromalo/master
...
Add joystick/gamepad deadzone setting
2022-04-24 17:39:48 +09:00