Dean Herbert
e8d4147773
Add missing null handling for never Markdig version
2021-06-07 16:08:44 +09:00
Dean Herbert
840f084dc4
Merge pull request #13303 from LeNitrous/mainmenu-storyboard-backgrounds
...
Add storyboards as a main menu background source
2021-06-04 19:50:40 +09:00
Dean Herbert
19a44d65c5
Tidy up code
2021-06-04 15:18:16 +09:00
Nathan Alo
996c156106
apply suggestions
...
- apply 0 alpha to beatmap background if storyboard replaces it
- use an AudioContainer to mute all samples coming from the storyboard
2021-06-04 13:56:10 +08:00
Nathan Alo
d7d0dde5d2
use created storyboard to check for drawables instead
2021-06-03 13:56:14 +08:00
Nathan Alo
62b07fb9ce
apply suggestions
...
- Replace the sprite with a solid black box when a storyboard requests it.
- Create a new storyboard instance and exclude the fail layer as well as strip all samples from it
- Do not attempt in creating the storyboard when it isn't needed
2021-06-03 13:27:00 +08:00
Nathan Alo
d00fb21188
prevent scaling container from creating a storyboard background
2021-06-03 13:24:21 +08:00
Dean Herbert
a62dd7cca0
Revert "refactor BeatmapBackgroundWithStoryboard to reduce overhead"
...
This reverts commit 277545bb06
2021-06-03 12:33:16 +09:00
Nathan Alo
277545bb06
refactor BeatmapBackgroundWithStoryboard to reduce overhead
...
This avoids loading the sprite if its not needed and instead of hiding it, it is removed when the storyboard replaces the background or there is a video.
This also only initializes DrawableStoryboard if there are any elements in any layer.
2021-06-02 20:27:12 +08:00
Nathan Alo
3c3ef13632
remove fade
2021-06-02 16:28:22 +08:00
Nathan Alo
e66f6e8f91
fix inspect code issues and cleanup code
2021-06-02 16:12:41 +08:00
Nathan Alo
dec18ef826
implement BeatmapBackgroundWithStoryboard
2021-06-02 15:50:58 +08:00
Dan Balasescu
47019196f6
Merge branch 'master' into fix-relative-link-resolution
2021-06-02 14:55:38 +09:00
Dean Herbert
ac761bb075
Use string.Empty instead of arbitrary string
2021-06-02 14:43:35 +09:00
Dean Herbert
3668f1861f
Fix one more null issue
2021-06-01 17:10:09 +09:00
Dean Herbert
145e42928b
Fix remaining null checks
2021-06-01 16:49:05 +09:00
Gagah Pangeran Rosfatiputra
b4dd935538
add corner radius and padding
2021-06-01 14:14:12 +07:00
Gagah Pangeran Rosfatiputra
5108dadfbc
use inline code in markdown text flow
2021-06-01 14:03:57 +07:00
Gagah Pangeran Rosfatiputra
1babb05fc7
add OsuMarkdownInlineCode
2021-06-01 14:03:31 +07:00
Dean Herbert
3ff97f787a
Localise all URL generation for now to avoid weird Schedule logic
2021-06-01 13:56:59 +09:00
Gagah Pangeran Rosfatiputra
e02739a136
remove unused colour provider
2021-05-26 13:57:35 +07:00
Gagah Pangeran Rosfatiputra
04f16c0783
Set DocumentUrl inside CreateChildDependencies
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2021-05-26 13:55:16 +07:00
Dean Herbert
200592114f
Make protected variables private
2021-05-26 14:13:02 +09:00
Gagah Pangeran Rosfatiputra
728258d93a
add website root url as document url
2021-05-25 00:29:59 +07:00
Gagah Pangeran Rosfatiputra
02cdd0b2de
use drawable link compiler in markdown link
2021-05-24 19:10:37 +07:00
Dean Herbert
b0a113a36b
Merge branch 'master' into localisation-proof-of-concept
2021-05-21 17:57:54 +09:00
Dean Herbert
0f4b502fdf
Add missing xmldoc
2021-05-20 20:09:22 +09:00
Dean Herbert
df5970fab4
Create base implementations of the two most common TernaryStateMenuItems
2021-05-20 19:34:53 +09:00
Dan Balasescu
ce7c503e6e
Merge branch 'master' into playlist-unicode
2021-05-17 11:47:10 +09:00
Dean Herbert
1bb3c609ae
Centralise implementation of cancel button logic
2021-05-11 18:39:14 +09:00
Gagah Pangeran Rosfatiputra
bca5bee72e
remove duplicate CreateSpriteText in OsuMarkdownTextFlowContainer
2021-05-10 19:28:32 +07:00
Dan Balasescu
e7355da201
Merge branch 'master' into osu-markdown
2021-05-10 20:02:04 +09:00
smoogipoo
cd25d76dbe
Merge branch 'master' into localisation-proof-of-concept
2021-05-08 18:11:07 +09:00
Gagah Pangeran Rosfatiputra
22677cfeaf
add CreateBorder method in markdown table cell
2021-05-07 14:54:46 +07:00
Gagah Pangeran Rosfatiputra
d92e593ddd
extract out table head and body border into separate component
2021-05-07 14:47:46 +07:00
Gagah Pangeran Rosfatiputra
64e9c5e9ba
add return xmldoc in markdown unordered list
2021-05-07 14:41:27 +07:00
Gagah Pangeran Rosfatiputra
79a1d7b2b3
simplify CreateEmphasisedSpriteText
2021-05-07 14:40:01 +07:00
Gagah Pangeran Rosfatiputra
17b8963cf8
simplify CreateSpriteText in markdown table cell
2021-05-07 14:38:19 +07:00
Gagah Pangeran Rosfatiputra
3524cb7924
simplify CreateSpriteText in markdown heading
2021-05-07 14:36:35 +07:00
Dean Herbert
01eff7f316
Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-score-display
2021-05-07 16:30:08 +09:00
Dean Herbert
a2e4fb5b6b
Update ScoreCounter components to bind outwards
2021-05-07 16:16:48 +09:00
Gagah Pangeran Rosfatiputra
5b003750f8
change CreateListItem method in OsuMarkdownContainer
2021-05-07 13:20:48 +07:00
Gagah Pangeran Rosfatiputra
9233248a0b
add OsuMarkdownUnorderedListItem
2021-05-07 13:20:20 +07:00
Gagah Pangeran Rosfatiputra
dfcf760b7b
add OsuMarkdownOrderedListItem
2021-05-07 13:20:06 +07:00
Gagah Pangeran Rosfatiputra
bdfe44ddca
change OsuMarkdownListItem to abstract class
2021-05-07 13:19:30 +07:00
Gagah Pangeran Rosfatiputra
92022f2cba
add Separator component in OsuMarkdownSeparator
2021-05-06 17:17:14 +07:00
Gagah Pangeran Rosfatiputra
7b43730fe6
add QuoteBackground in OsuMarkdownQuoteBlock
2021-05-06 17:13:46 +07:00
Gagah Pangeran Rosfatiputra
010f625870
use derived component in OsuMarkdownFencedCodeBlock
2021-05-06 17:05:41 +07:00
Gagah Pangeran Rosfatiputra
67f51959db
Merge branch 'master' into osu-markdown
2021-05-06 16:23:20 +07:00
Gagah Pangeran Rosfatiputra
ba634cbf11
change line spacing to 21
...
We use margin bottom in osu-web markdown paragraph[1] as reference for
this line spacing value.
The value from osu-web itself is 1.5em[2]. Because the base font size of
the paragraph is 14px[3][4], the actual value is 14 * 1.5 = 21px
[1] 376cac43a0/resources/assets/less/bem/osu-md.less (L230)376cac43a0/resources/assets/less/variables.less (L58)376cac43a0/resources/assets/less/bem/osu-md.less (L9)376cac43a0/resources/assets/less/variables.less (L161)
2021-05-06 15:15:50 +07:00
