Dean Herbert
804b1b0d88
Fix settings colour scheme wrong when viewing gameplay from skin editor button
...
Closes https://github.com/ppy/osu/issues/27949 .
2024-04-23 20:54:48 +08:00
Bartłomiej Dach
12acdeebf1
Merge pull request #27866 from Joehuu/fix-online-score-export
...
Fix replay export not working correctly from online leaderboards
2024-04-23 09:08:04 +02:00
Bartłomiej Dach
1f010c4bfd
Merge pull request #27808 from smoogipoo/fix-incorrect-pp-counter
...
Fix gameplay PP counter not matching results screen
2024-04-23 08:43:49 +02:00
Joseph Madamba
49154c0e23
Fix code quality
2024-04-22 11:23:38 -07:00
Joseph Madamba
35eddf35c5
Return Task.CompletedTask instead of null
2024-04-22 11:22:39 -07:00
Joseph Madamba
a59bf6d373
Improve xmldoc wording
2024-04-22 11:17:27 -07:00
Joseph Madamba
2eda56ff08
Revert beatmap query change
2024-04-22 11:15:50 -07:00
Bartłomiej Dach
70a5288a68
Do not attempt to pass files that don't look like audio to BASS
2024-04-22 10:45:09 +02:00
Bartłomiej Dach
78f97d0ec7
Merge branch 'master' into verify-check-incorrect-audio-formats
2024-04-22 10:34:14 +02:00
Bartłomiej Dach
ceeb9b0819
Use explicit reference equality check
2024-04-22 10:27:30 +02:00
Bartłomiej Dach
1bcf835d22
Remove redundant array type specification
2024-04-22 10:25:46 +02:00
Arthur Araujo
49563f4e5b
Use bitwise to check hitsound formats
2024-04-22 04:44:38 -03:00
Dan Balasescu
89a4a6878f
Merge pull request #27922 from peppy/quick-exit-from-results
...
Add ability to quick exit from results screen
2024-04-22 16:01:13 +09:00
Andrei Zavatski
1d3fd65d86
Adjust execution order
2024-04-22 07:02:49 +03:00
Andrei Zavatski
722fa228ce
Don't consider editor table content for input
2024-04-21 17:40:35 +03:00
Dean Herbert
b9b341affd
Merge pull request #27930 from peppy/update-framework
...
Update framework
2024-04-20 05:26:53 +08:00
Dean Herbert
4cffc39dff
Don't require hold for quick exit at results screen
2024-04-20 04:53:31 +08:00
Bartłomiej Dach
3d64ffc93e
Merge pull request #27935 from smoogipoo/serialised-drawable-sane-defaults
...
Give SerialisedDrawableInfo sane defaults
2024-04-19 17:00:49 +02:00
Bartłomiej Dach
1344ca4e19
Merge pull request #27780 from mafarrica/27105-fix-mod-search-box-focus-changes
...
Fix mod search box not tracking external changes to focus state
2024-04-19 17:00:06 +02:00
Dan Balasescu
bac70da1a1
Give SerialisedDrawableInfo sane defaults
2024-04-19 22:03:19 +09:00
Dean Herbert
6e08fd7f27
Merge pull request #27931 from smoogipoo/remove-unused-lookup-members
...
Remove unused members from GameplaySkinComponentLookup
2024-04-19 20:51:09 +08:00
Dan Balasescu
ddc1b90ee1
Remove unused method
2024-04-19 20:36:24 +09:00
Arthur Araujo
92b85beff6
Remove ChannelType from messages
2024-04-19 08:01:23 -03:00
Arthur Araujo
68e86b5105
Remove unsued import and add a blankline before yield break;
2024-04-19 07:39:31 -03:00
Arthur Araujo
eac9dededf
Use periods instead of semicolons
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-04-19 07:20:59 -03:00
Bartłomiej Dach
509862490e
Revert unnecessary changes
2024-04-19 11:11:18 +02:00
Bartłomiej Dach
2dcbb823ef
Use textbox focus state directly rather than trying to track it independently
2024-04-19 11:08:34 +02:00
Dan Balasescu
362a7b2c77
Remove unused members from GameplaySkinComponentLookup
2024-04-19 18:03:13 +09:00
Dean Herbert
a41ae99dd7
Update framework
2024-04-19 15:14:52 +08:00
Dean Herbert
fe30c9ec2a
Merge branch 'master' into add-sound-to-tab-selection-change-2
2024-04-19 12:40:22 +08:00
Dean Herbert
c39eb5c5aa
Merge branch 'master' into upgrade-to-SDL3
2024-04-18 22:23:55 +08:00
Dean Herbert
46e2cfdba5
Update framework
2024-04-18 18:33:30 +08:00
Joseph Madamba
d08b1e5ae7
Add xmldoc to GetScore() and Export() and remove xmldoc from private getDatabasedScoreInfo()
2024-04-17 21:52:36 -07:00
Dean Herbert
f92833b588
Add ability to quick exit from results screen
2024-04-18 12:02:49 +08:00
Arthur Araujo
ac03856ebd
Fix test methods names
2024-04-17 08:22:05 -03:00
Arthur Araujo
8d94f8d995
Remove BassFlags.Prescan and free the decodeStream
2024-04-17 08:14:19 -03:00
Salman Ahmed
a7e043bdbe
Fix beatmap rulest selector playing sound for initial ruleset selection
2024-04-17 11:20:17 +03:00
Salman Ahmed
24e8b88320
Add inline comment to the custom implementation of multiple-selection tab items
2024-04-17 11:20:17 +03:00
Salman Ahmed
9e69268676
Change editor screen selection logic to use SelectItem for sound feedback
2024-04-17 11:20:17 +03:00
Salman Ahmed
42892acc1a
Fix multiple selection filter tab items no longer playing sounds
...
These tab items are not managed by a `TabControl`, activation events are manually served by the class itself toggling `Active` when clicked.
2024-04-17 11:20:17 +03:00
Salman Ahmed
50a21fb727
Change ToolbarRulesetSelector to use SelectItem to trigger new sound feedback path
2024-04-17 11:20:17 +03:00
Salman Ahmed
2a3ae6bce1
Update all TabItem implementations to play select sample on OnActivatedByUser
2024-04-17 11:20:17 +03:00
Bartłomiej Dach
6c943681b0
Fix preview tracks playing after their owning overlay has hidden
...
RFC. Closes https://github.com/ppy/osu/issues/27883 .
The idea here is that `PopOut()` is called _when the hide is requested_,
so once an overlay trigger would hide, the overlay would
`StopAnyPlaying()`, but because of async load things, the actual track
would start playing after that but before the overlay has fully hidden.
(That last part is significant because after the overlay has fully
hidden, schedules save the day.)
Due to the loose coupling between `PreviewTrackManager` and
`IPreviewTrackOwner` there's really no easy way to handle this locally
to the usages of the preview tracks. Heck, `PreviewTrackManager` doesn't
really know which preview track owner is to be considered _present_ at
any time, it just kinda works on vibes based on DI until the owner tells
all of its preview tracks to stop.
This solution causes the preview tracks to stop a little bit later but
maybe that's fine? Just trying to not overthink the issue is all.
No tests because this is going to suck to test automatically while it is
pretty easy to test manually (got it in a few tries on master).
The issue also mentions that the track can sometimes resume playing
after the overlay is pulled up again, but I don't see that as a problem
necessarily, and even if it was, it's not going to be that easy to
address due to the aforementioned loose coupling - to fix that, play
buttons would have to know who is the current preview track owner and
cancel schedules upon determining that their preview track owner has
gone away.
2024-04-16 16:19:26 +02:00
Arthur Araujo
c32d99250f
Deal with corrupt audio files
...
This removes the corrupt file check from CheckTooShortAudioFiles and makes the audio formats checks deal with it instead to avoid redundant messages.
2024-04-16 06:53:55 -03:00
Bartłomiej Dach
d2a67d2d54
Merge pull request #27881 from smoogipoo/fix-mod-refilter
...
Don't re-filter unless mods may change the filter
2024-04-16 11:21:35 +02:00
Arthur Araujo
9ef27104ce
Add checks for audio formats
2024-04-16 06:15:21 -03:00
Joseph Madamba
514e316b49
Make getDatabasedScoreInfo() private and move to GetScore() and Export()
2024-04-15 20:48:51 -07:00
Joseph Madamba
67cfcddc77
Use another beatmap query to not depend on databased score info
2024-04-15 20:18:24 -07:00
Dean Herbert
a651cb8d50
Stop background processing from running when inside a high performance session
2024-04-16 10:04:38 +08:00
Dean Herbert
d89edd2b4f
Expose high performance session state
2024-04-16 10:04:38 +08:00
