3203 Commits

• Rename localised string to something slightly more correct
  Dean Herbert · 2025-03-18 00:12:13 +09:00
  43d7918548
• Change CopyUrlToClipboard to CopyStringToClipboard
  GAMIS65 · 2025-03-14 10:02:41 +01:00
  f72de39e4d
• Use localisable string
  Bartłomiej Dach · 2025-03-13 08:37:02 +01:00
  c18764d764
• Remove unused using
  Bartłomiej Dach · 2025-03-13 08:36:19 +01:00
  3515f9a8f8
• Add support for team beatmap leaderboards
  Dean Herbert · 2025-03-13 16:28:20 +09:00
  b0cf5e8bff
• Add helper methods to check whether beatmap leaderboard scope requires supporter
  Dean Herbert · 2025-03-13 16:28:19 +09:00
  9af3c8351d
• Change ModSelectOverlay.ShowPresets to init
  Dean Herbert · 2025-03-04 22:32:13 +09:00
  dff354247e
• Flash footer freemod/freestyle buttons when active
  Dean Herbert · 2025-02-12 18:30:34 +09:00
  218151bb3c
• Merge branch 'master' into multiplayer-free-style
  Dean Herbert · 2025-01-24 17:23:35 +09:00
  1bfb4d4c2b
• Perform client side validation that the selected beatmap and ruleset have valid online IDs

  This is local to playlists, since in multiplayer the validation is
  already provided by `osu-server-spectator`.

  Dean Herbert · 2025-01-21 19:51:55 +09:00
  459847cb80
• Add tooltips explaining multiplayer mod selection buttons
  Dean Herbert · 2025-01-21 18:35:59 +09:00
  f88102610d
• Merge branch 'master' into multiplayer-free-style
  Dean Herbert · 2025-01-21 17:49:21 +09:00
  c68a0bc7e3
• Add back explicit right click handling of carousel absolute scrolling
  Dean Herbert · 2025-01-21 17:24:42 +09:00
  6c27e87714
• Don't highlight friends' scores under beatmap's friend score leaderboard
  CloneWith · 2025-01-20 00:21:10 +08:00
  72e1b2954c
• Move absolute scroll support local to carousel and allow custom bindings
  Dean Herbert · 2025-01-16 20:47:59 +09:00
  a6057a9f54
• Remove setting for right-mouse scroll (make it always applicable)
  Dean Herbert · 2025-01-16 20:27:38 +09:00
  56b450c4a6
• Update game ScrollContainer usage in line with framework changes

  See https://github.com/ppy/osu-framework/pull/6467.

  Dean Herbert · 2025-01-11 01:42:59 +09:00
  94ea003d90
• Merge pull request #31138 from bdach/mark-as-played

  Implement ability to mark beatmap as played

  Dean Herbert · 2024-12-24 21:43:15 +09:00
  62e536baf6
• Initial support for free style selection
  Dan Balasescu · 2024-12-23 20:12:25 +09:00
  638d959c5c
• Move "global" scroll-adjusts-volume to a per-screen component-based implementation
  Dean Herbert · 2024-12-16 15:21:07 +09:00
  bdd417c1a1
• Implement ability to mark beatmap as played

  Reported at https://osu.ppy.sh/community/forums/topics/2015478?n=1.
  
  Would you believe it that this button that has been there for literal
  years never did anything?
  
  Implemented at a per-beatmap level. Also additionally added to context
  menu (at @peppy's suggestion), and also copy reworded from "Delete from
  unplayed" to "Mark as played" because double negation hurt my tiny
  brain.

  Bartłomiej Dach · 2024-12-16 10:49:19 +09:00
  a6e00d6eac
• Move BeatmapInfoWedgeV2 to correct namespace
  Dean Herbert · 2024-12-12 12:53:05 +09:00
  862b41c38e
• Remove BeatmapCarousel testing backdoor
  Dean Herbert · 2024-12-11 16:28:51 +09:00
  a868c33380
• Access beatmap store via abstract base class

  The intention here is to make things more testable going forward.
  Specifically, to remove the "back-door" entrance into `BeatmapCarousel`
  where `BeatmapSets` can be set by tests and bypas/block realm retrieval.

  Dean Herbert · 2024-12-11 16:28:51 +09:00
  c94b393e30
• Remove no-longer-correct comment
  Dean Herbert · 2024-12-11 16:28:50 +09:00
  bab9b9c937
• Some Carousel classes can be abstract
  Dean Herbert · 2024-12-11 16:28:50 +09:00
  de31a48beb
• Add "freeplay" button to multiplayer song select
  Dan Balasescu · 2024-12-10 23:02:26 +09:00
  0fb75233ff
• Move rate-changing TODO to a common place in CalculateRateWithMods
  Tim Schumacher · 2024-12-02 23:49:51 +01:00
  e920cfa187
• Remove unnecessary local subscription in BeatmapCarousel

  Not sure why I left this around during the refactor. This is 100%
  handled by the `DetachedBeatmapStore`.
  
  Removing this subscription reduces overheads by a huge amount for users
  with large beatmap databases. My hypothesis is that subscriptions are
  more expensive based on **the number of results matching**. This one
  matches almost every beatmap so removing it is a large win.

  Dean Herbert · 2024-11-27 14:24:57 +09:00
  aa3d3a6344
• Fix right click scroll at song select not quite matching scrollbar position

  Closes https://github.com/ppy/osu/issues/30744.

  Dean Herbert · 2024-11-18 23:54:56 +09:00
  a2af4cbb50
• Add missing source query filter in song select
  Joseph Madamba · 2024-11-15 22:53:23 -08:00
  465cc716d3
• Merge pull request #30579 from peppy/fix-rank-display-song-select

  Fix top rank display not showing up on beatmaps with many difficulties

  Bartłomiej Dach · 2024-11-12 12:26:26 +01:00
  c25215d2cf
• Make math more logical
  Dean Herbert · 2024-11-11 22:57:26 +09:00
  8c5785fdf6
• Remove unused using directives
  Bartłomiej Dach · 2024-11-11 11:04:43 +01:00
  d29dd2c223
• Reduce semi-opaque layers at song select

  I made these changes while working on
  https://github.com/ppy/osu/pull/30579. Basically, it's hard to fix the
  ranks not loading while underneath the footer, and the transparency both
  looks bad, and is going away in the redesign.
  
  I've chosen values here that are moving *in the direction* of the new
  design without overhauling everything.
  
  - I know that there's still some transparency. I did this because it
  helps keep all current elements / colours contrasting without too much
  effort.
  - I completely removed the transparency adjustments on the beatmap
  panels. This always looked bad due to being applied per-layer, and I
  don't think it added much.

  Dean Herbert · 2024-11-11 17:57:23 +09:00
  f84ee3996f
• Fix top rank display not showing up on beatmaps with many difficulties
  Dean Herbert · 2024-11-11 17:49:34 +09:00
  e8b69581b7
• Fix weird local variable typo
  Dean Herbert · 2024-11-11 16:59:02 +09:00
  f8ac54d61c
• Merge pull request #30425 from bdach/multiplayer-song-select-wyd

  Fix multiplayer song select not correctly applying filter sometimes

  Dean Herbert · 2024-11-11 14:54:48 +09:00
  322df72cce
• Extract "copy link" text to common localisation
  Bartłomiej Dach · 2024-11-04 13:59:48 +01:00
  51f26993fa
• Fix multiplayer song select not correctly applying filter sometimes

  Fixes the root client-side failure causing
  https://github.com/ppy/osu/issues/30415.
  
  Thread of breakage is as follows:
  
  1. `SongSelect` loads the carousel.
     At this point, the ruleset is what the ambient ruleset would have
     been at the time of pushing song select, so most likely it will
     match the current ruleset.
     Notably, the carousel is loaded with `AllowSelection == false`.
  2. `OnlinePlaySongSelect` sets the ruleset to the one taken from
     the relevant playlist item in `LoadComplete()`.
  3. At any point between the previous and the next step, the user
     changes the ruleset manually.
  4. `SongSelect.carouselBeatmapsLoaded()` is ran, which calls
     `transferRulesetValue()`, which calls `FilterControl.FilterChanged`.
     But at this stage `Carousel.AllowSelection` is still false, so
     the filter is not executed, but `pendingFilterApplication` is set
     instead.
     Unfortunately, the pending filter never gets applied after that.
     The only place that checks that flag is `OnEntering()`, which at
     this point has already ran.
  
  To fix, move the `pendingFilterApplication` check to `Update()`, which
  seems like the most obvious and safe solution.

  Bartłomiej Dach · 2024-10-25 21:29:53 +02:00
  b78e7d5d9a
• Fix beatmap selection being lost during update process

  Broke due to something changing in the way we handle realm things in the
  carousel. The deselection happens in `updateBeatmapSet` so we need to
  store / check the original selection before this occurs.
  
  Doesn't seem this had test coverage? Probably implies that the overhead
  of adding a test was very large, so maybe best to leave it that way.

  Dean Herbert · 2024-10-22 17:53:34 +09:00
  e1a950e2d3
• Merge pull request #30145 from WitherFlower/ranked-date-filtering

  Add ranked date and submitted date filtering to song select

  Dean Herbert · 2024-10-17 02:38:36 +09:00
  dafe8d6448
• Fix Beatmap Delete Dialog
  Shin Morisawa · 2024-10-14 09:55:28 +09:00
  90a08b8a68
• Filter out unranked/unsubmitted beatmaps when using the ranked/submitted search filters
  WitherFlower · 2024-10-11 09:49:47 +02:00
  da376c534b
• Improve regex readability by using character set
  WitherFlower · 2024-10-10 17:42:43 +02:00
  eb2f1d09f8
• Fix code quality and formatting issues
  WitherFlower · 2024-10-10 17:41:29 +02:00
  6b532824b1
• Decouple AdvancedStats from global mods

  Closes https://github.com/ppy/osu/issues/30163.
  
  If I'm to be blunt, the decoupled stuff in song select makes my head
  spin. I spent a solid 20 minutes thinking how I was going to fix this
  one but then finally realised that generally most of the cause there
  was the fact that `AdvancedStats` was seeing the new rulesets *before*
  the "ensure global selected mods are valid for current ruleset" logic,
  and so decided to just _delay_ that until the decoupled transfer
  thingamajig happens.
  
  I was honestly considering combining `BeatmapInfo`, `Ruleset`, and
  `Mods` into one property on `AdvancedStats`. I figured I'd rather not
  push my luck and try the baseline version first, but I honestly think
  that direction is going to be required at some point to properly corral
  all of the decoupled madness taking place in song select.

  Bartłomiej Dach · 2024-10-10 14:22:16 +02:00
  f1842d781e
• Add slash and dot as valid separators in dates.
  WitherFlower · 2024-10-08 14:13:27 +02:00
  b58576f31b
• Implement ranked and submitted date filtering
  WitherFlower · 2024-10-08 13:56:55 +02:00
  2369e98cfc
• Fix delete dialogs having generic "Caution" header text

  Regressed in https://github.com/ppy/osu/pull/28363.

  Dean Herbert · 2024-10-07 16:46:53 +09:00
  11fc811e2f