46008 Commits

• Re-fetch status of any beatmaps stuck in qualified status

  Best we do this rather than leaving it up to users to fix their broken
  beatmaps.
  
  https://github.com/ppy/osu/discussions/32406
  https://github.com/ppy/osu/discussions/32431

  Dean Herbert · 2025-03-19 14:35:43 +09:00
  76f286a01b
• Add some lenience around mod customisation expanding overlay

  It was quite easy to dismiss by accident. I've added some positional and
  time based lenience with numbers that feel good to me. Open to
  discussion on whether both are required and if the numbers feel good.
  
  Going forward, at some point, we'll likely want to standardise this
  across to other expand-on-hover elements (like player load overlays).
  
  Addresses https://github.com/ppy/osu/discussions/32368.

  Dean Herbert · 2025-03-19 12:46:41 +09:00
  52dad654f7
• Merge pull request #32366 from GAMIS65/add-copy-version-button

  Allow copying version via right click in settings footer

  Dean Herbert · 2025-03-19 00:22:14 +09:00
  c9c60424a1
• Fix tests
  Bartłomiej Dach · 2025-03-18 14:18:00 +01:00
  efe1416aa3
• Fix editor crashing if beatmap does not have a mode explicitly specified in the .osu

  Closes https://github.com/ppy/osu/issues/32440.
  
  Probably another "regression" from
  https://github.com/ppy/osu/pull/32315.
  
  Trying very hard not to type out any hyperbolic rants here.

  Bartłomiej Dach · 2025-03-18 12:05:36 +01:00
  87a8281b29
• Update framework
  Dean Herbert · 2025-03-18 18:12:00 +09:00
  ab576d57a0
• Merge pull request #32376 from nekodex/better-kiai-fountain-sfx

  Improve SFX playback behaviour of rapid kiai/star fountain activations

  Dean Herbert · 2025-03-18 17:49:21 +09:00
  aa6d644f70
• Merge pull request #32436 from smoogipoo/fix-join-error-logging

  Fix multiplayer join errors potentially not being logged

  Dean Herbert · 2025-03-18 17:35:21 +09:00
  94713e6bea
• Merge pull request #32363 from zihadmahiuddin/fix/mod-select-diff-attr-highlight

  Highlight difficulty attribute changes in mod select

  Dan Balasescu · 2025-03-18 17:10:20 +09:00
  d4328e8c4e
• Update resources
  Dean Herbert · 2025-03-18 17:10:13 +09:00
  2be450c010
• Code quality pass
  Dean Herbert · 2025-03-18 16:49:44 +09:00
  a4ced55640
• Fix multiplayer join errors potentially not being logged
  Dan Balasescu · 2025-03-18 15:55:02 +09:00
  a55abdb9b3
• Make freestyle not bypass ruleset filter once more
  Dan Balasescu · 2025-03-18 14:32:07 +09:00
  bf3caacf51
• Merge pull request #32418 from bdach/text-flow-why-do-you-torment-me-so

  Fix miscellaneous text flow container breakage

  Dan Balasescu · 2025-03-18 14:19:16 +09:00
  ac5a970558
• Rename localised string to something slightly more correct
  Dean Herbert · 2025-03-18 00:12:13 +09:00
  43d7918548
• Move BeatmapVersion from BeatmapInfo to IBeatmap

  Closes https://github.com/ppy/osu/issues/32420.
  
  The failure cause here is that in editor the beatmap version for the
  beatmap affected (or... any beatmap, really), is 0 (ZERO). That is
  probably a regression from https://github.com/ppy/osu/pull/32315, but
  like... can we universally agree that calling that change "a regression"
  in any capacity is dumb? Like what was that code *doing* playing dumb
  reference games and copying stuff into an arbitrary instance that could
  get or not get used later on? And now you have a 50/50 chance of
  accessing the *correct* model's field, depending on whether you go via
  `BeatmapInfo` or `Beatmap.BeatmapInfo`?
  
  Moving the field to `IBeatmap`, i.e. what is by now - by consensus,
  since https://github.com/ppy/osu/pull/28473 - supposed to be the "decoded
  and materialised" beatmap, fixes this issue.
  
  I probably should have done this as part of
  https://github.com/ppy/osu/pull/28473 but it slipped my mind. Probably
  for the better too because this change has rather large chances of
  breaking stuff so maybe better to examine it in isolation (via diffcalc
  runs or whatever).
  
  For added humour points, you'd say that the field on `BeatmapInfo` was
  not `[Ignore]`d, so this is a realm schema change, right? No. As far as
  I can tell, it's not. I opened realm studio and `BeatmapVersion` *is not
  a listed column` on `Beatmap` models.
  
  I'm also not gonna get into the fact that I think `EditorBeatmap` doing
  dumb games with juggling two `BeatmapInfo` references since
  https://github.com/ppy/osu/pull/15075 is bad, because I don't think I
  have the mental capacity to hotfix this by going down that train of
  thought.

  Bartłomiej Dach · 2025-03-17 15:04:48 +01:00
  91f3be5fea
• Use link flow at a higher level to fix broken layout
  Bartłomiej Dach · 2025-03-17 13:04:57 +01:00
  87932f707d
• Make logic clearer & fix issues
  Bartłomiej Dach · 2025-03-17 12:36:05 +01:00
  e430619e0e
• Merge branch 'master' into set-guest-update
  Bartłomiej Dach · 2025-03-17 12:26:41 +01:00
  05366c2397
• Fix baseline misalignment in drawable comment link section

  `CommentReportButton` is pretty cursed but I guess I can see why it is
  like it is. Short of inlining it into `DrawableComment` this is probably
  the best escape hatch (which I wouldn't be against doing, by the way,
  just not sure it's the most productive use of time unless review
  feedback comes in saying that would be a better path forward).

  Bartłomiej Dach · 2025-03-17 08:53:53 +01:00
  3954d8f3be
• Fix broken text alignment in supporter display

  See previous commit.

  Bartłomiej Dach · 2025-03-17 08:53:20 +01:00
  427f75a703
• Fix broken text alignment in medal display

  Bit unfortunate that this is code that can be written and do stupid
  things. Unsure if additional API protections against this are desired
  framework-side.

  Bartłomiej Dach · 2025-03-17 08:39:05 +01:00
  64c7263342
• Fix tag add request using wrong method
  Dean Herbert · 2025-03-17 12:20:37 +09:00
  f9078b98dd
• Use switch statement class type matching
  Dean Herbert · 2025-03-16 12:09:10 +09:00
  ef8448caaa
• Allow spectator button to work without begin play requests
  Dean Herbert · 2025-03-16 01:42:02 +09:00
  0bde11b504
• Merge pull request #32346 from bdach/user-tags-on-results

  Add ability to vote for beatmap user tags after completing a play

  Dean Herbert · 2025-03-15 14:36:27 +09:00
  d704adf5fa
• Fix more code quality errors
  GAMIS65 · 2025-03-14 13:33:07 +01:00
  f2b57e3954
• Fix code quality
  GAMIS65 · 2025-03-14 13:23:10 +01:00
  f37f60b22d
• Improve SFX playback behaviour of rapid kiai/star fountain activations
  Jamie Taylor · 2025-03-14 20:47:11 +09:00
  d5074bb30f
• Filter freestyle rooms against all rulesets
  Dan Balasescu · 2025-03-14 19:11:32 +09:00
  145cff5091
• Use CopyStringToClipboard
  GAMIS65 · 2025-03-14 10:09:10 +01:00
  c671eef260
• Rename parameter
  GAMIS65 · 2025-03-14 10:06:28 +01:00
  c31fcb946b
• Change CopyUrlToClipboard to CopyStringToClipboard
  GAMIS65 · 2025-03-14 10:02:41 +01:00
  f72de39e4d
• Move the context menu container to a higher level
  GAMIS65 · 2025-03-14 09:50:53 +01:00
  b6b115e269
• Add copy version context menu
  GAMIS65 · 2025-03-13 23:41:41 +01:00
  993be4da41
• Highlight diff attribute changes in mod select
  Zihad · 2025-03-13 17:50:14 +06:00
  17b17f4d71
• Switch add beatmap tag request to using path paramx

  See https://github.com/ppy/osu-web/pull/11999.

  Bartłomiej Dach · 2025-03-13 12:07:19 +01:00
  607c83abd6
• Require high enough score rank for tagging beatmap
  Bartłomiej Dach · 2025-03-13 10:17:27 +01:00
  5b1a4c8ed1
• Simplify boolean flags
  Bartłomiej Dach · 2025-03-13 10:17:27 +01:00
  f78e371b1b
• Merge pull request #32360 from peppy/add-team-beatmap-leaderboards

  Add team beatmap leaderboards

  Bartłomiej Dach · 2025-03-13 10:04:53 +01:00
  0f74f7eed5
• Merge pull request #32352 from smoogipoo/friend-display-user-presence

  Make friends display respond to realtime user presence

  Dean Herbert · 2025-03-13 17:24:57 +09:00
  dc1674105e
• Use localisable string
  Bartłomiej Dach · 2025-03-13 08:37:02 +01:00
  c18764d764
• Remove unused using
  Bartłomiej Dach · 2025-03-13 08:36:19 +01:00
  3515f9a8f8
• Add support for team beatmap leaderboards
  Dean Herbert · 2025-03-13 16:28:20 +09:00
  b0cf5e8bff
• Update resources
  Dean Herbert · 2025-03-13 16:28:20 +09:00
  249bbd0b59
• Add helper methods to check whether beatmap leaderboard scope requires supporter
  Dean Herbert · 2025-03-13 16:28:19 +09:00
  9af3c8351d
• Standardise sizing of placeholder messages on beatmap scores overlay
  Dean Herbert · 2025-03-13 16:28:19 +09:00
  3e71d04bd0
• Merge pull request #31148 from peppy/editor-right-click-as-people-expect

  Add back right-click-for-new-combo and right-click-delete when in object placement mode

  Bartłomiej Dach · 2025-03-13 08:24:08 +01:00
  61ed52eb69
• Add inline TODOs regarding sorting modes
  Dan Balasescu · 2025-03-13 16:04:29 +09:00
  d74dd262f5
• Merge pull request #32349 from bdach/text-flow-broke

  Fix `OsuTextFlowContainer.AddArbitraryDrawable()` not aligning the drawable correctly

  Dean Herbert · 2025-03-13 14:35:03 +09:00
  9f198f3722