h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-05-26 15:50:29 +08:00
Code Issues Releases Wiki Activity

Merge pull request #32436 from smoogipoo/fix-join-error-logging

Browse Source 
Fix multiplayer join errors potentially not being logged
This commit is contained in:
Dean Herbert
2025-03-18 17:35:21 +09:00
committed by GitHub
Unverified
parent d4328e8c4e a55abdb9b3
commit 94713e6bea
2 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game/Screens/OnlinePlay/Lounge/LoungeSubScreen.cs
+5 -1
View File
@@ -351,7 +351,11 @@ namespace osu.Game.Screens.OnlinePlay.Lounge
{
joiningRoomOperation?.Dispose();
joiningRoomOperation = null;
onFailure?.Invoke(error);
if (onFailure != null)
onFailure(error);
else
Logger.Log(error, level: LogLevel.Error);
});
});
osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerLoungeSubScreen.cs
+1 -6
View File
@@ -88,12 +88,7 @@ namespace osu.Game.Screens.OnlinePlay.Multiplayer
if (exception?.GetHubExceptionMessage() is string message)
onFailure(message);
else
{
const string generic_failure_message = "Failed to join multiplayer room.";
if (result.Exception != null)
Logger.Error(result.Exception, generic_failure_message);
onFailure(generic_failure_message);
}
onFailure($"Failed to join multiplayer room: {exception?.Message}");
}
});
}